[Bug 329296] Re: Improve notifications
** Changed in: gnome-power Status: Confirmed = Fix Released ** Changed in: gnome-power Importance: Unknown = Low -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
** Branch linked: lp:ubuntu/gnome-power-manager -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Upon request from seb128 I also opened a new bug https://bugs.edge.launchpad.net/ubuntu/+source/gnome-power- manager/+bug/415932 for my updated patch alone. -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
I've sent pitti, seb128 and kenvandine a slew of new .dsc, .diff.gz and orig.tar.gz for karmics gnome-power-manager-2.27.5 with the updated and reworked patch. But for the sake of completeness I provide you with my changelog-entry and the extracted new/reworked patch here too. changelog-entry: gnome-power-manager (2.27.5-0ubuntu3) karmic; urgency=low * reworked the notify-osd integration patch 02-notify-osd-support, but had to drop keyboard-brightness as this has been moved out of g.p.m. and also dropped general brightness-changed support (bubble showing up when laptop- -lid is opened) -- Mirco Müller (MacSlow) mirco.muel...@ubuntu.com Fri, 14 Aug 2009 12:09:12 +0200 ** Attachment added: 02-notify-osd-support.patch http://launchpadlibrarian.net/30318271/02-notify-osd-support.patch -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
The new gnome-power-manager (2.27.3, to be released next Monday) has a completely rewritten notification system, so our current patch does not apply at all any more. I disabled it in lp:~gnome-power-manager-team /gnome-power/trunk for now. Can you please update the patch? Thanks! ** Changed in: gnome-power-manager (Ubuntu) Status: Fix Released = Triaged ** Changed in: gnome-power-manager (Ubuntu) Assignee: Martin Pitt (pitti) = Cody Russell (bratsche) -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
I'm sorry, I meant the support notify-osd patch, not the actual changes to the notifications. ** Changed in: gnome-power-manager (Ubuntu) Status: Triaged = Fix Released ** Changed in: gnome-power-manager (Ubuntu) Assignee: Cody Russell (bratsche) = (unassigned) -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Milan, that bubble shouldn't exist any more; please report that as a separate bug. -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
By the way, would somebody change the icon used by the Your battery is discharging bubble? For now, it's a warning triangle, which is obviously not appropriate... -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
David, please reopen bugs if you update patches, or create a new bug. Comments on closed bugs just fall through the cracks too easily. ** Changed in: gnome-power-manager (Ubuntu) Status: Fix Released = In Progress -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
David, Cody, please also send the latest version to the upstream bug, and create it against trunk. If you wish, you can also test 2.25 from my PPA, which is very close to trunk. http://martinpitt.wordpress.com/2009/03/11/wanna-touch-devicekit/ -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
This bug was fixed in the package gnome-power-manager - 2.24.2-2ubuntu7 --- gnome-power-manager (2.24.2-2ubuntu7) jaunty; urgency=low * Update 96_feedback-notify-osd.patch to notify-osd's new hint names, and provide a title to notifications for accessibility purposes (the title is not displayed except by readers like gnome-orca). Patch by David Barth. (LP: #329296) -- Martin Pitt martin.p...@ubuntu.com Wed, 18 Mar 2009 21:04:49 +0100 ** Changed in: gnome-power-manager (Ubuntu) Status: In Progress = Fix Released -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
New version of the patch: * resync with the latest versions of the hints returned by notify-osd (x-canonical-private-*) * provide a title to notifications for accessibility purposes (the title is not displayed except by readers like gnome-orca) * i18n (accessible) titles ** Attachment added: 96_feedback-notify-osd.patch.2009-03-17 http://launchpadlibrarian.net/24020846/96_feedback-notify-osd.patch.2009-03-17 -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
** Changed in: gnome-power-manager (Ubuntu) Status: Fix Released = In Progress -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Here is also a new patch for providing feedback notifications with gnome-power-manager. The patch has been updated to reflect the hints changes in the latest notify-osd-0.9 version. This patch replaces the 96_feedback-notify.patch patch file. ** Attachment added: 96_feedback-notify-osd-0_9.patch http://launchpadlibrarian.net/23353489/96_feedback-notify-osd-0_9.patch -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
This bug was fixed in the package gnome-power-manager - 2.24.2-2ubuntu5 --- gnome-power-manager (2.24.2-2ubuntu5) jaunty; urgency=low * Update 96_feedback-notify-osd.patch to notify-osd's new hint names. Patch by David Barth. (LP: #329296) -- Martin Pitt martin.p...@ubuntu.com Tue, 03 Mar 2009 14:50:35 +0100 ** Changed in: gnome-power-manager (Ubuntu) Status: In Progress = Fix Released -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Cody, the linked upstream bug might indeed be a good place to put this patch at. -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Thanks, I've posted the patch upstream to http://bugzilla.gnome.org/show_bug.cgi?id=423186 -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Sebastien, can you please review this? ** Changed in: gnome-power-manager (Ubuntu) Assignee: (unassigned) = Sebastien Bacher (seb128) -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Doing myself now. ** Changed in: gnome-power-manager (Ubuntu) Assignee: Sebastien Bacher (seb128) = Martin Pitt (pitti) -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
This bug was fixed in the package gnome-power-manager - 2.24.2-2ubuntu3 --- gnome-power-manager (2.24.2-2ubuntu3) jaunty; urgency=low * Add 26-notifications.patch: Show alert boxes for important situations (“Battery may be recalled”, “Battery may be broken”, etc., and do not use actions in notifications if the notification-daemon does not support them. Thanks to Cody Russell! (LP: #329296) This also fixes the problem of cut-off notifications for broken batteries. (LP: #155191) * 74-disable-quirks-reference.patch: Updated for above patch, and simplified. -- Martin Pitt martin.p...@ubuntu.com Tue, 17 Feb 2009 16:34:44 +0100 ** Changed in: gnome-power-manager (Ubuntu) Status: New = Fix Released -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
** Bug watch added: GNOME Bug Tracker #423186 http://bugzilla.gnome.org/show_bug.cgi?id=423186 ** Also affects: gnome-power via http://bugzilla.gnome.org/show_bug.cgi?id=423186 Importance: Unknown Status: Unknown -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
** Changed in: gnome-power Status: Unknown = Confirmed -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Thanks Cody. Can you please submit this to upstream, together with a rationale of the change (which should include a pointer to the general DX design philosophy, in the sense of why are actions in notifications bad?). Thanks! -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
Corrected patch. The last patch accidentally contained some code in gpm-engine.c I was using to test the changes with. This patch fixes that but is otherwise the same. ** Attachment added: gnome-power-alerts-3.diff http://launchpadlibrarian.net/22610087/gnome-power-alerts-3.diff -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
** Attachment added: Proposed patch http://launchpadlibrarian.net/22600210/gnome-power-alerts.diff -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 329296] Re: Improve notifications
An updated patch. This fixes a memory leak in the previous patch (the hash table entry wasn't freed after the alert callback is executed). This also addresses the following issues that I failed to post in the bug description above: Another situation is fairly common, but any response involves the hardware rather than the software, so it should use a notification bubble: * “Battery Discharging”, “The AC power has been unplugged. The system is now using battery power.” with a “Do not show me this again” button. This button should be made conditional on whether the notification server supports actions. Two others should put up neither a notification bubble nor an alert, so their bubbles should be removed: * “Sleep warning”, “Your laptop will not sleep if you shut the lid as a running program has prevented this. Some laptops can overheat if they do not sleep when the lid is closed.” * “Battery Charged”, “Your laptop battery is now fully charged”. ** Attachment added: Updated patch http://launchpadlibrarian.net/22600740/gnome-power-alerts-2.diff -- Improve notifications https://bugs.launchpad.net/bugs/329296 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
