[Bug 372874] Re: Generic get_brightness function should read 'actual_brightness' not 'brightness'
Ubuntu should not wait for upstream. Try out the patch. It solves the brightness-notification issue. 1. Apply attached patch to hald 2. echo "options thinkpad_acpi hotkey=enable,0xfd" > /etc/modprobe.d/thinkpad_acpi.conf 3. Restart hal, reload thinkpad_acpi module => brightness notification works on Thinkpads, thus partly solving bug #357673. ** Summary changed: - Generic get_brightness function should read 'actual_brightness' not 'brightness' + [ThinkPads] No brightness-notification - Bug in generic get_brightness function ** Description changed: Binary package hint: hal Brightness notification always shows the same value for laptops with - hardwired brightness control, ex T42. + hardwired brightness control, ex T42. Thus not reflecting the true + brightness value. Problem is get_backlight () function in: hald/linux/addons/addon- generic-backlight.c Line 67 reads: g_snprintf (sysfs_path, sizeof (sysfs_path), "%s/brightness", path); should be: g_snprintf (sysfs_path, sizeof (sysfs_path), "%s/actual_brightness", path); 'actual_brightness' holds the current value of brightness. 'brightness' is used to set the brightness, and when read gives the last writen value! -- [ThinkPads] No brightness-notification - Bug in generic get_brightness function https://bugs.launchpad.net/bugs/372874 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 372874] Re: Generic get_brightness function should read 'actual_brightness' not 'brightness'
Thanks, since there is a patch (and upstream report) I'll mark as triaged! ** Changed in: hal (Ubuntu) Importance: Undecided => Low ** Changed in: hal (Ubuntu) Status: New => Triaged -- Generic get_brightness function should read 'actual_brightness' not 'brightness' https://bugs.launchpad.net/bugs/372874 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 372874] Re: Generic get_brightness function should read 'actual_brightness' not 'brightness'
** Changed in: hal Status: Unknown => Confirmed -- Generic get_brightness function should read 'actual_brightness' not 'brightness' https://bugs.launchpad.net/bugs/372874 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 372874] Re: Generic get_brightness function should read 'actual_brightness' not 'brightness'
** Also affects: hal via https://bugs.freedesktop.org/show_bug.cgi?id=21612 Importance: Unknown Status: Unknown -- Generic get_brightness function should read 'actual_brightness' not 'brightness' https://bugs.launchpad.net/bugs/372874 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 372874] Re: Generic get_brightness function should read 'actual_brightness' not 'brightness'
Tested attached patch, which fixes this issue. Brightness notifications works again. Please include patch in jaunty hal! ** Attachment added: "addon-generic-backlight.c.diff" http://launchpadlibrarian.net/26424981/addon-generic-backlight.c.diff -- Generic get_brightness function should read 'actual_brightness' not 'brightness' https://bugs.launchpad.net/bugs/372874 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 372874] Re: Generic get_brightness function should read 'actual_brightness' not 'brightness'
Filed bug upstream: http://bugs.freedesktop.org/show_bug.cgi?id=21612 ** Bug watch added: freedesktop.org Bugzilla #21612 https://bugs.freedesktop.org/show_bug.cgi?id=21612 -- Generic get_brightness function should read 'actual_brightness' not 'brightness' https://bugs.launchpad.net/bugs/372874 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 372874] Re: Generic get_brightness function should read 'actual_brightness' not 'brightness'
Fixing this would partly fix bug #357673. thinkpad hotkeys for brightness should be enabled by default after this fix. -- Generic get_brightness function should read 'actual_brightness' not 'brightness' https://bugs.launchpad.net/bugs/372874 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
