[Bug 412647] Re: Firefox is not able to play mp4 video tags

2015-08-04 Thread Mathew Hodson
** This bug is no longer a duplicate of bug 1051559
   Build Firefox with GStreamer support

** Also affects: iceweasel (Debian) via
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682917
   Importance: Unknown
   Status: Unknown

** Changed in: firefox (Ubuntu)
   Status: Triaged = Fix Released

** Bug watch removed: Red Hat Bugzilla #843583
   https://bugzilla.redhat.com/show_bug.cgi?id=843583

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2015-08-04 Thread Bug Watch Updater
** Changed in: iceweasel (Debian)
   Status: Unknown = Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2014-07-23 Thread Oibaf
*** This bug is a duplicate of bug 1051559 ***
https://bugs.launchpad.net/bugs/1051559

** This bug has been marked a duplicate of bug 1051559
   Build Firefox with GStreamer 1.0 support

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-10-04 Thread xunxun1982
(In reply to Ralph Giles (:rillian) from comment #304)
 (In reply to xunxun from comment #303)
 
  Can we introduce GStreamer to Mozilla source tree?
 
 If you think that would be useful please open a separate bug for discussion.
 Especially if you can provide patches.
 
 A simpler approach in the near term might be to add support for linking
 against one of the pre-built SDKs, e.g. from entropywave or fluendo. IIRC
 fluendo's had a problem with mismatched runtimes on windows, though.
 
  
  Because on Windows, Gstreamer need rebuilding using the user's compiler.

I found that Opera had a Gstreamer project for windows Clone :
http://sourcecode.opera.com/gstreamer/

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-10-04 Thread Gquigs+bugs
Are there plans to enable this in Linux builds?  Should that be a
separate Mozilla bug?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-10-04 Thread Riles
There are no plans to enable this in official builds. If you think there
should be, please open a new bug for that, and mark it dependent on this
one.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-10-04 Thread sam tygier
there is a more focused discussion on Bug #1051559

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-09-17 Thread sam tygier
having trouble with launchpad, but probably interesting to look at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682917 and
https://bugzilla.redhat.com/show_bug.cgi?id=843583

** Bug watch added: Debian Bug tracker #682917
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682917

** Bug watch added: Red Hat Bugzilla #843583
   https://bugzilla.redhat.com/show_bug.cgi?id=843583

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-09-14 Thread Oibaf
Yes, but the only pratical point of adding gstreamer is adding support
for H.264, since all the free formats are already natively supported
(while other formats aren't interesting in firefox). Other softwares
need gstreamer because is the only supported backend also for the free
formats.

Also, while flash is widely used, HTML5 video still is not, and there is
still not a winner between H.264/Webm, so there is a point in supporting
only free formats here - at least until/if H.264 definitively wins over
Webm.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-09-07 Thread Oibaf
** Description changed:

  Binary package hint: firefox
  
  With firefox 3.5 html5 was introduced. However only ogg is supported as
  it seems. The html5-preview on youtube.com
  (http://www.youtube.com/html5) doesn't work at all, but it does play in
  safari and epiphany-webkit.
  
  Please make firefox able to install video codecs or use the ones avaible
  through gstreamer.
  
  As of firefox 14, gstreamer support can be enabled with --enable-
  gstreamer. If the required gstreamer codecs are install then firerfox
  can play H.264 in a video tag.
+ 
+ Note that the Windows build only supports patent free codecs. Given the
+ Ubuntu commitment to free software, do we really want to enable support
+ for patented codec?

** Description changed:

- Binary package hint: firefox
- 
- With firefox 3.5 html5 was introduced. However only ogg is supported as
- it seems. The html5-preview on youtube.com
- (http://www.youtube.com/html5) doesn't work at all, but it does play in
- safari and epiphany-webkit.
- 
- Please make firefox able to install video codecs or use the ones avaible
- through gstreamer.
+ With firefox 3.5 html5 was introduced. Since 4.0 both ogg/theora and
+ webm/vp8 video formats are supported.
  
  As of firefox 14, gstreamer support can be enabled with --enable-
- gstreamer. If the required gstreamer codecs are install then firerfox
- can play H.264 in a video tag.
+ gstreamer. If the required gstreamer codecs are install then firefox can
+ play H.264 in a video tag.
  
- Note that the Windows build only supports patent free codecs. Given the
- Ubuntu commitment to free software, do we really want to enable support
- for patented codec?
+ Note that the Windows build still only supports patent free codecs.
+ Given the Ubuntu commitment to free software, do we really want to
+ enable support for patented codec?

** Description changed:

  With firefox 3.5 html5 was introduced. Since 4.0 both ogg/theora and
  webm/vp8 video formats are supported.
  
  As of firefox 14, gstreamer support can be enabled with --enable-
- gstreamer. If the required gstreamer codecs are install then firefox can
- play H.264 in a video tag.
+ gstreamer. If the required gstreamer codecs are installed then firefox
+ can play H.264 in a video tag.
  
  Note that the Windows build still only supports patent free codecs.
  Given the Ubuntu commitment to free software, do we really want to
  enable support for patented codec?

** Description changed:

  With firefox 3.5 html5 was introduced. Since 4.0 both ogg/theora and
  webm/vp8 video formats are supported.
  
  As of firefox 14, gstreamer support can be enabled with --enable-
  gstreamer. If the required gstreamer codecs are installed then firefox
  can play H.264 in a video tag.
  
- Note that the Windows build still only supports patent free codecs.
- Given the Ubuntu commitment to free software, do we really want to
- enable support for patented codec?
+ === Open questions ===
+ 
+ 1. Note that the Windows build still only supports patent free codecs.
+ 2. How stable that code is? Which regression could introduce?
+ 3. Given the Ubuntu commitment to free software, do we really want to enable 
support for other codecs other than the officially supported free ones?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-09-07 Thread Oibaf
** Description changed:

  With firefox 3.5 html5 was introduced. Since 4.0 both ogg/theora and
  webm/vp8 video formats are supported.
  
  As of firefox 14, gstreamer support can be enabled with --enable-
  gstreamer. If the required gstreamer codecs are installed then firefox
  can play H.264 in a video tag.
  
  === Open questions ===
  
  1. Note that the Windows build still only supports patent free codecs.
- 2. How stable that code is? Which regression could introduce?
- 3. Given the Ubuntu commitment to free software, do we really want to enable 
support for other codecs other than the officially supported free ones?
+ 2. Note that youtube already supports webm/vp8 (altough still not for all 
videos), while wikipedia supports ogg/theora. Which important sites require 
other codecs?
+ 3. Chrome supports H.264, but promised to drop support for it ( 
http://blog.chromium.org/2011/01/html-video-codec-support-in-chrome.html ).
+ 4. How stable that code is? Which regression could introduce?
+ 5. Given the Ubuntu commitment to free software, do we really want to enable 
support for other codecs other than the officially supported free ones?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-09-07 Thread sam tygier
5. Given the Ubuntu commitment to free software, do we really want to
enable support for other codecs other than the officially supported free
ones?

building with gstreamer does not in itself allow firefox to play h264.
it means that firefox can use the gstreamer codecs that you can install.
this work equivient to rhythmbox, banshee, totem etc, where codec
support is expandable by installing new gstreamer codecs.

If there is a desire to prevent firefox supporting non-free formats then
its plugin support would need to be disabled so that it can't use flash
or realplayer.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-07-26 Thread sam tygier
** Description changed:

  Binary package hint: firefox
  
  With firefox 3.5 html5 was introduced. However only ogg is supported as
  it seems. The html5-preview on youtube.com
  (http://www.youtube.com/html5) doesn't work at all, but it does play in
  safari and epiphany-webkit.
  
  Please make firefox able to install video codecs or use the ones avaible
  through gstreamer.
+ 
+ As of firefox 14, gstreamer support can be enabled with --enable-
+ gstreamer. If the required gstreamer codecs are install then firerfox
+ can play H.264 in a video tag.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-07-25 Thread xunxun1982
Can we introduce GStreamer to Mozilla source tree?

Because on Windows, Gstreamer need rebuilding using the user's compiler.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-07-25 Thread Riles
(In reply to xunxun from comment #303)

 Can we introduce GStreamer to Mozilla source tree?

If you think that would be useful please open a separate bug for
discussion. Especially if you can provide patches.

A simpler approach in the near term might be to add support for linking
against one of the pre-built SDKs, e.g. from entropywave or fluendo.
IIRC fluendo's had a problem with mismatched runtimes on windows,
though.

 
 Because on Windows, Gstreamer need rebuilding using the user's compiler.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-06-12 Thread Andoni Morales
There are several reasons why we decided to build the SDK against the
system CRT msvcrt.dll, but the most important one is that if you decide
to link against any of the VS ones you will be forced to distribute
broken software.

According to MS EULA you can't distribute yourself this system library
(eg: msvcr100.dll) so your software is depending on a third party
installer (Microsoft Visual C++ 20XX Redistributable Package). The GPL
also forbids explicitely the redistribution of System Libraries
(http://www.gnu.org/licenses/gpl-faq.en.html#WindowsRuntimeAndGPL).

How is this handled in Firefox?

There is the option of rebuilding the SDK linking against msvcr100.dll,
this would require on our side providing a gcc spec that links against
moldnames100 and msvcr100 and rebuilding gcc so that libgcc_s_sjlj-1.dll
and libstdc++6.dll are linked against the new CRT and using the gcc spec
in the toolchain.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-06-12 Thread Ted Mielczarek
We ship the CRT files alongside our app. I don't think your reading of
the EULA is correct. Those files are explicitly listed as
redistributable, and historically you have been allowed to ship the
DLL files with your application.

The GPL wrinkle is tricky, that sounds like a big PITA. In any event, we
ship Firefox under the MPL, so it's not an issue for us.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-06-12 Thread Andoni Morales
(In reply to Ted Mielczarek [:ted] from comment #301)
 We ship the CRT files alongside our app. I don't think your reading of the
 EULA is correct. Those files are explicitly listed as redistributable, and
 historically you have been allowed to ship the DLL files with your
 application.

Apparently I was hitten by this bug when I last read the EULA:
http://archive.msdn.microsoft.com/KB956414. But indeed it's very clear
here that you are allowed to redistribute them even without the
installer (http://msdn.microsoft.com/en-us/library/ms235299.aspx)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-06-11 Thread Pawsome
(In reply to Alessandro Decina from comment #296)

 I'm waiting for the SDK to be ready (gonna be ready Any Day Now ;)), then my
 plan is to integrate it in the build and start a discussion on how and where
 to enable the gstreamer backend by default.

Just in case, SDK is out.
http://gstreamer.com/

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-06-11 Thread Cpearce-t
(In reply to Sid from comment #298)
 Just in case, SDK is out.
 http://gstreamer.com/

In the Windows installation instructions they recommend removing the
client app's dependency on MSVC2010's runtime DLL and using the “basic”
C runtime which comes in every Windows system since Windows XP, and is
named MSVCRT.DLL.

See:

Removing the dependency with the Visual Studio runtime
http://docs.gstreamer.com/display/GstSDK/Installing+on+Windows

We apparently ship with the MSVC 2010's RT, and switching runtimes makes
me nervous... Were we to ship this on Windows, we may be best to build
the SDK ourselves with MSVCRT2010 or get Collabora to build one with
MSVCRT2010.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-05-20 Thread shawnlandden
** Package changed: firefox-3.5 (Ubuntu) = firefox (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-05-20 Thread shawnlandden
The upstream fix is preffed off by default, can we get --enable-
gstreamer in the ubuntu builds? (version 15+)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-09 Thread A2414578
Could someone, please, compile a build for Windows with this special
flag needed to include GStreamer support?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-09 Thread Pawsome
(In reply to Ralph Giles (:rillian) from comment #290)
 Note however that which GStreamer support is in the codebase, Official
 builds do not have it turned on. At least, not yet.

Is there a bug for turning it on? If not, should we file one? What are
the current plans for this feature?

(In reply to Sean Newman from comment #292)
 Could someone, please, compile a build for Windows with this special flag
 needed to include GStreamer support?

Seconded.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-09 Thread Riles
(In reply to Sid from comment #293)

 Is there a bug for turning it on? If not, should we file one? What are the
 current plans for this feature?

If you think it should be on by default you should certainly file a bug
so it can be discussed. As far as I know current plans aren't settled;
the decision to change policy on the official builds depends on the
codec issues, and we don't have consensus or working code there yet.

 (In reply to Sean Newman from comment #292)
  Could someone, please, compile a build for Windows with this special flag
  needed to include GStreamer support?

Note that for this to be useful, we'd have to build and include a copy
of Gstreamer as well. It's generally available on Linux systems, but not
Windows, Mac or Android. That's probably a separate bug as well: getting
gstreamer building on non-linux archs either as part of our monolithic
build, or by bundling a standalone  gstreamer + plugins build, such as
the sdk from entropywave, or the one fluendo announced a few months ago.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-09 Thread Pawsome
(In reply to Ralph Giles (:rillian) from comment #294)
 As far as I know current plans aren't settled; the
 decision to change policy on the official builds depends on the codec
 issues, and we don't have consensus or working code there yet.

Yeah, I forgot about codec problems. Let's wait then. Anyway, if those
issues are solved, it would be better to try and implement a native
DirectShow or Media Foundation backend for Windows (bug 435339).

 It's generally available on Linux systems, but not Windows, Mac or
Android.

There is a Windows port of GStreamer available on
http://ossbuild.googlecode.com (although it seems abandoned at v0.10.7).
Will it work with GStreamer-enabled Nightly build?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-09 Thread Alessandro Decina
(In reply to Sid from comment #295)
 (In reply to Ralph Giles (:rillian) from comment #294)
  As far as I know current plans aren't settled; the
  decision to change policy on the official builds depends on the codec
  issues, and we don't have consensus or working code there yet.
 
 Yeah, I forgot about codec problems. Let's wait then. Anyway, if those
 issues are solved, it would be better to try and implement a native
 DirectShow or Media Foundation backend for Windows (bug 435339).

Why do you think that would be better?
 

  It's generally available on Linux systems, but not Windows, Mac or Android.
 
 There is a Windows port of GStreamer available on
 http://ossbuild.googlecode.com (although it seems abandoned at v0.10.7).
 Will it work with GStreamer-enabled Nightly build?

GStreamer has pretty good Windows support and it even supports some of
the native codecs. Building it and shipping it on Windows is not as easy
as it could be though. To fix that, as Ralph mentioned, there's an
undergoing effort to produce an easy to use (and ship and build)
GStreamer SDK for linux, mac and windows, see http://is.gd/tteunv.

I'm waiting for the SDK to be ready (gonna be ready Any Day Now ;)),
then my plan is to integrate it in the build and start a discussion on
how and where to enable the gstreamer backend by default.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-09 Thread Riles
(In reply to Alessandro Decina from comment #296)

 I'm waiting for the SDK to be ready (gonna be ready Any Day Now ;)), then my
 plan is to integrate it in the build and start a discussion on how and where
 to enable the gstreamer backend by default.

Great! Can you open a bug for that? The discussion thread here is long
enough already. :)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-07 Thread Diego Viola
Nice to see this issue got resolved. Thanks to everyone who worked on
this.

Does Firefox 12 already has GStreamer support? Or will GStreamer support
come with a further Firefox version? Like Firefox 13 or 14?

Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-07 Thread Riles
The patch landed on the Firefox 14 branch. (See the 'Target Milestone'
field at the top of the  bug). Firefox 14 will become the stable release
in July.

Note however that which GStreamer support is in the codebase, Official
builds do not have it turned on. At least, not yet.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-05-07 Thread Diego Viola
(In reply to Ralph Giles (:rillian) from comment #290)
 The patch landed on the Firefox 14 branch. (See the 'Target Milestone' field
 at the top of the  bug). Firefox 14 will become the stable release in July.
 
 Note however that which GStreamer support is in the codebase, Official
 builds do not have it turned on. At least, not yet.

Thanks a lot.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-24 Thread Konstartyom
Thank you for your excellent patch. Do you plan to add support of
standalone mp3 audio (in the audio tag)?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-20 Thread Ehsan-mozilla
https://hg.mozilla.org/mozilla-central/rev/c04a467c48ac

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-20 Thread Dao
(In reply to IU from comment #285)
 Keywords field has mobile but platform is all.  So, is this still fennec
 only or should this work with Firefox, including on Windows?

See https://bugzilla.mozilla.org/describekeywords.cgi
The mobile keyword means important to mobile developmental work, not 
mobile-only.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-20 Thread Dave
Keywords field has mobile but platform is all.  So, is this still
fennec only or should this work with Firefox, including on Windows?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-20 Thread Alessandro Decina
Should work with Firefox on any platform, including Windows.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2012-04-20 Thread Bug Watch Updater
** Changed in: firefox
   Status: In Progress = Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-19 Thread Akeybl
Comment on attachment 615622
GStreamer backend for audio/video decoding (including all the post review fixes)

[Triage Comment]
We've now given NPOTB patches blanket approval - a=npotb. 
https://wiki.mozilla.org/Tree_Rules#mozilla-central_.28Nightly_channel.29

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-19 Thread Ryanvm
https://hg.mozilla.org/integration/mozilla-inbound/rev/c04a467c48ac

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-18 Thread Michael-monreal+moz
As GSteamer 1.0 is just around the corner...

http://gstreamer.freedesktop.org/wiki/ZeroPointEleven
http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/random/porting-to-0.11.txt

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-18 Thread Riles
Comment on attachment 615622
GStreamer backend for audio/video decoding (including all the post review fixes)

Chris Double is on vacation. Flagging to land in his stead.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-18 Thread Release-a
Try run for 1e0e98d406ac is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Tryrev=1e0e98d406ac
Results (out of 230 total builds):
success: 196
warnings: 34
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rgi...@mozilla.com-1e0e98d406ac

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-18 Thread Riles
This is NPOTB (not part of the default build) and should land.

Try push at https://tbpl.mozilla.org/?tree=Tryrev=1e0e98d406ac is
clean; it shows two Mochitest orange, both of which are known in, and a
bunch of restarts after infrastructure or timeout issues.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-18 Thread Alessandro Decina
(In reply to Michael Monreal [:monreal] from comment #275)
 As GSteamer 1.0 is just around the corner...
 
 http://gstreamer.freedesktop.org/wiki/ZeroPointEleven
 http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/random/porting-to-
 0.11.txt

Hehe, yeah that's on the todo list already :)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-18 Thread Ryanvm
Comment on attachment 615622
GStreamer backend for audio/video decoding (including all the post review fixes)

Ralph, just use the checkin-needed flag. The checkin? flag is mainly
used when landing on multiple branches or landing only a subset of
patches. Also, obsoleting old patches is appreciated. Also, with
mozilla-central/inbound in lockdown mode currently, this will need
approval before landing.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-18 Thread Riles
Ok, thanks. I just wanted to be clear which patch we intended to land.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-17 Thread shawnlandden
can you update your github repo with the new patch?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-17 Thread Alessandro Decina
Created attachment 615622
GStreamer backend for audio/video decoding (including all the post review fixes)

New patch checking for gst =0.10.33 and dealing with the
comments in your last review. The patch is not incremental but
contains all the changes so far, which should ease merging.

I pushed everything to my github repo so you can look at the individual
commits here https://github.com/alessandrod/mozilla-central/commits/bugs/422540

I also ran the reftests as you suggested. These are the results for
webm:

REFTEST INFO | Result summary:
REFTEST INFO | Successful: 26 (26 pass, 0 load only)
REFTEST INFO | Unexpected: 2 (2 unexpected fail, 0 unexpected pass, 0 
unexpected asserts, 0 unexpected fixed asserts, 0 failed load, 0 exception)
REFTEST INFO | Known problems: 5 (0 known fail, 0 known asserts, 5 random, 0 
skipped, 0 slow)


These are the results for ogg:

REFTEST INFO | Result summary:
REFTEST INFO | Successful: 27 (27 pass, 0 load only)
REFTEST INFO | Unexpected: 0 (0 unexpected fail, 0 unexpected pass, 0 
unexpected asserts, 0 unexpected fixed asserts, 0 failed load, 0 exception)
REFTEST INFO | Known problems: 5 (0 known fail, 0 known asserts, 5 random, 0 
skipped, 0 slow)
REFTEST INFO | Total canvas count = 4

Now i'm going to check what those two webm failures are about and
i'm going to add H264 specific mochitests.

I agree that things are good enough to be merged now. I flagged the
patch for checkin, do I need to do anything else?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-17 Thread Roc-ocallahan
I think you're ready to land.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-17 Thread Alessandro Decina
Great, waiting for someone with commit access to merge then \o/

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-14 Thread Galtgendo
AFAIU, this code is yet to be merged, right ?
In such case, did anyone checked this code for required changes in regard of 
gstreamer 1.0 candidates ?
Just so, that if gstreamer upstream releases before you do, it could be used 
with either 0.10 or 1.0, depending on build options.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-13 Thread Chris Double
Comment on attachment 611716
New patch addressing 1st review comments + misc fixes. See comment #263.

Review of attachment 611716:
-

Looks good, just minor comments. r+ with those, and the configure change
you mentioned to address the gstreamer version. I don't think it's
required that all mochitests pass to land your patch since it's disabled
by default - it isn't built without --enable-gstreamer. Followup bugs
can be raised to address the failing tests and additional functionality.
Additional tests would be good for H.264 encoded files and anything else
specific to the backend that you think would be useful.

Have you tried the reftests that compare the result of the decoded video
frames with a reference image?

::: content/media/gstreamer/nsGStreamerReader.cpp
@@ +185,2 @@
  
 +  /* We do 3 attemtps here: decoding audio and video, decoding video only,

Minor: Spelling of 'attempts'.

@@ +322,5 @@
 +  mDecoder-NotifyBytesConsumed(mByteOffset - mLastReportedByteOffset);
 +  mLastReportedByteOffset = mByteOffset;
 +}
 +
 +bool nsGStreamerReader::WaitForDecodedData(int *counter)

Minor: Change 'counter' to 'aCounter'.

@@ +613,5 @@
  
  void nsGStreamerReader::NeedData(GstAppSrc *aSrc, guint aLength)
  {
 +  if (aLength == -1)
 +aLength = 50 * 1024;

Can you make this magic number (50*1024) a define/constant somewhere.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-11 Thread Chris Double
(In reply to Alessandro Decina from comment #264)
 Created attachment 611716
 New patch addressing 1st review comments + misc fixes. See comment #263.

I get an error when trying to play a video/mp4 with this patch applied:

GLib-GObject-WARNING **:
/build/buildd/glib2.0-2.26.1/gobject/gsignal.c:2275: signal `source-
setup' is invalid for instance `0x7fa4debfc000

The previous patch worked fine on this video. Is this something to do
with the change to playbin?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-11 Thread Alessandro Decina
source-setup was added to playbin2 in 0.10.33. The gst check in
configure.in should check for gstreamer core and gst-plugins-base =
0.10.33. I'll fix this in the next patch.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-03 Thread Alessandro Decina
 AudioDataValue[bufferSize]);

I can't use PR_STATIC_ASSERT as the size of the buffer is not fixed. I
can avoid the multiplication though and did so.

 
 Also use nsAutoArrayPtr here (as the wave example does).

Done

 
 @@ +238,5 @@
  +  frames, data, mInfo.mAudioChannels);
  +
  +  mAudioQueue.Push(audio);
  +
  +  gst_buffer_unref(buffer);
 
 Is it worth creating some safe ref/unref class that unrefs in the destructor
 for Gst objects?

I don't think so. The code that does gst refcounting is self contained
and it's done just in an handful of places. Don't have a strong
opinion/preference on this though.


 
 @@ +244,5 @@
  +  return true;
  +}
  +
  +bool nsGStreamerReader::DecodeVideoFrame(bool aKeyFrameSkip,
  +  PRInt64 aTimeThreshold)
 
 Align PRInt64 with bool in the line above. Ditto with any similar alignment
 in function arguments later in the file.

Done


 
 @@ +277,5 @@
  +timestamp = gst_segment_to_stream_time(mVideoSegment,
  +GST_FORMAT_TIME, timestamp);
  +timestamp = nextTimestamp = GST_TIME_AS_USECONDS(timestamp);
  +if (GST_CLOCK_TIME_IS_VALID(GST_BUFFER_DURATION(buffer))) {
  +nextTimestamp += GST_TIME_AS_USECONDS(GST_BUFFER_DURATION(buffer));
 
 Is there danger of overflow here? Should it be checked?

Here timestamp is something that goes (roughly) from zero for the first
frame, to the duration of the stream for the last, so in normal
circumstances this won't overflow.

It can overflow I guess if GST_BUFFER_DURATION is specifically forged.
I'm going to see if I can create a test about this.


 @@ +324,5 @@
  +   nextTimestamp,
  +   b,
  +   isKeyframe,
  +   -1,
  +   mPicture);
 
 Align with 'mInfo' in line 320.

Done


 
 @@ +587,5 @@
  +  GstCaps *caps = gst_pad_get_negotiated_caps(sinkpad);
  +  GstStructure *s = gst_caps_get_structure(caps, 0);
  +  gst_structure_get_int(s, rate, (gint *) mInfo.mAudioRate);
  +  gst_structure_get_int(s, channels, (gint *) mInfo.mAudioChannels);
  +  mInfo.mHasAudio = true;
 
 Might need to sanity check these values to ensure they're within a valid
 range (to prevent overflow's, etc later). Ditto with the video parameters
 later.

Gst already does as we have caps restrictions on the sinks. I added some
NS_ASSERTIONs in addition.


  +  static void EosCb(GstAppSink *aSink, gpointer aUserData);
  +  void Eos(GstAppSink *aSink);
  +
 
 Can you add comments to the functions above with a brief explanation of
 when/why they're called.
 
 @@ +121,5 @@
  +  GstAppSinkCallbacks mSinkCallbacks;
  +  mozilla::ReentrantMonitor mGstThreadsMonitor;
  +  GstSegment mVideoSegment;
  +  GstSegment mAudioSegment;
  +  bool mReachedEos;
 
 Some comments for what these are used for, threading requirements (if any),
 etc if possible.

Done. If needed, I guess I can add more general comments about how
threading synchronization works between gst threads and the decoder
state machine threads.


 ::: js/src/ctypes/libffi/Makefile.am
 @@ +82,4 @@
   
   MAKEOVERRIDES=
   
  +ACLOCAL_AMFLAGS= -I m4
 
 Was this included in the patch by mistake?

Oops, yes.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-03 Thread Alessandro Decina
Created attachment 611716
New patch addressing 1st review comments + misc fixes. See comment #263.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-03 Thread Matthew Gregan
(In reply to Alessandro Decina from comment #263)
 I started running the mochi tests in content/media/ and fixed a good number
 of issues already. Not all the tests pass, but most of those that don't pass
 fail because gstreamer is reporting slightly different durations (the diff
 is in the order of milliseconds) from what the tests expect.

That could be bug 646331.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-04-03 Thread Cpearce-t
(In reply to Matthew Gregan [:kinetik] from comment #265)
 (In reply to Alessandro Decina from comment #263)
  I started running the mochi tests in content/media/ and fixed a good number
  of issues already. Not all the tests pass, but most of those that don't pass
  fail because gstreamer is reporting slightly different durations (the diff
  is in the order of milliseconds) from what the tests expect.
 
 That could be bug 646331.

You mean when GStreamer is playing the Ogg/WebM files rather than
Firefox's built in decoders? If so GStreamer must be returning durations
different to the built in decoders, otherwise the built in decoders
would be failing the tests too. If we set the durations in manifest.js
to the durations the built in decoders find, do the tests still fail?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-21 Thread Riles
I withdraw my rejection in comment 255, and agree with the plan to
review and land Alessandro Decina's patch.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-16 Thread Chris Double
);
 +  GstStructure *s = gst_caps_get_structure(caps, 0);
 +  gst_structure_get_int(s, rate, (gint *) mInfo.mAudioRate);
 +  gst_structure_get_int(s, channels, (gint *) mInfo.mAudioChannels);
 +  mInfo.mHasAudio = true;

Might need to sanity check these values to ensure they're within a valid
range (to prevent overflow's, etc later). Ditto with the video
parameters later.

::: content/media/gstreamer/nsGStreamerReader.h
@@ +73,5 @@
 +  }
 +
 +private:
 +  static void NewDecodedPadCb(GstElement *aDecodebin, GstPad *aPad,
 +gboolean last, gpointer aUserData);

s/last/aLast

@@ +103,5 @@
 +  void NewAudioBuffer();
 +
 +  static void EosCb(GstAppSink *aSink, gpointer aUserData);
 +  void Eos(GstAppSink *aSink);
 +

Can you add comments to the functions above with a brief explanation of
when/why they're called.

@@ +121,5 @@
 +  GstAppSinkCallbacks mSinkCallbacks;
 +  mozilla::ReentrantMonitor mGstThreadsMonitor;
 +  GstSegment mVideoSegment;
 +  GstSegment mAudioSegment;
 +  bool mReachedEos;

Some comments for what these are used for, threading requirements (if
any), etc if possible.

::: js/src/ctypes/libffi/Makefile.am
@@ +82,4 @@
  
  MAKEOVERRIDES=
  
 +ACLOCAL_AMFLAGS= -I m4

Was this included in the patch by mistake?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-15 Thread Blassey-bugs
Comment on attachment 605705
nsBuiltinDecoder* based implementation

Alessandro, did you want someone to review this patch? If so, you'll
need to request review from a module owner or peer on the patch's
details page.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-15 Thread Henri Sivonen
Comment on attachment 605705
nsBuiltinDecoder* based implementation

+  video/3gpp

Does IE9 support this MIME type? If not, we probably shouldn't, either,
to avoid format proliferation.

(Thank you for the patch. Very topical for the discussion in dev-
platform.)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-15 Thread Cpearce-t
Comment on attachment 605705
nsBuiltinDecoder* based implementation

Passing review to Chris Double, he's much more knowledgeable about
GStreamer than I.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-14 Thread Alessandro Decina
Created attachment 605705
nsBuiltinDecoder* based implementation

tl;dr: I'm attaching a new, simpler patch that adds gst decoding
support to firefox, based on the recent(ish) gecko
nsBuiltinDecoder* interfaces. Hopefully this version will be
easier to review, merge and maintain.

I'm a gst developer and I deal with embedded devices a lot. I
recently started working on this patch as I'm interested in
porting b2g to new devices. Also more generally, i'd like to see
firefox do media playback as efficiently as possible on embedded
devices, making use of gst's hw support.

Two weeks ago, after the GStreamer SDK effort was announced
(http://is.gd/tteunv), I decided to pick up the existing firefox
gst patch.  After getting familiar with it and the gecko media
code, and after an half failed rebase attempt (content/media/ has
changed significantly and the patch has bitrotten a bit), I
decided to write a new gst decoder based on the recent
nsBuiltinDecoder* interfaces in gecko.

My approach is deliberately simpler than the older patch. My goal
was to just get hw decoding support through gst, delegating the
rest of the work (i/o, synchronization, rendering, state
management etc) to the existing media code like the WebM and OGG
decoders do.

The code is self contained and 99% of it is in the
nsGStreamerReader class in
content/media/gstreamer/nsGStreamerReader.cpp. In terms of lines
of code and complexity, it's comparable to nsWebMReader and
nsOggReader. 

Internally it uses the following gst pipeline: appsrc !
decodebin2 name=d d. ! ffmpegcolorspace !
video/x-raw-yuv,format=I420 ! appsink d. ! audioconvert !
audioresample ! appsink.

In english: it feeds data from gecko to gstreamer using appsrc,
decodes using the decodebin2 element and feeds a/v back to
firefox using appsink elements.

The patch adds an --enable-gstreamer opt-in switch to configure.
When enabled, it currently takes over WebM and OGG decoding and
adds H264 support (see my closing note efore starting flames on
this please). Eventually i think i'd like to make it
takeover WebM and OGG decoding depending on runtime prefs.

I tested the patch on OSX. I've got accelerated h264 decoding
(supported by the gst applemedia plugin) working but it requires
a colorspace conversion currently, which I plan to fix soonish in
the plugin. After that, my goal is to make firefox mobile do hw
accelerated decoding on android using the gst-omx plugin. 

There are a few known bugs at this point, the major one being
that I need to implement efficient buffer allocation. Also the
the bytes-read, frames-parsed/decoded stats are not implemented
yet. Being my first firefox patch, there are probably also plenty
of stylistic fixes needed. Anyway, overall I think it's good for
a first review.

Please note: i don't want to get into the argument of whether
firefox should support h264 decoding or not. The patch currently
adds h264 decoding only so that I could test and demo accelerated
decoding on OSX. I think decoding using gst has merits regardless of
whether h264 ends up being supported or not. I'm more than
willing to remove h264 support from the patch if that makes it
easier to get it merged.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Konstartyom
When is this going to be landed anywhere? A very large piece work have
done, and Firefox would have a lot of cool multimedia features (choosing
audio back-end without recompilation, hardware video acceleration
through experimental va-api gstreamer modules, ffmpeg support etc) at
least on Linux with gstreamer installed, if you landed it. Do you still
plan adding compile-time option?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Connor Behan
I completely agree. I'm aware of all the comments telling us to stay on
topic but at this point, that amounts to telling us to be content with
the fact that a perfectly good patch is collecting dust. If the patch
is still not ready, please give Oleg a list of ATTAINABLE GOALS
explaining how it needs to be improved. Since months have gone by
without this being posted, I can only assume that the developers with
commit access are either ignoring this patch or discussing it behind
closed doors.

The longer they wait to add this option and make it enabled by default,
the more Firefox will lag behind the newer browsers.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Chris Double
(In reply to Connor Behan from comment #238)
 If the patch is still
 not ready, please give Oleg a list of ATTAINABLE GOALS explaining how it
 needs to be improved. Since months have gone by without this being posted, I
 can only assume that the developers with commit access are either ignoring
 this patch or discussing it behind closed doors.

No one has asked for review on the patch recently which is probably why
it hasn't had any feedback since the last review cycle. Running the
media mochitests with this patch applied will also give an indication of
how close it is to being complete (I have not done this recently).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Riles
My opinion is that we shouldn't land these patches at this time.

This is essentially for policy reasons:

Running codecs beyond the minimal set we support presents a larger
surface to security review.

Running codecs which other browsers don't support doesn't help web
authors. Our goal is not to inspire web pages 'Best viewed in Firefox'.
Quite the opposite. So adding the wide range of formats gstreamer offers
doesn't advance the web as a platform.

These are the main reasons we haven't added support for codecs like
speex, flac, opus, jpeg2000, jpeg-xr, webp, etc. We have a wav reader in
mozilla-central for debugging, but it's disabled by default.

We have for some years been holding the line against for royalty-free
codecs in HTML against very strong commercial and market pressure,
because the patent terms available for otherwise popular formats like
mp3 and mp4 are incompatible with our principles of user freedom.
Requiring an alternative while flash adoption is falling is an important
check against those commercial interests. Hooking into platform-level
support for those codecs would greatly weaken that stance.

I appreciate the work that's been done on these patches, but unlike
doublec I don't think the code should be in the tree, even disabled by
default. I think the bug should stay open in case we are forced to
reverse our position on mp4, in which case we'll probably want this code
in hurry.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Romaxa
This patch was hacked by 3-4 different people. and it is a bit outdated.
Right way to add gstreamer support is open interface which would allow to use 
external codecs (HW accelerated, gstreamer et.c.) so community could maintain 
media plugins separately. and IIUC Bug 714408 exactly implementing that 
interface.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Romaxa
 think the bug should stay open in case we are forced to reverse our
position on mp4

Support for random proprietary codecs and unwanted formats like mp4 is one side 
of the problem.
Most important reason why we should have media plugin interface, is that 
different mobile platforms might have HW accelerated decoding for WebM and Ogg, 
and the only way to use these accelerated codecs implementation is media 
interface.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Riles
Kinetik pointed out the wav decoder is actually built by default,
there's just no media document for it. It works as a source for an
audio element. It's the support for 'raw' video data which is disabled
by default.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Connor Behan
(In reply to Ralph Giles (:rillian) from comment #241)
 Running codecs which other browsers don't support doesn't help web authors.
 Our goal is not to inspire web pages 'Best viewed in Firefox'. Quite the
 opposite. So adding the wide range of formats gstreamer offers doesn't
 advance the web as a platform.

But these are formats that other browsers DO support. It's the main
reason that Firefox has been losing so much ground to Chrome. Users
aren't happily taking up your mission of resisting H.264 and most of
them don't even know why H.264 videos are failing to play for them. I've
heard many people shrug it off as firefox is buggy with video, use
chrome.

 We have for some years been holding the line against for royalty-free codecs
 in HTML against very strong commercial and market pressure, because the
 patent terms available for otherwise popular formats like mp3 and mp4 are
 incompatible with our principles of user freedom.

And linking to Flash in a plugin suggestion box isn't? The whole point
of this patch is that it will absolve Firefox of the dilemma to support
non-free codecs. If you already had your mind made up that you would not
support extra codecs even in this indirect way, I think that is unfair
to the people that have worked hard on this patch, probably because they
thought it had a chance of being accepted before the mp4 patent expires.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Sven
(In reply to Ralph Giles (:rillian) from comment #241)
 My opinion is that we shouldn't land these patches at this time.

I think your main points are:
1) Holding the line against for royalty-free codecs
2) Security issues

I'm not sure, whether using gstreamer would HAVE to result in mp4
support. You could probably limit gstreamer to specific container/codec
combinations on purpose. Also, including another library always includes
security risks.

However, I'm not convinced that FireFox does the best it can to playback
videos. Especially on older systems, I expected HTML5 to be faster than
Flash. Turns out, HTML5 on youtube is worse than Flash - at least in
FireFox. Firefox uses slightly more CPU and the X server process
consumes more than twice as much CPU as when using Flash. Using a native
player consumes less than half the CPU time flash needs and of course
much less than half the HTML5 player on youtube.

As far as I understand, it was also raised in this thread that using
gstreamer can have advantages in those areas as well (vaapi, vdpau,
opengl?). I leave it up to you, whether improvements in these areas are
to be achieved with or without gstreamer.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Connor Behan
(In reply to Oleg Romashin (:romaxa) from comment #242)
 This patch was hacked by 3-4 different people. and it is a bit outdated.
 Right way to add gstreamer support is open interface which would allow to
 use external codecs (HW accelerated, gstreamer et.c.) so community could
 maintain media plugins separately. and IIUC Bug 714408 exactly implementing
 that interface.

The gstreamer patch is only outdated because Mozilla let it rot in the
bugtracker rather than committing it a year ago. Bug 714408 may have a
better API but it is entirely unclear if anyone will take on the task of
porting it a non-mobile platform in the foreseeable future. And when
someone does it will probably face the same political barriers that are
stopping the patch from being ready now.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Josh Triplett
(In reply to Connor Behan from comment #245)
 (In reply to Ralph Giles (:rillian) from comment #241)
  Running codecs which other browsers don't support doesn't help web authors.
  Our goal is not to inspire web pages 'Best viewed in Firefox'. Quite the
  opposite. So adding the wide range of formats gstreamer offers doesn't
  advance the web as a platform.
 
 But these are formats that other browsers DO support. It's the main reason
 that Firefox has been losing so much ground to Chrome. Users aren't happily
 taking up your mission of resisting H.264 and most of them don't even know
 why H.264 videos are failing to play for them. I've heard many people shrug
 it off as firefox is buggy with video, use chrome.

http://blog.chromium.org/2011/01/html-video-codec-support-in-chrome.html

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Connor Behan
(In reply to Josh Triplett from comment #248)
 (In reply to Connor Behan from comment #245)
  (In reply to Ralph Giles (:rillian) from comment #241)
   Running codecs which other browsers don't support doesn't help web 
   authors.
   Our goal is not to inspire web pages 'Best viewed in Firefox'. Quite the
   opposite. So adding the wide range of formats gstreamer offers doesn't
   advance the web as a platform.
  
  But these are formats that other browsers DO support. It's the main reason
  that Firefox has been losing so much ground to Chrome. Users aren't happily
  taking up your mission of resisting H.264 and most of them don't even know
  why H.264 videos are failing to play for them. I've heard many people shrug
  it off as firefox is buggy with video, use chrome.
 
 http://blog.chromium.org/2011/01/html-video-codec-support-in-chrome.html

Ok, I stand corrected.

Nevertheless, a chromium user who is serious about HTML5 video can
download chromium-codecs-ffmpeg from a (most likely unofficial)
repository. A firefox user who wants the same thing has to download
gstreamer-ffmpeg from an unofficial repository and recompile a patched
firefox. So ground is probably still being lost.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Lars-naty
(In reply to Ralph Giles (:rillian) from comment #241)
 My opinion is that we shouldn't land these patches at this time.
 
 This is essentially for policy reasons:
[..]
 We have for some years been holding the line against for royalty-free codecs
 in HTML against very strong commercial and market pressure, because the
 patent terms available for otherwise popular formats like mp3 and mp4 are
 incompatible with our principles of user freedom. 

Hasn't it occured to you that people would like to make their own
choices about codec support? Is it because you think that your own
userbase is not principled enough for you that you force your choice on
all of us?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Josh Triplett
(In reply to Lars Olafsen from comment #250)
 (In reply to Ralph Giles (:rillian) from comment #241)
  My opinion is that we shouldn't land these patches at this time.
  
  This is essentially for policy reasons:
 [..]
  We have for some years been holding the line against for royalty-free codecs
  in HTML against very strong commercial and market pressure, because the
  patent terms available for otherwise popular formats like mp3 and mp4 are
  incompatible with our principles of user freedom. 
 
 Hasn't it occured to you that people would like to make their own choices
 about codec support? Is it because you think that your own userbase is not
 principled enough for you that you force your choice on all of us?

Mozilla's policy on codec support has nothing to do with what users
choose; it affects what *sites* choose.  Currently, sites provide WebM
video as well, because several browsers only support WebM.  If most or
all browsers support H.264, sites will only provide H.264 video.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Konstartyom
(In reply to Ralph Giles (:rillian) from comment #241)
 Running codecs which other browsers don't support doesn't help web authors.
 Our goal is not to inspire web pages 'Best viewed in Firefox'. Quite the
 opposite. So adding the wide range of formats gstreamer offers doesn't
 advance the web as a platform.

Why not? Nowadays web becomes a platform for new OSs. And although we could 
play unsupported web video in media player (what I do with h264 videos in the 
web) on traditional PC, on web OS browser itself becomes a multimedia player. I 
think, supporting as much as possible video formats is a good idea in that 
case. It even helps to increase popularity of the new html5 video technology 
against the proprietary flash. 
 
 We have for some years been holding the line against for royalty-free codecs
 in HTML against very strong commercial and market pressure, because the
 patent terms available for otherwise popular formats like mp3 and mp4 are
 incompatible with our principles of user freedom. Requiring an alternative
 while flash adoption is falling is an important check against those
 commercial interests. Hooking into platform-level support for those codecs
 would greatly weaken that stance.

Why do you think adding gstreamer support will kill free WebM codec? There is 
still a lot of people that cannot use non-free formats in gstreamer and if web 
developer want to make a page playable in every browser he should still add 
WebM/Ogg coded media. The other side of the coin is that a huge amount of 
people may use non-free media formats without any law restrictions and they 
will probably migrate to Chrome if you don't add an ability to play these 
formats.
The only practical disadvantage of landing this patch is that such architecture 
is really bad. Maybe, it should be modular: support of free formats in browser 
itself and something like plug-in/extention for others (code for supporting 
free formats could be also converted to a module, but developed and supported 
by Mozilla). Such API would be very suitable. It would be possible to write 
backend for native codec support on every OS and keep Firefox as a single 
project with no branches like 'with gstreamer support', 'with Windows codecs 
support' etc. Gstreamer support in this case may be used as a first example of 
such module. Is this possible?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread dqe...@gmail.com
(In reply to konstartyom from comment #252)
 Why do you think adding gstreamer support will kill free WebM codec? 

Because WebM sucks. Its far inferior to h.264

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Villalu
This is really not the place for this discussion. Please take it
elsewhere.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Riles
 (In reply to Ralph Giles (:rillian) from comment #241)

 As far as I understand, it was also raised in this thread that using
 gstreamer can have advantages in those areas as well (vaapi, vdpau,
 opengl?). I leave it up to you, whether improvements in these areas are to
 be achieved with or without gstreamer.

It's true that gstreamer could let us adopt technologies like that more
quickly, since the maintenance burden would be shared. Especially if we
were able to use Gstreamer on more than traditional GNU/Linux systems.

However, one of the reasons playback in the browser is slower than a
dedicated player is that one can do more with the output, such as css
transformations, html rendered on top, etc. We'd like to make that
faster, and I expect that will happen over time, but right now it's
slower because it's not just decoding straight to the application's
compositor buffer.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Connor Behan
Yes, Flash chose to make itself slow in that regard:
http://swfdec.freedesktop.org/wiki/FAQ Supporting these relatively
useless features came at a large performance cost. I was kind of hoping
that HTML5 wouldn't make the same mistake :S

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-03-12 Thread Chris Double
Bug 714408 adds support for a media plugin framework for HTML video.
Whilst it is b2g specific at the moment it'd be interesting to refactor
the gstreamer support into that framework so that it'd provide dynamic
loading of gstreamer support if it was available.

This would also involve refactoring to fit in with the 'builtin decoder'
changes that were made when WebM was supported and cut down on the
amount of code in the patch itself since many things like event handling
would be provided by the builtin code.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-02-26 Thread Nirbheek
(In reply to Diego Viola from comment #235)
 Is there a browser that already have GStreamer support?

Browsers that use webkit-gtk (epiphany, midori, etc) use GStreamer for
audio and video.

PS: this subject is off-topic for this bug, so let us not submit any
more comments about this here.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2012-02-26 Thread Diego Viola
I'd like to have this, I think GStreamer would bring two good things to
Firefox: FFmpeg and PulseAudio, which is nice for HTML5 video, etc.

e.g.

Firefox - GStreamer - FFmpeg
Firefox - GStreamer - PulseAudio

Can't wait.

Is there a browser that already have GStreamer support?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-12-25 Thread Josh Triplett
Just checking on the status of this bug.  The last patch review seems to
have occurred about 11 months ago, and the latest patch appeared 4
months ago.  What issues remain that prevent merging the current patch?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-08-26 Thread Romaxa
Created attachment 555879
Latest tip 49884897bb5c patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-01-25 Thread Timeless-bemail
If people don't mind, I'd like to request that this bug be limited to
technical comments on the current work and not political comments or
requests for features.

If people have questions beyond the actual technical code, I
respectfully request that they contact people via email, irc, or some
other means.

Note: Stefan's comments are on topic since they're technical review
points. The next four comments (including this one) are off-topic.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-01-22 Thread Stefan Kost
(In reply to comment #227)
 Comment on attachment 503489 [details]
 Latest Gstreamer patch
 
 +static GstFlowReturn gst_fennecvideosink_buffer_alloc(GstBaseSink* aBsink,
 +{
 +  // Allocate a buffer with new
 +  void *newBuffer;
 
 +  // Allocating 128 byte aligned memory.
 +  if (posix_memalign(newBuffer, 128, ROUND_UP(aSize, 128)) != 0)
 +newBuffer = NULL;
 
 +  if (!*aBuf) {
 +// Release the mem we got
 +delete [] newBuffer;
 
 coverity notes that delete (array) is wrong for void*. your allocator here is
 posix memalign, so the release should be posix-something not c++ delete

For performance reasons it would be really good if the sink could manage
a list of buffers and receycle them. Ideally the memory would point to a
location where fennec would render from so that no extra dcopy or other
data transfer would be needed.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-01-22 Thread Tihokibertron
Would it be reasonable to add GStreamer support as a non-default compile
time option for desktop FF releases?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-01-22 Thread Romaxa
(In reply to comment #229)
 Would it be reasonable to add GStreamer support as a non-default compile time
 option for desktop FF releases?
I would like to have it too, possibly it may bring possibility to create DSP 
optimized codecs support and make xulrunner codebase usable for non-FF 
applications like songbird or similar

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-01-22 Thread Chris Double
(In reply to comment #229)
 Would it be reasonable to add GStreamer support as a non-default compile time
 option for desktop FF releases?

This is what I hope will be the result of this bug. GStreamer support
available as a compile time option, turned off by default.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-01-21 Thread Timeless-bemail
Comment on attachment 503489
Latest Gstreamer patch

+static GstFlowReturn gst_fennecvideosink_buffer_alloc(GstBaseSink* aBsink,
+{
+  // Allocate a buffer with new
+  void *newBuffer;

+  // Allocating 128 byte aligned memory.
+  if (posix_memalign(newBuffer, 128, ROUND_UP(aSize, 128)) != 0)
+newBuffer = NULL;

+  if (!*aBuf) {
+// Release the mem we got
+delete [] newBuffer;

coverity notes that delete (array) is wrong for void*. your allocator
here is posix memalign, so the release should be posix-something not c++
delete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2011-01-14 Thread Romaxa
Created attachment 503489
Latest Gstreamer patch

Latest gstreamer patch from maemo6 patch queue.
This probably still has some missing review comments. but I'll post it here: 
compatible with http://hg.mozilla.org/mozilla-central/rev/7fcae0c7f36a

I see one useful point here is:
1) possibility to integrate gstreamer codecs (DSP optimized webm/ogg)
2) useful for some XULRunner media applications in order to play all gstreamer 
available codecs.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 video tags

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2010-10-19 Thread Chris Double
Comment on attachment 465180
finding supported gstreamer codec/demuxer plugins

+if (nsnull == supportedCodecs) {
+#ifdef MOZ_GSTREAMER
+  NS_ConvertUTF16toUTF8 CodecTypeUTF8(token);
+  if (!IsGstSupportedType(CodecTypeUTF8.get()))
+return CANPLAY_NO;
+#endif
+} else {
+  if (!CodecListContains(supportedCodecs, token)) {
+// Totally unsupported codec
+return CANPLAY_NO;
+  }

If MOZ_GSTREAMER is mot defined then we have the empty if condition and
the else is ever executed. Can you restructure this to avoid that.

+ * The Initial Developer of the Original Code is the Mozilla
Corporation.

Apparently this should be 'Mozilla Foundation' not 'Mozilla
Corporation'. I realize lots of existing media code probably still has
Corporation sadly. You should take the header from the official
boilerplate rather than copying it from other files. See here:

http://weblogs.mozillazine.org/gerv/archives/2010/02/mpl_initial_developer_for_mozilla_employ.html

+ * Portions created by the Initial Developer are Copyright (C) 2007

Change year from 2007 to 2010.

+struct _GstCodecDetails {
+ char klass[255]; // video/audio/demux
+ char feature[25]; //mimetype
+};

Use 2 space indents.

+  if (g_strrstr (gst_element_factory_get_klass (f), ((GstCodecDetails
*)data)-klass)) {

Use C++ style casts. static_cast, reinterpret_cast, etc. This applies
everywhere you are doing casts.

+GstStaticPadTemplate *pad_template;
+GList *template_list = f-staticpadtemplates;
+for (pad_template = (GstStaticPadTemplate *) template_list-data;
+ pad_template;
+ pad_template = (template_list = template_list-next) ? 
(GstStaticPadTemplate *) template_list-data : NULL) {
+  if (g_strrstr(pad_template-name_template, sink)  
g_strrstr(pad_template-static_caps.string, ((GstCodecDetails 
*)data)-feature)) {
+NS_GSTREAMER_LOG((caps:%s, feature:%s\n, 
pad_template-static_caps.string,  GST_PLUGIN_FEATURE_NAME(feature)));
+return TRUE;
+  }
+}
+  }
+  return FALSE;
+}

Restructure code so it fits within 80 characters.

+  /* Initialisation */
+  gst_init_check(0, 0, NULL);

The docs for gst_init_check say:

  This function should be called before calling any other GLib
functions. 

How are you ensuring this is the case? Also, check return value.

-- 
Firefox is not able to play mp4 video tags
https://bugs.launchpad.net/bugs/412647
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2010-10-19 Thread Chris Double
Comment on attachment 462048
gstreamer changes alone in single patch

+# The Initial Developer of the Original Code is the Mozilla Corporation.
+# Portions created by the Initial Developer are Copyright (C) 2007

Initial developer should be Mozilla Foundation and update copyright to
2010. This change should be done to all the license headers included in
the patch.

+// Define the max size of video elements in pixels
+// Copied from the OGG decoder (Jan 29 - 2010)
+#define MAX_VIDEO_WIDTH  4000
+#define MAX_VIDEO_HEIGHT 3000

This should probably be declared somewhere in content/media so it can be
shared between the decoders.

+// Define how much data we should try to read at a time,
+// changing the value can potentially decrease or increase performance.
+// Feel free to experiment
+#define GST_BUFFER_READ_CHUNK_SIZE 1024*16

Should have brackets: (1024*16)

+// Check that we are compatible with the GStreamer version (we wish to support
+// the build system for the N800, but can't actually run on something older
+// than 0.10.25 (as in the Nokia N900)
+#if 10  GST_VERSION_MINOR || (22  GST_VERSION_MICRO  10 == 
GST_VERSION_MINOR)
+#error We do not support versions of the GStreamer library previous to 
0.10.22 \
+  while building, and previous to 0.10.25 when running.
+#endif

Is this checked in 'configure' as well?

+  mUnknownTypeSignal = g_signal_connect( mDecodeBin,
+ unknown-type,
+ G_CALLBACK(DecodeBinUnknownType),
+ this);

Remove spacing after the bracket and first function parameter. This
happens in another place too.

+void nsGStreamerDecodeBin::DecodeBinNewPadAdded(void *,
+GstPad * aPad,
+gboolean aIsLast,
+nsGStreamerDecodeBin * aMe)

Align the '*' immediately after the type name. ie. no spacing:

GstPad* aPad,
nsGStreamerDecodeBin* aMe)

Make this change everywhere this appears.

+{
+  // Check pre-conditions
+  PR_ASSERT(aMe);
+  PR_ASSERT(aMe-mPadDest);

Why use PR_ASSERT instead of NS_ equivalents?

+NS_IMETHODIMP nsGStreamerDecoder::Observe(nsISupports *aSubjet,
+  const char *aTopic,
+  const PRUnichar *someData)

Align arguments.

+  // Forwarder function to enable access to a protected member of the base 
class
+  void SetVideoData(PRInt32 aWidth,
+PRInt32 aHeight,
+float aFramerate,
+float aAspectRatio,
+Image *aImage)
+{
+  gfxIntSize aSize;
+  aSize.width=aWidth;
+  aSize.height=aHeight;
+
+  nsMediaDecoder::SetVideoData(aSize,
+   aAspectRatio,
+   aImage);
+};

Drop { .. } to align with 'void'.

+  // Define cleanup macro
+#define NSGSTREAMER_INPUT_BIN_INIT_RETURN_FAILURE(arg) \
+  NS_GSTREAMER_LOG((Failure due to :  arg )); \
+  Shutdown(); \
+  return PR_FALSE;

I'm not a fan of declaring macros inside functions since their scope is
global. Put this at the top of the file in global scope. It can have a
shorted name too.

+  // Retrieve the src pad of the app source element
+  GstPad *pad = gst_element_get_static_pad(mAppSrc, src);
+
+  if(!pad) {
+NSGSTREAMER_INPUT_BIN_INIT_RETURN_FAILURE(Couldn't get static pad from 
+  mAppSrc element\n);
+  }
+
+  // Create a ghost pad
+  GstPad *ghostPad = gst_ghost_pad_new(src, pad);
+
+  if(!ghostPad) {
+NSGSTREAMER_INPUT_BIN_INIT_RETURN_FAILURE(Couldn't create ghost pad\n);
+  }

The 'pad' needs to be unrefed here since the macro results in a return.

+  // Add the ghost pad to the input bin
+  if(!gst_element_add_pad(GST_ELEMENT_CAST(mInputBin), ghostPad)) {
+NSGSTREAMER_INPUT_BIN_INIT_RETURN_FAILURE(Couldn't attach pad to bin);
+  }

Does the ghostPad need to be unrefed here?

+  // Obtain lock
+  PR_Lock(mElementWrapperLock);
+  // Store the element wrapper
+  mElementWrapper = aElementWrapper;
+  // Release lock
+  PR_Unlock(mElementWrapperLock);

For this and all other uses of PR_Lock/PR_Unlock, use nsAutoLock.

+// The data source data can be read from
+nsMediaStream *mNsMediaStream;

No need for the 'Ns' in the name. Just call it mMediaStream or something
like that.

+// TODO: Add some thread protection to the below two memebers

Spelling of 'members'

+// See if we can initialize the lib
+if (gst_init_check(0, 0, gstreamerErrorText)) {

gst_init_check has this requirement:

 This function should be called before calling any other GLib
functions

How are you managing this?

+  if (0 == major  10 == minor  25 = micro) {

Throughout 

[Bug 412647]

2010-10-19 Thread Timeless-bemail
+NS_IMETHODIMP nsGStreamerDecoder::Observe(nsISupports *aSubjet,

please spell Subject correctly

+  const PRUnichar *someData)

this should be aData - and this convention should be followed for all
arguments to functions...

-- 
Firefox is not able to play mp4 video tags
https://bugs.launchpad.net/bugs/412647
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647]

2010-10-14 Thread Roc-ocallahan
Comment on attachment 461487
gfx/layers changes for arm

See comment #201

-- 
Firefox is not able to play mp4 video tags
https://bugs.launchpad.net/bugs/412647
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 412647] Re: Firefox is not able to play mp4 video tags

2010-09-13 Thread Bug Watch Updater
** Changed in: firefox
   Importance: Unknown = Wishlist

-- 
Firefox is not able to play mp4 video tags
https://bugs.launchpad.net/bugs/412647
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


  1   2   >