Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
Wouldn't hangling '' as the commentin the same way the 'add attachment' web form does be sane? Then the web form could be ajaxified too :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
On 27 April 2011 19:09, Brian Murray wrote: > Well the api requires a comment when adding an attachment so it doesn't > seem that there is a way to modify apport to prevent multiple email > messages. Ah, see, here's the problem: Internally `comment` can be either a string or an IMessage, which is how we can theoretically have several attachments linked to one comment. In the declaration for IBug, we see: @operation_parameters( data=Bytes(constraint=attachment_size_constraint), comment=Text(), filename=TextLine(), is_patch=Bool(), content_type=TextLine(), description=Text()) @export_factory_operation(IBugAttachment, []) def addAttachment(owner, data, comment, filename, is_patch=False, content_type=None, description=None): So, the problem is that the API won't let you pass a message in to addAttachment(). If we want to change that we should probably track it elsewhere. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
What if you have an empty comment, or does it reject that? If it rejects it its probably a bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Well the api requires a comment when adding an attachment so it doesn't seem that there is a way to modify apport to prevent multiple email messages. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
@Brian: yes, that's exactly what Graham reported. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Gary does this mean that if apport were not to actually comment and only add attachments this would reduce the quantity of emails? For example in https://bugs.launchpad.net/ubuntu/+source/xserver-xorg- video-intel/+bug/750259/comments/7 - we can see apport adds a message of 'apport information'. If we were to remove that from apport would all the attachments being added be sent in one email? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Graham investigated the status of aggregating attachments in notification emails. Launchpad already aggregates attachments that are from the same person and for the same bug. Therefore, this bug, as described in its title and in the goals set out by Deryck and Graham, is fixed. I've marked it fix released. However, we only allow each notification to contain a single comment. Apport includes comments with each attachment. Therefore, we might be able to solve the original complaint that led this bug to be filed by allowing notifications to aggregate comments (in additions to metadata and attachments). I filed this as bug 768997. ** Changed in: launchpad Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
** Changed in: launchpad Status: Triaged => In Progress ** Branch linked: lp:~gmb/launchpad/bug-424849 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Marking this as Triaged again since we won't be coming back to it until after the new subscription UI work is done. ** Changed in: malone Status: In Progress => Triaged ** Changed in: malone Milestone: 10.08 => None -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
** Tags added: story-better-notification-sending -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
** Changed in: malone Milestone: 10.07 => 10.08 -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
** Branch linked: lp:~gmb/launchpad/batch-attachment-notifications- bug-424849 ** Changed in: malone Status: Triaged => In Progress ** Changed in: malone Assignee: (unassigned) => Graham Binns (gmb) ** Changed in: malone Milestone: None => 10.06 -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
** Changed in: malone Status: In Progress => Triaged ** Changed in: malone Assignee: Graham Binns (gmb) => (unassigned) -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
** Changed in: malone Assignee: (unassigned) => Graham Binns (gmb) ** Changed in: malone Status: Triaged => In Progress ** Branch linked: lp:~gmb/launchpad/batch-attachment-notification- emails-bug-424849 -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Thanks for the detailed explanation, Graham. That meshes with my understanding of what we do, too. That is a nice example of the advantage to sending mail from the bug rather than the person, but I think it should be a separate concern and we should consider this bug fixed when we batch attachments from the same person. That's an easy fix and and easy win. We should open a bug about batching comments themselves, assuming we can find a nice way to do that. I would have thought that bug existed, but I cannot find one. Otherwise, as Graham says, we do this genrally okay now. It's just not obvious to people because comments are common, frequent, and can break batching of other changes in unexpected ways. Cheers, deryck -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
On 6 June 2010 01:46, Deryck Hodge wrote: > Don't we batch in 5 minute (or some such) intervals now? Except for > comments and attachments, of course. > > I thought that was the point of this bug, to enable batching for > attachments. We batch in five minute intervals but comments mark the boundaries between batches, so if you make a bunch of changes and add a comment and then someone else makes a bunch of changes you'll get two separate notifications. Attachments cause problems because they each get their own comment, so we send out one notification per attachment. Otherwise our batching is quite sane at the moment. We *might* be able to move to five-minute digests when we've fixed all the Launchpad-fakes-email-addresses bugs. The easy fix to some of those bugs is to start to use <$bu...@bugs.launchpad.net> as the From address for notifications and if we do that we may be able to change notification emails to look like this: From: Bug $FOO <$...@bugs.launchpad.net> ... ** Graham Binns (gmb) made the following changes * In Ubuntu: * status Incomplete -> Confirmed * Comment added: This new digest thing is the bomb isn't it? ** Deryck Hodge (deryck) made the following changes: * In Malone * status Incomplete -> Fix Released * Comment added: Yeah, it's not bad. But I'm not yet convinced that there would be a massive reduction in bug mail traffic if we did that, or at least not a reduction directly related to the batching of attachment notifications. -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
Well, when there are many consecutive comments I have the impression that I get many consecutive e-mails? Is this wrong impression? The idea is that many comments sent in the same block of time don't result in many e-mails. I rarely see something batched. The most common is a status change following or followed by a comment, which result in only one e-mail for both actions. -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Don't we batch in 5 minute (or some such) intervals now? Except for comments and attachments, of course. I thought that was the point of this bug, to enable batching for attachments. -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
On 4 June 2010 20:10, Leo wrote: > Is it simpler to detect and batch attachments than just replacing on- > the-fly notifications by 5-minute-interval digests? > At this point, yes. The bug notification code (which can be found in lib/canonical/launchpad/mailnotification.py [1] for anyone who wants to take a look) is pretty ugly and is in sore need of refactoring. As part of that work we may look at how batching works and whether we need to do something different, but that's not the first thing on our list of priorities. This bug is causing a lot of noise, so it's better to fix this sooner rather than later. [1] http://bazaar.launchpad.net/~launchpad- pqm/launchpad/devel/files/head:/lib/canonical/launchpad/mailnotification.py -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Is it simpler to detect and batch attachments than just replacing on- the-fly notifications by 5-minute-interval digests? -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Graham: In that case, should I report a new bug with a more ambiguous summary? -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
Graham, this bug concerns more than just attachment emails - it is also about changing tags, summary, importance, etc. ** Summary changed: - Launchpad should batch attachment notification emails + Launchpad should batch notification emails -- Launchpad should batch notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 424849] Re: Launchpad should batch attachment notification emails
** Summary changed: - merge multiple notification emails into one + Launchpad should batch attachment notification emails ** Changed in: malone Importance: Low => High -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
