Re: [Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-16 Thread Scott Kitterman
Not past final freeze for Universe.  Go ahead.

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-16 Thread Benjamin Drung
sync request ACK'd

** Changed in: phatch (Ubuntu)
   Status: New = Confirmed

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-15 Thread stani

** Attachment added: phatch_0.2.4-1_amd64.build
   http://launchpadlibrarian.net/33749895/phatch_0.2.4-1_amd64.build

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-15 Thread Piotr Ożarowski
attaching debdiff (0.2.3-2ubuntu1 - 0.2.4-1 without '*/docs/*')

** Attachment added: phatch.debdiff
   http://launchpadlibrarian.net/33751155/phatch.debdiff

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-15 Thread Benjamin Drung
Is the */docs/* diff so huge or why did you remove it?

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-15 Thread Piotr Ożarowski
with docs directory (docs are regenerated at build time, btw) the
debdiff would have 48637 lines and I assumed you're not interested in
these changes (see attached diffstat)

** Attachment added: phatch.diffstat
   http://launchpadlibrarian.net/33752250/phatch.diffstat

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-15 Thread Benjamin Drung
At build time? Didn't you use the debdiff command to generate the diff?

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-15 Thread stani
The */docs/* are shipped in the upstream tarball as source restructured
text *.rst, which are converted by sphinx to *.html. Debian and Ubuntu
ignore the shipped *.html files and use sphinx at build time to
regenerate them from the source *.rst files. I don't know if this is a
Debian policy, but besides as the upstream author I would also recommend
it to ensure the html files are always up to date. (As a human being I
might forget to update the html files before doing a release.)

The diff we are seeing here affects only the */docs/build/html/* files,
which are ignored by Debian/Ubuntu, but not the */docs/source/*.rst
files which are used by Debian and Ubuntu. So this diff does not matter
for Debian and Ubuntu at all.

If you would be curious why the html changes and not the rst source
files, this is because the html uses now a left navigation sidebar
instead of a right navigation sidebar which affects the html code (but
not the rst source). But again, this is of no value for Ubuntu.

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-15 Thread Benjamin Drung
Looks good. I would give my ACK, but we are past final freeze.
Subscribing motu-release for the acknowledgment.

** Changed in: phatch (Ubuntu)
   Importance: Undecided = Wishlist

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 452430] Re: Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)

2009-10-15 Thread stani
@Benjamin
Thanks. I still hope it can be accepted, as one bug is *very* critical at least 
for phatch. Otherwise I would not take the effort to push this bugfix release.

-- 
Please sync phatch 0.2.4-1 (universe) from Debian Unstable (main)
https://bugs.launchpad.net/bugs/452430
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs