[Bug 495225] Re: Support application indicators for Lucid
** Changed in: rhythmbox Status: Invalid = Expired ** Changed in: rhythmbox Importance: Unknown = Wishlist -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
** Changed in: rhythmbox Status: New = Invalid -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
** Changed in: rhythmbox Status: Unknown = New -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
closing again since the bug is fixed in lucid and sent upstream now too ** Changed in: rhythmbox (Ubuntu) Status: Triaged = Fix Released -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
Brian, thanks.. yeah that works just fine. Let's just change one line to keep it a bit cleaner looking: -#if defined(HAVE_NOTIFY) +#if defined(HAVE_NOTIFY) defined(HAVE_APP_INDICATOR) -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
Per bug 510778:
If I try to build 0.12.6-1ubuntu6 without libappindicator-dev the build
breaks:
CCLD libstatus-icon.la
.libs/libstatus_icon_la-rb-tray-icon-gtk.o: In function
`rb_tray_icon_attach_notification':
/usr/src/rhythmbox-0.12.6/plugins/status-icon/rb-tray-icon-gtk.c:344: multiple
definition of `rb_tray_icon_attach_notification'
.libs/libstatus_icon_la-rb-status-icon-plugin.o:/usr/src/rhythmbox-0.12.6/plugins/status-icon/rb-status-icon-plugin.c:513:
first defined here
collect2: ld returned 1 exit status
make[5]: *** [libstatus-icon.la] Error 1
make[5]: Leaving directory `/usr/src/rhythmbox-0.12.6/plugins/status-icon'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/usr/src/rhythmbox-0.12.6/plugins/status-icon'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/usr/src/rhythmbox-0.12.6/plugins'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/usr/src/rhythmbox-0.12.6'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/src/rhythmbox-0.12.6'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Surely the addition of this patch should not cause a FTBS if one opts
not to use libappindicator.
This patch seems to correct the build error. I don't know how well it
fits in with the logic of adding the appinidicator though.
--- /tmp/old2010-01-21 12:49:22.0 -0500
+++ debian/patches/82_rhythmbox-indicators.patch2010-01-21
12:42:37.0 -0500
@@ -627,16 +627,18 @@
break;
default:
-@@ -488,6 +507,13 @@
+@@ -488,6 +507,15 @@
return TRUE;
}
++#if defined(HAVE_APP_INDICATOR)
+#if defined(HAVE_NOTIFY)
+void
+rb_tray_icon_attach_notification (RBTrayIcon *icon, NotifyNotification
*notification)
+{
+}
+#endif
++#endif
+
static void
notify_playing_entry (RBStatusIconPlugin *plugin, gboolean requested)
--
Support application indicators for Lucid
https://bugs.launchpad.net/bugs/495225
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
I'm going to keep this open as a tracker bug of getting the patch finished and upstreamed. Ken, Fix Release this when the patch is sent to the upstream bug tracker, thanks! ** Bug watch added: GNOME Bug Tracker #606972 https://bugzilla.gnome.org/show_bug.cgi?id=606972 ** Also affects: rhythmbox via https://bugzilla.gnome.org/show_bug.cgi?id=606972 Importance: Unknown Status: Unknown ** Changed in: rhythmbox (Ubuntu) Status: Fix Released = Triaged -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
** Tags added: indicator-application -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
This bug was fixed in the package rhythmbox - 0.12.6-1ubuntu2 --- rhythmbox (0.12.6-1ubuntu2) lucid; urgency=low * debian/control.in - Build-Depends on libappindicator-dev * debian/patches/82_rhythmbox-indicators.patch - Add support for application indicators (LP: #495225) -- Ken VanDine ken.vand...@canonical.com Thu, 10 Dec 2009 11:07:56 -0500 ** Changed in: rhythmbox (Ubuntu) Status: Confirmed = Fix Released -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
** Changed in: rhythmbox (Ubuntu) Status: New = Confirmed ** Changed in: rhythmbox (Ubuntu) Importance: Undecided = Wishlist -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
Generating against rhythmbox git master. ** Attachment added: rhythmbox-indicators-2.diff http://launchpadlibrarian.net/36670518/rhythmbox-indicators-2.diff ** Changed in: rhythmbox (Ubuntu) Assignee: (unassigned) = Ken VanDine (ken-vandine) -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
** Attachment added: configure output now says if libappindicator is not found http://launchpadlibrarian.net/36671887/rhythmbox-indicators-3.diff -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 495225] Re: Support application indicators for Lucid
** Branch linked: lp:~ken-vandine/rhythmbox/karmic ** Branch linked: lp:~ken-vandine/rhythmbox/lucid -- Support application indicators for Lucid https://bugs.launchpad.net/bugs/495225 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
