[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Ubuntu) Status: Incomplete = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/507072 Title: Add support for freenode ircd-seven CAP command To manage notifications about this bug go to: https://bugs.launchpad.net/xchat/+bug/507072/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Debian) Status: Fix Committed = Fix Released -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Debian) Status: New = Fix Committed -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
Current Terence's implementation violates CAP specs. Now xchat looks only to first capability returned by server. So, LS :identify-msg multi-prefix works, but LS :multi-prefix identify-msg doesn't. This patch makes xchat to look the whole cap list, not only the first one. ** Patch added: xchat.patch http://launchpadlibrarian.net/50810676/xchat.patch -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Ubuntu) Status: Fix Released = Incomplete -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Debian) Status: Fix Released = New -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Debian) Status: New = Fix Released -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Debian) Status: Unknown = New -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Bug watch added: Debian Bug tracker #565380 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=565380 ** Also affects: xchat (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=565380 Importance: Unknown Status: Unknown -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
I am unfamiliar with the XChat source, so the patch I produced was just an attempt at preserving the feature, the patch at http://adipose.attenuate.org/~stephen/ircd-seven/xchat-ircd-seven- identify-msg.patch.txt certainly looks cleaner than mine and does everything my patch does and more. I would suggest that the patch you posted be used instead of the one I provided, and so I've supplied a debdiff with the new patch. ** Attachment added: Debdiff 2.8.6-4ubuntu2 - 2.8.6-4ubuntu3 with new patch http://launchpadlibrarian.net/37876346/xchat_2.8.6-4ubuntu2_4ubuntu3.debdiff ** Changed in: xchat (Ubuntu) Status: Incomplete = New -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
Uploaded. Thanks for your work! I updated your patch to add a DEP3 header, like this: ## Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/xchat/+bug/507072 ## Bug: http://sourceforge.net/support/tracker.php?aid=2931474 ## Origin: http://adipose.attenuate.org/~stephen/ircd-seven/xchat-ircd-seven-identify-msg.patch.txt ## Description: Add support for ircd-seven CAP command. Could you also report it to Debian? Anyway, thanks! Fabrice ** Changed in: xchat (Ubuntu) Status: New = Fix Committed -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
Also reference the bug you are closing in your changelog :-) Manually closing the bug report. -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Ubuntu) Status: Fix Committed = Fix Released -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Attachment added: Debdiff 2.8.6-4ubuntu2 - 2.8.6-4ubuntu3 http://launchpadlibrarian.net/37855330/xchat_2.8.6-4ubuntu2_4ubuntu3.debdiff -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
Updated debdiff ** Attachment added: Debdiff 2.8.6-4ubuntu2 - 2.8.6-4ubuntu3 modified http://launchpadlibrarian.net/37855570/xchat_2.8.6-4ubuntu2_4ubuntu3.debdiff ** Bug watch added: SourceForge.net Tracker #2931474 http://sourceforge.net/support/tracker.php?aid=2931474 ** Also affects: xchat via http://sourceforge.net/support/tracker.php?aid=2931474 Importance: Unknown Status: Unknown -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
** Changed in: xchat (Ubuntu) Status: New = In Progress ** Changed in: xchat (Ubuntu) Assignee: (unassigned) = Fabrice Coutadeur (fabricesp) -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 507072] Re: Add support for freenode ircd-seven CAP command
Hi, It seems that the same guy that provide a patch for rssi, also provide a patch for xchat at http://adipose.attenuate.org/~stephen/ircd-seven/xchat-ircd-seven-identify-msg.patch.txt It looks a bit different to the one you're submitting: could you have a look and see what is done differently? At a first glance, the way the patch handles the command is cleaner, and less attack prone (by checking the length first, and then each character one by one, as done for other commands). Thanks, Fabrice ** Changed in: xchat (Ubuntu) Status: In Progress = Incomplete ** Changed in: xchat (Ubuntu) Assignee: Fabrice Coutadeur (fabricesp) = (unassigned) -- Add support for freenode ircd-seven CAP command https://bugs.launchpad.net/bugs/507072 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
