[Bug 539226]
xref bug 1058177 - gvfs within firefox process using 100% disk. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/539226/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226] Re: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS
Hi! When I go to File - Open - I don't see any network bookmars, only local folder. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/539226/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226] Re: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS
Starting with Ubuntu 11.04, Firefox is compiled with gio. Please report any other issues you may find. ** Changed in: firefox (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/539226/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226] Re: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS
** Changed in: firefox Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
The patch as checked in still is full of debugging g_warnings()s; I think they should be removed, as the reviewer in comment 5 and comment 16 also said. MapGIOResult(gint) converts GIOErrorEnum codes to nsresult, but MapGIOResult(GError*) hands it any GError's ->code without first checking that ->domain == G_IO_ERROR (there's no guarantee all those gio functions only return G_IO_ERROR errors). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
http://hg.mozilla.org/mozilla-central/rev/7c42f37e0284 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
http://hg.mozilla.org/projects/cedar/rev/7c42f37e0284 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Comment on attachment 502759 Patch 0.1, fixed license Agreed, this is too big of a change for Firefox 4 at this point. We'll get this in after branching! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226] Re: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS
** Changed in: firefox Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
I really think we should take this post-FF4. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
(In reply to comment #31) > Setting checkin-needed, is it possible? Unfortunately not. This patch need to be approved before landing on mozilla-central because we are too close to the release. If it's not approved, it will be able to be pushed after the release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Setting checkin-needed, is it possible? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
(In reply to comment #23) > ... this is not part of the default build ... To be more precise: This extension is not enabled by default. The only change to the default build here is a lookup of the service NS_NETWORK_PROTOCOL_CONTRACTID_PREFIX"moz-gio" (which won't normally be present). This is similar to what is done for the gnomevfs extension. The benefit of the patch is that distributions no longer shipping gnomevfs can enable the gio extension for similar behaviour using modern system libraries. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Created attachment 502759 Patch 0.1, fixed license -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Comment on attachment 502458 Patch 0.9, fixed comments and mount operation enum >+++ b/extensions/gio/Makefile.in Mon Jan 10 12:32:39 2011 +0100 >+# This code is based on original Mozilla gnome-vfs extension. It implements >+# input stream provided by GVFS/GIO. This license header needs to be made consistent with the original gnomevfs Makefile.in, in the same way as you fixed up for nsGIOProtocolHandler.cpp. I think we can request approval2.0 when that's done. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Created attachment 502458 Patch 0.9, fixed comments and mount operation enum Ah, sorry about it, I was too hasty with enums. Thanks for fixing comments too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Comment on attachment 501632
Patch 0.8, fixed comments and added mount operation enum
>+nsGIOInputStream::SetMountResult(GMountOperationResult result, gint
>error_code)
>+{
>+ mozilla::MonitorAutoEnter mon(mMonitorMountInProgress);
>+ mMountRes = (result == G_MOUNT_OPERATION_HANDLED)
>+ ? MOUNT_OPERATION_SUCCESS : MOUNT_OPERATION_FAILED;
SetMountResult is only used in this file and the parameter is not really a
GMountOperationResult. It should be the internal enum "MountOperationResult".
>+ , mMountRes(MOUNT_OPERATION_IN_PROGRESS)
mMountRes is only used in nsGIOInputStream::MountVolume() so doesn't need to
be initialized here.
>+ /* A g_file_mount_enclosing_volume is using dbus request to mount
volume.
"/* g_file_mount_enclosing_volume uses a dbus request to mount the
volume."
>+ Callback mount_enclosing_volume_finished is called in main thread
>+ (not this thread from witch it this method called). */
"(not this thread on which this method is called)."
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/539226
Title:
firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Created attachment 501632 Patch 0.8, fixed comments and added mount operation enum Here it comes... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Comment on attachment 501303 Patch 0.7, sync to mozilla-central >+#include "nsIStandardURL.h" >+#include "nsMimeTypes.h" >+#include "nsNetUtil.h" >+#include "mozilla/Monitor.h" >+#include "nsIStandardURL.h" One of the nsIStandardURL.h includes can be removed too :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
The merge with m-c looks good, thanks, but, before checkin, can you correct the "Calling g_file_mount_enclosing_volume creates a new thread" comment and use a new distinct enum type for mMountRes, in line with comment 21, please? We'll also need to get approval2.0, but as this is not part of the default build, I don't expect that to be a problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226]
Created attachment 501303 Patch 0.7, sync to mozilla-central Please have a look at version synced with latest mozilla-central. When review gets positive I'll try to set need-checkin. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/539226 Title: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226] Re: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS
** Changed in: firefox Importance: Unknown => Wishlist -- firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS https://bugs.launchpad.net/bugs/539226 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226] Re: firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS
** Bug watch added: Mozilla Bugzilla #494163 https://bugzilla.mozilla.org/show_bug.cgi?id=494163 ** Also affects: firefox via https://bugzilla.mozilla.org/show_bug.cgi?id=494163 Importance: Unknown Status: Unknown -- firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS https://bugs.launchpad.net/bugs/539226 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 539226] [NEW] firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS
Public bug reported: Binary package hint: firefox GnomeVFS is deprecated and won't be included in future GNOME releases Also, GNOME support in mozilla seems quite modular and can be selected the desired libraries: https://hg.mozilla.org/mozilla-central/file/69cb1df1cb0f/toolkit/system/gnome/nsGnomeModule.cpp ** Affects: firefox Importance: Unknown Status: Unknown ** Affects: firefox (Ubuntu) Importance: Undecided Status: New -- firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS https://bugs.launchpad.net/bugs/539226 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
