[Bug 543679] Re: Add a plymouth theme for sabily
Unsubscribing sponsors for now. Seems Emmet uploaded it. -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
Is sabily-plymouth-artwork on REVU still needed? -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 543679] Re: Add a plymouth theme for sabily
On Tue, Apr 06, 2010 at 08:18:46AM -, Daniel Holbach wrote: Is sabily-plymouth-artwork on REVU still needed? ---end quoted text--- I don't think so, since it is in the repository now: http://packages.ubuntu.com/lucid/plymouth-theme-sabily -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
** Changed in: ubuntu Status: Confirmed = Fix Released -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
** Branch linked: lp:ubuntu/plymouth-theme-sabily -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
Renamed the package to plymouth-theme-sabily re-uploaded to: http://revu.ubuntuwire.com/details.py?upid=8040 -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
It's unfortunate that the script has to be modified to change the colors instead of being able to pass these as variables in the .plymouth file, but at least this is now in sync. FFe granted. ** Changed in: ubuntu Status: New = Confirmed -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
As explained by IRC, you should get first a Release ack. Unsubscribing sponsors. -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
** Attachment added: Build log http://launchpadlibrarian.net/42027118/sabily-plymouth-artwork_1.0.buildlog -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
** Attachment added: Install log http://launchpadlibrarian.net/42028386/install.log -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
The postinst script in the package on REVU has: configure) # FIXME: do this with alternatives plymouth-set-default-theme --rebuild-initrd sabily ;; First, this isn't safe; if the user has this package installed but chooses to use a different theme, that choice will be clobbered on every upgrade. Second, the code to implement update-alternatives handling of themes is already in place in the bzr branch at lp:ubuntu/plymouth, and will be uploaded shortly. Please implement compatible handling in your package, and if necessary add a versioned dependency on plymouth 0.8.1-1, so that your package will play well with the theme handling targeted for lucid from the first upload. Third, this theme has been constructed by cut-and-pasting the ubuntu- logo theme from the plymouth package, and that theme is still actively under development - you need to implement this in a way that doesn't duplicate the bugs whatever bugs happen to be in the current ubuntu-logo code. I would suggest that the correct way to accomplish this is by having your package Depend on plymouth-theme-ubuntu-logo and reference /lib/plymouth/themes/ubuntu-logo/ubuntu-logo.script directly as the ScriptFile in sabily.plymouth - then you just need to provide the same image set under the same names but in the /lib/plymouth/themes/sabily directory. Provided that these packaging issues are addressed, FFe granted - this package is a clear successor to usplash-theme-sabily and sabily-xsplash- artwork and should be permitted in so we don't regress from karmic. ** Changed in: ubuntu Importance: Undecided = Medium -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 543679] Re: Add a plymouth theme for sabily
Thanks, On Fri, Mar 26, 2010 at 08:29:02AM -, Steve Langasek wrote: Third, this theme has been constructed by cut-and-pasting the ubuntu- logo theme from the plymouth package, and that theme is still actively under development - you need to implement this in a way that doesn't duplicate the bugs whatever bugs happen to be in the current ubuntu-logo code. I would suggest that the correct way to accomplish this is by having your package Depend on plymouth-theme-ubuntu-logo and reference /lib/plymouth/themes/ubuntu-logo/ubuntu-logo.script directly as the ScriptFile in sabily.plymouth - then you just need to provide the same image set under the same names but in the /lib/plymouth/themes/sabily directory. ---end quoted text--- Actually, I modified .script file a bit (modified the vertical positions of the progress dots labels). So I don't think that this suggestion would work for me. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
Modified according to discussion above, and re-uploaded to REVU. -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 543679] Re: Add a plymouth theme for sabily
REVU URL: http://revu.ubuntuwire.com/details.py?upid=8017 -- Add a plymouth theme for sabily https://bugs.launchpad.net/bugs/543679 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
