Re: [Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-31 Thread Mark Shuttleworth

Yes, these are looking god now. Thanks and nicely done.

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-30 Thread Kenneth Wimer
w00t, this looks excellent in my latest install! Nicely done Cody!

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-30 Thread Dylan McCall
Hi Cody,

Just to follow up, I don't have that issue any more with up to date
Lucid after restarting. It was either my imagination, or it fixed
itself.

Yay! :)

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread David Barth
Putting that under the radar

** Changed in: ayatana-ubuntu
Milestone: None = ubuntu-10.04-beta-2

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread David Barth

** Attachment added: me menu with ambiance
   http://launchpadlibrarian.net/42391820/indicator-me-ambiance.png

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread David Barth

** Attachment added: me menu with radiance
   http://launchpadlibrarian.net/42391825/indicator-me-radiance.png

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Dylan McCall
I would be DELIGHTED if this theme change landed.

I should point out one reason against, though, just to be fair: it's a tad 
better for accessibility that we specify which menu items are radio / check 
items and which are regular actions. I expect that's one of the reasons they 
are how they are.
On the other hand, though, toggle _buttons_ are indecipherable from regular 
buttons, it's not always clear that two groups of radio items side by side are 
separate groups, and the labels on check mark items should explain themselves 
(that they enable something), not the picture of a check box.

To solve the unsolved issues there, it's important to keep groups of radio 
items visually connected using separators. That is the case on the message 
indicators, but we should make sure this doesn't break any other supported apps 
and patch them appropriately :)
(And - though don't quote me on it - I think the GNOME HIG supports us here, so 
it shouldn't be a big problem).

Probably the best route to that is a Planet Ubuntu post asking for bug
reports if the theme is changed.

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Cody Russell

** Patch added: murrine patch
   http://launchpadlibrarian.net/42403393/546263-1.diff

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Cody Russell

** Attachment added: Screenshot of the last patch
   http://launchpadlibrarian.net/42403466/radios.png

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Cody Russell
I forgot to fix check boxes in this patch, so expect another one in a
few minutes.

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Cody Russell
Also should note that the radio knob is using text[NORMAL] for its
color, so this should just work for any theme out there.

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Cody Russell

** Patch added: Updated patch with checkbox support
   http://launchpadlibrarian.net/42405179/546263-2.diff

** Changed in: ayatana-ubuntu
   Status: New = In Progress

** Changed in: light-themes (Ubuntu)
   Status: New = Invalid

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Sebastien Bacher
** Also affects: gtk2-engines-murrine (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: gtk2-engines-murrine (Ubuntu)
   Importance: Undecided = Wishlist

** Changed in: gtk2-engines-murrine (Ubuntu)
   Status: New = Fix Committed

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Launchpad Bug Tracker
This bug was fixed in the package gtk2-engines-murrine -
0.90.3+git20100323-0ubuntu2

---
gtk2-engines-murrine (0.90.3+git20100323-0ubuntu2) lucid; urgency=low

  * debian/patches/01_display_only_selected_menu_items.patch:
- change by Cody Russell to display the menu entry widgets only next to
  the selected entries (lp: #546263)
 -- Sebastien Bacher seb...@ubuntu.com   Mon, 29 Mar 2010 22:44:28 +0200

** Changed in: gtk2-engines-murrine (Ubuntu)
   Status: Fix Committed = Fix Released

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Cody Russell
** Changed in: ayatana-ubuntu
   Status: In Progress = Fix Released

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Dylan McCall
Okay, with the current version there is one bit of inconsistency: When
the current menu item is hovered (thus getting a lighter background),
checkmarks turn black (inconsistent with the text!) while radio buttons
stay the same.

Want me to file a new bug report?

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Cody Russell
Hey Dylan, can you ensure that you've restarted your desktop session
(sometimes things can get confused otherwise).  If the problem still
continues, just reopen the part of this bug that's assigned to me and
post a screenshot of the problem please.  If there's a problem I'll fix
it first thing in the morning.

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread Ivanka Majic
** Also affects: ayatana-ubuntu
   Importance: Undecided
   Status: New

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-29 Thread David Barth
Cody: how difficult / invasive a code change is that?

** Changed in: ayatana-ubuntu
 Assignee: (unassigned) = Cody Russell (bratsche)

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-25 Thread Kenneth Wimer
There is currently no way to change this appearance as desired without
patching the theme engine.

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 546263] Re: Checkmark and radio items in menus have ugly frames

2010-03-25 Thread chewit
Something does need doing about the awful decision with the radio
buttons in the me menu.

** Tags added: lucid

-- 
Checkmark and radio items in menus have ugly frames
https://bugs.launchpad.net/bugs/546263
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs