[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Martin Pitt]

I built xorg-server locally with this package, and it works now:

dh_strip -pxserver-xorg-core --dbg-package=xserver-xorg-core-dbg
dh_strip debug symbol extraction: all non-arch-all packages for this build 
platform amd64: xserver-xorg-core xserver-xorg-dev xdmx xdmx-tools xnest xvfb 
xserver-xephyr xserver-xfbdev xserver-xorg-core-dbg 
dh_strip debug symbol extraction: not adding gnu debuglinks since --dbg-package 
is given
dh_strip debug symbol extraction: packages to act on: xserver-xorg-core 
dh_strip debug symbol extraction: ignored packages: 
dpkg-deb: Warnung: 
»/home/martin/ubuntu/tmp/xorg-server-1.7.6/debian/xserver-xorg-core-dbgsym/DEBIAN/control«
 enthält benutzerdefiniertes Feld »Original-Maintainer«
dpkg-deb: Warnung: Ignoriere 1 Warnungen wegen der control-Datei(en)

dpkg-deb: Baue Paket »xserver-xorg-core-dbgsym« in 
»../xserver-xorg-core-dbgsym_1.7.6-2ubuntu7_amd64.ddeb«.
dh_strip -s --remaining-packages
dh_strip debug symbol extraction: all non-arch-all packages for this build 
platform amd64: xserver-xorg-core xserver-xorg-dev xdmx xdmx-tools xnest xvfb 
xserver-xephyr xserver-xfbdev xserver-xorg-core-dbg 
dh_strip debug symbol extraction: packages to act on: xserver-xorg-core 
xserver-xorg-dev xdmx xdmx-tools xnest xvfb xserver-xephyr xserver-xfbdev 
xserver-xorg-core-dbg 
dh_strip debug symbol extraction: ignored packages: 
xserver-xorg-core is already stripped, ignoring
xserver-xorg-dev is already stripped, ignoring


-rw-r--r--  1 martin martin 5204262 2010-04-26 14:28 
xserver-xorg-core-dbgsym_1.7.6-2ubuntu7_amd64.ddeb


So I uploaded this to lucid-proposed, awaiting SRU approval now.

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Martin Pitt]

** Description changed:

+ SRU INFORMATION:
+ Impact: Produces empty ddebs and broken debug links on packages which call 
dh_strip on a package more than once, when being built on Soyuz (not locally).
+ Patch: 
http://bazaar.launchpad.net/~ubuntu-core-dev/pkg-create-dbgsym/ubuntu/revision/180
+ Test case: 
http://bazaar.launchpad.net/~ubuntu-core-dev/pkg-create-dbgsym/ubuntu/revision/176
+ Regression potential: p-c-d has quite an extensive test suite which cover a 
lot of different build systems, debhelper compat levels, etc. Almost all bug 
reports get a test written first to ensure that it reproduces the bug and the 
patch fixes it. However, being a toolchain package it can potentially cause all 
further builds to be broken completely (which is very very unlikely, though); a 
more realistic regression potential is that this now causes debug packages to 
stop being built because the check for "has debug symbols" is imprecise.
+ 
  Update: Probably affects all packages which happen to run dh_strip twice
  on the same binary package.
  
  Binary package hint: xserver-xorg-core-dbg
  
  After upgrading to Lucid, I get the following error when trying
  to debug xorg:
  
  $ gdb /usr/bin/Xorg
  GNU gdb (GDB) 7.1-ubuntu
  Copyright (C) 2010 Free Software Foundation, Inc.
  License GPLv3+: GNU GPL version 3 or later 
  This is free software: you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
  and "show warranty" for details.
  This GDB was configured as "x86_64-linux-gnu".
  For bug reporting instructions, please see:
  ...
  Reading symbols from /usr/bin/Xorg...
  warning: the debug information found in "/usr/lib/debug//usr/bin/Xorg" does 
not match "/usr/bin/Xorg" (CRC mismatch).
  
  warning: the debug information found in "/usr/lib/debug/usr/bin/Xorg"
  does not match "/usr/bin/Xorg" (CRC mismatch).
  
  (no debugging symbols found)...done.
  (gdb)
  
  It worked just fine on 9.10.
  
  I've version 2:1.7.6-2ubuntu3 installed, on amd64.
  
  If you need more information, please let me know.
  
  Thanks,
   Alberto

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Martin Pitt]

Fixed for good in http://bazaar.launchpad.net/~ubuntu-core-dev/pkg-
create-dbgsym/ubuntu/revision/180 now. Sorry about that!

** Changed in: pkg-create-dbgsym (Ubuntu)
Milestone: None => lucid-updates

** Also affects: pkg-create-dbgsym (Ubuntu Lucid)
   Importance: High
 Assignee: Martin Pitt (pitti)
   Status: In Progress

** Also affects: xorg-server (Ubuntu Lucid)
   Importance: Undecided
   Status: Confirmed

** Changed in: pkg-create-dbgsym (Ubuntu Lucid)
   Status: In Progress => Fix Committed

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Martin Pitt]

Argh, I know why. It's because on Soyuz we currently disable adding the
ddebs to debian/files, thus the grep wouldn't find them.

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Martin Pitt]

** Changed in: pkg-create-dbgsym (Ubuntu)
   Status: Confirmed => In Progress

** Changed in: xorg-server (Ubuntu)
   Status: Fix Released => Confirmed

** Changed in: xorg-server (Ubuntu)
Milestone: ubuntu-10.04 => None

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Tormod Volden]

Unfortunately this is not fixed in the xorg-server case. The build log
for 2:1.7.6-2ubuntu7 confirms that pkg-create-dbgsym 0.42 got installed,
but I still get CRC mismatch on /usr/bin/Xorg.

The snippet below from the build log shows that -dbgsym was built twice.
Why there is Make messages in there is also a bit funny, it seems like
some parallel makes are running, which I would not expect in this phase
of the build.

dh_strip -pxserver-xorg-core --dbg-package=xserver-xorg-core-dbg
dh_strip debug symbol extraction: all non-arch-all packages for this build 
platform i386: xserver-xorg-core xserver-xorg-dev xdmx xdmx-tools xnest xvfb 
xserver-xephyr xserver-xfbdev xserver-xorg-core-dbg 
pkgmaintainermangler: Not overriding Maintainer for domain lists.ubuntu.com
dpkg-deb: warning: 'debian/xserver-common/DEBIAN/control' contains user-defined 
field 'Original-Maintainer'
dpkg-deb: warning: ignoring 1 warnings about the control file(s)

dpkg-deb: building package `xserver-common' in 
`../xserver-common_1.7.6-2ubuntu7_all.deb'.
dh_strip debug symbol extraction: not adding gnu debuglinks since --dbg-package 
is given
dh_strip debug symbol extraction: packages to act on: xserver-xorg-core 
dh_strip debug symbol extraction: ignored packages: 
make[1]: Leaving directory `/build/buildd/xorg-server-1.7.6'
WARNING: not running pkgbinarymangler for this package, as requested
dpkg-deb: warning: 
'/build/buildd/xorg-server-1.7.6/debian/xserver-xorg-core-dbgsym/DEBIAN/control'
 contains user-defined field 'Original-Maintainer'
dpkg-deb: warning: ignoring 1 warnings about the control file(s)

dpkg-deb: building package `xserver-xorg-core-dbgsym' in 
`../xserver-xorg-core-dbgsym_1.7.6-2ubuntu7_i386.ddeb'.
dh_strip -s --remaining-packages
dh_strip debug symbol extraction: all non-arch-all packages for this build 
platform i386: xserver-xorg-core xserver-xorg-dev xdmx xdmx-tools xnest xvfb 
xserver-xephyr xserver-xfbdev xserver-xorg-core-dbg 
dh_strip debug symbol extraction: packages to act on: xserver-xorg-core 
xserver-xorg-dev xdmx xdmx-tools xnest xvfb xserver-xephyr xserver-xfbdev 
xserver-xorg-core-dbg 
dh_strip debug symbol extraction: ignored packages: 
WARNING: not running pkgbinarymangler for this package, as requested
dpkg-deb: warning: 
'/build/buildd/xorg-server-1.7.6/debian/xserver-xorg-core-dbgsym/DEBIAN/control'
 contains user-defined field 'Original-Maintainer'
dpkg-deb: warning: ignoring 1 warnings about the control file(s)

dpkg-deb: building package `xserver-xorg-core-dbgsym' in 
`../xserver-xorg-core-dbgsym_1.7.6-2ubuntu7_i386.ddeb'.
WARNING: not running pkgbinarymangler for this package, as requested
dpkg-deb: warning: 
'/build/buildd/xorg-server-1.7.6/debian/xdmx-dbgsym/DEBIAN/control' contains 
user-defined field 'Original-Maintainer'
dpkg-deb: warning: ignoring 1 warnings about the control file(s)


** Changed in: pkg-create-dbgsym (Ubuntu)
   Status: Fix Released => Confirmed

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Bryce Harrington]

The upload was approved today and should now be included in ubuntu

** Changed in: xorg-server (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Bryce Harrington]

-RC is out, I've uploaded the fix for 565981.  I forgot to mention this
bug in that changelog unfortunately, so this will need to be closed
manually.

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Launchpad Bug Tracker]

** Branch linked: lp:ubuntu/pkg-create-dbgsym

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Martin Pitt]

So with that xorg-server just needs a rebuild. If one is done for bug
565981 anyway, then this will just be solved along with it, otherwise
you have my ack to do a no-change upload for right-after-RC to get the
ddebs back.

Thanks again, Tormod!

** Changed in: xorg-server (Ubuntu)
   Status: Confirmed => Fix Committed

** Changed in: xorg-server (Ubuntu)
Milestone: None => ubuntu-10.04

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Launchpad Bug Tracker]

This bug was fixed in the package pkg-create-dbgsym - 0.42

---
pkg-create-dbgsym (0.42) lucid; urgency=low

  * Add tests/dhtest.doublestrip/: Call dh_strip twice, to check whether this
keeps the debug symbols intact. This reproduces LP #562418, where debug
symbols and CRC checksums were damaged due to double-stripping.
  * pkg_create_dbgsym: Do nothing if we already have built a .ddeb during this
package build, i. e. it is in debian/files already. This fixes
overwriting good .ddebs and debug links in case dh_strip gets called
twice. Thanks to Tormod Volden for investigating this! (LP: #562418)
  * debian/control: Bump Standards-Version to 3.8.4 (no changes necessary).
 -- Martin PittThu, 22 Apr 2010 10:36:38 +0200

** Changed in: pkg-create-dbgsym (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Martin Pitt]

Test case: 
http://bazaar.launchpad.net/~ubuntu-core-dev/pkg-create-dbgsym/ubuntu/revision/176
Fix: 
http://bazaar.launchpad.net/~ubuntu-core-dev/pkg-create-dbgsym/ubuntu/revision/177

** Changed in: pkg-create-dbgsym (Ubuntu)
   Status: In Progress => Fix Committed

** Changed in: pkg-create-dbgsym (Ubuntu)
   Importance: Undecided => High

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Launchpad Bug Tracker]

** Branch linked: lp:pkg-create-dbgsym

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Martin Pitt]

Ah, *headdesk*, thanks for figuring this out! I'll create and commit a
test case and then merge your branch.

** Changed in: pkg-create-dbgsym (Ubuntu)
   Status: Confirmed => In Progress

** Changed in: pkg-create-dbgsym (Ubuntu)
 Assignee: (unassigned) => Martin Pitt (pitti)

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Tormod Volden]

I was kindly pointed to the debhelper generic option --remaining-
packages. I can imagine that the "real" dh_strip calls some debhelper
functions to honour this option (it uses $dh{DOPACKAGES}), but I guess
the dh_strip wrapper in pkg_create_debug does not so it will do its
ddebs work on all packages before handing over to the real dh_strip.

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Tormod Volden]

Interestingly, xorg-server tries this:
dh_strip -pxserver-xorg-core --dbg-package=xserver-xorg-core-dbg
dh_strip -s --remaining-packages

Unfortunately that is wishful thinking, because dh_strip does not have
any --remaining-packages option.

I have tested that my fix works on the mesa packages. See the attachment
for details on what happens at which steps in the stripping processes.


** Attachment added: "mesa-build-dbgsym-analysis.txt"
   http://launchpadlibrarian.net/44982364/mesa-build-dbgsym-analysis.txt

** Description changed:

+ Update: Probably affects all packages which happen to run dh_strip twice
+ on the same binary package.
+ 
  Binary package hint: xserver-xorg-core-dbg
- 
  
  After upgrading to Lucid, I get the following error when trying
  to debug xorg:
  
  $ gdb /usr/bin/Xorg
  GNU gdb (GDB) 7.1-ubuntu
  Copyright (C) 2010 Free Software Foundation, Inc.
  License GPLv3+: GNU GPL version 3 or later 
  This is free software: you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
  and "show warranty" for details.
  This GDB was configured as "x86_64-linux-gnu".
  For bug reporting instructions, please see:
  ...
  Reading symbols from /usr/bin/Xorg...
  warning: the debug information found in "/usr/lib/debug//usr/bin/Xorg" does 
not match "/usr/bin/Xorg" (CRC mismatch).
  
- 
- warning: the debug information found in "/usr/lib/debug/usr/bin/Xorg" does 
not match "/usr/bin/Xorg" (CRC mismatch).
+ warning: the debug information found in "/usr/lib/debug/usr/bin/Xorg"
+ does not match "/usr/bin/Xorg" (CRC mismatch).
  
  (no debugging symbols found)...done.
- (gdb) 
- 
+ (gdb)
  
  It worked just fine on 9.10.
  
  I've version 2:1.7.6-2ubuntu3 installed, on amd64.
  
  If you need more information, please let me know.
  
  Thanks,
-  Alberto
+  Alberto

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Tormod Volden]

This problem arises for packages which run dh_strip several times in
debian/rules. When using only the "real" dh_strip (as in PPAs) it is no
problem, because dh_strip will detect an already stripped file and
ignore it.

pkg_create_dbgsym, on the other hand, will gladly strip a file a second
time, and thus obtain no debug symbols from it, but still create the
almost zero symbol file, and to top it off, write this useless CRC to
the binary.

So in the end the -dbgsym packages will have no symbols and a good CRC,
while the -dbg packages have no matching CRC any longer.

For instance the mesa rules file should be changed so it does not run dh_strip 
on the same package twice. Now it does:
dh_strip -plibgl1-mesa-dri --dbg-package=libgl1-mesa-dri-dbg
dh_strip -s

Here the second line should have had -Nlibgl1-mesa-dri appended to it so
that these packages are not processed again. (Both dh_strip and
pkg_create_dbgsym are smart enough to ignore -dbg packages).

But since we often sync packages from Debian where this is no problem,
we should make pkg_create_dbgsym handle this better. See the one-liner
in my linked branch.

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 562418] Re: many -dbg packages have debug symbols mismatch

[Tormod Volden]

** Summary changed:

- xserver-xorg-core-dbg debug symbols mismatch
+ many -dbg packages have debug symbols mismatch

** Changed in: pkg-create-dbgsym (Ubuntu)
   Status: New => Confirmed

-- 
many -dbg packages have debug symbols mismatch
https://bugs.launchpad.net/bugs/562418
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs