[Bug 570583] Re: does not check all required locks in is_package_system_locked
** Tags added: testcase -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/570583 Title: does not check all required locks in is_package_system_locked To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-service/+bug/570583/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
Accepted ubuntu-system-service into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance! ** Tags added: verification-needed -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
** Branch linked: lp:ubuntu/lucid-proposed/ubuntu-system-service -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
** Branch linked: lp:system-service -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
Fix is uploaded to lucid-proposed. ** Description changed: Binary package hint: ubuntu-system-service The dbus call for "is_package_system_locked" does not check all possible locks. This can lead to update-notifier (that uses this interface) to auto-opening update-manager when there is a package management operation already in progress. Its a bit of a corner case as most package managers take /var/lib/dpkg/lock (and that is already tested). But should be fixed nevertheless. + + TEST CASE: + 1. use lucid and log into desktop + 2. open two terminals + 3. run "while true; do apt-get update; done" in the first + 4. run "NO_FAKE_STAT=1 faketime -f +10d update-notifier" and verify that update-manager opens + + 5. close the terminals + 6. install new ubuntu-system-servce and run "sudo killall system-service-d" to ensure the old one is gone + 7. run "gconftool --unset /apps/update-manager/launch_time" to ensure the launch time is reset + 8. repeat steps 3,4 and verify that update-manager does not open this time ** Description changed: Binary package hint: ubuntu-system-service The dbus call for "is_package_system_locked" does not check all possible locks. This can lead to update-notifier (that uses this interface) to auto-opening update-manager when there is a package management operation already in progress. Its a bit of a corner case as most package managers take /var/lib/dpkg/lock (and that is already tested). But should be fixed nevertheless. TEST CASE: - 1. use lucid and log into desktop - 2. open two terminals - 3. run "while true; do apt-get update; done" in the first - 4. run "NO_FAKE_STAT=1 faketime -f +10d update-notifier" and verify that update-manager opens + 1. use lucid and log into desktop + 2. open two terminals + 3. run "while true; do apt-get update; done" in the first + 4. run "NO_FAKE_STAT=1 faketime -f +10d update-notifier" and verify that update-manager opens - 5. close the terminals - 6. install new ubuntu-system-servce and run "sudo killall system-service-d" to ensure the old one is gone - 7. run "gconftool --unset /apps/update-manager/launch_time" to ensure the launch time is reset - 8. repeat steps 3,4 and verify that update-manager does not open this time + 5. close the terminals + 6. install new ubuntu-system-servce and run "sudo killall system-service-d" to ensure the old one is gone + 7. run "gconftool --unset /apps/update-manager/launch_time" to ensure the launch time is reset + 8. repeat steps 3,4 and verify that update-manager does not open this time + + 9. close the terminals that was opened in step 3 + 10. repeat step 4, verify that update-manager now auto-opens ** Changed in: ubuntu-system-service (Ubuntu Lucid) Status: Confirmed => Fix Committed -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
This bug was fixed in the package ubuntu-system-service - 0.1.20.1 --- ubuntu-system-service (0.1.20.1) lucid-proposed; urgency=low * backend/system-service-d: - check for download lock files as well when running "is_package_system_locked" (LP: #570583) -- Michael VogtTue, 27 Apr 2010 10:47:35 +0200 ** Changed in: ubuntu-system-service (Ubuntu Lucid) Status: Fix Committed => Fix Released -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
Copied lucid-proposed to maverick. ** Changed in: ubuntu-system-service (Ubuntu) Status: Fix Committed => Fix Released ** Changed in: ubuntu-system-service (Ubuntu Lucid) Status: Fix Released => Fix Committed -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
Running the test case. I confirm that with the lucid-final version u-manager opens automatically, greys out, and just results in a crash report (_usr_bin_update-manager.1000.crash). I upgraded u-s-s to lucid-proposed, downgraded another package (udisks) to final (so that there was still a reason to upgrade your system) and re-ran the test case. Without the apt-get loop, u-m runs automatically, as desired. With the apt-get loop, u-n does not auto-open until I control-c the apt-get update loop. ** Tags added: verification-done ** Tags removed: verification-needed -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
This bug was fixed in the package ubuntu-system-service - 0.1.20.1 --- ubuntu-system-service (0.1.20.1) lucid-proposed; urgency=low * backend/system-service-d: - check for download lock files as well when running "is_package_system_locked" (LP: #570583) -- Michael VogtTue, 27 Apr 2010 10:47:35 +0200 ** Changed in: ubuntu-system-service (Ubuntu Lucid) Status: Fix Committed => Fix Released -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
Thanks Paul for your verification effort and sorry for not getting back to you earlier. I just updated the testcase (it did not include a killall update-notifier). This lead to the problem that update-notifier was still running and the new one (with the faketime argument) would not start. Could you (or someone else) please retry the verification with the updated instructions? Thanks, Michael ** Description changed: Binary package hint: ubuntu-system-service The dbus call for "is_package_system_locked" does not check all possible locks. This can lead to update-notifier (that uses this interface) to auto-opening update-manager when there is a package management operation already in progress. Its a bit of a corner case as most package managers take /var/lib/dpkg/lock (and that is already tested). But should be fixed nevertheless. TEST CASE: 1. use lucid and log into desktop 2. open two terminals 3. run "while true; do apt-get update; done" in the first - 4. run "NO_FAKE_STAT=1 faketime -f +10d update-notifier" and verify that update-manager opens + 4. run "killall update-notifier; NO_FAKE_STAT=1 faketime -f +10d update-notifier" and verify that update-manager opens 5. close the terminals 6. install new ubuntu-system-servce and run "sudo killall system-service-d" to ensure the old one is gone 7. run "gconftool --unset /apps/update-manager/launch_time" to ensure the launch time is reset 8. repeat steps 3,4 and verify that update-manager does not open this time - 9. close the terminals that was opened in step 3 - 10. repeat step 4, verify that update-manager now auto-opens + 9. close the terminals that was opened in step 3 + 10. repeat step 4, verify that update-manager now auto-opens ** Changed in: ubuntu-system-service (Ubuntu Lucid) Status: Fix Committed => In Progress ** Changed in: ubuntu-system-service (Ubuntu Lucid) Status: In Progress => Fix Committed ** Tags added: verification-needed ** Tags removed: verification-failed -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
I'm not sure 0.1.20.1 from lucid-proposed fixes the issue, after following the test case and installing the proposed package, update- manager does not appear at all on my system in the final step when issuing: NO_FAKE_STAT=1 faketime -f +10d update-notifier This is even when no other apt activity is (knowingly) running. Can you verify the test case steps are correct? -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570583] Re: does not check all required locks in is_package_system_locked
** Tags added: verification-failed ** Tags removed: verification-needed -- does not check all required locks in is_package_system_locked https://bugs.launchpad.net/bugs/570583 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
