[Bug 721636] Re: nickle crashes on amd64 natty
Synced 2.71-1 ** Changed in: nickle (Ubuntu) Status: Incomplete => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
** Changed in: nickle (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
Notes from the Debian bug: On Sat, 2011-11-26 at 10:14 -0800, Keith Packard wrote: Package: nickle > Version: 2.71-1 > > On Sat, 26 Nov 2011 08:46:20 -0800, Kamal Mostafa wrote: > > Michael Terry's strncpy patch is still probably a good idea though, so > > leaving this bug open for maintainer review. > > No, strncpy is wrong -- it doesn't copy the trailing '\0' byte. You > could use memcpy (adding one to length) if desired, but I don't see the > point; the code already 'trusts' the incoming string length. > > In any case, the root cause of the bug was fixed by using 0-length > arrays at the end of various structs for variable-sized allocations. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
I confirm that nickle 2.71-1 from Debian unstable fixes the problem (it runs properly even with _FORTIFY_SOURCE). A no-change build of nickle 2.71-1 is available in my PPA: https://launchpad.net/~kamalmostafa/+archive/nickle @Michael, I suggest dropping your patch and sync'ing 2.71-1 into Precise. I would also like to see this fixed for Oneiric and Natty (nickle 2.70 is entirely unusable starting with Natty) -- do I need to file a separate SRU request? ** Changed in: nickle (Ubuntu) Status: Fix Released => Incomplete ** Changed in: nickle (Ubuntu) Assignee: (unassigned) => Michael Terry (mterry) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
Update: Keith has uploaded nickle-2.71-1 to Debian to address this issue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
Hi Michael- I discussed the problem with the author of nickle (Keith Packard) in 2011-09 and he determined that there were other places in the code that would trigger the same type of failure at runtime, if presented with certain inputs. The NewStrString instance is most obvious since it happened at startup regardless of input, but fixing it with strncpy is not sufficient to cover the other cases Keith identified (they occur in other routines which cannot be converted to strncpy since they don't use strcpy). Keith stated his intention to fix the the problems "the right way" and push a new version to Debian, but that has not yet occurred (I'll poke him). In the meantime, I recommend that we do just switch off _FORTIFY_SOURCE for nickle. While I fully agree with the general goodness of _FORTIFY_SOURCE, nickle 2.70 really doesn't work properly with it enabled. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
** Changed in: nickle (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
** Branch linked: lp:ubuntu/nickle -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
This bug was fixed in the package nickle - 2.70-1ubuntu1 --- nickle (2.70-1ubuntu1) precise; urgency=low * string.c: - Use strncpy instead of strcpy to avoid 'overflow detected' crashes. LP: #721636 -- Michael TerryMon, 21 Nov 2011 11:23:12 -0600 ** Changed in: nickle (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
** Bug watch added: Debian Bug tracker #649506 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649506 ** Also affects: nickle (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649506 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
Karmal, I'd prefer not to just disable FORTIFY_SOURCE. It is a useful flag. Wouldn't it be better to use strncpy instead of strcpy and such as indicated on https://wiki.ubuntu.com/ToolChain/CompilerFlags ? I'm looking into a patch that does that. But you mention multiple similar constructs? I only know of the crash from NewStrString. Where else do you see problems? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
This patch just disables _FORTIFY_SOURCE, which will resolve other instances of the same problematic construct which appear in other places in nickle. This patch fixes nickle's crash(es) and is sufficient to close this bug. ** Patch added: "nickle-disable-fortify.patch" https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+attachment/2482128/+files/nickle-disable-fortify.patch ** Changed in: nickle (Ubuntu) Assignee: Kamal Mostafa (kamalmostafa) => (unassigned) ** Patch removed: "fix-buffer-overflow-detected-crash.patch" https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+attachment/2478403/+files/fix-buffer-overflow-detected-crash.patch ** Changed in: nickle (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
A fixed installable nickle package (built with _FORTIFY_SOURCE disabled) is now available in my PPA: https://launchpad.net/~kamalmostafa/+archive/nickle -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
The attachment "fix-buffer-overflow-detected-crash.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report. [This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
Note: similar constructs appear elsewhere in the code. A more general fix is now in the works by the author. In the meantime building with -U_FORTIFY_SOURCE might be the best solution. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
Attached patch fixes the problem, described in more detail here: https://wiki.ubuntu.com/CompilerFlags (see "*** buffer overflow detected ***"). ** Patch removed: "fix-buffer-overflow-detected-crash.patch" https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+attachment/2478323/+files/fix-buffer-overflow-detected-crash.patch ** Patch added: "fix-buffer-overflow-detected-crash.patch" https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+attachment/2478403/+files/fix-buffer-overflow-detected-crash.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
Attached patch fixes the crash. ** Changed in: nickle (Ubuntu) Assignee: (unassigned) => Kamal Mostafa (kamalmostafa) ** Patch added: "fix-buffer-overflow-detected-crash.patch" https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+attachment/2478323/+files/fix-buffer-overflow-detected-crash.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nickle/+bug/721636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
** Changed in: nickle (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 721636] Re: nickle crashes on amd64 natty
** Attachment added: "nickle output" https://bugs.launchpad.net/bugs/721636/+attachment/1859132/+files/nickle-crash.txt -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/721636 Title: nickle crashes on amd64 natty -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
