[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
We didn't manage to reproduce this bug, plus it's quite old and Natty is not supported anymore. Therefore I changed the status to Won't Fix. If you are still having the problem in one of the supported Ubuntu releases please feel free to re-open it and update the description. Thank you! ** Changed in: compiz Status: Triaged => Won't Fix ** Changed in: compiz (Ubuntu) Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp To manage notifications about this bug go to: https://bugs.launchpad.net/compiz/+bug/729903/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
** Changed in: compiz Milestone: 0.9.12.1 => 0.9.12.2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp To manage notifications about this bug go to: https://bugs.launchpad.net/compiz/+bug/729903/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
** Changed in: compiz Milestone: 0.9.11.0 => 0.9.12.1 ** Changed in: compiz (Ubuntu) Assignee: Sam Spilsbury (smspillaz) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp To manage notifications about this bug go to: https://bugs.launchpad.net/compiz/+bug/729903/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
** Changed in: compiz Status: New => Triaged ** Changed in: compiz Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp To manage notifications about this bug go to: https://bugs.launchpad.net/compiz/+bug/729903/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
** Changed in: compiz Milestone: 0.9.10.0 => 0.9.11.0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp To manage notifications about this bug go to: https://bugs.launchpad.net/compiz/+bug/729903/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
** Also affects: compiz Importance: Undecided Status: New ** Changed in: compiz Milestone: None => 0.9.10.0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp To manage notifications about this bug go to: https://bugs.launchpad.net/compiz/+bug/729903/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
On 03/10/2011 05:06 AM, Sam "SmSpillaz" Spilsbury wrote: > [...] where eg the screen layout changes between two > different output geometries but the bounding geometry around both > outputs (eg the root window) doesn't actually change size so we never > get a ConfigureNotify for that. Sure. If use the gnome-display-properties to shut off the larger external monitor that shows up on the right by default, and apply... Then move it over to the left, and turn it back on, and apply, Compiz already works fine with no patch. But if I simply move the monitor over to the left and click apply, it does not pick up the change without that patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
On Tue, Mar 8, 2011 at 12:24 AM, Danny Baumann wrote: > Hi, > >> It will now update the screen info, then detect and update output >> devices just like it does in CompScreen::init. This allows compiz to >> do the right thing when an external monitor or projector is plugged in >> and enabled using the 'gnome-display-properties' dialog or the >> 'xrandr' command line tool. >> >> Call XRRSelectInput in CompScreen::init, asking for >> RRScreenChangeNotify events. Without this those events are never given >> to compiz. That means that the switch case for it in >> plugins/composite/screen.cpp was never triggered, until now. > > What is the exact problem this patch is trying to solve? I never had a > problem with dynamically adding/removing monitors, because compiz is > listening for ConfigureNotify on the root window, and some esoterical > corner cases aside, the root window will change its size anyway when > hotplugging monitors. > I re-read some of the explanations here [1], it looks like this is specifically to handle the case where you don't get a ConfigureNotify event on the root window because only the layout of the two monitors is actually changing (eg the bounding rect of both monitors is the same). Although I'm worried about some potential doubling-up of handing screen resizes - since it is possible for us to get both an RRScreenChangeNotify and ConfigureNotify on the root window for the same resolution change. Perhaps it would be better to check for the existence of XRandR in this case and *only* handle the RRScreenChangeNotify event if XRandR is available. According to the documentation anyways it looks like you'll get RRScreenChangeNotify for pretty much anything regarding the size of the screen [2] Cheers, Sam [1] https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/729903 [2] http://keithp.com/~keithp/talks/randr/protocol.txt > I don't see a problem in adding that patch (it's obviously correct), I > just want to understand the reasoning. > > Regards, > > Danny -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
Hi Karl Sorry for getting back to you so late - as discussed on the compiz mailing list the general idea behind your patch is OK and I'm generally in favor of including it. I'd just like to run some ideas past Danny so that everyone knows what is going on (I re-read your explanation and can now see a usecase, where eg the screen layout changes between two different output geometries but the bounding geometry around both outputs (eg the root window) doesn't actually change size so we never get a ConfigureNotify for that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
Thank you for your work there, Sam could you review the patch? ** Changed in: compiz (Ubuntu) Assignee: (unassigned) => Sam "SmSpillaz" Spilsbury (smspillaz) ** Changed in: compiz (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
** Changed in: compiz (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 729903] Re: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp
** Patch added: "110_handle_xrandr_screen_change_notify.patch" https://bugs.launchpad.net/bugs/729903/+attachment/1888641/+files/110_handle_xrandr_screen_change_notify.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/729903 Title: Xrandr, Handle RRScreenChangeNotify in src/screen.cpp -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
