[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
Many dupes in bzr too, eg bug 762065, and it's biting me every time I use it. My comment #7 was misguided; I'm sure seahorse isn't breaking it, but also fairly sure something else involved in the stack believes passwords don't contain newlines. Which is pretty reasonable after all. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
** Also affects: python-launchpadlib (Ubuntu Natty) Importance: High Status: Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
I think one thing that's happening here is that the keyring gui strongly assumes passwords fit on a single line, and it possibly also implicitly saves them when you close the window. So if you open it up to see what launchpadlib is saving in there, it will break them. One option would be to just use json or some other serialization that will not include newlines. ** Changed in: python-launchpadlib (Ubuntu) Status: New = Triaged ** Changed in: python-launchpadlib (Ubuntu) Importance: Undecided = High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
On Tue, Apr 19, 2011 at 02:10:25AM -, Martin Pool wrote: I think one thing that's happening here is that the keyring gui strongly assumes passwords fit on a single line, and it possibly also implicitly saves them when you close the window. So if you open it up to see what launchpadlib is saving in there, it will break them. That's not the root of the problem I'm experiencing. I looked in seahorse only *because* saving credentials wasn't working right. Any time I use a launchpadlib-based tool on natty, I have to first open seahorse and delete the previously-stored invalid credentials, then re-authenticate to openid. The host-based credentials saving is worse than useless to me at present; at least if it weren't saving the credentials I could skip the step of opening seahorse to delete creds. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developerhttp://www.debian.org/ slanga...@ubuntu.com vor...@debian.org -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
No, I agree it's not the root cause. I don't know what the real root is. I will take a quick stab at this by: - catching and gracefully handling retrieval errors - storing a new format that is always all on one line I'm not sure that will fix it, but it seems connected to line breaks so it might. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
** Changed in: launchpadlib Status: New = Triaged ** Changed in: launchpadlib Importance: Undecided = Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
As far as I can tell this means the second run of any lplib client will fail. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
parser.write() sent to a stringio does seem to produce the right kind of thing: '[1]\nconsumer_key = System-wide: Ubuntu (myhostname)\nconsumer_secret = \naccess_token = \naccess_secret = uu\n\n' Apparently the Python keyring module, or something it calls, assumes passwords are a single line and it truncates them at the first \n: if I immediately try to get it back then keyring.get_password('launchpadlib', 'System-wide: Ubuntu (grace)@https://api.launchpad.net/') '[1]' however a simple interactive use of the keyring module doesn't hit this: In [4]: keyring.set_password('test', 'test', 'bite\nme') In [5]: keyring.get_password('test', 'test') Out[5]: 'bite\nme' In [6]: print _5 bite me -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
I know Leonard has observed some odd behaviour with python-keyring (and esp. the gnomekeyring module) some weeks ago [0], so this might be related. [0] https://bitbucket.org/kang/python-keyring-lib/issue/40/failures- happen-at-random-points-in-the -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
[0] https://bitbucket.org/kang/python-keyring-lib/issue/40/failures- happen-at-random-points-in-the I wonder if, for Natty, launchpadlib should disable keyring integration if it's really as flaky as that post and this bug suggests. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 745801] Re: system-based authorization doesn't store useful credentials in gnome-keyring
Here's the serialize code for what is stored parser.add_section(CREDENTIALS_FILE_VERSION) parser.set(CREDENTIALS_FILE_VERSION, 'consumer_key', self.consumer.key) parser.set(CREDENTIALS_FILE_VERSION, 'consumer_secret', self.consumer.secret) parser.set(CREDENTIALS_FILE_VERSION, 'access_token', self.access_token.key) parser.set(CREDENTIALS_FILE_VERSION, 'access_secret', self.access_token.secret) parser.write(writable_file) so it executes the first line fine, but the rest don't have the desired effect. I'm not sure what would cause the other statements to have no effect. The write() must have an effect, otherwise you would get nothing, so either there is something odd going on with the ConfigParserClass or we are getting the equivalent of short read/write (the writeable_file isn't a real file here, just an in memory one, so it's not that exactly) There is some oddness with a credential_save_failed that could be involved. Adding an upstream task for their input. Thanks, James ** Also affects: launchpadlib Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/745801 Title: system-based authorization doesn't store useful credentials in gnome- keyring -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs