[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
** Changed in: util-linux (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/980835 Title: tty[1-6] is now root:tty 0660 instead of root:root 0600 To manage notifications about this bug go to: https://bugs.launchpad.net/util-linux-ng/+bug/980835/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
This has been fixed upstream in release 2.23. ** Also affects: util-linux-ng Importance: Undecided Status: New ** Changed in: util-linux-ng Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/980835 Title: tty[1-6] is now root:tty 0660 instead of root:root 0600 To manage notifications about this bug go to: https://bugs.launchpad.net/util-linux-ng/+bug/980835/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
Maybe it is weak google-fu, but I can't find any justification for why util-linux chose 0660. My gut feeling is they chose it because it seemed reasonable for them at the time, but that doesn't mean it is reasonable for us and I would encourage us to consider using the udev default of 0620. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/980835 Title: tty[1-6] is now root:tty 0660 instead of root:root 0600 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/980835/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
I forgot to mention that this is where udev introduced the change from 0666 to 0620: http://www.mail-archive.com/lfs-book@linuxfromscratch.org/msg09416.html and this is where 0620 was mentioned in Debian (but for makedev, not udev): http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=244751/0620#42 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/980835 Title: tty[1-6] is now root:tty 0660 instead of root:root 0600 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/980835/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
So, while don't have a strong opinion on if group read is a problem, it seems that if getty is going to allow looser permissions than the default udev rule, (ie adding group read), it should be an active decision to solve a real problem. Before the permissions were more strict, so from a security point of view, it wasn't a problem. Perhaps we should adjust util-linux to use 0620 to mimic the udev rule? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/980835 Title: tty[1-6] is now root:tty 0660 instead of root:root 0600 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/980835/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
** Changed in: util-linux (Ubuntu) Importance: Undecided => Medium ** Changed in: util-linux (Ubuntu) Status: New => Confirmed ** Tags added: kernel-da-key precise -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/980835 Title: tty[1-6] is now root:tty 0660 instead of root:root 0600 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/980835/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
08:36 < infinity> Right, the code you hilighted is making them 660. 08:36 < infinity> The code I hilighted (or the removal) is making them remain root:tty. 08:37 < infinity> If there's a valid argument for the udev rule being 620, we could make util-linux mirror that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/980835 Title: tty[1-6] is now root:tty 0660 instead of root:root 0600 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/980835/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
Adam Conrad points out that all the other /dev/tty[0-9]* have group tty ownership. However, they are 0620: $ ls -l /dev/tty10 crw--w 1 root tty 4, 10 Apr 13 09:29 /dev/tty10 This is presumably from the udev default in /lib/udev/rules.d/50-udev-default.rules: KERNEL=="tty[0-9]*",GROUP="tty", MODE="0620" -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/980835 Title: tty[1-6] is now root:tty 0660 instead of root:root 0600 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/980835/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 980835] Re: tty[1-6] is now root:tty 0660 instead of root:root 0600
This is actually the code responsible:
@@ -686,12 +770,16 @@ static void open_tty(char *tty, struct termios *tp,
struct options *op)
log_err("%s: tcgetattr: %m", tty);
/*
-* Linux login(1) will change tty permissions. Use root owner and group
-* with permission -rw--- for the period between getty and login.
+* Detect if this is a virtual console or serial/modem line.
+* In case of a virtual console the ioctl TIOCMGET fails and
+* the error number will be set to EINVAL.
*/
- ignore_result(chown(tty, 0, 0));
- ignore_result(chmod(tty, 0600));
- errno = 0;
+ if (ioctl(STDIN_FILENO, TIOCMGET, &serial) < 0 && (errno = EINVAL)) {
+ op->flags |= F_VCONSOLE;
+ if (!op->term)
+ op->term = DEFAULT_VCTERM;
+ } else if (!op->term)
+ op->term = DEFAULT_STERM;
setenv("TERM", op->term, 1);
}
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/980835
Title:
tty[1-6] is now root:tty 0660 instead of root:root 0600
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/980835/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
