[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Copied to dapper-updates. ** Changed in: multipath-tools (Ubuntu Dapper) Status: Fix Committed => Fix Released -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
This requires very special hardware and otherwise does not affect dapper, so I take Fabio's test as sufficient here. ** Tags added: verification-done ** Tags removed: verification-needed -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Martin, I completed the tests with dapper-proposed. It is all good here. Please move the package to -updates. Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Martin, ok i do that asap. Tore, i guess we will wait for you. This bug has been taking a long time, week more/week less won't make much of a difference :) better to do QA and get it done properly. Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
* Martin Pitt > If Tore could test the actual packages in -proposed again, and you do > too, that's fine for our purposes. I'm going away on holidays soon, so I won't be able to do so before coming home in about three weeks. -- Tore Anderson -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Hi, Fabio Massimo Di Nitto [2007-06-13 11:30 -]: > I am not sure how our SRU team can do QA on this bug without a SAN... > > how should we handle it? If Tore could test the actual packages in -proposed again, and you do too, that's fine for our purposes. -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Hi Martin, I am not sure how our SRU team can do QA on this bug without a SAN... how should we handle it? I did clearly tested it as much as possible and on your request asked and waited for Tore to test it too... Any idea? Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Accepted into dapper-proposed, please go ahead with QA testing. ** Changed in: multipath-tools (Ubuntu Dapper) Status: In Progress => Fix Committed ** Tags added: verification-needed -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Package uploaded to dapper-proposed after Tore testing of the diff as agreed with Martin & co. Fabio ** Changed in: multipath-tools (Ubuntu Dapper) Status: In Progress => Fix Committed ** Changed in: multipath-tools (Ubuntu Dapper) Status: Fix Committed => In Progress -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
we are not going to fix this one in edgy. ** Changed in: multipath-tools (Ubuntu Edgy) Status: Confirmed => Rejected -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
* Fabio Massimo Di Nitto > Tore, ok thanks. I will wait for when you can reboot one of them. > > This bug is really annoying and i understand it's not easy for you to > do such operation, but it's also really important for me to know that > I didn't break existing setups. > > Specially note the fact that we are moving all the operations into > udev rules. That means that if there are issues they will show up > only on boot or when you plug/8unplug devices. Hey. I finally got the chance to test it on one machine, and booted it (after manually having rebuilt the initramfs image, don't know if that was necessary though). No problems at all! :-) -- Tore Anderson -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Tore, ok thanks. I will wait for when you can reboot one of them. This bug is really annoying and i understand it's not easy for you to do such operation, but it's also really important for me to know that I didn't break existing setups. Specially note the fact that we are moving all the operations into udev rules. That means that if there are issues they will show up only on boot or when you plug/8unplug devices. Thanks Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
* Tore Anderson > Just got back from holiday so I need to take care of a few loose ends > first, and tomorrow is Constitution Day here in Norway so nobody's > going to work. I will try to test it early next week, hopefully that's > okay with you. Built and installed OK. Can't reboot these machines now, sorry. :-/ -- Tore Anderson -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
* Fabio Massimo Di Nitto > i am ok if you can't test the 10GB thingy, but i would like to know > if the package works with the other changes too on setups that are > just not mine. > > Even if i need to wait a bit longer i am good. Just got back from holiday so I need to take care of a few loose ends first, and tomorrow is Constitution Day here in Norway so nobody's going to work. I will try to test it early next week, hopefully that's okay with you. -- Tore Anderson -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Hi Tore, i am ok if you can't test the 10GB thingy, but i would like to know if the package works with the other changes too on setups that are just not mine. Even if i need to wait a bit longer i am good. thanks Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
* Fabio Massimo Di Nitto > This should be final. > > Tore it would be great if you can test it on your systems too and (if > you can) add a couple of partitions to the SAN export. This should > trigger the dev/mapper/multipathname[partition] to be created too > (known to be broken in dapper at the moment). I'm not sure I'll be able to do so in the near future, as the 10GB LUN that triggered the bug has since been resized, and I don't think I have time to get a Dapper test rig online before the weekend (and next week I'll be away). I trust you, though. ;-) -- Tore Anderson -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Hi guys, please scratch all the previous patches. This should be final. Tore it would be great if you can test it on your systems too and (if you can) add a couple of partitions to the SAN export. This should trigger the dev/mapper/multipathname[partition] to be created too (known to be broken in dapper at the moment). Fabio ** Attachment added: "dapper proposed patch" http://librarian.launchpad.net/7513269/multipath.debdiff -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Martin, yes, the patch for dapper needs to redone from scratch but in order for me to test, I need to fix another blocker that was fixed in edgy SRU but not dapper related to loading firmwares from initramfs. Until i can't sort that blocker, my tests would be incomplete. Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Fabio, the Feisty version of debian/hsg80_start seems to be a bit more elaborate, and it has a different if logic than the dapper one (Feisty restarts the device if sg_turs is false, dapper's script doesn't). Does that need some updates? The rest of the diff looks good. -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Hi guys, I managed to move all the crap into udev for feisty and it works fine here. Martin the way in which udev works in feisty allows me to remove the init script that's causing troubles. Tore, sorry i didn't manage to get the documentation in for this upload due to time pressure. I will fix that as soon as feisty+1 opens. Fabio ** Changed in: multipath-tools (Ubuntu Feisty) Status: Confirmed => Fix Released ** Attachment added: "feisty fix" http://librarian.launchpad.net/7283361/mp-tools-feisty.debdiff -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Martin I am working to fix it in feisty, but feisty has a totally different udev interaction and it shows other issues. I also found another bug in dapper that we must address. Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Alright, sounds good. Can we get this fixed in Feisty soon? I'm not comfortable with a fix in stables that isn't already fixed in Feisty (that's also what the SRU rules prescribe). -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Here is an updated debdiff for dapper We cannot remove the init script call for different reasons: - copy hsg80_start in the initramfs will pull in a lot of junk. - running hsg80_start from initramfs is subject to a race condition while initramfs init is moving mountpoints from / to /root before running the real init. - not installing hsg80_start in the initramfs will leave passive devices in a bad state when devices are discovered before real root and real udev rules are available. So in this patch we readd the hsg80_start call in init script but done with proper checks. Fabio ** Attachment added: "mp-tools-dapper.debdiff" http://librarian.launchpad.net/7236432/mp-tools-dapper.debdiff -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Updated debdiff for dapper to include sg_turs test. Fabio ** Attachment added: "mp-tools-dapper.debdiff" http://librarian.launchpad.net/7125659/mp-tools-dapper.debdiff -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
ok i tested sg_turs and yes it makes sense to add it as check. Thanks for spotting it. Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
i did try to check for the vendor but it's tricky because it depends from the HSG firmware release. For instance on mine it's still DEC (old firmware) but i know that most recent onces have been published by Compaq and HP and the vendor has been changed. I will see what sg_turs tells me about passive path.. Thanks for the suggestions.. Fabio -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
* Fabio Massimo Di Nitto > - change /etc/udev/rules.d/85-multipath.rules to invoke > /sbin/hsg80_start only if we detect that we are really on an HSG80 > and with the recognized passive path (size is set to 10GB by HSG > firmware). Hm, wait. Isn't there a better way to detect this? You'll end up starting active paths to volumes that for some reason happen to be 10GB this way. Not sure if that's a problem at all though, but won't maybe sg_turs be a better test to see if it indeed is a passive path? I also noticed that you don't check the vendor attribute in sysfs when matching the HSG80. Probably not necessary, but for the sake of completeness... -- Tore Anderson -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
* Fabio Massimo Di Nitto > Here is the proposed patch for dapper. Looks good to me, it would certainly ensure that non-HSG80-using people like me won't run into trouble. Can't comment much on the correctness of the new HSG80-specific code though. -- Tore Anderson -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Here is the proposed patch for dapper. Problems: - init script does not perform proper check before attempting to initialize hsg80 multibus failover - hsg80 failover is not handled properly causing multipathd to spin 100% of the CPU without readding the proper device to dm-multipath Solutions: - remove hsg80 init from init script. - add a separate command /sbin/hsg80_start: - the script is more robust, it performs better error checking and it solves the race issue caused by multipathd attempting to readd the passive leg of the hsg80 to dm-multipath *before* started properly. - change /etc/udev/rules.d/85-multipath.rules to invoke /sbin/hsg80_start only if we detect that we are really on an HSG80 and with the recognized passive path (size is set to 10GB by HSG firmware). a similar solution will be applied to edgy and feisty. debdiffs will follow with the same logic. udev rules and sg_start invocation will be different. Fabio ** Attachment added: "mp-tools-dapper.debdiff" http://librarian.launchpad.net/7125067/mp-tools-dapper.debdiff ** Changed in: multipath-tools (Ubuntu Dapper) Status: Confirmed => In Progress -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 98518] Re: Fails to install because of brain damage in init script that should be converted to udev rules
Hi Tore, thanks for the information, I am changing bug information to make sure we do the very right thing including getting rid of this brain damaged init script and let the kernel+udev handle everything properly. Fabio ** Summary changed: - Fails to install because of brain damage in init script + Fails to install because of brain damage in init script that should be converted to udev rules -- Fails to install because of brain damage in init script that should be converted to udev rules https://bugs.launchpad.net/bugs/98518 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
