[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
We should also dissect OSErrors and append errno. Python 3 already does that by having specific subclasses such as PermissionError for EACCES, but this is still useful for Python 2 or if we run into an errno which doesn't have a subclass. ** Changed in: apport (Ubuntu) Assignee: (unassigned) => Martin Pitt (pitti) ** Changed in: apport (Ubuntu) Status: Triaged => In Progress ** Summary changed: - the signatures match code should probably consider the exception for python errors + Make duplicate signature more specific for DBusException and OSError -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: Make duplicate signature more specific for DBusException and OSError To manage notifications about this bug go to: https://bugs.launchpad.net/daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
Due to the nature of Python exceptions this indeed can only ever be a
heuristic. Some Python errors are already very specific, and we *don't*
want their message be part of the signature. For example, we want to
treat PermissionError('/home/fred/foo') and
PermissionError('/home/joe/bar') as one and the same bug. Likewise, in
the example in the description we would want
"org.freedesktop.Accounts.Error.Failed: 'bg_BG.UTF-8' is not a valid
locale name" to be treated exactly the same as any other locale name.
Exception messages also often have localized or otherwise user/system
specific context in them.
For DBusError the situation is still relatively easy -- this is a well-
known one from dbus-python which actually wraps a "real" exception on
the server. For the duplicate signature we certainly should unwrap that
inner exception, so that we end up with something like
"DBusException:org.freedesktop.Accounts.Error.PermissionDenied".
The other case of pyapt's SystemErrors are harder to dissect as there is
no structure in the exceptions and their messages. So the only real
options that we have are to keep the status quo (don't use the message
at all) or take it wholesale. But I think the latter wouldn't be
helpful as it would consider too many things as "not the same bug". One
could go further and just take the last word, but I think that would be
completely arbitrary and still not help (translations/not capturing the
important part).
So I propose to do one step at a time and unwrap DBusExceptions for now.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/989819
Title:
the signatures match code should probably consider the exception for
python errors
To manage notifications about this bug go to:
https://bugs.launchpad.net/daisy/+bug/989819/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
** Changed in: daisy Assignee: Evan Dandrea (ev) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: the signatures match code should probably consider the exception for python errors To manage notifications about this bug go to: https://bugs.launchpad.net/daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
** Changed in: daisy Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: the signatures match code should probably consider the exception for python errors To manage notifications about this bug go to: https://bugs.launchpad.net/daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
** Also affects: apport (Ubuntu) Importance: Undecided Status: New ** Changed in: apport (Ubuntu) Status: New = Triaged ** Changed in: apport (Ubuntu) Importance: Undecided = High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: the signatures match code should probably consider the exception for python errors To manage notifications about this bug go to: https://bugs.launchpad.net/daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
We can see how the crash signature is created by apport for python
tracebacks here: http://bazaar.launchpad.net/~ubuntu-core-
dev/ubuntu/quantal/apport/ubuntu/view/head:/apport/report.py#L1206.
The problematic bit follows:
return self['ExecutablePath'] + ':' + trace[-1].split(':')[0] + sig
Here were just using the first part of the last line of the trace to
create the signature. Considering just the trace[-1].split(':')[0]
portion we have the same partial signature for bugs 772083 781360 -
'SystemError'. However, if we expand this out a bit we have:
772083: SystemError: E:Encountered a section with no Package: header,
E:Problem with MergeList
/var/lib/apt/lists/archive.canonical.com_ubuntu_dists_natty_partner_binary-i386_Packages,
E:The package lists or status file could not be parsed or opened.
781630: SystemError: E:Write error - write (28: No space left on device), E:IO
Error saving source cache, E:The package lists or status file could not be
parsed or opened.
which is quite different. For the partial signature we could use all of
trace[-1] or a portion there of. I have code that will download all the
tracebacks for a package and compare their old partial signatures to a new one.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/989819
Title:
the signatures match code should probably consider the exception for
python errors
To manage notifications about this bug go to:
https://bugs.launchpad.net/daisy/+bug/989819/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
** Also affects: daisy Importance: Undecided Status: New ** Changed in: daisy Importance: Undecided = High ** Changed in: daisy Assignee: (unassigned) = Evan Dandrea (ev) ** No longer affects: whoopsie-daisy (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: the signatures match code should probably consider the exception for python errors To manage notifications about this bug go to: https://bugs.launchpad.net/daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
** Changed in: whoopsie-daisy (Ubuntu) Importance: Undecided = High ** Changed in: whoopsie-daisy (Ubuntu) Milestone: None = ubuntu-12.10 ** Changed in: whoopsie-daisy (Ubuntu) Assignee: (unassigned) = Evan Dandrea (ev) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: the signatures match code should probably consider the exception for python errors To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/whoopsie-daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
** This bug is no longer a duplicate of bug 523896 useradd: cannot lock /etc/passwd; try again later. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: the signatures match code should probably consider the exception for python errors To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/whoopsie-daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
*** This bug is a duplicate of bug 523896 *** https://bugs.launchpad.net/bugs/523896 ** This bug is no longer a duplicate of bug 988995 package whoopsie 0.1.32 failed to install/upgrade: el subproceso instalado el script post-installation devolvió el código de salida de error 1 ** This bug has been marked a duplicate of bug 523896 useradd: cannot lock /etc/passwd; try again later. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: the signatures match code should probably consider the exception for python errors To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/whoopsie-daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 989819] Re: the signatures match code should probably consider the exception for python errors
*** This bug is a duplicate of bug 988995 *** https://bugs.launchpad.net/bugs/988995 ** This bug has been marked a duplicate of bug 988995 package whoopsie 0.1.32 failed to install/upgrade: el subproceso instalado el script post-installation devolvió el código de salida de error 1 ** This bug has been marked a duplicate of bug 988995 package whoopsie 0.1.32 failed to install/upgrade: el subproceso instalado el script post-installation devolvió el código de salida de error 1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/989819 Title: the signatures match code should probably consider the exception for python errors To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/whoopsie-daisy/+bug/989819/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
