Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Mon, Apr 05, 2021 at 03:22:24PM -, James Hennig wrote:
>Since this is the main thread on the Internet about this issue, I
>suppose it is appropriate to post here even though I am using Manjaro.
>
>- This issue is non-present on a Thinkpad 3 14ADA05 with touchpad
>MSFT0001:00 06CB:CE2D on kernel 5.9.16-1 which uses i2c_hid. It is not
>elantech or designware (doesn't load the associated specific i2c
>drivers). Installing an entirely new keyboard panel with a new touchpad,
>essentially rebuilding the entire laptop does not address this issue. It
>is the same model touchpad for this specific laptop model even if you
>order a new one (unless I got bad luck of the draw).

If kernel 5.9.16-1 with i2c_hid driver worked for you, I'd suggest you
stick with the i2c_hid that comes with kernel 5.9.16-1 and build a
stand-alone driver for newer kernel and replace newer i2c_hid driver.

>
>- The issue becomes present on kernel 5.10.23-1 (and previous versions
>of 5.10) up to 5.12rc3. Have not tried compiling 5.12rc5, but no reason
>to believe it would work.
>
>The touchpad will fail to be recognized and work on bootup between 1-30
>reboots. I have tried many things such as different kernels and
>GRUB_CMDLINE_LINUX_DEFAULT options, yes even checking to set the kernel
>config option others are suggesting (Manjaro removed then reinstated the
>CONFIG_I2C_HID_ACPI=m option). I also tore apart kernels 5.9 and 5.10 to
>look at the pinctrl-amd.c driver and found that there was no difference
>between the two on these kernels, so it is something other than what
>https://launchpadlibrarian.net/500948605/0303-pinctrl-amd2.patch
>addresses since it works on the former kernel but not the latter. Also,
>the patch fails to apply on 5.12rc5.
>
>I don't really know how to compare the entire torn-apart kernels 5.9 and
>5.10 to try and find what change(s) could possibly cause this bug.
>Hopefully someone else knows how to?
>
>Might be able to get somewhere if so...
>
>Other mods might be replacing the touchpad with a model not designed for
>the laptop, but I don't know where to start with that either.
>

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Sat, Mar 06, 2021 at 03:24:35PM -, Shatadru Banerjee wrote:
>I want to politely point out that this thread is not helping anymore; it
>has become mere chit-chat. Things were confusing to begin with and
>unfortunately it is becoming more confusing. What is the fix? Does is
>work with a particular kernel? The use of mainline kernel 5.11 should
>solve all the problems? Is this nvidia gpu issue related to the solution
>to the trackpad? Why can't the external monitor work, even with the AMD
>iGPU? Most importantly, what one should do to have a working touchpad,
>working nvida gpu and working external monitor? Please reply only if you
>know what are you going to write.


On Sat, Mar 13, 2021 at 03:17:55AM -, Shatadru Banerjee wrote:
>I did not mention brightness issue. With 5.11.3 the brightness does not
>work flawlessly however there are more serious problems. 1. External
>monitor not detected via HDMI, 2. still the wifi is not stable, 3.
>cannot switch to nvidia.

On Thu, Apr 01, 2021 at 03:06:02AM -, Shatadru Banerjee wrote:
>This thread has gone from stupid to completely pointless.

Sorry to know this thread didn't help you. This thread only deals with 
the touchpad issue and it's too long to follow. But I've summarized
what's needed in the beginning of the bug report. As far as I know, the
fix for the touchpad doesn't affect nvidia issue. In fact, I don't
experience any of the issues you mentioned including external monitor 
not detected and brightness issue on Manjara with kernel=5.11.6-1 
after installing optimus manager [1]. [1] is "a port to Archlinux of the
nvidia-prime solution created by Canonical for Ubuntu" so I assume the
issues of external monitor and brightness don't bother Ubuntu users
either.

[1] https://github.com/Askannz/optimus-manager/

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Tue, Mar 02, 2021 at 01:40:54AM -, Helmut Stult wrote:
>Works again - have to set CONFIG_I2C_HID_ACPI=m in config

Well done!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Fri, Feb 26, 2021 at 02:28:24PM -, Marton Danko wrote:
>Hi Coiby,
>
>Thanks, it seems that correctly telling which hardware button do I press.
>Right:
>-event18  POINTER_BUTTON   +0.174s  BTN_RIGHT (273) pressed, seat count: 1
> event18  POINTER_BUTTON   +0.318s  BTN_RIGHT (273) released, seat count: 0
>Middle:
> event18  POINTER_BUTTON   +3.086s  BTN_MIDDLE (274) pressed, seat count: 1
> event18  POINTER_BUTTON   +3.362s  BTN_MIDDLE (274) released, seat count: > 0
>Left:
> event18  POINTER_BUTTON   +5.132s  BTN_LEFT (272) pressed, seat count: 1
> event18  POINTER_BUTTON   +5.271s  BTN_LEFT (272) released, seat count: 0
>
>And in the mentioned bug report the following resolution works:
>"Apparently it's a change they did in GNOME 3.28 and can be fixed by switching 
>to Area mouse click emulation in GNOME Tweaks."
>

Good to know that:)

>Thanks for your help, and now I need to go to the corner to cry again,
>why such a stupid default configuration is shipped with the system...
>

You are welcome!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi Marton,

On Tue, Feb 23, 2021 at 05:00:30PM -, Marton Danko wrote:
>Hi Coiby,
>
>Did you find anything about why it still doesn't work properly on my
>machine?
>

Your GPIO pin register value for the touchpad is 0x51b00 which means the
root cause has been fixed. I've less certain about the evest result but
I don't find something suspicious when comparing it with my laptop. Can
you create another user and check if the problem still occurs after 
logging in?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi Maton,

On Mon, Feb 15, 2021 at 08:46:57AM -, Maton Danko wrote:
>I've checked the 5.11.0-rc7 and the touchpad still doesn't work
>properly, on the left and right bottom side the same primary action is
>being taken instead of secondary on the right and primary on the left!
>

5.11.0-rc7 is expected to fix your touchpad. Could you paste the output of
"sudo cat /sys/kernel/debug/gpio|grep pin130 -A1" and also the output of 
"sudo evest" when you lick the left bottom and right bottom button?

>-- 
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/1887190
>
>Title:
>  MSFT Touchpad not working on Lenovo Legion-5 15ARH05
>
>Status in Pop!_OS:
>  New
>Status in linux package in Ubuntu:
>  Confirmed
>Status in xserver-xorg-input-libinput package in Ubuntu:
>  Confirmed
>Status in linux package in Arch Linux:
>  Fix Committed
>Status in linux package in Fedora:
>  Confirmed
>Status in linux package in openSUSE:
>  New
>
>Bug description:
>  Update (based on #296)
>  =
>
>  The latest kernel tree
>  (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git)
>  has the complete solution to fix this bug. So we can expect kernel
>  v5.11 to fix this issue without any additional work.
>
>  Before the release of v5.11, you are suggested to use #189 to save your 
> touchpad. Note that for distributions like Ubuntu and Fedora, the pinctrl-amd 
> driver is built into the initramfs. So you have to rebuild the initramfs 
> after replacing the old module with new one.
>  On Fedora, run `sudo dracut --force`; On ubuntu, run `sudo update-initramfs 
> -u`.
>
>  The complete solution is three patches,
>   - 47a0001436352c9853d72bf2071e85b316d688a2 ("pinctrl: amd: remove debounce 
> filter setting in IRQ type setting")
>   - 06abe8291bc31839950f7d0362d9979edc88a666 ("pinctrl: amd: fix incorrect 
> way to disable debounce filter")
>   - 8dcb7a15a585b6d0fee15751ce11d7a68cfedd56 ("gpiolib: acpi: Take into 
> account debounce settings")
>
>  The first two patches has reached the stable tree. If the last one is
>  also backported to LTS kernel, you won't need to install kernel 5.11.
>  But I don't know when this will happen.
>
>  Original bug report
>  ===
>
>  Hello
>
>  The MSFT touchpad of this Lenovo Legion-5 15ARH05 laptop is not reacting at 
> all (pointer and click never move when touchpad is touched). This has been 
> reported by other users in various websites, with various linux systems 
> including other Ubuntu systems, but I saw no launchpad bug so I post one. 
> Example of websites covering the issue :
>  - https://askubuntu.com/questions/1253830/lenovo-legion-5-touchpad (exactly 
> the same laptop)
>  - https://www.linux.org/threads/lenovo-legion-5-touchpad.29536/ (similar 
> laptop)
>
>  xinput indentifies it as MSFT0001:00 04F3:3140
>
>  Virtual core pointer id=2[master pointer  (3)]
>  ⎜   ↳ Virtual core XTEST pointer id=4[slave  pointer 
>  (2)]
>  ⎜   ↳ MSFT0001:00 04F3:3140 Touchpad id=17   [slave  pointer 
>  (2)]
>  ⎜   ↳ MSFT0001:00 04F3:3140 Mouseid=16   [slave  pointer 
>  (2)]
>  ⎜   ↳ ITE Tech. Inc. ITE Device(8910) Consumer Control   id=12   [slave  
> pointer  (2)]
>  ⎜   ↳ Logitech USB Optical Mouse id=11   [slave  pointer 
>  (2)]
>  ⎣ Virtual core keyboard  id=3[master keyboard (2)]
>  ↳ Virtual core XTEST keyboardid=5[slave  
> keyboard (3)]
>  ↳ Ideapad extra buttons  id=15   [slave  
> keyboard (3)]
>  ↳ Power Button   id=6[slave  
> keyboard (3)]
>  ↳ Integrated Camera: Integrated Cid=10   [slave  
> keyboard (3)]
>  ↳ Video Bus  id=7[slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE Device(8910) Consumer Control   id=19   [slave  
> keyboard (3)]
>  ↳ Power Button   id=9[slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE Device(8910) Wireless Radio Control id=13   [slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE Device(8910) Keyboard   id=14   [slave  
> keyboard (3)]
>  ↳ AT Translated Set 2 keyboard   id=18   [slave  
> keyboard (3)]
>  ↳ Video Bus  id=8[slave  
> keyboard (3)]
>
>  Thanks a lot for your time. It does not help, but I can confirm what
>  was reported on askubuntu by another user : the touchpad does work on
>  Windows.
>
>  ProblemType: Bug
>  DistroRelease: Ubuntu 20.04
>  Package: linux-image-5.4.0-40-generic 5.4.0-40.44
>  ProcVersionSignature: Ubuntu 5.4.0-40.44-generic 5.4.44
>  Uname: Linux 5.4.0-40-generic x86_64
>  NonfreeKernelModules: nvidia_modeset nvidia
>  ApportVersion: 2.20.11-0ubuntu27.3
>  Architecture: amd64
>  AudioDevicesInUse:
>   USER

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi resolve,

On Sun, Feb 14, 2021 at 04:09:09PM -, roselove wrote:
>Hi, I think I personally tried everything from bbs.archlinux.org,
>forum.manjaro.org, reddit, https://github.com/coiby/standalone_i2c_hid,
>bugzilla, bugs.launchpad.net, etc...
>
>I tried Coiby solution this very day (2021-02-14).
>
>Nothing ever worked since I updated to 9.7 kernel (coiby solution was
>nice before that ^^)
>
>Here is my lenovo model :
>https://psref.lenovo.com/Detail/Legion/Lenovo_Legion_5_15ARH05?M=82B50015FR
>
>Here is my touchpad model :
>```
>Input device ID: bus 0x18 vendor 0x6cb product 0x7f28 version 0x100
>Input device name: "MSFT0001:00 06CB:7F28 Touchpad"
>```
>
>evtest gives that btw :
>```
>Testing ... (interrupt to exit)
>expected 24 bytes, got -1
>
>evtest: error reading: No such device
>```
>

Did the above error happens when using
https://github.com/coiby/standalone_i2c_hid?

Have you tried what's suggested in the bug description?

>Now I'm running on `Kernel: 5.10.15-1-MANJARO`, I never managed to make
>touchpad OR brightness work \o/, I guess I'll need to reinstall
>everything someday but if anyone have any clue I guess I'll take it :D
>

As for the brightness issue, https://github.com/Askannz/optimus-manager/
works for me.

>-- 
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/1887190
>
>Title:
>  MSFT Touchpad not working on Lenovo Legion-5 15ARH05
>
>Status in Pop!_OS:
>  New
>Status in linux package in Ubuntu:
>  Confirmed
>Status in xserver-xorg-input-libinput package in Ubuntu:
>  Confirmed
>Status in linux package in Arch Linux:
>  Fix Committed
>Status in linux package in Fedora:
>  Confirmed
>Status in linux package in openSUSE:
>  New
>
>Bug description:
>  Update (based on #296)
>  =
>
>  The latest kernel tree
>  (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git)
>  has the complete solution to fix this bug. So we can expect kernel
>  v5.11 to fix this issue without any additional work.
>
>  Before the release of v5.11, you are suggested to use #189 to save your 
> touchpad. Note that for distributions like Ubuntu and Fedora, the pinctrl-amd 
> driver is built into the initramfs. So you have to rebuild the initramfs 
> after replacing the old module with new one.
>  On Fedora, run `sudo dracut --force`; On ubuntu, run `sudo update-initramfs 
> -u`.
>
>  The complete solution is three patches,
>   - 47a0001436352c9853d72bf2071e85b316d688a2 ("pinctrl: amd: remove debounce 
> filter setting in IRQ type setting")
>   - 06abe8291bc31839950f7d0362d9979edc88a666 ("pinctrl: amd: fix incorrect 
> way to disable debounce filter")
>   - 8dcb7a15a585b6d0fee15751ce11d7a68cfedd56 ("gpiolib: acpi: Take into 
> account debounce settings")
>
>  The first two patches has reached the stable tree. If the last one is
>  also backported to LTS kernel, you won't need to install kernel 5.11.
>  But I don't know when this will happen.
>
>  Original bug report
>  ===
>
>  Hello
>
>  The MSFT touchpad of this Lenovo Legion-5 15ARH05 laptop is not reacting at 
> all (pointer and click never move when touchpad is touched). This has been 
> reported by other users in various websites, with various linux systems 
> including other Ubuntu systems, but I saw no launchpad bug so I post one. 
> Example of websites covering the issue :
>  - https://askubuntu.com/questions/1253830/lenovo-legion-5-touchpad (exactly 
> the same laptop)
>  - https://www.linux.org/threads/lenovo-legion-5-touchpad.29536/ (similar 
> laptop)
>
>  xinput indentifies it as MSFT0001:00 04F3:3140
>
>  Virtual core pointer id=2[master pointer  (3)]
>  ⎜   ↳ Virtual core XTEST pointer id=4[slave  pointer 
>  (2)]
>  ⎜   ↳ MSFT0001:00 04F3:3140 Touchpad id=17   [slave  pointer 
>  (2)]
>  ⎜   ↳ MSFT0001:00 04F3:3140 Mouseid=16   [slave  pointer 
>  (2)]
>  ⎜   ↳ ITE Tech. Inc. ITE Device(8910) Consumer Control   id=12   [slave  
> pointer  (2)]
>  ⎜   ↳ Logitech USB Optical Mouse id=11   [slave  pointer 
>  (2)]
>  ⎣ Virtual core keyboard  id=3[master keyboard (2)]
>  ↳ Virtual core XTEST keyboardid=5[slave  
> keyboard (3)]
>  ↳ Ideapad extra buttons  id=15   [slave  
> keyboard (3)]
>  ↳ Power Button   id=6[slave  
> keyboard (3)]
>  ↳ Integrated Camera: Integrated Cid=10   [slave  
> keyboard (3)]
>  ↳ Video Bus  id=7[slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE Device(8910) Consumer Control   id=19   [slave  
> keyboard (3)]
>  ↳ Power Button   id=9[slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE Device(8910) Wireless Radio Control id=13   [slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE 

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

HI Nicolas,

On Fri, Jan 29, 2021 at 12:07:30PM -, Nicolas Rogues wrote:
>Following the bot's message, I do not see a new kernel in -proposed ?
>(with 5.8.0-41-generic rightg now). Is this a bot bug, or is there a
>newer 5.8 kernel with all patches applied ?
>
>Regarding brightness control, as mentioned early in the thread by
>Helmut, we also had the issue on this model. No version from 5.4 to 5.8
>allowed it to work in discrete GPU mode.
>
>Now things have a little changed since yesterday's update of NVIDIA runtimepm 
>(bug 1895855) solving PRIME support issue, now I can boot in hybrid mode and 
>enjoy brightness control when using the iGPU
>https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1895855
>

In hybrid mode, does external monitor work for you?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Mon, Jan 25, 2021 at 07:03:55PM -, Adam Felson wrote:
>Before I grab'n'build 5.11, I'd like to know if my issue is similar.
>I have a lenovo ideapad 730s.
>The touchpad works fine for pointing, single, double and triple clicks.
>I have tried both the synaptics and libinput drivers.  It's been a while since 
>I was comparing them;  IIRC, I'm currently running the synaptics driver as 
>libinput didn't have scrolling/coasting working.
>
>My problem is that palm detection and pressure sensitivity do not work.
>This makes the laptop pretty much unusable as it is almost impossible to
>do any text entry without the insertion point jumping to wherever the
>pointer was left.
>
>Might the 5.11 kernel fix it?

Your issue sounds different to this one. But you needn't to build the
kernel to see if the solution here works for you. You can try #189. If
it works for you, then 5.11 could also fix your issue. You may also want
to give https://github.com/coiby/standalone_i2c_hid a try.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Thu, Jan 21, 2021 at 01:05:48PM -, Joe Zhou wrote:
>Lenovo R7000P Laptop. Sadly, still not a good solution. The touch pad
>now works with kernel 5.11.0, but it has problem with Nvidia GPU and the
>brightness control is not working. I can have Nvidia GPU working and
>manually do some fixes to enable brightness control with 5.8.0, though
>touch pad is not working.

Newer kernels must have caused regression about brightness control.

You can follow the bug description and #189 to fix the touchpad with 5.8.0,
then you can have both Nvidia GPU and touchpad working.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi Robin Windey (r0wi) and Stéphane Roussel (stephane-roussel),

On Fri, Dec 25, 2020 at 08:52:35PM -, Robin Windey wrote:
>Had access to another Ideapad with touchpad MSFT0001:00 04F3:3140
>installed. Kernel 5.10.2-051002-generic #202012210832 did not work out
>of the box but in combination with #322 it worked so i can confirm, too.

We shouldn't use #322 because it's equivalent of keeping polling the
touchpad.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi Kai-Heng Feng,

On Sun, Dec 20, 2020 at 07:30:12AM -, Kai-Heng Feng wrote:
>8dcb7a15a585b6d0fee15751ce11d7a68cfedd56 ("gpiolib: acpi: Take into
>account debounce settings") is part of a series with 18 patches, so it's
>safer to only bakcport it for 5.10 kernels.

Although it's part of a patch set, it's rather an independent patch
because it's filling a missing implementation of the ACPI specs. I guess
Windows have already implemented it and that's why the touchpad works
for Windows.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi @Helmut Stult (helmut-stult)

On Wed, Dec 16, 2020 at 6:32 PM Helmut Stult <1887...@bugs.launchpad.net>
wrote:

> The problem is your last patch
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl
> /pinctrl-amd.c?h=v5.10=47a0001436352c9853d72bf2071e85b316d688a2
> 
>
There is nothing wrong with this patch. As written in the commit
message, this patch depends on commit 06abe8291bc31839950f7d0362d9979edc88a666
("pinctrl: amd: fix incorrect way to disable debounce filter") and
commit 8dcb7a15a585 ("gpiolib: acpi: Take into account debounce settings")
to fix the touchpad. And the latter one hasn't been adopted by Linux
kernel v5.10.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi Logan,

On Sun, Dec 6, 2020 at 12:05 PM Logan <1887...@bugs.launchpad.net> wrote:
> The output Coiby requested
> [root@lappy-the-laptop ~]# journalctl -k | grep -i amd_
> Dec 05 15:55:13 lappy-the-laptop kernel: amd_uncore: AMD NB counters detected
> Dec 05 15:55:13 lappy-the-laptop kernel: amd_uncore: AMD LLC counters detected
> Dec 05 15:55:13 lappy-the-laptop kernel: amd_gpio reg_val=500e8, pin=130 
> (before set_type)
> Dec 05 15:55:13 lappy-the-laptop kernel: amd_gpio reg_val=50388, pin=130 
> (LEVEL_LOW)
> Dec 05 15:55:13 lappy-the-laptop kernel: amd_gpio reg_val=503c8, pin=130 
> (before set_type)
> Dec 05 15:55:13 lappy-the-laptop kernel: amd_gpio reg_val=50388, pin=130 
> (LEVEL_LOW)
 ^
50388 means the glitch filter has been disabled. So the patch has took
info effect. You touchpad should work now.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi Mike,

On Sun, Dec 06, 2020 at 09:12:23PM -, Mike Boruta wrote:
>Hello Coiby,
>
>I built and installed the module as per the instructions in the branch
>you linked me to and `journalctl -k|grep amd_gpio` showed nothing. No
>new printouts in the kernel log. So I recompiled the module again with
>the pr_alert() statement you printed above and still nothing.
>
>So, I recompiled the kernel from source once again but this time I made
>the source code changes before compiling the entire kernel (instead of
>then recompiling the kernel module and overwriting the current one). And
>this worked! Touchpad works just fine and I see the printouts as
>expected (0x50388 instead of 0x51bc8).
>
>My understanding was that simply copying the module over to the old one
>in `/lib/modules/$(uname -r)/kernel/drivers/pinctrl/pinctrl-amd.ko`
>would suffice, but that does not seem to be the case, at least with this
>ubuntu-flavored kernel version. I am interested to know why, but I will
>probably look that up on my own. The important thing is that there
>shouldnt be any doubt regarding whether or not the fix works on 5.7 as
>well.
>
Since you could still access /sys/kernel/debug/gpio, it means the old
module must have been loaded.  The path of the old module could be
/lib/modules/$(uname -r)/kernel/drivers/pinctrl/pinctrl-amd.ko.xz.

So when both old pinctrl-amd.ko.xz and new pinctrl-amd.ko exist, the old
module is loaded by the kernel.

>So once again thank you Coiby for your fix and for helping me to get to
>the bottom of this!
>

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi Mike,

On Sat, Dec 05, 2020 at 09:09:35PM -, Mike Boruta wrote:
>Hello Coiby,
>
>Hmm, as far as I can tell the proper module is being used since I
>executed the same steps for both the 5.7.19 and 5.8 kernels. I also
>confirmed this by running `modinfo pinctrl_amd` and verifying that it is
>no longer signed. I understand what you are saying regarding 0x51bc8,
>maybe a different code path is being executed? Perhaps it would be best
>for someone to independently confirm this before digging in further; I
>have run through these steps a few times so I don't think I made a silly
>mistake but anything is possible.

Could you insert some pr_alert code to verify the updated module has
been loaded?

pr_alert("amd_gpio reg_val=%x, pin=%lu (LEVEL_LOW)",
pin_reg, d->hwirq);

You can also use the repo
https://github.com/coiby/standalone_pinctrl_amd/tree/debug_for_Mike.

And after the system getting rebooted, paste the result of `journalctl
-k|grep amd_gpio` here?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi Mike,

On Sun, Nov 29, 2020 at 08:07:43PM -, Mike Boruta wrote:
>@Coiby Xu (coiby)
>
>Hello Coiby, had some time today so I compiled 5.7.19 from ubuntu
>mainline (https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.7.19/) with
>pinctrl_amd configured as a module, applied the patch in #171, and ran
>the command you provided:
>
>$ sudo cat /sys/kernel/debug/gpio | grep -A1 pin130
>pin130 Level trigger| Active low| interrupt is enabled| interrupt is unmasked| 
>disable wakeup in S0i3 state| disable wakeup in S3 state|
> disable wakeup in S4/S5 state| input is high|   pull-up is disabled| 
> Pull-down is disabled|   output is disabled| 0x51bc8
>
Obviously, the patch in #171 didn't take into effect because 0x51bc8 means
debounce filter is enabled and the debounce timeout is set to 124.8ms.
So my best guess is
/lib/modules/`uname -r`/kernel/drivers/pinctrl/pinctrl-amd.ko.xz
hasn't been replaced by the patched one.

>Please let me know if I can be of further help!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

@Pedro Ribeiro

On Wed, Nov 25, 2020 at 10:23:25AM -, Pedro Ribeiro wrote:
>Don't want to hijack this thread, but has anyone here with a Legion 5
>(AMD version) has gotten the backlight working in Discrete graphics mode
>(only the nvidia GPU enabled)?

Have you tried installing the proprietary NVIDIA graphics card driver?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

@Mike Boruta

On Tue, Nov 24, 2020 at 02:37:34AM -, Mike Boruta wrote:
>@Coiby Xu (coiby)
>
>Yes, that summarizes my findings nicely.

That's a bit strange. It should work for at least 5.7 as well. If you
have time, you can show me the result of
"sudo cat /sys/kernel/debug/gpio|grep -A1 pin130" using older Linux after
applying the patch in #171.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

@Azizkhan (injkgz)

On Mon, Nov 23, 2020 at 04:39:29PM -, Pedro Ribeiro wrote:
>@Azizkhan (injkgz)
>
>I don't think it is, I believe the for-next branch in linux-gpio will
>only be integrated in 5.11, but @Coiby Xu (coiby) should be able to
>confirm that.
>
It may also be backported to stable trees like 4.19, 5.4.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

@Pedro Ribeiro (pedrib)

On Sun, Nov 22, 2020 at 07:48:27AM -, Pedro Ribeiro wrote:
>@Coiby Xu (coiby)
>
>I build the next branch of linux-gpio (which contains the patch you mentioned 
>in #251), and the trackpad works just fine without the hid polling on the 
>kernel command line.
>You can contact me if you'd like further testing, my email is 
>pedrib_at_gmail_dot_com

Thank you for testing the patch! I'll put you in the Cc list next time.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

@Mike Boruta (maridius)

On Sun, Nov 15, 2020 at 08:34:03PM -, Mike Boruta wrote:
>@Coiby Xu (coiby)
>
>It seems that the patch in 171 does not work (i.e. touchpad is still
>dead) on kernels older than 5.8. I tried 5.4.75, 5.7.19, and 5.8.18. I
>don't really want to look into this further since I'm fine with the
>newer kernel, but wanted to give you and any other users a heads up in
>case they find themselves in a similar situation. The kernels I was
>testing were taken straight from Ubuntu's mainline kernel page, and had
>only the following changes: CONFIG_PINCTRL_AMD was made into a module,
>specified line in  pinctrl-amd.c was commented out.
>
So the patch in 171 works on kernels >=5.8 but doesn't work for older
version like 5.7.19?
>Thanks again for all of your help in making the linux experience with
>this class of laptop much more enjoyable!
>
>--
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/1887190
>
>Title:
>  MSFT Touchpad not working on Lenovo Legion-5 15ARH05
>
>Status in Pop!_OS:
>  New
>Status in linux package in Ubuntu:
>  Confirmed
>Status in xserver-xorg-input-libinput package in Ubuntu:
>  Confirmed
>Status in linux package in Arch Linux:
>  Fix Committed
>Status in linux package in Fedora:
>  Confirmed
>Status in linux package in openSUSE:
>  New
>
>Bug description:
>  Hello
>
>  The MSFT touchpad of this Lenovo Legion-5 15ARH05 laptop is not reacting at 
> all (pointer and click never move when touchpad is touched). This has been 
> reported by other users in various websites, with various linux systems 
> including other Ubuntu systems, but I saw no launchpad bug so I post one. 
> Example of websites covering the issue :
>  - https://askubuntu.com/questions/1253830/lenovo-legion-5-touchpad (exactly 
> the same laptop)
>  - https://www.linux.org/threads/lenovo-legion-5-touchpad.29536/ (similar 
> laptop)
>
>  xinput indentifies it as MSFT0001:00 04F3:3140
>
>  Virtual core pointer id=2[master pointer  (3)]
>  ⎜   ↳ Virtual core XTEST pointer id=4[slave  pointer 
>  (2)]
>  ⎜   ↳ MSFT0001:00 04F3:3140 Touchpad id=17   [slave  pointer 
>  (2)]
>  ⎜   ↳ MSFT0001:00 04F3:3140 Mouseid=16   [slave  pointer 
>  (2)]
>  ⎜   ↳ ITE Tech. Inc. ITE Device(8910) Consumer Control   id=12   [slave  
> pointer  (2)]
>  ⎜   ↳ Logitech USB Optical Mouse id=11   [slave  pointer 
>  (2)]
>  ⎣ Virtual core keyboard  id=3[master keyboard (2)]
>  ↳ Virtual core XTEST keyboardid=5[slave  
> keyboard (3)]
>  ↳ Ideapad extra buttons  id=15   [slave  
> keyboard (3)]
>  ↳ Power Button   id=6[slave  
> keyboard (3)]
>  ↳ Integrated Camera: Integrated Cid=10   [slave  
> keyboard (3)]
>  ↳ Video Bus  id=7[slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE Device(8910) Consumer Control   id=19   [slave  
> keyboard (3)]
>  ↳ Power Button   id=9[slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE Device(8910) Wireless Radio Control id=13   [slave  
> keyboard (3)]
>  ↳ ITE Tech. Inc. ITE Device(8910) Keyboard   id=14   [slave  
> keyboard (3)]
>  ↳ AT Translated Set 2 keyboard   id=18   [slave  
> keyboard (3)]
>  ↳ Video Bus  id=8[slave  
> keyboard (3)]
>
>  Thanks a lot for your time. It does not help, but I can confirm what
>  was reported on askubuntu by another user : the touchpad does work on
>  Windows.
>
>  ProblemType: Bug
>  DistroRelease: Ubuntu 20.04
>  Package: linux-image-5.4.0-40-generic 5.4.0-40.44
>  ProcVersionSignature: Ubuntu 5.4.0-40.44-generic 5.4.44
>  Uname: Linux 5.4.0-40-generic x86_64
>  NonfreeKernelModules: nvidia_modeset nvidia
>  ApportVersion: 2.20.11-0ubuntu27.3
>  Architecture: amd64
>  AudioDevicesInUse:
>   USERPID ACCESS COMMAND
>   /dev/snd/controlC0:  nicolas1567 F pulseaudio
>   /dev/snd/controlC1:  nicolas1567 F pulseaudio
>   /dev/snd/controlC2:  nicolas1567 F pulseaudio
>  CasperMD5CheckResult: skip
>  CurrentDesktop: ubuntu:GNOME
>  Date: Fri Jul 10 20:14:25 2020
>  InstallationDate: Installed on 2020-07-02 (8 days ago)
>  InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
>  MachineType: LENOVO 82B5
>  ProcEnviron:
>   TERM=xterm-256color
>   PATH=(custom, no user)
>   XDG_RUNTIME_DIR=
>   LANG=fr_FR.UTF-8
>   SHELL=/bin/bash
>  ProcFB: 0 EFI VGA
>  ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-5.4.0-40-generic 
> root=UUID=d8898017-2821-434e-ab52-fec76ac93106 ro quiet splash vt.handoff=7
>  RelatedPackageVersions:
>   linux-restricted-modules-5.4.0-40-generic N/A
>   linux-backports-modules-5.4.0-40-generic  N/A
>   linux-firmware 

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

Hi @Maxim (pavlenkoms),

Is your laptop also a Lenovo Legion-5 model?

On Thu, Nov 12, 2020 at 09:02:54AM -, Maxim wrote:
>Hi @Coiby Xu (coiby)
>I tried #189 and #211 (different combinations) on mate-ubuntu 20.04 with 
>custom kernels 5.8 and 5.9
>I tried to install Manjaro with kernel 5.8.18, and after that I rebuilt custom 
>kernel again with all patches
>But result is only one: touchpad still doesn't work. Is there any way to debug 
>or figure out what exactly went wrong?
>
>And here is an interresting detail. Touchpad devices disappearing in
>xinput output from time to time, and could not work even in uefi menu.
Do you mean the touchpad works sometimes after the booting the system
but would fail when booting system next time?
>

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Sun, Nov 08, 2020 at 07:38:15PM -, Azizkhan wrote:
>Hi all!
>@Coiby Xu (coiby)
>When your patch will be applied to mainline kernel? When we can just update 
>our kernels and do nothing to fix touchpad?

I'm not sure when these patch(es) will be accepted and merged. It's up
to the maintainers to accept the patch(es). If there is any update, I'll
post the notification here.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Sun, Nov 08, 2020 at 01:14:48PM -, Mike Boruta wrote:
>Definitely! The attached output was compiled from 5.4.0-52 with the
>patch listed in 171.

#171 should fix your touchpad. According to your shared gpio-config,
that patch didn't take effect. So I guess you are still using the old
pinctrl-amd module.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Sun, Nov 08, 2020 at 04:33:43PM -, Baq Domalaq wrote:
>Hi everyone! I have the same problem with my touchpad on Lenovo Ideapad
>Gaming 3 15ARH05 under Pop!_OS.
>
>My touchpad device number is slightly different:
>MSFT0001:00 06CB:CE2D
>
>I've applied a patch in comment #179 (I assumed that's the most fitting
>solution for me) and it works now! Thank you people for trying to fix
>this.
>
>Anyway the comments now are very long and confusing. And I'm not sure if
>I used the best solution. So if anyone can point to something better,
>let me know.
>

The touchpads on Legion-5 could be saved by either polling (#179)
or interrupt (#171). I've submitted both patches upstream for these
two methods. After getting reviewed by the kernel developer community,
I will keep improving them until these patches get accepted by the
maintainer. I would suggest you try #171 before the patches getting
merged into the mainline kernel. If it doesn't work, you can send me
your ACPI DSDT table.

>Also let me know how to help with pushing this to official kernel. I've
>posted an issue to Pop OS Github repo. I'll also add a comment about my
>workarounds there.
>
You can send me your email address. I'll Cc you when submitting the
patch(es). Then you can test the received patch and reply to the email
with a Tested-by tag if the patch(es) works,

Tested-by: Your_name 

>Have a nice day!
>

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Wed, Nov 04, 2020 at 12:12:24PM -, Von wrote:
>@Coiby Xu (coiby)
>
>> Will decreasing
>polling_interval_active_us to 1ms fix the problem?
>> $echo 1000 > /sys/module/i2c_hid/parameters/polling_interval_active_us
>
>Yes, I installed the latest version from Github, and decreasing
>polling_interval_active_us seems to fix the problem.

I notice that if I use xf86-input-synaptics, I would also experience
this problem. So another solution is to use xf86-input-libinput.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Sun, Nov 08, 2020 at 03:03:03AM -, Mike Boruta wrote:
>Hello again, I manually applied both the patches present in #239 and in
>#171 to kernel 5.4.0-52 without success (touch pad still does not work),
>however I applied the patch listed on #109 with success. My device is a
>MSFT0001:00 04F3:3186, unlike the 3140 most users have. Have any other
>users with a 3186 experienced success with the pinctrl-amd patches?
>
>I'm very happy with the polling patch so far, but I would like to have
>the core issue fixed if possible.

Hi Mike! Can you paste the output of "sudo cat /sys/kernel/debug/gpio" and
also attach your ACPI DSDT table which can be obtained by following the
instructions in #109?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Tue, Oct 27, 2020 at 07:53:05PM -, Von wrote:
>The standalone patch #217 is working for MSFT0001:00 04F3:3140 but isn't
>working perfectly for MSFT0001:00 06CB:7F28.  The MSFT0001:00 06CB:7F28
>touchpad frequently locks into scroll mode when using multitouch
>gestures.
Thank you for reporting this problem. The latest version [1] allows
you to adjust the polling interval. Will decreasing
polling_interval_active_us to 1ms fix the problem?

$ echo 1000 > /sys/module/i2c_hid/parameters/polling_interval_active_us
# you may change polling_interval_idle_ms as well
$ echo 2 > /sys/module/i2c_hid/parameters/polling_interval_idle_ms

[1] https://github.com/coiby/standalone_i2c_hid

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Tue, Oct 20, 2020 at 09:28:54AM -, Benjamin Rogoll wrote:
>Hey there guy, can anyone tell me what im doing wrong with the patch
>provided in #217. The tutorial in #211 doesnt work for me.
>
>p_$$/tmp.o; mkdir -p 
>/home/benjamin/Downloads/i2c-hid_standalone(1)/i2c-hid_standalone/.tmp_$$; 
>trap "rm -rf 
>/home/benjamin/Downloads/i2c-hid_standalone(1)/i2c-hid_standalone/.tmp_$$" 
>EXIT; if ( echo "int main() {}" | gcc -xc -o /dev/null -lelf  -) >/dev/null 
>2>&1; then echo "1"; else echo "0"; fi'
>/bin/sh: -c: line 0: syntax error near unexpected token `('
>/bin/sh: -c: line 0: `make -f ./scripts/Makefile.build 
>obj=/home/benjamin/Downloads/i2c-hid_standalone(1)/i2c-hid_standalone \'
>make: *** [Makefile:1752: 
>/home/benjamin/Downloads/i2c-hid_standalone(1)/i2c-hid_standalone] Error 1
>make: Leaving directory '/usr/lib/modules/5.8.16-2-MANJARO/build'
>
>help much appreciated
>
Can you run "make V=1" to have more verbose output?

Btw, I would suggest you to try #189 instead because polling could
consume a little more power than interrupting.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Sat, Oct 17, 2020 at 03:23:05PM -, Ivan Zakharyaschev wrote:
>I had problems (the touchpad not working and the suspend not working)
>with ELAN0001:00 04F3:3140 under linux-image-unsigned-5.6.0-1021-oem on
>Ubuntu, but they are gone if I manually unbind the device from
>elants_i2c driver and bind it to i2c_hid --
>https://bugs.launchpad.net/ubuntu/+source/linux-oem-5.6/+bug/1900254
>
Thank you for sharing the info! Do you use the same laptop model?
If that's the case, it would surprise me because the root cause
for this laptop model has been found.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Thu, Oct 15, 2020 at 04:27:05PM -, Lu Do wrote:
>Just try this morning the #210, it's working well on ubuntu 20.04 !
>Thanks @Coiby Xu (coiby)
>
>I also confirmed the suspend will break the touchpad

Thank you for testing it! I've sent a new patch to
https://lore.kernel.org/patchwork/patch/1321917/.
But you may not need it since the old patch will only
break the touchpad with the polling mode disabled.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Thu, Oct 15, 2020 at 04:11:49PM -, Helmut Stult wrote:
>@Coiby Xu (coiby)
>
>We have received feedback in our forum that the touchpad no longer works
>after a resuming from suspend.
>
>I've attached the link - maybe you can take a look at it.
>
>https://forum.manjaro.org/t/i2c-touchpad-does-not-function-after-
>resuming-from-suspend/31987/5

Thanks for the reporting! I've sent a new version to you.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Thu, Oct 15, 2020 at 05:37:46AM -, Kai-Heng Feng wrote:
>Coiby, can you please work on a DMI based workaround in gpiolib-acpi.c?
>It'll have higher chance to get merged.
>
Thank you for the suggestion! Linus Walleij also suggested introducing
a new quirk [1]. Although my main effort is on patching pinctrl-amd.c
without affecting other touchpad together with Hans de Goede [1], I
have spent some time on understanding gpiolib-acpi.c. For now my
conclusion is there is no way to bypass pinctrl-amd by introducing
a new quirk.

[1] https://www.spinics.net/lists/linux-gpio/msg53641.html
[2] https://www.spinics.net/lists/linux-gpio/msg53901.html

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Tue, Oct 13, 2020 at 01:44:31PM -, jbuncle wrote:
>I had the same issue (with both Ubuntu 20.04 and 20.10). It does seem to
>be resolved after installing a 5.9 Kernel with the above patch applied
>(from @coiby https://www.spinics.net/lists/linux-input/msg69458.html.

Glad it works for you. You may want to reply to that email with the
following content to make the patch accepted by the maintainer faster,

Tested-by: Your_name 

The receiver should be linux-in...@vger.kernel.org.

And put the following addresses in the CC filed,
Jiri Kosina 
Benjamin Tissoires 
coiby...@gmail.com

You should also put set the reply-to header to
20201009081100.3154-1-coiby...@gmail.com in your client client so the
message will show in the same thread. And make sure use the plain text
format.

If you don't want go through these hassles, you may send your name to me
by email so I'll do it on behalf of you.

>
>I have scripted the process I used (download, patch, compile and install
>the kernel) for anyone else that's eager to get a working Touchpad on a
>Ubuntu 20 installation on Lenovo Legion 5 (Obviously there may be
>unwanted side effects of doing this). This will probably require Secure
>Boot to be disabled in the BIOS.
>
>See GitHub Gist here: 
>https://gist.github.com/jbuncle/7dacde983b3c33b3b816b10e2fd2308a
>Command for convenience: `bash <(curl 
>https://gist.githubusercontent.com/jbuncle/7dacde983b3c33b3b816b10e2fd2308a/raw/build-patched-kernel.sh)`
>
>Note the need for updating GRUB_CMDLINE_LINUX_DEFAULT with i2c-
>hid.polling_mode=1
>
>(First time I've built the Linux Kernel myself or even commented on
>here!)

Congratulations!

>Thanks to @Coiby Xu (coiby)

You are welcome!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Tue, Oct 13, 2020 at 05:27:44AM -, Azizkhan wrote:
>> i2c-hid.polling_mode=1 to the kernel boot parameters to make the
>touchpad work.
>you mean that I can just flash 5.9 kernel and then add to grub this line:
>GRUB_CMDLINE_LINUX_DEFAULT="quiet splash video.use_native_backlight=1 
>i2c-hid.polling_mode=1"

This patch hasn't been included in Linux 5.9. And I'm not sure when this
patch will be accepted by the subsystem maintainer and eventually reach
your distribution. But you can following the instructions in #211 and
#212 to try this solution.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Sun, Oct 11, 2020 at 07:07:37PM -, Paulinski wrote:
>Is there any chance that his patch will be part of the official kernel
>build soon?

I have yet to submit the patch of fixing the root cause. But I've
submitted a patch of adding polling mode to the i2c-hid module to
https://www.spinics.net/lists/linux-input/msg69458.html last Friday.
After the patch reaches end users like you, you can add
i2c-hid.polling_mode=1 to the kernel boot parameters to make the
touchpad work.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1887190] Re: MSFT Touchpad not working on Lenovo Legion-5 15ARH05

[Coiby Xu]

On Sat, Oct 10, 2020 at 11:38:27AM -, PD wrote:
>@Coiby Xu (coiby)
>Thanks a log for your contribution
>
It's my pleasure!

>I tried to use the way of "echo out > gpio386/direction" to fix the
>problem without patching the kernel, but I found Touchpad click
>sensitivity is less than patching the kernel.

You shouldn't use "echo out > gpio386/direction" to fix the touchpad. It
will make the GPIO chip keep firing interrupts even you don't use the
touchpad as you can seen from the result by wangjun in #193.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1887190

Title:
  MSFT Touchpad not working on Lenovo Legion-5 15ARH05

To manage notifications about this bug go to:
https://bugs.launchpad.net/pop-os/+bug/1887190/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs