Re: [Bug 209537] Re: diffstat does not honor COLUMNS environment variable
On Wed, 20 Jan 2010, Steve Langasek wrote: The request was for diffstat to honor the existing $COLUMNS env variable. Commandline options are orthogonal to this. If you have some advice on how to not impact existing usage, you should comment on that in the bug report. -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net -- diffstat does not honor COLUMNS environment variable https://bugs.launchpad.net/bugs/209537 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 209537] Re: diffstat does not honor COLUMNS environment variable
On Mon, 2008-03-31 at 06:25 +, Daniel Holbach wrote: Michael: can you also forward the patch upstream? Sorry, I forgot to mention that I had done that, too. I have emailed the bare patch to the author of the diffstat program. I did both Ubuntu and the upstream author at the same time. I have not heard back from the upstream author yet, however. --- Mike -- Michael B. Trausch [EMAIL PROTECTED] home: 404-592-5746, 1 www.trausch.us cell: 678-522-7934 im: [EMAIL PROTECTED], jabber Ubuntu Unofficial Backports Project:http://backports.trausch.us/ ** Attachment added: unnamed http://launchpadlibrarian.net/12991022/unnamed -- diffstat does not honor COLUMNS environment variable https://bugs.launchpad.net/bugs/209537 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 209537] Re: diffstat does not honor COLUMNS environment variable
On Mon, 2008-03-31 at 20:04 +, Steve Langasek wrote: While it may seem obvious that we would want diffstat to use the $COLUMNS value from the environment, this change is a behavior change for anyone running diffstat in a terminal window that's not 80 columns wide, which may have unexpected side effects for tools that invoke diffstat. So I think it's better to defer this change until after the hardy release. In the meantime, perhaps you could consider getting this change accepted into the Debian package, so that it will flow into intrepid automatically once the archive unfreezes? Also, you may want to consider whether the decision to honor the $COLUMNS value should be conditional on whether stdout points at a terminal - this is something that packages like, e.g., dpkg do, to good effect. I have submitted it upstream for consideration, and I can look into getting it into Debian. Not sure what that would entail precisely, but I can look at it and see what I can do with it. Also you brought up a great point there about considering what stdout is. I will add that to my patch shortly. Thanks! -- Michael B. Trausch [EMAIL PROTECTED] home: 404-592-5746, 1 www.trausch.us cell: 678-522-7934 im: [EMAIL PROTECTED], jabber Ubuntu Unofficial Backports Project:http://backports.trausch.us/ ** Attachment added: unnamed http://launchpadlibrarian.net/13003980/unnamed -- diffstat does not honor COLUMNS environment variable https://bugs.launchpad.net/bugs/209537 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
