Re: [Bug 372170] Re: intel isw raid metadata at odd offset
On Tue, 2009-05-12 at 07:59 +, Giuseppe Iuculano wrote: > Hi Robert, > > Robert Collins ha scritto: > > So, I may have been writing an hpa interpreter. > > > > Could you try with my patch, with and without 'libata.ignore_hpa=0' ? > > > For the HPA issue, Tejun Heo wrote[1] a patch but upstream never commented it. > He works on his NV raid, but I think make isw use the new alt_size he > implemented, shouldn't be too complicated. Perhaps you could take a look... Certainly looks like the right approach. That will depend on a kernel bump at least, which makes it more complex. -Rob -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
Hi Robert, Robert Collins ha scritto: > So, I may have been writing an hpa interpreter. > > Could you try with my patch, with and without 'libata.ignore_hpa=0' ? For the HPA issue, Tejun Heo wrote[1] a patch but upstream never commented it. He works on his NV raid, but I think make isw use the new alt_size he implemented, shouldn't be too complicated. Perhaps you could take a look... [1]http://lwn.net/Articles/317492/ http://patchwork.kernel.org/patch/4950/ http://patchwork.kernel.org/patch/4952/ http://patchwork.kernel.org/patch/4951/ Cheers, Giuseppe. -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
On Tue, 2009-05-12 at 00:58 +, 3b wrote: > seems to work: ... Cool, thanks. I think this validates the hpa theory, and we should rename the patch accordingly. Better still would be to lookup the specs on hpa and create||use a libhpa to adjust di->sectors. But that can wait. -Rob -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
On Tue, 2009-05-12 at 00:41 +, Luke Yelavich wrote: > Tested dmraid from karmic with Robert's patch included on my ICH9 > controller, and everything works fine. > > My server has ICH10, since it was built last year, and likely has HPA > stuff I could enable, however I am not about to take it offline and plug > a pair of spare disks in to test unless there is an absolute need to do > so. Well, we now know I haven't utterly borked everything. I'd just upload it :). -Rob -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
Tested dmraid from karmic with Robert's patch included on my ICH9 controller, and everything works fine. My server has ICH10, since it was built last year, and likely has HPA stuff I could enable, however I am not about to take it offline and plug a pair of spare disks in to test unless there is an absolute need to do so. -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
On Mon, 2009-05-11 at 23:10 +, 3b wrote: > Sure, if i can figure out how to build it :) apt-get source dmraid apt-get build-dep dmraid wget http://launchpadlibrarian.net/26558415/17_fix_isw_raid_detection_1TB.patch cd dmraid-1.0.0.rc15 (I think, you may have a slightly different name) export QUILT_PATCHES=$(pwd)/debian/patches quilt import -p0 ../17_fix_isw_raid_detection_1TB.patch (I think, you may need -p1) dpkg-buildpackage -us -uc -b now you should have a couple of ../libdmraid*.deb files. sudo dpkg -i the one without -dev in its name. then dmraid -r -d. Cheers, Rob -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
On Mon, 2009-05-11 at 20:25 +, 3b wrote: > > This is actually the metadata being moved to a different location so > dmraid cant find it. > with 2113 fewer total blocks on /dev/sda, and dmraid finds the metadata > on both disks. So, I may have been writing an hpa interpreter. Could you try with my patch, with and without 'libata.ignore_hpa=0' ? Thanks, Rob -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
On Sun, 2009-05-10 at 13:13 +, danwood76 wrote: > Sounds good, if someone else with ICH10 can test it would be great. > Write a patch based on your idea and I will test it to verify it still > works with ICH8 also but I obviously cannot test the ICH10. Thanks, shall do. -Rob -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
Robert Collins wrote: > On Sat, 2009-05-09 at 10:57 +, danwood76 wrote: > >> You could do a probe for the ICH10 tag for now. >> That would probably be safer than guessing a dereference, then we need some >> more ICH10R based people to test which will take time. >> >> You could try building another RAID set with a couple of other disks and >> see if the meta is in the same place on those disks also. >> > > I think the ICH10 tag is actually a serial or some such; its at an odd > spot there. > > What do you think of treating GAFR as a magic bytes, then using the > sector offset following that? > > As long as the final location is checked for still being > 0 we won't > try to read negative offsets, and the followup is_isw call will fail on > non-isw environments. > > It seems pretty safe to me to assume that: > find GAFR > follow a word sector offset > find a 10 byte isw signature > > is only going to occur when someone actually has a ICH environment. > > re testing: I don't have any disks I can wipe I'm sorry. > > -Rob > > Sounds good, if someone else with ICH10 can test it would be great. Write a patch based on your idea and I will test it to verify it still works with ICH8 also but I obviously cannot test the ICH10. regards, Dnany -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 372170] Re: intel isw raid metadata at odd offset
On Sat, 2009-05-09 at 10:57 +, danwood76 wrote: > You could do a probe for the ICH10 tag for now. > That would probably be safer than guessing a dereference, then we need some > more ICH10R based people to test which will take time. > > You could try building another RAID set with a couple of other disks and > see if the meta is in the same place on those disks also. I think the ICH10 tag is actually a serial or some such; its at an odd spot there. What do you think of treating GAFR as a magic bytes, then using the sector offset following that? As long as the final location is checked for still being > 0 we won't try to read negative offsets, and the followup is_isw call will fail on non-isw environments. It seems pretty safe to me to assume that: find GAFR follow a word sector offset find a 10 byte isw signature is only going to occur when someone actually has a ICH environment. re testing: I don't have any disks I can wipe I'm sorry. -Rob -- intel isw raid metadata at odd offset https://bugs.launchpad.net/bugs/372170 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
