Re: [Merge] lp:~khurshid-alam/unity-control-center/fix-image-preview into lp:unity-control-center
Review: Approve that's better, thanks -- https://code.launchpad.net/~khurshid-alam/unity-control-center/fix-image-preview/+merge/359937 Your team Unity Control Center development team is subscribed to branch lp:unity-control-center. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/media-keys-fix into lp:unity-settings-daemon
Review: Approve Thanks, that looks fine to me -- https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/media-keys-fix/+merge/359935 Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-control-center/fix-image-preview into lp:unity-control-center
Review: Needs Fixing Thank you for your work The corresponding upstream change for the user panel is https://gitlab.gnome.org/GNOME/gnome-control-center/commit/5c5d6087 Why didn't you take the other parts of the change? The "non-const" seems needed since now mime_type is the return of a g_strdup. The free call is also needed otherwise you leak the dup-ed string The appareance capplet code is in the same case -- https://code.launchpad.net/~khurshid-alam/unity-control-center/fix-image-preview/+merge/359937 Your team Unity Control Center development team is subscribed to branch lp:unity-control-center. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
