Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base 3.28.2 > meta_gpu_kms_flip_closure_container_free@Base 3.28.3+git20190124 > meta_gpu_kms_flip_crtc@Base 3.28.2 > + meta_gpu_kms_get_current_time_ns@Base 3.28.3+git20190124-0ubuntu18.04.3 >From memory, the change to libmutter-2-0.symbols was not by choice. It was to >silence a lintian warning. If you know how to unexport the symbol via *.symbols (not changing patches compared to what's already released) and keep lintian happy then I am happy to do so. > meta_gpu_kms_get_fd@Base 3.28.2 > meta_gpu_kms_get_file_path@Base 3.28.2 > meta_gpu_kms_get_max_buffer_size@Base 3.28.2 -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
See the inline diff for the added-symbol. I'd like to have a SRU upload without it since we don't need to use anywhere else Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base 3.28.2 > meta_gpu_kms_flip_closure_container_free@Base 3.28.3+git20190124 > meta_gpu_kms_flip_crtc@Base 3.28.2 > + meta_gpu_kms_get_current_time_ns@Base 3.28.3+git20190124-0ubuntu18.04.3 Mhmmh, the fact we've a new symbol would probably be seen as packaging level as something would need an ABI bump... So, since this symbol isn't used anyway, couldn't maybe just make sure this is hidden and not exported (adding some inline things or maybe is just fine to rename is with a leading '_' for this branch)? > meta_gpu_kms_get_fd@Base 3.28.2 > meta_gpu_kms_get_file_path@Base 3.28.2 > meta_gpu_kms_get_max_buffer_size@Base 3.28.2 -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base 3.28.2 > meta_gpu_kms_flip_closure_container_free@Base 3.28.3+git20190124 > meta_gpu_kms_flip_crtc@Base 3.28.2 > + meta_gpu_kms_get_current_time_ns@Base 3.28.3+git20190124-0ubuntu18.04.3 I'm saying that the symbol isn't used outside of mutter (i.e. by the shell), that's why I was saying that could be just not exported. Although could not be a problem either, but was to make the SRU review faster. The symbol version is indeed fine. > meta_gpu_kms_get_fd@Base 3.28.2 > meta_gpu_kms_get_file_path@Base 3.28.2 > meta_gpu_kms_get_max_buffer_size@Base 3.28.2 -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic
Review: Approve OK then. I can confirm that last commit 78e6f42 looks correct and is what I expected. -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/362055 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
Sorry I keep forgetting to save my inline comments. This is from a few hours ago... Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base 3.28.2 > meta_gpu_kms_flip_closure_container_free@Base 3.28.3+git20190124 > meta_gpu_kms_flip_crtc@Base 3.28.2 > + meta_gpu_kms_get_current_time_ns@Base 3.28.3+git20190124-0ubuntu18.04.3 The reason it is public seems to be because it is shared between different source files. I see your point about a '_' prefix but I don't think it's appropriate to go making any such design changes here since the existing form is already in disco and cosmic. > meta_gpu_kms_get_fd@Base 3.28.2 > meta_gpu_kms_get_file_path@Base 3.28.2 > meta_gpu_kms_get_max_buffer_size@Base 3.28.2 -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base 3.28.2 > meta_gpu_kms_flip_closure_container_free@Base 3.28.3+git20190124 > meta_gpu_kms_flip_crtc@Base 3.28.2 > + meta_gpu_kms_get_current_time_ns@Base 3.28.3+git20190124-0ubuntu18.04.3 Simply not mentioning the symbol in libmutter-2-0.symbols doesn't work (from memory). The build automatically exports it and adds it to the final .symbols file. > meta_gpu_kms_get_fd@Base 3.28.2 > meta_gpu_kms_get_file_path@Base 3.28.2 > meta_gpu_kms_get_max_buffer_size@Base 3.28.2 -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon
The proposal to merge lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/libnm-port/+merge/366761 -- Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon
Review: Approve Thanks for the work, I don't think it makes sense to review the code there since it's a lot of change and basically a backport from upstream code already used in GNOME, let's rather go through functional testing. Landing the change (especially early in the cycle) is +1 from me, let me know when you are happy uploading -- https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/libnm-port/+merge/366761 Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-control-center/libnm-port into lp:unity-control-center
Review: Approve Thanks for the work, I don't think it makes sense to review the code there since it's a lot of change and basically a backport from upstream code already used in GNOME, let's rather go through functional testing. Landing the change (especially early in the cycle) is +1 from me, let me know when you are happy uploading -- https://code.launchpad.net/~khurshid-alam/unity-control-center/libnm-port/+merge/366762 Your team Unity Control Center development team is subscribed to branch lp:unity-control-center. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base 3.28.2 > meta_gpu_kms_flip_closure_container_free@Base 3.28.3+git20190124 > meta_gpu_kms_flip_crtc@Base 3.28.2 > + meta_gpu_kms_get_current_time_ns@Base 3.28.3+git20190124-0ubuntu18.04.3 The symbol is used. It is critical. I would not have included it otherwise. P.S. Laney requested that specific symbol version. > meta_gpu_kms_get_fd@Base 3.28.2 > meta_gpu_kms_get_file_path@Base 3.28.2 > meta_gpu_kms_get_max_buffer_size@Base 3.28.2 -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] lp:~khurshid-alam/unity-control-center/libnm-port into lp:unity-control-center
The proposal to merge lp:~khurshid-alam/unity-control-center/libnm-port into lp:unity-control-center has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~khurshid-alam/unity-control-center/libnm-port/+merge/366762 -- Your team Unity Control Center development team is subscribed to branch lp:unity-control-center. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
