Re: Application for ubuntu-desktop membership
On Tue, 25 Jun 2019 at 12:08, Gunnar Hjalmarsson wrote: > On 2019-06-25 11:57, Iain Lane wrote: > > That makes three¹, so I've gone ahead and added Gunnar to the Ubuntu > > Desktop team. > > > > Thanks, and welcome! > > Thanks all for the showed trust in me. I'll try to prove worthy of it. > Congratulations Gunnar, and thanks for all your work over the years. Cheers, Will -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Application for ubuntu-desktop membership
On 2019-06-25 11:57, Iain Lane wrote: That makes three¹, so I've gone ahead and added Gunnar to the Ubuntu Desktop team. Thanks, and welcome! Thanks all for the showed trust in me. I'll try to prove worthy of it. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Application for ubuntu-desktop membership
On Tue, Jun 25, 2019 at 11:46:18AM +0200, Olivier Tilloy wrote: > This application fully makes sense, +1 from me. That makes three¹, so I've gone ahead and added Gunnar to the Ubuntu Desktop team. Thanks, and welcome! Cheers, -- Iain Lane [ i...@orangesquash.org.uk ] Debian Developer [ la...@debian.org ] Ubuntu Developer [ la...@ubuntu.com ] ¹ rest of thread: https://lists.ubuntu.com/archives/ubuntu-desktop/2019-June/006099.html signature.asc Description: PGP signature -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Application for ubuntu-desktop membership
On Mon, Jun 24, 2019 at 9:48 PM Gunnar Hjalmarsson wrote: > > I apply to the ubuntu-desktop team members for becoming a member of the > team. > > I have been around since 2010, and my contributions have mostly been > related somehow to the internationalization of the desktop, such as the > tools for setting language and locales, fonts, keyboard layouts/input > methods, spellcheck dictionaries, and the translation infrastructure. > I'm also keeping up the Ubuntu flavor of the desktop guide (Help). > > My work has led me to get involved in quite a few packages, and more > often than not I'm targeting packages in the ubuntu-desktop packageset. > Via PPU:s and a personal packageset I have upload rights to a few of them: > > https://people.canonical.com/~ubuntu-archive/packagesets/eoan/personal-gunnarhj > > but often I need to ask for sponsorship. > > As a member of ubuntu-desktop I would be able to contribute more > efficiently and save some time for the developers. But please note that, > if you would grant me membership, you wouldn't get rid of my prompts for > reviews completely. ;) I'm self-educated in computing, and my knowledge > about programming, packaging, etc. is fragmentary. The good news is that > I'm aware of my limitations, and have gained a feeling for when I should > consult with someone and/or ask for review, and when I'm sure enough to > just do it. > > Thanks in advance for considering my application! I have had the opportunity to sponsor some of Gunnar's uploads recently, and his work was impeccable. I also know him through his numerous contributions to the desktop stack, particularly focused on internationalization. He is knowledgeable and rigorous. This application fully makes sense, +1 from me. Cheers, Olivier -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1832138 into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
Ouch, I still had an old kernel in my vm, updating it to standard disco worked even without this patch. -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/369083 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1832138 into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications into lp:unity-settings-daemon
This is part of upower .99 port of g-s-d, but most of the commits are not required for unity. So I cherry picked only the most commit since double check is happening here. -- https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications/+merge/369223 Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic.
Commit message:
Enable IBus IM in live session (LP: #1786344)
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu): "Default IBus input method
ignored in live session"
https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1786344
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/369154
I have tested the daily build ISO from this morning UTC. The issue was resolved
as expected.
So this MP is the bionic equivalent to this upload:
https://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.32.1-1ubuntu2
The branch successfully built in PPA:
https://launchpad.net/~gunnarhj/+archive/ubuntu/gnome-settings-daemon
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic.
diff --git a/debian/changelog b/debian/changelog
index 04e625e..c321c66 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+gnome-settings-daemon (3.28.1-0ubuntu1.3) bionic; urgency=medium
+
+ * debian/patches/ubuntu_ibus_configs.patch:
+- Always call add_ibus_sources_from_locale() during the first run
+ of g-s-d. This ensures that an IBus method is included in "live
+ sessions" when applicable (LP: #1786344).
+ * debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch:
+- Refreshed
+
+ -- Gunnar Hjalmarsson Fri, 21 Jun 2019 11:58:00 +0200
+
gnome-settings-daemon (3.28.1-0ubuntu1.2) bionic; urgency=medium
* debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch:
diff --git a/debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch b/debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch
index 6a76d1b..a0c2efd 100644
--- a/debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch
+++ b/debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch
@@ -166,7 +166,7 @@ index 343b049..480e735 100644
}
static void
-@@ -812,8 +859,15 @@ start_keyboard_idle_cb (GsdKeyboardManager *manager)
+@@ -818,8 +865,15 @@ start_keyboard_idle_cb (GsdKeyboardManager *manager)
set_devicepresence_handler (manager);
manager->priv->input_sources_settings = g_settings_new (GNOME_DESKTOP_INPUT_SOURCES_DIR);
@@ -184,7 +184,7 @@ index 343b049..480e735 100644
manager->priv->cancellable = g_cancellable_new ();
-@@ -876,10 +930,12 @@ gsd_keyboard_manager_stop (GsdKeyboardManager *manager)
+@@ -882,10 +936,12 @@ gsd_keyboard_manager_stop (GsdKeyboardManager *manager)
g_clear_object (>settings);
g_clear_object (>input_sources_settings);
diff --git a/debian/patches/ubuntu_ibus_configs.patch b/debian/patches/ubuntu_ibus_configs.patch
index 5b9212a..e731a3e 100644
--- a/debian/patches/ubuntu_ibus_configs.patch
+++ b/debian/patches/ubuntu_ibus_configs.patch
@@ -3,8 +3,8 @@ Description: restore the code that configure the input method according to
Bug: https://bugs.launchpad.net/bugs/1719938
Forwarded: not-needed
---
- plugins/keyboard/gsd-keyboard-manager.c | 53 +
- 1 file changed, 53 insertions(+)
+ plugins/keyboard/gsd-keyboard-manager.c | 64 +++-
+ 1 file changed, 62 insertions(+), 2 deletions(-)
Index: gnome-settings-daemon-3.26.1/plugins/keyboard/gsd-keyboard-manager.c
===
@@ -69,15 +69,57 @@ Index: gnome-settings-daemon-3.26.1/plugins/keyboard/gsd-keyboard-manager.c
static void
xkb_init (GsdKeyboardManager *manager)
{
-@@ -711,8 +763,10 @@ maybe_create_initial_settings (GsdKeyboa
+@@ -656,7 +708,7 @@ convert_libgnomekbd_layouts (GSettings *settings)
+ g_object_unref (libgnomekbd_settings);
+ }
+
+-static void
++static gboolean
+ maybe_convert_old_settings (GSettings *settings)
+ {
+ GVariant *sources;
+@@ -664,6 +716,7 @@ maybe_convert_old_settings (GSettings *settings)
+ gchar *stamp_dir_path = NULL;
+ gchar *stamp_file_path = NULL;
+ GError *error = NULL;
++gboolean is_first_run = FALSE;
+
+ stamp_dir_path = g_build_filename (g_get_user_data_dir (), PACKAGE_NAME, NULL);
+ if (g_mkdir_with_parents (stamp_dir_path, 0755)) {
+@@ -675,6 +728,8 @@ maybe_convert_old_settings (GSettings *settings)
+ if (g_file_test (stamp_file_path, G_FILE_TEST_EXISTS))
+ goto out;
+
++is_first_run = TRUE;
++
+ sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
+ if (g_variant_n_children (sources) < 1) {
+ convert_libgnomekbd_layouts (settings);
+@@ -693,6 +748,8 @@ maybe_convert_old_settings (GSettings
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1832138 into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
Review: Approve The workaround works for me, even in disco. So, if the kernel doesn't get updated earlier, we should land this in both disco and bionic -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/369083 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1832138 into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] lp:~khurshid-alam/unity-settings-daemon/fix-airplane-switch into lp:unity-settings-daemon
The proposal to merge lp:~khurshid-alam/unity-settings-daemon/fix-airplane-switch into lp:unity-settings-daemon has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/fix-airplane-switch/+merge/368880 -- Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1832138 into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
The fix is for bionic because the bug only exists in kernels older than 4.17. -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/369083 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1832138 into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master
Review: Approve This LGTM -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/368536 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/gdm3:fix-lp1705369-eoan into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/master
Review: Approve I indeed can't reproduce the issue anymore in eoan, with the patch removed. Let's merge this then, thanks! -- https://code.launchpad.net/~vanvugt/ubuntu/+source/gdm3/+git/gdm3/+merge/369024 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/gdm3:fix-lp1705369-eoan into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] lp:~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications into lp:unity-settings-daemon
Khurshid Alam has proposed merging
lp:~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications into
lp:unity-settings-daemon.
Commit message:
power: Remove 'on AC' check from warning-levels
UPower already does this for us, to avoid warning levels being set
when the batteries didn't notice the AC yet.
Requested reviews:
Sebastien Bacher (seb128)
For more details, see:
https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications/+merge/369223
--
Your team Unity Settings Daemon Development Team is subscribed to branch
lp:unity-settings-daemon.
=== modified file 'plugins/power/gsd-power-manager.c'
--- plugins/power/gsd-power-manager.c 2016-06-15 15:40:17 +
+++ plugins/power/gsd-power-manager.c 2019-06-24 06:33:38 +
@@ -1171,14 +1171,6 @@
"time-to-empty", _to_empty,
NULL);
-/* check to see if the batteries have not noticed we are on AC */
-if (kind == UP_DEVICE_KIND_BATTERY) {
-if (!up_client_get_on_battery (manager->priv->up_client)) {
-g_warning ("ignoring low message as we are not on battery power");
-goto out;
-}
-}
-
if (kind == UP_DEVICE_KIND_BATTERY) {
/* if the user has no other batteries, drop the "Laptop" wording */
@@ -1287,7 +1279,6 @@
/* TRANSLATORS: this is the sound description */
CA_PROP_EVENT_DESCRIPTION, _("Battery is low"), NULL);
-out:
if (icon != NULL)
g_object_unref (icon);
g_free (message);
@@ -1312,14 +1303,6 @@
"time-to-empty", _to_empty,
NULL);
-/* check to see if the batteries have not noticed we are on AC */
-if (kind == UP_DEVICE_KIND_BATTERY) {
-if (!up_client_get_on_battery (manager->priv->up_client)) {
-g_warning ("ignoring critically low message as we are not on battery power");
-goto out;
-}
-}
-
if (kind == UP_DEVICE_KIND_BATTERY) {
/* if the user has no other batteries, drop the "Laptop" wording */
@@ -1468,7 +1451,7 @@
CA_PROP_EVENT_DESCRIPTION, _("Battery is critically low"), NULL);
break;
}
-out:
+
if (icon != NULL)
g_object_unref (icon);
g_free (message);
@@ -1489,14 +1472,6 @@
"kind", ,
NULL);
-/* check to see if the batteries have not noticed we are on AC */
-if (kind == UP_DEVICE_KIND_BATTERY) {
-if (!up_client_get_on_battery (manager->priv->up_client)) {
-g_warning ("ignoring critically low message as we are not on battery power");
-goto out;
-}
-}
-
if (kind == UP_DEVICE_KIND_BATTERY) {
/* TRANSLATORS: laptop battery is really, really, low */
@@ -1596,7 +1571,7 @@
CA_PROP_EVENT_ID, "battery-caution",
/* TRANSLATORS: this is the sound description */
CA_PROP_EVENT_DESCRIPTION, _("Battery is critically low"), NULL);
-out:
+
if (icon != NULL)
g_object_unref (icon);
g_free (message);
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~vanvugt/ubuntu/+source/gdm3:fix-lp1705369-eoan into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/master
The proposal to merge ~vanvugt/ubuntu/+source/gdm3:fix-lp1705369-eoan into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~vanvugt/ubuntu/+source/gdm3/+git/gdm3/+merge/369024 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/gdm3:fix-lp1705369-eoan into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1832138 into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic
Hmm, in bug 1832138 it now sounds like we might get a kernel fix instead. If so then this workaround can be dropped. -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/369083 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1832138 into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
