[Merge] ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master
The proposal to merge ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~vanvugt/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/372051 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Bug 1624317] Re: systemd-resolved breaks VPN with split-horizon DNS
** Bug watch added: bugzilla.gnome.org/ #783569 https://bugzilla.gnome.org/show_bug.cgi?id=783569 ** Changed in: network-manager Remote watch: GNOME Bug Tracker #783569 => bugzilla.gnome.org/ #783569 ** Bug watch removed: GNOME Bug Tracker #783569 https://gitlab.gnome.org/783569 -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1624317 Title: systemd-resolved breaks VPN with split-horizon DNS To manage notifications about this bug go to: https://bugs.launchpad.net/network-manager/+bug/1624317/+subscriptions -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression
** CVE removed: https://cve.mitre.org/cgi- bin/cvename.cgi?name=2018-15688 -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1754671 Title: Full-tunnel VPN DNS leakage regression To manage notifications about this bug go to: https://bugs.launchpad.net/network-manager/+bug/1754671/+subscriptions -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master
Daniel van Vugt has proposed merging ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master. Commit message: background_login.patch: Match 19.10 Yaru purple login screen with noise. This way the login animation will appear to expand over the login screen (system background) instead of suddenly replacing it. Requested reviews: Didier Roche (didrocks) Ubuntu Desktop (ubuntu-desktop) For more details, see: https://code.launchpad.net/~vanvugt/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/372051 It would be so nice to automate matching of these two styles, but nobody has made the time yet. P.S. The diff of the diff looks wrong when it's not. Try just reviewing the whole file: https://git.launchpad.net/~vanvugt/ubuntu/+source/gnome-shell/tree/debian/patches/ubuntu/background_login.patch?h=fix-eoan-purple-system-background -- Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master. diff --git a/debian/patches/ubuntu/background_login.patch b/debian/patches/ubuntu/background_login.patch index 98334d7..29bbceb 100644 --- a/debian/patches/ubuntu/background_login.patch +++ b/debian/patches/ubuntu/background_login.patch @@ -1,27 +1,15 @@ -From: Daniel van Vugt -Date: Wed, 6 Mar 2019 14:48:10 + -Subject: js/ui/background.js: Use Ubuntu purple to match login screen - -Original author: Didier Roche -Bug-Ubuntu: https://launchpad.net/bugs/1813119 -Last-Update: 2019-03-01 -Forwarded: not-needed - -This way the login animation will appear to expand over the login -screen (system background) instead of suddenly replacing it. +Description: js/ui/background.js: Match 19.10 Yaru purple login screen with noise. + This way the login animation will appear to expand over the login + screen (system background) instead of suddenly replacing it. Original author: Didier Roche Author: Daniel van Vugt -Bug-Ubuntu: https://launchpad.net/bugs/1813119 -Last-Update: 2019-03-01 +Last-Update: 2019-08-30 Forwarded: not-needed - js/ui/background.js | 20 - 1 file changed, 20 insertions(+) -diff --git a/js/ui/background.js b/js/ui/background.js -index babc1e4..ab1dba0 100644 a/js/ui/background.js -+++ b/js/ui/background.js +Index: gnome-shell/js/ui/background.js +=== +--- gnome-shell.orig/js/ui/background.js gnome-shell/js/ui/background.js @@ -96,6 +96,7 @@ const { Clutter, GDesktopEnums, Gio, GLib, GnomeDesktop, Meta } = imports.gi; const Signals = imports.signals; @@ -30,16 +18,18 @@ index babc1e4..ab1dba0 100644 const LoginManager = imports.misc.loginManager; const Main = imports.ui.main; const Params = imports.misc.params; -@@ -499,6 +500,25 @@ let _systemBackground; - - var SystemBackground = class SystemBackground { +@@ -501,6 +502,27 @@ var SystemBackground = class SystemBackg constructor() { + let file = Gio.File.new_for_uri('resource:///org/gnome/shell/theme/noise-texture.png'); + +// Yaru is default ubuntu theme, match GDM look +if (Desktop.is("ubuntu")) { +if (_systemBackground == null) { -+_systemBackground = new Meta.Background({ meta_display: global.display }); -+let [, ubuntuColor] = Clutter.Color.from_string('#2C001E'); ++_systemBackground = new Meta.Background({ meta_display: global.display }) ++// Yaru uses darken(#762572, 10%) + noise for #lockDialogGroup ++let [, ubuntuColor] = Clutter.Color.from_string('#4f194c'); +_systemBackground.set_color(ubuntuColor); ++_systemBackground.set_file(file, GDesktopEnums.BackgroundStyle.WALLPAPER); +} +this.actor = new Meta.BackgroundActor({ meta_display: global.display, +monitor: 0, @@ -53,6 +43,6 @@ index babc1e4..ab1dba0 100644 +return; +} + - let file = Gio.File.new_for_uri('resource:///org/gnome/shell/theme/noise-texture.png'); - if (_systemBackground == null) { + _systemBackground = new Meta.Background({ meta_display: global.display }); + _systemBackground.set_color(DEFAULT_BACKGROUND_COLOR); -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon
Review: Approve Looks good to me, would have been nice in a further iteration to change the settings/gsettings naming to something clearer, but not a fault of this MR. -- https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154 Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression
Launchpad has imported 73 comments from the remote bug at https://bugzilla.gnome.org/show_bug.cgi?id=746422. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2015-03-18T22:30:03+00:00 Dcbw-y wrote: If the VPN routes all traffic (eg, its ipv4.never-default=false) that usually indicates that the VPN's nameservers should be used instead of the parent interface's nameservers, since the parent interface's nameservers would be accessed over the VPN anyway (since it's routing all traffic). But with dns=dnsmasq, the dnsmasq plugin always does split DNS regardless of the never-default value of the VPN's IPv4 config: /* Use split DNS for VPN configs */ for (iter = (GSList *) vpn_configs; iter; iter = g_slist_next (iter)) { if (NM_IS_IP4_CONFIG (iter->data)) add_ip4_config (conf, NM_IP4_CONFIG (iter->data), TRUE); else if (NM_IS_IP6_CONFIG (iter->data)) add_ip6_config (conf, NM_IP6_CONFIG (iter->data), TRUE); } instead I think that each config should be added with split DNS only if ipv4.never-default=true for that config. That would ensure that when the VPN was routing all traffic, split DNS was not used, but when the VPN was not routing all traffic, split DNS was used. If the user really does want to use the parent interface's nameservers even though they will be contacted over the VPN, they can either add custom dnsmasq options to /etc/NetworkManager/dnsmasq.d or enter them manually for the connection. ISTR that the behavior I'm suggesting was always intended, but apparently we changed that behavior a long time ago and possibly didn't realize it? Reply at: https://bugs.launchpad.net/ubuntu/+source/network- manager/+bug/1754671/comments/0 On 2015-03-19T11:15:43+00:00 Psimerda wrote: In my opinion it is useful to use split DNS view in all cases and only use never-default setting to decide the global DNS. Rationale: There is no such think as sending all traffic across VPN, only default route traffic, i.e. traffic for which there's no specific route over a specific interface. As specific routes (as found in the routing table) are still used even with default route over VPN, I believe that specific zones (as found in per-connection lists of domains) should be maintained as well. Reply at: https://bugs.launchpad.net/ubuntu/+source/network- manager/+bug/1754671/comments/1 On 2015-03-20T07:58:02+00:00 warthog9 wrote: Pavel, I'll admit to not 100% following what you've suggested, so please excuse me if I've horribly miss-understood. I disagree with the assertion that "There is no such think as sending all traffic across VPN". The parent interface's adapter will have a local route mainly so you can get to the gateway, as well as a route for vpn endpoint you need to push traffic at however, there are some mitigating circumstances that forcing split-dns, so that the DNS on the VPN is ONLY serving the search spaces pushed, is actually exactly the opposite of what a user likely wants and/or causes some rather broken behavior. - VPNs can, and often do, have IP space overlap issues. So if the parent interface's network you are on happens to be in the 10.0.0.0/255.255.252.0 (gateway 10.0.0.1, DNS server 10.0.0.2 & 10.0.0.3) ip range, and the VPN uses 10.0.1.0/255.255.255.0, you can end up in some very screwed up situation. This is actually taken from a real world scenario (which is why I learned of the change to default to split DNS at all). If you are routing all traffic over the VPN you now have lost access to the two parent interface's DNS servers, and with split DNS you now have *NO* DNS access at all. As it currently stands the only way to fix this is to either manually edit /etc/resolv.conf or to restart NM without dnsmasq. - DNS is not equal at all locations, which your assumption about split DNS I think assumes. DNS zones mean that something that resolves externally one way, may resolve completely differently (and potentially). example.com, to an external resolver may go to a coloed and public instance, while the same dns entry from an internal dns server may not. Assuming the VPN only pushes a search of internal.example.com, but doesn't push a search for example.com (making the assumption that people will just type it), the internal site is now unreachable. Keeping in mind I'm talking about VPNs, and those are typically used in more corporate environments where you are dealing with corporate IT departments. - In a more casual environment, lets say a hotel, part of the reasons to use a VPN is because the u
[Merge] lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon
Khurshid Alam has proposed merging lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon. Commit message: * Port media keys to use com.canonical.unity.settings-daemon u-s-d will still use org.gnome.settings-daemon in dbus. Fixes LP:#1842324 * Use new gsettings key location for mouse & keyboard. https://gitlab.gnome.org/GNOME/gnome-settings-daemon/commit/6dff93a0dfa80db3f481eed5d6ed689bf469aa1b https://gitlab.gnome.org/GNOME/gnome-settings-daemon/commit/710a4c4e7828828cb35ea14333882354ae73264f Requested reviews: Sebastien Bacher (seb128) Related bugs: Bug #1842324 in unity-settings-daemon (Ubuntu): "Port schemas from gnome-settings-daemon-common to com.canonical.unity.settings-daemon" https://bugs.launchpad.net/ubuntu/+source/unity-settings-daemon/+bug/1842324 For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154 -- Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. === modified file 'debian/unity-settings-daemon.install' --- debian/unity-settings-daemon.install 2016-08-22 12:45:05 + +++ debian/unity-settings-daemon.install 2019-09-02 15:07:10 + @@ -7,3 +7,4 @@ debian/source_unity-settings-daemon.py /usr/share/apport/package-hooks debian/user/unity-settings-daemon.service /usr/lib/systemd/user/ debian/user/unity-settings-daemon.override /usr/share/upstart/systemd-session/upstart/ +debian/user/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml /usr/share/glib-2.0/schemas/ === modified file 'debian/unity-settings-daemon.postinst' --- debian/unity-settings-daemon.postinst 2013-12-04 23:55:26 + +++ debian/unity-settings-daemon.postinst 2019-09-02 15:07:10 + @@ -18,4 +18,7 @@ rmdir --ignore-fail-on-non-empty /etc/gnome/config fi fi +if which glib-compile-schemas >/dev/null 2>&1; then +glib-compile-schemas /usr/share/glib-2.0/schemas +fi esac === added file 'debian/user/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml' --- debian/user/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml 1970-01-01 00:00:00 + +++ debian/user/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml 2019-09-02 15:07:10 + @@ -0,0 +1,228 @@ + + + + + 0 + Priority to use for this plugin + Priority to use for this plugin in unity-settings-daemon startup queue + + + true + Activation of this plugin + Whether this plugin would be activated by unity-settings-daemon or not + + + [] + Custom keybindings + List of custom keybindings + + + 'XF86Calculator' + Launch calculator + Binding to launch the calculator. + + + 'XF86Tools' + Launch settings + Binding to launch GNOME settings. + + + 'XF86Mail' + Launch email client + Binding to launch the email client. + + + 'XF86Eject' + Eject + Binding to eject an optical disc. + + + '' + Launch help browser + Binding to launch the help browser. + + + 'XF86Explorer' + Home folder + Binding to open the Home folder. + + + 'XF86AudioMedia' + Launch media player + Binding to launch the media player. + + + 'XF86AudioNext' + Next track + Binding to skip to next track. + + + 'XF86AudioPause' + Pause playback + Binding to pause playback. + + + 'XF86AudioPlay' + Play (or play/pause) + Binding to start playback (or toggle play/pause). + + + 'Delete' + Log out + Binding to log out. + + + 'XF86AudioPrev' + Previous track + Binding to skip to previous track. + + + ' l' + Lock screen + Binding to lock the screen. + + + 'XF86Search' + Search + Binding to launch the search tool. + + + 'XF86AudioStop' + Stop playback + Binding to stop playback. + + + ' p' + Video output + Binding to switch the video output device. + + + 'XF86AudioLowerVolume' + Volume down + Binding to lower the volume. + + + 'XF86AudioMute' + Volume mute/unmute + Binding to mute/unmute the volume. + + + 'XF86AudioRaiseVolume' + Volume up + Binding to raise the volume. + + + 'XF86AudioMicMute' + Microphone mute/unmute + Binding to mute/unmute the microphone. + + + 'Print' + Take a screenshot + Binding to take a screenshot. + + + ' Print' + Take a screenshot of a window + Binding to take a screenshot of a window. + + + ' Print' + Take a screenshot of an area + Binding to take a screenshot of an area. + + + ' Print' + Co
[Bug 1828134] Re: Wifi not working after suspend/resume cycle
** Changed in: network-manager Status: Unknown => New -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1828134 Title: Wifi not working after suspend/resume cycle To manage notifications about this bug go to: https://bugs.launchpad.net/network-manager/+bug/1828134/+subscriptions -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Bug 1624317] Re: systemd-resolved breaks VPN with split-horizon DNS
** Description changed: [Impact] - * NetworkManager incorrectly handles dns-priority of the VPN-like + * NetworkManager incorrectly handles dns-priority of the VPN-like connections, which leads to leaking DNS queries outside of the VPN into the general internet. - * Upstream has resolved this issue in master and 1.8 to correctly + * Upstream has resolved this issue in master and 1.8 to correctly configure any dns backends with negative dns-priority settings. - - [Test Case] - - #FIXME# - - * detailed instructions how to reproduce the bug - - * these should allow someone who is not familiar with the affected -package to reproduce the bug and verify that the updated package fixes -the problem. - - #FIXME# [Regression Potential] - * If this issue is changed DNS resolution will change, for certain + * If this issue is changed DNS resolution will change, for certain queries, to go via VPN rather than general internet. And therefore, one may get new/different results or even loose access to resolve/access certain parts of the interent depending on what the DNS server on VPN chooses to respond to. [Other Info] - - * Original bug report + + * Original bug report I use a VPN configured with network-manager-openconnect-gnome in which a split-horizon DNS setup assigns different addresses to some names inside the remote network than the addresses seen for those names from outside the remote network. However, systemd-resolved often decides to ignore the VPN’s DNS servers and use the local network’s DNS servers to resolve names (whether in the remote domain or not), breaking the split-horizon DNS. This related bug, reported by Lennart Poettering himself, was closed with the current Fedora release at the time reaching EOL: https://bugzilla.redhat.com/show_bug.cgi?id=1151544 -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1624317 Title: systemd-resolved breaks VPN with split-horizon DNS To manage notifications about this bug go to: https://bugs.launchpad.net/network-manager/+bug/1624317/+subscriptions -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
I have now removed the override. -- https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~3v1n0/ubuntu/+source/ubuntu-settings:master into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
The proposal to merge ~3v1n0/ubuntu/+source/ubuntu-settings:master into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~3v1n0/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/371500 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/ubuntu-settings:master into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master
The proposal to merge ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master has been updated. Description changed to: It would be so nice to automate matching of these two styles, but nobody has made the time yet. P.S. The diff of the diff looks wrong but it's not. Try just reviewing the whole file: https://git.launchpad.net/~vanvugt/ubuntu/+source/gnome-shell/tree/debian/patches/ubuntu/background_login.patch?h=fix-eoan-purple-system-background For more details, see: https://code.launchpad.net/~vanvugt/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/372051 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
Right, it makes sense. -- https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon
Review: Approve -- https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154 Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Bug 1624317] Re: systemd-resolved breaks VPN with split-horizon DNS
Launchpad has imported 28 comments from the remote bug at https://bugzilla.gnome.org/show_bug.cgi?id=783569. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2017-06-08T19:17:14+00:00 Nicholas Stommel wrote: Created attachment 353426 fixes DNS leaks over some NM-VPN connections using systemd-resolved I have patched the Network Manager to fix DNS leaks over network-manger VPN links (like those created with network-manager-openvpn) when using systemd-resolved as the default dns-manger/resolver on Ubuntu. This addresses some critical security concerns with DNS leaks over NM-VPN links. Please see the following high-priority bug at launchpad: https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1624317 There, I attached a patch for the current version of the network manager on Ubuntu 17.04 (1.4.4-1ubuntu3 zesty). Per request of kai.heng.f...@canonical.com on launchpad, I have patched the latest upstream source, made sure that it compiles correctly without warnings, and attached it here. So far, this is known to solve DNS leaks with network-manager-openvpn but could also solve DNS leaks for other VPNs that use TUN, TAP, or Cisco GRE network interfaces through the network-manager. It would be great to backport this fix to the current Ubuntu distribution! Reply at: https://bugs.launchpad.net/network- manager/+bug/1624317/comments/75 On 2017-06-09T07:51:45+00:00 Thomas Haller wrote: there is ipv4.dns-priority setting Quoting `man nm-settings`: "Intra-connection DNS priority. The relative priority to be used when determining the order of DNS servers in resolv.conf. A lower value means that servers will be on top of the file. Zero selects the default value, which is 50 for VPNs and 100 for other connections. Note that the priority is to order DNS settings for multiple active connections. It does not disambiguate multiple DNS servers within the same connection profile. For that, just specify the DNS servers in the desired order. When multiple devices have configurations with the same priority, the one with an active default route will be preferred. Note that when using dns=dnsmasq the order is meaningless since dnsmasq forwards queries to all known servers at the same time. Negative values have the special effect of excluding other configurations with a greater priority value; so in presence of at least a negative priority, only DNS servers from connections with the lowest priority value will be used." Why is that not the right solution? Reply at: https://bugs.launchpad.net/network- manager/+bug/1624317/comments/77 On 2017-06-09T08:07:38+00:00 Bgalvani wrote: Hi, in addition to what Thomas said, I think it is wrong to assume the connection is a VPN based on the link type, since you can have non-VPN tun/tap/gre/gretap connections as well, and they are affected by this patch. Also, it seems to me that commit [1] should already fix the leak for VPNs that don't get the default route... did you try if git master of NM is still affected by this bug? If it is, can you please attach the output of 'nmcli connection show ' for the VPN, and the output of 'systemd-resolve --status'? I mean, without your patch, to verify why the existing commit is not working. Thanks! [1] https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=c4864ba63f4a13e9938a978787490005f5ba48fb Reply at: https://bugs.launchpad.net/network- manager/+bug/1624317/comments/78 On 2017-06-09T16:30:24+00:00 Nicholas Stommel wrote: Oh, sorry I didn't think of that :/ I suppose that commit is a better fix. I'll see if that works instead. Reply at: https://bugs.launchpad.net/network- manager/+bug/1624317/comments/79 On 2017-06-09T21:07:27+00:00 Nicholas Stommel wrote: Created attachment 353487 current version of nm-systemd-resolved.c in Ubuntu network manager Wait...that commit from [1] is already found in the zesty version of network-manager 1.4.4-1ubuntu3. See attachment. This suggests that if this is still an issue on Ubuntu 17.04, the problem is still present and unsolved. [1] https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=c4864ba63f4a13e9938a978787490005f5ba48fb Reply at: https://bugs.launchpad.net/network- manager/+bug/1624317/comments/81 On 2017-06-09T21:58:24+00:00 Nicholas Stommel wrote: So the issue persists I believe. Unfortunately I just broke totally broke my ins
[Merge] lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon
The proposal to merge lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154 -- Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~till-kamppeter/network-manager:master into network-manager:master
Till Kamppeter has proposed merging ~till-kamppeter/network-manager:master into network-manager:master. Commit message: Backport detecting Wi-Fi FT support per interface, release as 1.20.0-1ubuntu2 See https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/2f8a4e90f0f Requested reviews: Network-manager (network-manager) For more details, see: https://code.launchpad.net/~till-kamppeter/network-manager/+git/network-manager/+merge/372162 This is a backport of the upstream change to not prefer FT-PSK when it is only supported by supplicant but not by the Wi-Fi interface or driver. >From upstream: Previously we only cared whether supplicant is build with support for FT. In that case we would pass FT-PSK to supplicant, like Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK' Supplicant would then always try FT with preference, regardless whether the interface/driver support it. That results in a failure to associate, if the driver does not support it. NetworkManager[1356]: [1566296144.9940] Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK' ... wpa_supplicant[1348]: wlan0: WPA: AP key_mgmt 0x42 network profile key_mgmt 0x142; available key_mgmt 0x42 wpa_supplicant[1348]: wlan0: WPA: using KEY_MGMT FT/PSK ... wpa_supplicant[1348]: * akm=0xfac04 ... kernel: ERROR @wl_set_key_mgmt : kernel: invalid cipher group (1027076) Since we pass a list of acceptable "key_mgmt" options to supplicant, FT-PSK should not be used when supplicant knows it's not supported. That is a supplicant bug. Regardless, work around it by checking the per-interface capability, and avoid it if support is apparently not present. -- Your team Network-manager is requested to review the proposed merge of ~till-kamppeter/network-manager:master into network-manager:master. diff --git a/debian/changelog b/debian/changelog index f626c1f..5893434 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +network-manager (1.20.0-1ubuntu2) eoan; urgency=medium + + * Backported upstream patch to detect Wi-Fi FT support per interface +and avoid enabling it if there is no support by the interface/driver. + + -- Till Kamppeter Fri, 30 Aug 2019 21:23:42 +0200 + network-manager (1.20.0-1ubuntu1) eoan; urgency=medium * New upstream version, merged from Debian diff --git a/debian/patches/WiFi-detect-FT-support-per-interface-and-avoid-enabling-it.patch b/debian/patches/WiFi-detect-FT-support-per-interface-and-avoid-enabling-it.patch new file mode 100644 index 000..10eebe5 --- /dev/null +++ b/debian/patches/WiFi-detect-FT-support-per-interface-and-avoid-enabling-it.patch @@ -0,0 +1,116 @@ +From: Thomas Haller +Date: Aug 20, 2019 +Subject: wifi: detect FT support per interface and avoid enabling it + +Previously we only cared whether supplicant is build with support for +FT. In that case we would pass FT-PSK to supplicant, like + + Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK' + +Supplicant would then always try FT with preference, regardless whether +the interface/driver support it. That results in a failure to associate, if +the driver does not support it. + + NetworkManager[1356]: [1566296144.9940] Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK' + ... + wpa_supplicant[1348]: wlan0: WPA: AP key_mgmt 0x42 network profile key_mgmt 0x142; available key_mgmt 0x42 + wpa_supplicant[1348]: wlan0: WPA: using KEY_MGMT FT/PSK + ... + wpa_supplicant[1348]: * akm=0xfac04 + ... + kernel: ERROR @wl_set_key_mgmt : + kernel: invalid cipher group (1027076) + +Since we pass a list of acceptable "key_mgmt" options to supplicant, +FT-PSK should not be used when supplicant knows it's not supported. +That is a supplicant bug. + +Regardless, work around it by checking the per-interface capability, and +avoid it if support is apparently not present. + +See: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/2f8a4e90f0f + +--- a/src/supplicant/nm-supplicant-interface.c b/src/supplicant/nm-supplicant-interface.c +@@ -135,7 +135,8 @@ + NMSupplicantFeature p2p_support; + NMSupplicantFeature mesh_support; + NMSupplicantFeature wfd_support; +- NMSupplicantFeature ft_support; ++ NMSupplicantFeature ft_support_global; ++ NMSupplicantFeature ft_support_per_iface; + NMSupplicantFeature sha384_support; + guint32max_scan_ssids; + guint32ready_count; +@@ -609,14 +610,25 @@ + parse_capabilities (NMSupplicantInterface *self, GVariant *capabilities) + { + NMSupplicantInterfacePrivate *priv = NM_SUPPLICANT_INTERFACE_GET_PRIVATE (self); +- gboolean have_active = FALSE, have_p2p = FALSE, have_ssid = FALSE; ++ gboolean have_active = FALSE; ++ gboolean have_ssid = FALSE; ++ gboolean have_p2p = FALSE; ++ gboolean have_ft = FALSE; + gint32 max_scan_ssids = -1; + const char **array; + + g_return_if_fail (capabilities && g_variant_is_of_type (capabilities, G_VARIANT_TYPE_VARDICT)); + +- if ( g_variant_l
[Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
Khurshid Alam has proposed merging ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master. Commit message: Port to com.canonical.unity.settings-daemon. LP: #1842324 Requested reviews: Sebastien Bacher (seb128) Related bugs: Bug #1842324 in unity-settings-daemon (Ubuntu): "Port schemas from gnome-settings-daemon-common to com.canonical.unity.settings-daemon" https://bugs.launchpad.net/ubuntu/+source/unity-settings-daemon/+bug/1842324 For more details, see: https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202 Note, lp:~ubuntu-desktop/ubuntu/+source/ubuntu-settings is out of sync with launchpad source lp:ubuntu/+source/ubuntu-settings but I can't open merge against lp:ubuntu/+source/ubuntu-settings. Edit: It is now resolved, thanks to Laney. -- Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master. diff --git a/debian/ubuntu-settings.gsettings-override b/debian/ubuntu-settings.gsettings-override index 83126da..de77274 100644 --- a/debian/ubuntu-settings.gsettings-override +++ b/debian/ubuntu-settings.gsettings-override @@ -190,7 +190,7 @@ unmaximize = ['Down','Down','F5'] [org.gnome.settings-daemon.plugins.background:Unity] active = true -[org.gnome.settings-daemon.plugins.media-keys:Unity] +[com.canonical.unity.settings-daemon.plugins.media-keys:Unity] screensaver = ['l'] [org.gnome.Terminal.Legacy.Settings:Unity] -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
Review: Disapprove Mh, since such settings are now handled in unity schema, wouldn't be better to just remove this override from unity settings (code is now in git though, at https://code.launchpad.net/~ubuntu-desktop/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+ref/master). So, I'd just remove this from ubuntu-settings and move it at https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154 -- https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-control-center/use-usd-schemas into lp:unity-control-center
Review: Approve All good -- https://code.launchpad.net/~khurshid-alam/unity-control-center/use-usd-schemas/+merge/372174 Your team Unity Control Center development team is subscribed to branch lp:unity-control-center. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] lp:~khurshid-alam/unity-control-center/use-usd-schemas into lp:unity-control-center
Khurshid Alam has proposed merging lp:~khurshid-alam/unity-control-center/use-usd-schemas into lp:unity-control-center. Commit message: * Port media keys to use com.canonical.unity.settings-daemon. LP: #1842324 * Update version number to 19.10 Requested reviews: Sebastien Bacher (seb128) Related bugs: Bug #1842324 in unity-settings-daemon (Ubuntu): "Port schemas from gnome-settings-daemon-common to com.canonical.unity.settings-daemon" https://bugs.launchpad.net/ubuntu/+source/unity-settings-daemon/+bug/1842324 For more details, see: https://code.launchpad.net/~khurshid-alam/unity-control-center/use-usd-schemas/+merge/372174 -- Your team Unity Control Center development team is subscribed to branch lp:unity-control-center. === modified file 'debian/rules' --- debian/rules 2019-03-01 16:13:07 + +++ debian/rules 2019-09-02 23:43:07 + @@ -18,6 +18,6 @@ DEB_DH_MAKESHLIBS_ARGS_libunity-control-center1 += -- -c4 binary-post-install/unity-control-center:: - ./panels/info/logo-generator --logo panels/info/UbuntuLogoBlank.png --text "ubuntu 19.04" --output debian/unity-control-center/usr/share/unity-control-center/ui/UbuntuLogo.png + ./panels/info/logo-generator --logo panels/info/UbuntuLogoBlank.png --text "ubuntu 19.10" --output debian/unity-control-center/usr/share/unity-control-center/ui/UbuntuLogo.png common-binary-post-install-arch:: list-missing === modified file 'panels/keyboard/00-multimedia.xml.in' --- panels/keyboard/00-multimedia.xml.in 2011-02-16 18:00:38 + +++ panels/keyboard/00-multimedia.xml.in 2019-09-02 23:43:07 + @@ -1,5 +1,5 @@ - + === modified file 'panels/keyboard/01-launchers.xml.in' --- panels/keyboard/01-launchers.xml.in 2013-11-28 04:38:37 + +++ panels/keyboard/01-launchers.xml.in 2019-09-02 23:43:07 + @@ -1,5 +1,5 @@ - + === modified file 'panels/keyboard/01-screenshot.xml.in' --- panels/keyboard/01-screenshot.xml.in 2013-11-28 06:01:16 + +++ panels/keyboard/01-screenshot.xml.in 2019-09-02 23:43:07 + @@ -1,5 +1,5 @@ - + === modified file 'panels/keyboard/01-system.xml.in' --- panels/keyboard/01-system.xml.in 2011-02-16 18:00:38 + +++ panels/keyboard/01-system.xml.in 2019-09-02 23:43:07 + @@ -1,5 +1,5 @@ - + === modified file 'panels/keyboard/50-accessibility.xml.in' --- panels/keyboard/50-accessibility.xml.in 2011-11-09 00:04:50 + +++ panels/keyboard/50-accessibility.xml.in 2019-09-02 23:43:07 + @@ -1,5 +1,5 @@ - + === modified file 'panels/keyboard/cc-keyboard-item.c' --- panels/keyboard/cc-keyboard-item.c 2013-11-28 04:33:09 + +++ panels/keyboard/cc-keyboard-item.c 2019-09-02 23:43:07 + @@ -31,7 +31,7 @@ #define CC_KEYBOARD_ITEM_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), CC_TYPE_KEYBOARD_ITEM, CcKeyboardItemPrivate)) -#define CUSTOM_KEYS_SCHEMA "org.gnome.settings-daemon.plugins.media-keys.custom-keybinding" +#define CUSTOM_KEYS_SCHEMA "com.canonical.unity.settings-daemon.plugins.media-keys.custom-keybinding" struct CcKeyboardItemPrivate { === modified file 'panels/keyboard/keyboard-shortcuts.c' --- panels/keyboard/keyboard-shortcuts.c 2014-03-14 14:43:48 + +++ panels/keyboard/keyboard-shortcuts.c 2019-09-02 23:43:07 + @@ -28,8 +28,8 @@ #include "cc-keyboard-option.h" #include "wm-common.h" -#define BINDINGS_SCHEMA "org.gnome.settings-daemon.plugins.media-keys" -#define CUSTOM_KEYS_BASENAME "/org/gnome/settings-daemon/plugins/media-keys/custom-keybindings" +#define BINDINGS_SCHEMA "com.canonical.unity.settings-daemon.plugins.media-keys" +#define CUSTOM_KEYS_BASENAME "/com/canonical/unity/settings-daemon/plugins/media-keys/custom-keybindings" #define CUSTOM_SHORTCUTS_ID "custom" #define WID(builder, name) (GTK_WIDGET (gtk_builder_get_object (builder, name))) === modified file 'panels/region/cc-region-keyboard-item.c' --- panels/region/cc-region-keyboard-item.c 2013-11-28 06:02:43 + +++ panels/region/cc-region-keyboard-item.c 2019-09-02 23:43:07 + @@ -31,7 +31,7 @@ #define CC_REGION_KEYBOARD_ITEM_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), CC_TYPE_REGION_KEYBOARD_ITEM, CcRegionKeyboardItemPrivate)) -#define CUSTOM_KEYS_SCHEMA "org.gnome.settings-daemon.plugins.media-keys.custom-keybinding" +#define CUSTOM_KEYS_SCHEMA "com.canonical.unity.settings-daemon.plugins.media-keys.custom-keybinding" struct CcRegionKeyboardItemPrivate { === modified file 'panels/region/keyboard-shortcuts.c' --- panels/region/keyboard-shortcuts.c 2013-11-29 06:28:37 + +++ panels/region/keyboard-shortcuts.c 2019-09-02 23:43:07 + @@ -26,8 +26,8 @@ #include "keyboard-shortcuts.h" #include "wm-common.h" -#define BINDINGS_SCHEMA "org.gnome.settings-daemon.plugins.media-keys" -#define CUSTOM_KEYS_BASENAME "/org/gnome/settings-daemon/plugins/media-keys/custom-keybindings" +#define BINDINGS_SCHEMA "com.canonical.unity.settings-daemon.plugins.media-keys" +#define CUSTOM_KEYS_BASENAME "/com/canonical/unity/settings-daemon/plugins/med
[Merge] lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon
Khurshid Alam has proposed merging lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon. Commit message: * Port media keys to use com.canonical.unity.settings-daemon u-s-d will still use org.gnome.settings-daemon in dbus. LP: #1842324 * Use new gsettings key location for mouse & keyboard. https://gitlab.gnome.org/GNOME/gnome-settings-daemon/commit/6dff93a0dfa80db3f481eed5d6ed689bf469aa1b https://gitlab.gnome.org/GNOME/gnome-settings-daemon/commit/710a4c4e7828828cb35ea14333882354ae73264f Requested reviews: Sebastien Bacher (seb128) Related bugs: Bug #1842324 in unity-settings-daemon (Ubuntu): "Port schemas from gnome-settings-daemon-common to com.canonical.unity.settings-daemon" https://bugs.launchpad.net/ubuntu/+source/unity-settings-daemon/+bug/1842324 For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154 -- Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. === modified file 'data/Makefile.am' --- data/Makefile.am 2014-08-29 10:24:00 + +++ data/Makefile.am 2019-09-04 12:49:16 + @@ -3,6 +3,14 @@ apidir = $(includedir)/unity-settings-daemon-$(GSD_API_VERSION)/unity-settings-daemon api_DATA = gsd-enums.h +gschema_in_files = com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml.in.in +gsettings_SCHEMAS = $(gschema_in_files:.xml.in.in=.xml) + +gsettingsdir = $(datadir)/glib-2.0/schemas + +%.gschema.xml.in: %.gschema.xml.in.in + $(AM_V_GEN) sed -e "s|\@GETTEXT_PACKAGE\@|$(GETTEXT_PACKAGE)|g" $< > $@ + @INTLTOOL_XML_NOMERGE_RULE@ @GSETTINGS_RULES@ @@ -22,6 +30,7 @@ EXTRA_DIST = \ $(convert_DATA)\ + $(gschema_in_files) \ $(desktop_in_files) \ $(gsettings_ENUM_FILES) \ unity-settings-daemon.pc.in \ @@ -36,4 +45,6 @@ MAINTAINERCLEANFILES = \ *~\ - Makefile.in + Makefile.in \ + $(gsettings_SCHEMAS:.xml=.valid) + === added file 'data/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml.in.in' --- data/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml.in.in 1970-01-01 00:00:00 + +++ data/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml.in.in 2019-09-04 12:49:16 + @@ -0,0 +1,228 @@ + + + + + 0 + Priority to use for this plugin + Priority to use for this plugin in unity-settings-daemon startup queue + + + true + Activation of this plugin + Whether this plugin would be activated by unity-settings-daemon or not + + + [] + Custom keybindings + List of custom keybindings + + + 'XF86Calculator' + Launch calculator + Binding to launch the calculator. + + + 'XF86Tools' + Launch settings + Binding to launch GNOME settings. + + + 'XF86Mail' + Launch email client + Binding to launch the email client. + + + 'XF86Eject' + Eject + Binding to eject an optical disc. + + + '' + Launch help browser + Binding to launch the help browser. + + + 'XF86Explorer' + Home folder + Binding to open the Home folder. + + + 'XF86AudioMedia' + Launch media player + Binding to launch the media player. + + + 'XF86AudioNext' + Next track + Binding to skip to next track. + + + 'XF86AudioPause' + Pause playback + Binding to pause playback. + + + 'XF86AudioPlay' + Play (or play/pause) + Binding to start playback (or toggle play/pause). + + + 'Delete' + Log out + Binding to log out. + + + 'XF86AudioPrev' + Previous track + Binding to skip to previous track. + + + ' l' + Lock screen + Binding to lock the screen. + + + 'XF86Search' + Search + Binding to launch the search tool. + + + 'XF86AudioStop' + Stop playback + Binding to stop playback. + + + ' p' + Video output + Binding to switch the video output device. + + + 'XF86AudioLowerVolume' + Volume down + Binding to lower the volume. + + + 'XF86AudioMute' + Volume mute/unmute + Binding to mute/unmute the volume. + + + 'XF86AudioRaiseVolume' + Volume up + Binding to raise the volume. + + + 'XF86AudioMicMute' + Microphone mute/unmute + Binding to mute/unmute the microphone. + + + 'Print' + Take a screenshot + Binding to take a screenshot. + + + ' Print' + Take a screenshot of a window + Binding to take a screenshot of a window. + + + ' Print' + Take a screenshot of an area + Binding to take a screenshot of an area. + + + ' Print' + Copy a screenshot to clipboard + Bi
Re: [Merge] ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master
Review: Approve thanks! -- https://code.launchpad.net/~vanvugt/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/372051 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~till-kamppeter/network-manager:master into network-manager:master
Iain Lane has proposed merging ~till-kamppeter/network-manager:master into network-manager:master. Requested reviews: Network-manager (network-manager) For more details, see: https://code.launchpad.net/~till-kamppeter/network-manager/+git/network-manager/+merge/372157 -- Your team Network-manager is requested to review the proposed merge of ~till-kamppeter/network-manager:master into network-manager:master. diff --git a/debian/changelog b/debian/changelog index f626c1f..5893434 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +network-manager (1.20.0-1ubuntu2) eoan; urgency=medium + + * Backported upstream patch to detect Wi-Fi FT support per interface +and avoid enabling it if there is no support by the interface/driver. + + -- Till Kamppeter Fri, 30 Aug 2019 21:23:42 +0200 + network-manager (1.20.0-1ubuntu1) eoan; urgency=medium * New upstream version, merged from Debian diff --git a/debian/patches/WiFi-detect-FT-support-per-interface-and-avoid-enabling-it.patch b/debian/patches/WiFi-detect-FT-support-per-interface-and-avoid-enabling-it.patch new file mode 100644 index 000..10eebe5 --- /dev/null +++ b/debian/patches/WiFi-detect-FT-support-per-interface-and-avoid-enabling-it.patch @@ -0,0 +1,116 @@ +From: Thomas Haller +Date: Aug 20, 2019 +Subject: wifi: detect FT support per interface and avoid enabling it + +Previously we only cared whether supplicant is build with support for +FT. In that case we would pass FT-PSK to supplicant, like + + Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK' + +Supplicant would then always try FT with preference, regardless whether +the interface/driver support it. That results in a failure to associate, if +the driver does not support it. + + NetworkManager[1356]: [1566296144.9940] Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK' + ... + wpa_supplicant[1348]: wlan0: WPA: AP key_mgmt 0x42 network profile key_mgmt 0x142; available key_mgmt 0x42 + wpa_supplicant[1348]: wlan0: WPA: using KEY_MGMT FT/PSK + ... + wpa_supplicant[1348]: * akm=0xfac04 + ... + kernel: ERROR @wl_set_key_mgmt : + kernel: invalid cipher group (1027076) + +Since we pass a list of acceptable "key_mgmt" options to supplicant, +FT-PSK should not be used when supplicant knows it's not supported. +That is a supplicant bug. + +Regardless, work around it by checking the per-interface capability, and +avoid it if support is apparently not present. + +See: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/2f8a4e90f0f + +--- a/src/supplicant/nm-supplicant-interface.c b/src/supplicant/nm-supplicant-interface.c +@@ -135,7 +135,8 @@ + NMSupplicantFeature p2p_support; + NMSupplicantFeature mesh_support; + NMSupplicantFeature wfd_support; +- NMSupplicantFeature ft_support; ++ NMSupplicantFeature ft_support_global; ++ NMSupplicantFeature ft_support_per_iface; + NMSupplicantFeature sha384_support; + guint32max_scan_ssids; + guint32ready_count; +@@ -609,14 +610,25 @@ + parse_capabilities (NMSupplicantInterface *self, GVariant *capabilities) + { + NMSupplicantInterfacePrivate *priv = NM_SUPPLICANT_INTERFACE_GET_PRIVATE (self); +- gboolean have_active = FALSE, have_p2p = FALSE, have_ssid = FALSE; ++ gboolean have_active = FALSE; ++ gboolean have_ssid = FALSE; ++ gboolean have_p2p = FALSE; ++ gboolean have_ft = FALSE; + gint32 max_scan_ssids = -1; + const char **array; + + g_return_if_fail (capabilities && g_variant_is_of_type (capabilities, G_VARIANT_TYPE_VARDICT)); + +- if ( g_variant_lookup (capabilities, "Modes", "^a&s", &array) +- && array) { ++ if (g_variant_lookup (capabilities, "KeyMgmt", "^a&s", &array)) { ++ have_ft = g_strv_contains (array, "wpa-ft-psk"); ++ g_free (array); ++ } ++ ++ priv->ft_support_per_iface = have_ft ++ ? NM_SUPPLICANT_FEATURE_YES ++ : NM_SUPPLICANT_FEATURE_NO; ++ ++ if (g_variant_lookup (capabilities, "Modes", "^a&s", &array)) { + if (g_strv_contains (array, "p2p")) + have_p2p = TRUE; + g_free (array); +@@ -627,8 +639,7 @@ + _notify (self, PROP_P2P_AVAILABLE); + } + +- if ( g_variant_lookup (capabilities, "Scan", "^a&s", &array) +- && array) { ++ if (g_variant_lookup (capabilities, "Scan", "^a&s", &array)) { + if (g_strv_contains (array, "active")) + have_active = TRUE; + if (g_strv_contains (array, "ssid")) +@@ -807,7 +818,13 @@ + NMSupplicantFeature + nm_supplicant_interface_get_ft_support (NMSupplicantInterface *self) + { +- return NM_SUPPLICANT_INTERFACE_GET_PRIVATE (self)->ft_support; ++ NMSupplicantInterfacePrivate *priv = NM_SUPPLICANT_INTERFACE_GET_PRIVATE (self); ++ ++ if (priv->ft_support_global == NM_SUPPLICANT_FEATURE_NO) ++ return NM_SUPPLICANT_FEATURE_NO; ++ if (priv->ft_support_per_iface != NM_SUPPLICANT_FEATURE_UNKNOWN) ++ return priv->ft_support_per_iface; ++ return priv->ft_support_global; + } + + NMSupplicantFeature +@@ -889,7 +906,7 @@ + { + N
Re: [Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
Review: Approve LGTM -- https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
The proposal to merge ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master has been updated. Commit message changed to: Remove screensaver override for unity Unity is now using it's own schema for media keys. See LP: #1842324 For more details, see: https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202 -- Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression
** Bug watch removed: bugzilla.gnome.org/ #766769 https://bugzilla.gnome.org/show_bug.cgi?id=766769 -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1754671 Title: Full-tunnel VPN DNS leakage regression To manage notifications about this bug go to: https://bugs.launchpad.net/network-manager/+bug/1754671/+subscriptions -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon
The proposal to merge lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154 -- Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon
Ok. Done. -- https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154 Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/use-usd-schemas into lp:unity-settings-daemon
Review: Needs Fixing As per comments in https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202, update the screensaver keybinding. Diff comments: > > === added file > 'data/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml.in.in' > --- > data/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml.in.in > 1970-01-01 00:00:00 + > +++ > data/com.canonical.unity.settings-daemon.plugins.media-keys.gschema.xml.in.in > 2019-09-04 12:49:16 + > @@ -0,0 +1,228 @@ > + > + > + id="com.canonical.unity.settings-daemon.plugins.media-keys" > path="/com/canonical/unity/settings-daemon/plugins/media-keys/"> > + > + 0 > + Priority to use for this plugin > + Priority to use for this plugin in unity-settings-daemon > startup queue > + > + > + true > + Activation of this plugin > + Whether this plugin would be activated by > unity-settings-daemon or not > + > + > + [] > + Custom keybindings > + List of custom keybindings > + > + > + 'XF86Calculator' > + Launch calculator > + Binding to launch the calculator. > + > + > + 'XF86Tools' > + Launch settings > + Binding to launch GNOME settings. > + > + > + 'XF86Mail' > + Launch email client > + Binding to launch the email client. > + > + > + 'XF86Eject' > + Eject > + Binding to eject an optical disc. > + > + > + '' > + Launch help browser > + Binding to launch the help browser. > + > + > + 'XF86Explorer' > + Home folder > + Binding to open the Home folder. > + > + > + 'XF86AudioMedia' > + Launch media player > + Binding to launch the media player. > + > + > + 'XF86AudioNext' > + Next track > + Binding to skip to next track. > + > + > + 'XF86AudioPause' > + Pause playback > + Binding to pause playback. > + > + > + 'XF86AudioPlay' > + Play (or play/pause) > + Binding to start playback (or toggle > play/pause). > + > + > + 'Delete' > + Log out > + Binding to log out. > + > + > + 'XF86AudioPrev' > + Previous track > + Binding to skip to previous track. > + > + > + ' l' As follow up, change this to the unity's (alternative) default Ctrl+Alt+L: https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202 > + Lock screen > + Binding to lock the screen. > + > + > + 'XF86Search' > + Search > + Binding to launch the search tool. > + > + > + 'XF86AudioStop' > + Stop playback > + Binding to stop playback. > + > + > + ' p' > + Video output > + Binding to switch the video output device. > + > + > + 'XF86AudioLowerVolume' > + Volume down > + Binding to lower the volume. > + > + > + 'XF86AudioMute' > + Volume mute/unmute > + Binding to mute/unmute the volume. > + > + > + 'XF86AudioRaiseVolume' > + Volume up > + Binding to raise the volume. > + > + > + 'XF86AudioMicMute' > + Microphone mute/unmute > + Binding to mute/unmute the microphone. > + > + > + 'Print' > + Take a screenshot > + Binding to take a screenshot. > + > + > + ' Print' > + Take a screenshot of a window > + Binding to take a screenshot of a window. > + > + > + ' Print' > + Take a screenshot of an area > + Binding to take a screenshot of an area. > + > + > + ' Print' > + Copy a screenshot to clipboard > + Binding to copy a screenshot to clipboard. > + > + > + ' Print' > + Copy a screenshot of a window to clipboard > + Binding to copy a screenshot of a window to > clipboard. > + > + > + ' Print' > + Copy a screenshot of an area to clipboard > + Binding to copy a screenshot of an area to > clipboard. > + > + > + ' R' > + Record a short video of the screen > + Binding to record a short video of the > screen > + > + > + ' t' > + Launch terminal > + Binding to launch the terminal. > + > + > + 'XF86WWW' > + Launch web browser > + Binding to launch the web browser. > + > + > + ' 8' > + Toggle magnifier > + Binding to show the screen magnifier > + > + > + ' s' > + Toggle screen reader > + Binding to start the screen reader > + > + > + '' > + Toggle on-screen keyboard > + Binding to show the on-screen keyboard > + > + > + '' > + Increase text size > + Binding to