Re: [Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master

2019-09-09 Thread Treviño
Review: Approve

LGTM
-- 
https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202
Your team Ubuntu Desktop is subscribed to branch 
~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop


Re: [Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master

2019-09-09 Thread Treviño
Review: Disapprove

Mh, since such settings are now handled in unity schema, wouldn't be better to 
just remove this override from unity settings (code is now in git though, at 
https://code.launchpad.net/~ubuntu-desktop/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+ref/master).

So, I'd just remove this from ubuntu-settings and move it at 
https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/use-usd-schemas/+merge/372154
-- 
https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202
Your team Ubuntu Desktop is subscribed to branch 
~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop


Re: [Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master

2019-09-09 Thread Khurshid Alam
Right, it makes sense.
-- 
https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202
Your team Ubuntu Desktop is subscribed to branch 
~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop


Re: [Merge] ~khurshid-alam/ubuntu/+source/ubuntu-settings:usd-schemas into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master

2019-09-09 Thread Khurshid Alam
I have now removed the override.
-- 
https://code.launchpad.net/~khurshid-alam/ubuntu/+source/ubuntu-settings/+git/ubuntu-settings/+merge/372202
Your team Ubuntu Desktop is subscribed to branch 
~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master.

-- 
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop