On 09/20/18 16:30, Dan Streetman wrote:
[...]
> however, looking at the commit, it appears it's totally isolated and
> uses none of the common code from ubuntutools/
>
> that's unfortunate and some of what you've done duplicates what's
> already under ubuntutools/, and some has better alternatives to how
> you implemented it.
I disagree on some aspects that it has "better alternatives". Some of
this is doing the exact same thing, just going about it a slightly
different way.
To be clear, this code started in a completely separate tree, and this
is the first commit to ubuntu-dev-tools of its codebase. I wasn't using
ubuntutools because it was "not available", not really practical to use
and keep the tree (and a snap) to use as few dependencies as possible. N
pull-lp-source use was added afterwards, and the 'mir' subcommand is
special in that I wouldn't expect it to be used by anyone but the MIR
review team -- it doesn't do much else than display a bug, find the
right bug based on a fuzzy search of the package (binary or source) to
review; and then drop you to a shell to do code review. It's certainly
reusable, but things were done in a way to scratch my own itches for the
purpose of MIR review.
Now, all this was pushed to ubuntu-dev-tools as a way to get more eyes
and more use -- so when you see things you disagree with, it's
absolutely fine for you to go ahead and fix the code. :)
Kindly,
--
Mathieu Trudel-Lapierre
Freenode: cyphermox, Jabber: mathieu...@gmail.com
4096R/65B58DA1 818A D123 0992 275B 23C2 CF89 C67B B4D6 65B5 8DA1
signature.asc
Description: OpenPGP digital signature
--
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel
