Re: Who's still maintaining libusb-0.1?

2010-07-09 Thread Martin Pitt
Hello Eric,

Eric Miao [2010-05-31 18:09 +0800]:
 Sorry I brought this topic to such a massive audience. But unfortunately 
 upower
 seems to be still linked with libusb-0.1, and thus bug 427805 and numerous 
 other
 duplicates are affecting many users. (http://bugs.launchpad.net/bugs/427805)

For the record, upower git head is ported to the newer libusb1.

 Debugged this and came up with a simple fix (a most common error), yet I don't
 know where to send except as attachment on LP.

But this was already SRUed into Lucid, so it shouldn't be a problem
any more?

Thanks,

Martin
-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

-- 
Ubuntu-devel-discuss mailing list
Ubuntu-devel-discuss@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss


Re: Who's still maintaining libusb-0.1?

2010-07-09 Thread Eric Miao
On Fri, Jul 2, 2010 at 4:53 PM, Martin Pitt mp...@debian.org wrote:
 Hello Eric,

 Eric Miao [2010-05-31 18:09 +0800]:
 Sorry I brought this topic to such a massive audience. But unfortunately 
 upower
 seems to be still linked with libusb-0.1, and thus bug 427805 and numerous 
 other
 duplicates are affecting many users. (http://bugs.launchpad.net/bugs/427805)

 For the record, upower git head is ported to the newer libusb1.


Good to know that.

 Debugged this and came up with a simple fix (a most common error), yet I 
 don't
 know where to send except as attachment on LP.

 But this was already SRUed into Lucid, so it shouldn't be a problem
 any more?


No, it's no more a problem. Switching to the new libusb1 is the definitely
the right way to go.

-- 
Ubuntu-devel-discuss mailing list
Ubuntu-devel-discuss@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss


Who's still maintaining libusb-0.1?

2010-07-02 Thread Eric Miao
Hi All,

Sorry I brought this topic to such a massive audience. But unfortunately upower
seems to be still linked with libusb-0.1, and thus bug 427805 and numerous other
duplicates are affecting many users. (http://bugs.launchpad.net/bugs/427805)

This happens intermittently and was ignored by me previously until several hours
ago I realized there are so many users out there affected by this, mostly Mac
users including me, and it looks Mac is vulnerable to this possibly
because of the
difference in the USB devices' descriptors.

Debugged this and came up with a simple fix (a most common error), yet I don't
know where to send except as attachment on LP. And we were also talking about
deprecating libusb-0.1 in -M, yet this seems to be still useful for
Lucid users at
this moment.

Patch attached.

- eric

revno: 378
committer: Eric Miao ycm...@macbook-lucid
branch nick: libusb
timestamp: Mon 2010-05-31 16:34:43 +0800
message:
  Initialized the allocated interface-altsetting to zero
  
  This prevents incorrect references to uninitialized fields within
  interface-altsetting[], which is the case for
  
Bug 427805 - usb_find_devices() crashed with SIGSEGV in free()
  
  where an uninitialized '-extra' pointer is being free()'ed in
  usb_destroy_configuration() called by usb_find_devices().
diff:
=== modified file 'descriptors.c'
--- descriptors.c	2006-02-18 00:28:19 +
+++ descriptors.c	2010-05-31 08:34:43 +
@@ -176,6 +176,9 @@
   return -1;
 }
 
+memset(interface-altsetting, 0, sizeof(struct usb_interface_descriptor) *
+					(interface-num_altsetting + 1));
+
 ifp = interface-altsetting + interface-num_altsetting;
 interface-num_altsetting++;
-- 
Ubuntu-devel-discuss mailing list
Ubuntu-devel-discuss@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss


Re: Who's still maintaining libusb-0.1?

2010-07-02 Thread Aurelien Jarno
On Mon, May 31, 2010 at 06:09:50PM +0800, Eric Miao wrote:
 Hi All,
Hi,

 Sorry I brought this topic to such a massive audience. But unfortunately 
 upower
 seems to be still linked with libusb-0.1, and thus bug 427805 and numerous 
 other
 duplicates are affecting many users. (http://bugs.launchpad.net/bugs/427805)
 
 This happens intermittently and was ignored by me previously until several 
 hours
 ago I realized there are so many users out there affected by this, mostly Mac
 users including me, and it looks Mac is vulnerable to this possibly
 because of the
 difference in the USB devices' descriptors.
 
 Debugged this and came up with a simple fix (a most common error), yet I don't
 know where to send except as attachment on LP. And we were also talking about
 deprecating libusb-0.1 in -M, yet this seems to be still useful for
 Lucid users at
 this moment.

Deprecating libusb-0.1 it's a huge task, a lot of software still depends
on it (and the API is quite different), beside the fact it is almost 
unmaintained upstream.

Last time I tried libusb-compat was not the same quality as libusb-0.1,
it introduced more problem than it solved. Maybe it has changed in the
meanwhile.

Cheers,
Aurelien

-- 
Aurelien Jarno  GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net

-- 
Ubuntu-devel-discuss mailing list
Ubuntu-devel-discuss@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss