Re: Fixing import errors and discouraging pushes

2012-12-03 Thread Barry Warsaw
On Dec 03, 2012, at 03:04 PM, Steve Langasek wrote:

>On Mon, Dec 03, 2012 at 04:07:47PM -0500, Barry Warsaw wrote:
>> I think we should (almost) never allow users to push to ubuntu: or debianlp:
>> branches, or at least, highly discourage it.  Just do the upload and let the
>> importer create the new revisions and it seems like that avoids a lot of
>> headaches and failures.
>
>If we're not going to allow pushing to the branches, then I don't think
>they're useful at all.  It's *only* for having rich branch history that I
>use these branches, and if they're not going to be usable that way I would
>discontinue my use of them altogether, moving the packages I maintain
>somewhere else for their primary VCS.

That's interesting, because I think source branches have a lot of benefit over
apt-get source by themselves.  For example, I like branching ubuntu:foo in a
local shared repo, then doing further branches for various bug fixes or other
development.

Letting the package importer update the branch seems akin to rebasing on the
current source branch once you've done the upload.

-Barry


signature.asc
Description: PGP signature
-- 
ubuntu-distributed-devel mailing list
ubuntu-distributed-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-distributed-devel


Re: Fixing import errors and discouraging pushes

2012-12-03 Thread Steve Langasek
On Mon, Dec 03, 2012 at 04:07:47PM -0500, Barry Warsaw wrote:
> I think we should (almost) never allow users to push to ubuntu: or debianlp:
> branches, or at least, highly discourage it.  Just do the upload and let the
> importer create the new revisions and it seems like that avoids a lot of
> headaches and failures.

If we're not going to allow pushing to the branches, then I don't think
they're useful at all.  It's *only* for having rich branch history that I
use these branches, and if they're not going to be usable that way I would
discontinue my use of them altogether, moving the packages I maintain
somewhere else for their primary VCS.

What's needed to actually fix this problem is for the branch importer to
take commit IDs from the branch as authoritative when they've changed from
what the importer itself pushed.  This has been discussed in the past, but
somehow never implemented.  I don't understand the reasons for that.  Is it
because no one who understands the code has time to make the change?  Are
people not convinced that such a change is correct?

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: Digital signature
-- 
ubuntu-distributed-devel mailing list
ubuntu-distributed-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-distributed-devel


Fixing import errors and discouraging pushes

2012-12-03 Thread Barry Warsaw
pykde4 is currently failing:

http://package-import.ubuntu.com/status/pykde4.html#2012-11-22 08:40:00.891722

I'd like to learn how to fix this in such a way that I can add some
suggestions to

https://wiki.ubuntu.com/DistributedDevelopment/UnderTheHood/Importer/CommonFailures

This way, folks can fix problems for packages they care about.

What I did:

$ bzr branch ubuntu:pykd4 raring
# This results in an out-of-date branch
$ bzr branch raring fiximport
$ chdist apt-get raring source pykde4
$ cd fiximport
$ bzr import-dsc ../pykde4_4.9.80-0ubuntu2.dsc

Now, is this enough to bzr push the fiximport branch to ubuntu:pykd4 and will
that fix the importer for subsequent runs?  Is there anything else I need to
do to the branch first?  Do I need to `push --overwrite`?   Is this much
harder than it seems?

I think we should (almost) never allow users to push to ubuntu: or debianlp:
branches, or at least, highly discourage it.  Just do the upload and let the
importer create the new revisions and it seems like that avoids a lot of
headaches and failures.  I'm not sure if there's anything more we can do
except to document this properly in the Ubuntu Developer Guide.

Cheers,
-Barry



signature.asc
Description: PGP signature
-- 
ubuntu-distributed-devel mailing list
ubuntu-distributed-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-distributed-devel