Re: ubuntu-specific modifications of pymsnt

2007-06-05 Thread Emilio Pozuelo Monfort
Sam Morris wrote:
> Hi there,

Hi Sam

> I maintain the Debian package of pymsnt. I recently found the utnubu
> service that displays the differences between Debian packages and their
> counterparts in Ubuntu. I looked up pymsnt and saw that you're patching
> the code like so:
> 
> diff -Nur pymsnt-0.11.2/src/main.py pymsnt-0.11.2.new/src/main.py
> --- pymsnt-0.11.2/src/main.py 2006-10-18 14:40:55.0 +1000
> +++ pymsnt-0.11.2.new/src/main.py 2007-04-05 10:14:37.0 
> +1000
> @@ -390,7 +390,10 @@
>   # Set SIGHUP to reload the config file & close & open debug file
>   signal.signal(signal.SIGHUP, SIGHUPstuff)
>   # Load some scripts for PID and daemonising
> - from twisted.scripts import twistd
> + try:
> + from twisted.scripts import _twistd_unix as twistd
> + except:
> + from twisted.scripts import twistd
>  
>  
>  def main():
> 
> Could someone please let me know what the purpose of this patch is?

From debian/changelog:

- debian/patches/130_twisted_2.5.patch: Add patch to work with
Twisted 2.5.

I'm CCing Lionel, who added that patch, in case he has something else to
say.

> In addition it would be nice if you could push changes upstream to the
> maintainer of the Debian package and to the original upstream
> developers, so that other users of Debian, Debian-derived distributions
> and other distributions can benefit from them. :)

We try to do it, but it's true we can improve there. At least I can
improve :)

> Regards,

Cheers
Emilio



signature.asc
Description: OpenPGP digital signature
-- 
Ubuntu-motu mailing list
Ubuntu-motu@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-motu


Re: ubuntu-specific modifications of pymsnt

2007-06-05 Thread Andy Price
On 05/06/07 21:11, Sam Morris wrote:
> Hi there,
Hi Sam

> I maintain the Debian package of pymsnt. I recently found the utnubu
> service that displays the differences between Debian packages and their
> counterparts in Ubuntu. I looked up pymsnt and saw that you're patching
> the code like so:

> Could someone please let me know what the purpose of this patch is?

>From the changelog: "- debian/patches/130_twisted_2.5.patch: Add patch
to work with Twisted 2.5."

See http://changelogs.ubuntu.com/changelogs/pool/universe/p/pymsnt/ for
the ubuntu additions to the pymsnt changelogs

> In addition it would be nice if you could push changes upstream to the
> maintainer of the Debian package and to the original upstream
> developers, so that other users of Debian, Debian-derived distributions
> and other distributions can benefit from them. :)

I believe this is usually standard practice. I guess this one slipped
through without being forwarded upstream. The change seems to relate to
this bug: https://launchpad.net/bugs/103102 which links to the origin of
the patch.

Hope that helps

--
Andy Price

-- 
Ubuntu-motu mailing list
Ubuntu-motu@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-motu