Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/216/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7631/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/216/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1652/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7630/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1652/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1437/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7629/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1437/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1402/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7628/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1402/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
[Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
The proposal to merge lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 -- Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/894/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1651 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1436 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1401 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/215 None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7627/console SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7626 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7623 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7624 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7625 Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/894/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/215/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7625/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/215/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1651/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7626/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1651/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1401/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7624/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1401/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2177 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1436/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7623/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1436/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Approve continuous-integration PASSED: Continuous integration, rev:2176 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1400/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7621/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1400/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2176 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/893/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1650/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1435/console SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1400 FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/214/console None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7622/console SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7620 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7618 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7621 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7619 Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/893/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2176 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/214/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7619/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/214/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2176 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1435/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7618/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1435/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2175 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1649/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7616/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1649/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2175 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/892/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1649/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1434/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1399/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/213/console None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7617/console SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7616 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7614 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7613 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7615 Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/892/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2175 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/213/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7615/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/213/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2175 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1399/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7613/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1399/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2174 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/212/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7611/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/212/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2174 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1648/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7610/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1648/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2174 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/891/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1648/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1433/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1398/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/212/console None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7612/console SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7610 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7609 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7608 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7611 Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/891/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2174 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1398/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7608/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1398/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2173 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1432/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7604/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1432/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2173 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1397/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7603/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1397/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2172 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/889/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1646/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1431/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1396/console FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/210/console None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7602/console SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7599 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7600 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7598 SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7601 Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/889/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
[Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
The proposal to merge lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging has been updated. Description changed to: Adding some description, i think CI may be failing because i don't have one. For more details, see: https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 -- Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2172 https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1646/ Executed test runs: None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7599/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1646/rebuild -- https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Review: Needs Fixing
I have one small request to it, otherwise good.
Diff comments:
> === modified file 'src/UbuntuToolkit/ucqquickimageextension.cpp'
> --- src/UbuntuToolkit/ucqquickimageextension.cpp 2016-09-12 09:03:50
> +
> +++ src/UbuntuToolkit/ucqquickimageextension.cpp 2017-02-02 14:51:24
> +
> @@ -61,12 +63,33 @@
> return m_source;
> }
>
> +
> void UCQQuickImageExtension::setSource(const QUrl& url)
> {
> if (url != m_source) {
> m_source = url;
> +reloadSourceOrPostEvent();
> +}
> +}
> +
> +void UCQQuickImageExtension::reloadSourceOrPostEvent()
> +{
> +// We need to wait until the component is complete
> +// so that m_image->sourceSize() is actually valid
> +if (QQuickItemPrivate::get(m_image)->componentComplete) {
> reloadSource();
> -}
> +} else {
> +qApp->postEvent(this, new QEvent(QEvent::User));
Please register the next event ID and use that.
> +}
> +}
> +
> +bool UCQQuickImageExtension::event(QEvent *e)
> +{
> +if (e->type() == QEvent::User) {
> +reloadSourceOrPostEvent();
> +return true;
> +}
> +return QObject::event(e);
> }
>
> void UCQQuickImageExtension::reloadSource()
--
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
Post to : ubuntu-sdk-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-sdk-team
More help : https://help.launchpad.net/ListHelp
[Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
The proposal to merge lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging has been updated. Commit Message changed to: Save a stat if the image we're loading is already in the cache No need to call UCUnits::resolveResource to learn we just need to load it normally because the fact that we already loaded it normally means we need to load it normally. For more details, see: https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235 -- Your team Ubuntu SDK team is requested to review the proposed merge of lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging. -- Mailing list: https://launchpad.net/~ubuntu-sdk-team Post to : ubuntu-sdk-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-sdk-team More help : https://help.launchpad.net/ListHelp
[Ubuntu-sdk-team] [Merge] lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into lp:ubuntu-ui-toolkit/staging
Albert Astals Cid has proposed merging
lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into
lp:ubuntu-ui-toolkit/staging.
Commit message:
Save a stat of the image we're loading is already in the cache
No need to call UCUnits::resolveResource to learn we just need to load it
normally because the fact that we already loaded it normally means we need to
load it normally.
Requested reviews:
Ubuntu SDK team (ubuntu-sdk-team)
Related bugs:
Bug #1558663 in ubuntu-ui-toolkit (Ubuntu): "Ubuntu Components is hard on the
disk and CPU when loading images"
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1558663
For more details, see:
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image/+merge/316235
--
Your team Ubuntu SDK team is requested to review the proposed merge of
lp:~aacid/ubuntu-ui-toolkit/save_stat_loading_already_loaded_image into
lp:ubuntu-ui-toolkit/staging.
=== modified file 'src/UbuntuToolkit/ucqquickimageextension.cpp'
--- src/UbuntuToolkit/ucqquickimageextension.cpp 2016-09-12 09:03:50 +
+++ src/UbuntuToolkit/ucqquickimageextension.cpp 2017-02-02 14:51:24 +
@@ -22,7 +22,9 @@
#include
#include
#include
+#include
#include
+#include
#include "ucunits_p.h"
@@ -61,12 +63,33 @@
return m_source;
}
+
void UCQQuickImageExtension::setSource(const QUrl& url)
{
if (url != m_source) {
m_source = url;
+reloadSourceOrPostEvent();
+}
+}
+
+void UCQQuickImageExtension::reloadSourceOrPostEvent()
+{
+// We need to wait until the component is complete
+// so that m_image->sourceSize() is actually valid
+if (QQuickItemPrivate::get(m_image)->componentComplete) {
reloadSource();
-}
+} else {
+qApp->postEvent(this, new QEvent(QEvent::User));
+}
+}
+
+bool UCQQuickImageExtension::event(QEvent *e)
+{
+if (e->type() == QEvent::User) {
+reloadSourceOrPostEvent();
+return true;
+}
+return QObject::event(e);
}
void UCQQuickImageExtension::reloadSource()
@@ -80,6 +103,22 @@
return;
}
+// If the url we're trying to load is already in the cache and
+// the devicePixelRatio is 1, we save calling UCUnits::resolveResource
+// and just set that image directly.
+// UCUnits::resolveResource is not cheap (does a stat on disk)
+if (qFuzzyCompare(qGuiApp->devicePixelRatio(), (qreal)1.0)) {
+QSize ss = m_image->sourceSize();
+if (ss.isNull() && m_image->image().isNull()) {
+ss = QSize(-1, -1);
+}
+
+if (QQuickPixmap::isCached(m_source, ss)) {
+m_image->setSource(m_source);
+return;
+}
+}
+
QString resolved = UCUnits::instance()->resolveResource(m_source);
if (resolved.isEmpty()) {
@@ -98,7 +137,9 @@
|| selectedFilePath.endsWith(QStringLiteral(".svgz"))) {
// Take care to pass the original fragment
QUrl selectedFileUrl(QUrl::fromLocalFile(selectedFilePath));
-selectedFileUrl.setFragment(fragment);
+if (m_source.hasFragment()) {
+selectedFileUrl.setFragment(fragment);
+}
m_image->setSource(selectedFileUrl);
} else {
// Need to scale the pixel-based image to suit the devicePixelRatio setting ourselves.
=== modified file 'src/UbuntuToolkit/ucqquickimageextension_p.h'
--- src/UbuntuToolkit/ucqquickimageextension_p.h 2016-09-09 17:49:07 +
+++ src/UbuntuToolkit/ucqquickimageextension_p.h 2017-02-02 14:51:24 +
@@ -50,11 +50,14 @@
void reloadSource();
protected:
+bool event(QEvent *e) override;
bool rewriteSciFile(const QString , const QString , QTextStream& output);
QString scaledBorder(const QString , const QString );
QString scaledSource(QString source, const QString , const QString );
private:
+void reloadSourceOrPostEvent();
+
QQuickImageBase* m_image;
QUrl m_source;
static QHash s_rewrittenSciFiles;
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
Post to : ubuntu-sdk-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-sdk-team
More help : https://help.launchpad.net/ListHelp
