[Bug 1060184] Re: puppet client init script pid file error

2012-10-15 Thread Matthew Malkin
After a clean install i type 
#apt-get install puppet
following which i change the line in /etc/default/puppet from START=no to 
START=yes

then i join the puppet client to my puppet server using 
#puppetd --server servername --waitforcert 60 --test
on the client side and 
#puppetca --sign servername
on the server side

then the following session can occur:


root@testserv1:~# pgrep puppet

root@testserv1:~# dpkg -s puppet
Package: puppet
Status: install ok installed
Priority: optional
Section: admin
Installed-Size: 336
Maintainer: Ubuntu Developers ubuntu-devel-disc...@lists.ubuntu.com
Architecture: all
Version: 2.7.11-1ubuntu2.1
Depends: puppet-common (= 2.7.11-1ubuntu2.1), ruby1.8
Pre-Depends: dpkg (= 1.15.7.2)
Recommends: rdoc
Suggests: puppet-el, vim-puppet, etckeeper
Conffiles:
 /etc/init.d/puppet 05404948b351469e8d56ac080f5d92fe
 /etc/default/puppet 9e5a0cf174ccff1af10342297b8b1bdb
Description: Centralized configuration management - agent startup and 
compatibility scripts
 This package contains the startup script and compatbility scripts for the
 puppet agent, which is the process responsible for configuring the local node.
 .
 Puppet lets you centrally manage every important aspect of your system
 using a cross-platform specification language that manages all the
 separate elements normally aggregated in different files, like users,
 cron jobs, and hosts, along with obviously discrete elements like
 packages, services, and files.
 .
 Puppet's simple declarative specification language provides powerful
 classing abilities for drawing out the similarities between hosts while
 allowing them to be as specific as necessary, and it handles dependency
 and prerequisite relationships between objects clearly and explicitly.
Homepage: http://projects.puppetlabs.com/projects/puppet
Original-Maintainer: Puppet Package Maintainers 
pkg-puppet-de...@lists.alioth.debian.org

root@testserv1:~# uname -a
Linux testserv1 3.2.0-31-generic #50-Ubuntu SMP Fri Sep 7 16:16:45 UTC 2012 
x86_64 x86_64 x86_64 GNU/Linux

root@testserv1:~# cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=12.04
DISTRIB_CODENAME=precise
DISTRIB_DESCRIPTION=Ubuntu 12.04.1 LTS

root@testserv1:~# /etc/init.d/puppet start
 * Starting puppet agent
   ...done.

root@testserv1:~# pgrep puppet
8459

root@testserv1:~# /etc/init.d/puppet stop
 * Stopping puppet agent
   ...done.
   
root@testserv1:~# pgrep puppet
8459

root@testserv1:~# /etc/init.d/puppet start
 * Starting puppet agent
   ...done.
   
root@testserv1:~# pgrep puppet
8459
8941

root@testserv1:~# /etc/init.d/puppet stop
 * Stopping puppet agent
   ...done.

root@testserv1:~# pgrep puppet
8459
8941

root@testserv1:~# /etc/init.d/puppet start
 * Starting puppet agent
   ...done.

root@testserv1:~# pgrep puppet
8459
8941
9395

root@testserv1:~# pkill puppet

root@testserv1:~# pgrep puppet
9395

root@testserv1:~# pkill puppet

root@testserv1:~# pgrep puppet

root@testserv1:~# exit



as you can see, the /etc/init.d/puppet stop appears to have no effect - puppet 
processes remain running after it is called.

the reason appears to be because the /etc/init.d/puppet file contains the line:
PIDFILE=/var/run/puppet/${NAME}.pid
I assume in this case ${NAME} resolves to puppet

therefore when it is attempting to stop puppet it searches for
/var/run/puppet/puppet.pid but the agent creates
/var/run/puppet/agent.pid

Simply changing the line in the /etc/init.d/puppet file from ${NAME}
to agent should (and does) solve the problem

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to puppet in Ubuntu.
https://bugs.launchpad.net/bugs/1060184

Title:
  puppet client init script pid file error

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1060184/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1060184] Re: puppet client init script pid file error

2012-10-15 Thread Matthew Malkin
Strange

Unfortunately I didn't keep the instance of the VM I just got those
results above from.

Having just recreated the VM (always from a snapshot of 12.04.1 before
first boot but after installation) following the same steps and before I
connected it to the puppetmaster i tested and it worked just fine as you
said. After connecting to the puppetmaster it continued to work just
fine.

I had created an puppetmaster entry for puppet's init script, but only
after i discovered the problem initially and only to solve that problem.
I have tested with that entry enabled and disabled so it appears to make
no difference. Indeed the only difference between the two files is one
(the one installed by the puppetmaster) has
PIDFILE=/var/run/puppet/agent.pid and the other (before puppetmaster
changed it) had /var/run/puppet/${NAME}.pid (difference tracked with
mercurial)

So i'm now a bit confused as to how this could have happened, but it
doesn't appear to be a bug as I originally thought.

This is how events have progressed:

2012-10-02:
- on new physical server: - detected problem
- installed copy of 12.04.1 server on virtualbox for testing
- took snapshot before first boot
- detected same problem on VM after installation - discovered it had to do with 
name of pid file
- reported bug

2012-10-15
- saw response
- rolled VM back to snapshot above
- installed puppet and produced output as seen above in my previous reply 
(recorded with screen and then manually tidied)
- saw response
- rolled VM back to snapshot above
- installed puppet without joining to puppetmaster - no problem
- joined to puppetmaster having commented out the entry that affects 
/etc/init.d/puppet - no problem
- uncommented entry - /etc/init.d/puppet changed - no problem

In conclusion

I don't know what was causing the problem initially but whatever it was appears 
to have gone away. Unless an update for puppet has been released between 2nd 
and 15th then I can't understand how come it now works, but it does so I shan't 
complain.
I am sorry - It seems I've been wasting your time.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to puppet in Ubuntu.
https://bugs.launchpad.net/bugs/1060184

Title:
  puppet client init script pid file error

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1060184/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1060184] [NEW] puppet client init script pid file error

2012-10-02 Thread Matthew Malkin
Public bug reported:

# lsb_release -rd

Description:Ubuntu 12.04.1 LTS
Release:12.04


# apt-cache policy puppet
puppet:
  Installed: 2.7.11-1ubuntu2.1
  Candidate: 2.7.11-1ubuntu2.1
  Version table:
 *** 2.7.11-1ubuntu2.1 0
500 http://gb.archive.ubuntu.com/ubuntu/ precise-updates/main amd64 
Packages
500 http://security.ubuntu.com/ubuntu/ precise-security/main amd64 
Packages
100 /var/lib/dpkg/status
 2.7.11-1ubuntu2 0
500 http://gb.archive.ubuntu.com/ubuntu/ precise/main amd64 Packages


It appears that when puppet is started it creates a pid file in 
/var/run/puppet/agent.pid but when you attempt to stop puppet it looks for the 
pid file in /var/run/puppet/puppet.pid doesn't find it and consequently doesn't 
stop puppet (despite returning ok). 

the error is then seen when you attempt to restart puppet as it won't
start because the pid file already exists.

changing variable in the pid file line of /etc/init.d/puppet to be
hardcoded /var/run/puppet/agent.pid solves the problem. This may however
not be the best solution.

Thanks

** Affects: puppet (Ubuntu)
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to puppet in Ubuntu.
https://bugs.launchpad.net/bugs/1060184

Title:
  puppet client init script pid file error

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1060184/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1060184] Re: puppet client init script pid file error

2012-10-02 Thread Matthew Malkin
Oh, i forgot to mention. I discovered this bug on a server, and then to
confirm i set up a clean install of ubuntu server (same version) in
virtualbox and it shows the same problem.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to puppet in Ubuntu.
https://bugs.launchpad.net/bugs/1060184

Title:
  puppet client init script pid file error

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1060184/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs