[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-28 Thread Launchpad Bug Tracker
This bug was fixed in the package squid3 - 3.3.8-1ubuntu6.4

---
squid3 (3.3.8-1ubuntu6.4) trusty-proposed; urgency=low

  * d/squid3.upstart: Use SIGINT to terminate squid and wait at most 40
seconds for it to finish. (LP: #1073478)

 -- Tiago Stürmer Daitx   Wed, 14 Oct 2015
02:54:20 +

** Changed in: squid3 (Ubuntu Trusty)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-28 Thread Launchpad Bug Tracker
This bug was fixed in the package squid3 - 3.1.19-1ubuntu3.12.04.4

---
squid3 (3.1.19-1ubuntu3.12.04.4) precise-proposed; urgency=low

  * d/squid3.upstart: Use SIGINT to terminate squid and wait at most 40
seconds for it to finish. (LP: #1073478)

 -- Tiago Stürmer Daitx   Wed, 14 Oct 2015
02:54:20 +

** Changed in: squid3 (Ubuntu Precise)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-28 Thread Michael Terry
And marking current task Invalid, since we moved away from upstart.

** Changed in: squid3 (Ubuntu)
   Status: Triaged => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-16 Thread Michael Terry
** Tags removed: verification-needed
** Tags added: verification-done-precise verification-done-trusty

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


Re: [Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-15 Thread Tiago Stürmer Daitx
> Yeah, but is the bug present in the sysinit script?  I'm assuming not,
> but it wouldn't hurt to verify.

Michael, indeed, thanks for the heads up. I did try it when
researching the SRU, but I forgot to include evidence that it worked
just fine. I have collected that just now.

# /etc/init.d/squid3 start
[ ok ] Starting squid3 (via systemctl): squid3.service.
# /etc/init.d/squid3 stop
[ ok ] Stopping squid3 (via systemctl): squid3.service.

# strace -r -e trace=signal,file -p $(cat /var/run/squid3.pid)
Process 2925 attached
 0.00 --- SIGTERM {si_signo=SIGTERM, si_code=SI_USER,
si_pid=3028, si_uid=0} ---
 0.68 kill(2923, SIGUSR1)   = 0
 0.46 rt_sigreturn()= -1 EINTR (Interrupted system call)
 0.81 stat("/etc/localtime", {st_mode=S_IFREG|0644,
st_size=127, ...}) = 0
 9.395299 --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED,
si_pid=2943, si_status=1, si_utime=0, si_stime=1} ---
 0.000778 rt_sigreturn()= -1 EINTR (Interrupted system call)
21.948196 stat("/etc/localtime", {st_mode=S_IFREG|0644,
st_size=127, ...}) = 0
 0.002870 kill(2931, SIGTERM)   = 0
 0.000606 --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_KILLED,
si_pid=2931, si_status=SIGTERM, si_utime=0, si_stime=0} ---
 0.000271 rt_sigreturn()= 9
 0.010035 unlink("/var/run/squid3.pid") = 0
 0.000397 open("/proc/sys/kernel/ngroups_max", O_RDONLY) = 10
 0.000353 open("/etc/group", O_RDONLY|O_CLOEXEC) = 10
 0.005137 +++ exited with 0 +++

As expected. it exits after about ~30 seconds.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-15 Thread Tiago Stürmer Daitx
Brian, thank you for uploading and publishing those to -proposed.

I have tested them on both Precise and Trusty and can confirm that they
work as expected: squid is killed with SIGINT, closing all outstanding
connections immediately and unlinking the PID file.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-15 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/precise-proposed/squid3

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-15 Thread Brian Murray
Hello Jan, or anyone else affected,

Accepted squid3 into precise-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/squid3/3.1.19-1ubuntu3.12.04.4 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: squid3 (Ubuntu Precise)
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-15 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/trusty-proposed/squid3

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-15 Thread Brian Murray
Hello Jan, or anyone else affected,

Accepted squid3 into trusty-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/squid3/3.3.8-1ubuntu6.4 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: squid3 (Ubuntu Trusty)
   Status: New => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


Re: [Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Tiago Stürmer Daitx
On the contrary, thanks for bringing that up. I was good to be made aware
of such problems. Just because it worked now on Precise and Trusty didn't
mean I should skip that check, as I might as well run into an obsolete or
deleted feature (not that upstart seem to have those). =)
On Oct 14, 2015 9:56 AM, "Robie Basak" <1073...@bugs.launchpad.net> wrote:

> On Wed, Oct 14, 2015 at 12:34:33PM -, Tiago Stürmer Daitx wrote:
> > According to http://upstart.ubuntu.com/cookbook/#stanzas-by-category
> > both "kill timeout" (all upstart versions) and "kill signal" (since
> > upstart 1.3) should be supported by upstart 1.5 in Precise so this SRU
> > should be fine.
>
> You're right. Sorry for the noise.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1073478
>
> Title:
>   [SRU] Update squid3 upstart script to kill it with SIGINT and wait
>   longer
>
> Status in squid3 package in Ubuntu:
>   Triaged
>
> Bug description:
>   [Impact]
>
>   Squid 3.1.19-1ubuntu3.12.04.3 on Precise and 3.3.8-1ubuntu6.3 on
>   Trusty do not clean up its PID file, causing logrotate to spit out an
>   error each night when cron runs it.
>
>   The underlying issue here is that the upstart script does not wait
>   long enough for squid3 to finish - one might also argue that it is
>   using the wrong signal if it expects squid to finish quickly.
>
>   By default, when squid3 receives a SIGTERM it will close the socket
>   for incoming connections and will wait for existing connections to
>   complete. The shutdown_lifetime directive configures how long it waits
>   before forcefully closing those open connections and it is set by
>   default to 30 seconds.
>
>   Current setting, SIGKILL happens after 5 seconds (which is the upstart
> default):
>   =
>   # strace -r -e trace=signal,file -p $(cat /var/run/squid3.pid)
>   Process 20865 attached - interrupt to quit
>0.00 --- SIGTERM (Terminated) @ 0 (0) ---
>0.000440 rt_sigreturn(0xf) = -1 EINTR (Interrupted system call)
>0.000418 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=118,
> ...}) = 0
>5.006483 +++ killed by SIGKILL +++
>
>   Killing squid with SIGKILL might lead to cache index corruption and a
>   very slow startup the next time it is started: http://lists.squid-
>   cache.org/pipermail/squid-users/2015-July/004752.html
>
>   The first way to avoid this is by increasing upstart's "kill timeout"
>   to a few seconds more then the "shutdown_lifetime" directive.
>
>   With "kill timeout 40" in upstart script, notice the pid file being
> unlinked (the ~30 seconds wait is due to the default value of
> shutdown_lifetime directive):
>   =
>   # strace -r -e trace=signal,file -p $(cat /var/run/squid3.pid)
>   Process 20805 attached - interrupt to quit
>0.00 --- SIGTERM (Terminated) @ 0 (0) ---
>0.000284 rt_sigreturn(0xf) = -1 EINTR (Interrupted system call)
>0.000402 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=118,
> ...}) = 0
>   31.611726 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=118,
> ...}) = 0
>0.001792 --- SIGCHLD (Child exited) @ 0 (0) ---
>0.000247 rt_sigreturn(0x) = 63
>0.006027 unlink("/var/run/squid3.pid") = 0
>0.000539 open("/proc/sys/kernel/ngroups_max", O_RDONLY) = 0
>0.000387 open("/etc/group", O_RDONLY|O_CLOEXEC) = 0
>   Process 20805 detached
>
>   Still, this will unfortunately lead to a slow shutdown time as
>   reported in http://askubuntu.com/questions/18127/squid3-starts-and-
>   stops-slowly
>
>   To solve this it is better to issue a SIGINT instead of SIGTERM
>   (upstart default) by adding "kill signal SIGINT" to squid's upstart
>   script.
>
>   With "kill signal SIGINT", which does not wait on outstanding
> connections:
>   =
>   # strace -r -e trace=signal,file -p $(cat /var/run/squid3.pid)
>   Process 20891 attached - interrupt to quit
>0.00 --- SIGINT (Interrupt) @ 0 (0) ---
>0.000312 rt_sigreturn(0x2) = -1 EINTR (Interrupted system call)
>0.000237 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=118,
> ...}) = 0
>1.123564 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=118,
> ...}) = 0
>0.000754 --- SIGCHLD (Child exited) @ 0 (0) ---
>0.000103 rt_sigreturn(0x) = 0
>0.002031 unlink("/var/run/squid3.pid") = 0
>0.000154 open("/proc/sys/kernel/ngroups_max", O_RDONLY) = 0
>0.000142 open("/etc/group", O_RDONLY|O_CLOEXEC) = 0
>   Process 20891 detached
>
>   The whole stop process is very quick. The downside is that squid will
>   forcefully close all open connections immediately, but that was
>   already happening when SIGKILL was being issued before - so we are
>   actually keeping the same behavior as before and there are no bugs
>   complaining about it. And the PID file gets removed anyway.
>
>   The proposal is to add 

[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Michael Terry
OK, I've uploaded these to precise and trusty.  Will subscribe ubuntu-
sru and unsubscribe ubuntu-sponsors.

Does this need any adjusting in wily?  We don't use upstart anymore but
do ship a traditional init.d file.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Michael Terry
(And thanks so much for preparing these patches / SRU description,
Tiago!)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Tiago Stürmer Daitx
Thank you Michael!

We only need to touch Wily if we want to keep the upstart script updated
there as well, but as you said Wily no longer uses upstart. Updating it
would not change any behavior. So far I couldn't find any documentation
explaining how to proceed on this scenario, so I'm open to suggestions.
I'm also ok providing a debdiff for it if we decide to go that way. =)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Michael Terry
Yeah, but is the bug present in the sysinit script?  I'm assuming not,
but it wouldn't hurt to verify.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Michael Terry
** Also affects: squid3 (Ubuntu Precise)
   Importance: Undecided
   Status: New

** Also affects: squid3 (Ubuntu Trusty)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


Re: [Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Robie Basak
On Wed, Oct 14, 2015 at 05:49:12PM -, Tiago Stürmer Daitx wrote:
> We only need to touch Wily if we want to keep the upstart script updated
> there as well, but as you said Wily no longer uses upstart. Updating it
> would not change any behavior. So far I couldn't find any documentation
> explaining how to proceed on this scenario, so I'm open to suggestions.
> I'm also ok providing a debdiff for it if we decide to go that way. =)

IMHO, this doesn't need to be a priority for Ubuntu. In my next merge I
intend to drop the upstart script part of the Ubuntu delta anyway.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Robie Basak
Note that there was an issue with php5 fpm (I think that was it) that we
can't ship a "kill" directive in an upstart job if someone can do a
release upgrade up to the version where that directive first appears.
Otherwise it gets done on the old upstart that does not support it and
break things. I can't find the bug reference right now, sorry, but it
should probably be checked against Precise.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Tiago Stürmer Daitx
Thanks for the feedback. Do you mean LP: #1272788 "php5-fpm upstart job
is not compatible with precise upstart" or LP: #1242376 "reload php5-fpm
crashes"?

That was one was caused because of the "reload" directive, only
introduced in upstart 1.10 while Precise only supports upstart 1.5.

According to http://upstart.ubuntu.com/cookbook/#stanzas-by-category
both "kill timeout" (all upstart versions) and "kill signal" (since
upstart 1.3) should be supported by upstart 1.5 in Precise so this SRU
should be fine.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


Re: [Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-14 Thread Robie Basak
On Wed, Oct 14, 2015 at 12:34:33PM -, Tiago Stürmer Daitx wrote:
> According to http://upstart.ubuntu.com/cookbook/#stanzas-by-category
> both "kill timeout" (all upstart versions) and "kill signal" (since
> upstart 1.3) should be supported by upstart 1.5 in Precise so this SRU
> should be fine.

You're right. Sorry for the noise.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


[Bug 1073478] Re: [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

2015-10-13 Thread Tiago Stürmer Daitx
** Summary changed:

- squid3 logrotate fails when squid is not running
+ [SRU] Update squid3 upstart script to kill it with SIGINT and wait longer

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid3 in Ubuntu.
https://bugs.launchpad.net/bugs/1073478

Title:
  [SRU] Update squid3 upstart script to kill it with SIGINT and wait
  longer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1073478/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs