[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
** Changed in: nova Status: Confirmed => Incomplete ** Changed in: nova (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
** Tags removed: in-stable-juno juno-backport-potential -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
** Changed in: nova/juno Assignee: (unassigned) = Matt Riedemann (mriedem) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
** Also affects: nova/juno Importance: Undecided Status: New ** Changed in: nova/juno Importance: Undecided = Medium ** Changed in: nova/juno Status: New = Fix Committed ** Changed in: nova/juno Milestone: None = 2014.2.3 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
Reviewed: https://review.openstack.org/166004 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=34f029e68d607c7154adcb6d6616da8da0db3650 Submitter: Jenkins Branch:stable/juno commit 34f029e68d607c7154adcb6d6616da8da0db3650 Author: Sahid Orentino Ferdjaoui sahid.ferdja...@redhat.com Date: Tue Mar 3 05:00:40 2015 -0500 libvirt: make default value of numa cell memory to 0 when not defined Some arch can have cells without memory or cpus defined and libvirt will return an XML without these elements. Our object defintion of the fields cpus and memory cannot let us to make them to None when not defined but currently the config representation of a NUMA make it to None. This patch fix the default value of config memory to 0 when libvirt does not return memory element for a cell. Also this cannot be considered come a fix for bug 1418187 since we have to handle these cases (cpus or memory not defined) during scheduling. thse case can be addressed when using distances which will be addressed in a next serie of patches. Conflicts: nova/tests/unit/virt/libvirt/test_config.py nova/virt/libvirt/config.py NOTE(mriedem): The conflict in config.py is due to the mempages code added on master with commit 3283e2a42 that's not in juno. The test conflict was due to moving the tests in kilo. Related-Bug: #1418187 Change-Id: Iac08d1221341a86c081d5e905c704fb1c9dca276 (cherry picked from commit 291c1a1db1ab3ceccfac7a3c8312b6fdce3aaa84) ** Tags added: in-stable-juno -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
Complete fix will likely not be backportable so this bug will not get Juno task in Launchpad! -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
We hit the same thing with powerkvm testing in juno have basically the same patch out of tree, I can't remember exactly why it didn't get upstream now, but I think there was at least a bug reported, I'm trying to dig that up for reference. ** Tags added: juno-backport-potential -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
The other bug was bug 1376307. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
If we look to your attachment we can see that: cell ids 1 and 17 do not provide any memory element. We need to figure out how it is possible and then we can fix it correctly. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
FYI, having _get_host_numa_topology() not generate an exception on reporting is the least of our worries here. The scheduling placement code for NUMA guests assumes that all NUMA cells have both memory cpus. So with the proposed patch you will have silenced the exception, but Nova will still be broken in practice, because it'll never schedule guests on 1/2 of the CPUs in this host - ie the ones without local memory will never get used. Fixing this is a far more invasive problem. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
I asked Daniel if his review in progress fixes this bug or we'll need to file another after that lands https://review.openstack.org/#/c/159106/ ** Changed in: nova Status: New = Confirmed ** Changed in: nova Importance: Undecided = Medium -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
** Changed in: nova Assignee: (unassigned) = sahid (sahid-ferdjaoui) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
revised patch.
--- driver.py.org 2015-02-05 03:07:39.396827122 +
+++ driver.py 2015-02-06 14:41:25.331949566 +
@@ -4682,11 +4687,16 @@
if topology is None or not topology.cells:
return
+if len([cell for cell in topology.cells if cell.memory is None]):
+LOG.warn(odd, some of your numa cells have None memory. %s,
+ [{id: cell.id, cpuset: set(cpu.id for cpu in cell.cpus),
+ memory: cell.memory} for cell in topology.cells])
+
topology = objects.NUMATopology(
cells=[objects.NUMACell(
id=cell.id,
cpuset=set(cpu.id for cpu in cell.cpus),
-memory=cell.memory / units.Ki,
+memory=(cell.memory if cell.memory else 0)/ units.Ki,
cpu_usage=0, memory_usage=0,
mempages=[
objects.NUMAPagesTopology(
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to nova in Ubuntu.
https://bugs.launchpad.net/bugs/1418187
Title:
_get_host_numa_topology assumes numa cell has memory
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
attaching workaround patch ** Also affects: nova Importance: Undecided Status: New ** Changed in: nova (Ubuntu) Status: New = Confirmed ** Changed in: nova (Ubuntu) Importance: Undecided = Medium ** Patch added: workaround patch https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1418187/+attachment/4313284/+files/1418187-hackfix.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
attachign virsh capabilities output. ** Attachment added: virsh capabilities output https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1418187/+attachment/4312433/+files/capabilities.txt -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1418187] Re: _get_host_numa_topology assumes numa cell has memory
** Tags added: openstack uosci -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1418187 Title: _get_host_numa_topology assumes numa cell has memory To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1418187/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
