[Bug 743484] [NEW] libupsclient.pc contains unresolved symbols

2011-03-26 Thread Fabrice Coutadeur
Public bug reported:

Binary package hint: nut

Hi,

While I was investigating a FTBFS in collectd:
...
configure:22249: checking for upscli_connect in -lupsclient
configure:22274: i686-linux-gnu-gcc -o conftest -Wall -g -O2 
-I/build/fabrice-collectd_4.10.1-2.1build1-i386-7yH3eE/collectd-4.10.1/debian/include
 -DLT_LAZY_OR_NOW='RTLD_LAZY|RTLD_GLOBAL' -UCONFIGFILE 
-DCONFIGFILE='"/etc/collectd/collectd.conf"'   -Wl,-Bsymbolic-functions 
@LIBSSL_LDFLAGS@ -L/lib -lupsclient   conftest.c -lupsclient  -ldl  >&5
i686-linux-gnu-gcc: @LIBSSL_LDFLAGS@: No such file or directory
I discovered that this reference to LIBSSL_LDFLAGS comes from libupsclient.pc.

As you can see in actual .pc file, this reference has not been resolved at 
compile time (content of more /usr/lib/pkgconfig/libupsclient.pc in a natty 
schroot):
prefix=/usr
exec_prefix=/
libdir=/lib
includedir=/usr/include
sysconfdir=/etc/nut
statepath=/var/run/nut
nutuser=nut

Name: libupsclient
Description: UPS monitoring with Network UPS Tools
Version: 2.6.0
Libs: -L${libdir} -lupsclient @LIBSSL_LDFLAGS@
Cflags: -I${includedir} 

This is because configure script and all makefile.in has been updated to use 
and substitute LIBSSL_LIBS instead of LIBSSL_LDFLAGS, but libupsclient.pc.in 
has not been updated.
By replacing LIBSSL_LDFLAGS with LIBSSL_LIBS in .in files, the generated .pc 
file is correct.

Thanks,
Fabrice

** Affects: nut (Ubuntu)
 Importance: Undecided
 Status: Confirmed

** Changed in: nut (Ubuntu)
   Status: New => In Progress

** Changed in: nut (Ubuntu)
 Assignee: (unassigned) => Fabrice Coutadeur (fabricesp)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to nut in Ubuntu.
https://bugs.launchpad.net/bugs/743484

Title:
  libupsclient.pc contains unresolved symbols

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs


Re: [Bug 743484] [NEW] libupsclient.pc contains unresolved symbols

2011-03-29 Thread Arnaud Quette
Salut Fabrice

2011/3/27 Fabrice Coutadeur 

> Public bug reported:
>
> Binary package hint: nut
>
> Hi,
>
> While I was investigating a FTBFS in collectd:
> ...
> configure:22249: checking for upscli_connect in -lupsclient
> configure:22274: i686-linux-gnu-gcc -o conftest -Wall -g -O2
> -I/build/fabrice-collectd_4.10.1-2.1build1-i386-7yH3eE/collectd-4.10.1/debian/include
> -DLT_LAZY_OR_NOW='RTLD_LAZY|RTLD_GLOBAL' -UCONFIGFILE
> -DCONFIGFILE='"/etc/collectd/collectd.conf"'   -Wl,-Bsymbolic-functions
> @LIBSSL_LDFLAGS@ -L/lib -lupsclient   conftest.c -lupsclient  -ldl  >&5
> i686-linux-gnu-gcc: @LIBSSL_LDFLAGS@: No such file or directory
> I discovered that this reference to LIBSSL_LDFLAGS comes from
> libupsclient.pc.
>
> As you can see in actual .pc file, this reference has not been resolved at
> compile time (content of more /usr/lib/pkgconfig/libupsclient.pc in a natty
> schroot):
> prefix=/usr
> exec_prefix=/
> libdir=/lib
> includedir=/usr/include
> sysconfdir=/etc/nut
> statepath=/var/run/nut
> nutuser=nut
>
> Name: libupsclient
> Description: UPS monitoring with Network UPS Tools
> Version: 2.6.0
> Libs: -L${libdir} -lupsclient @LIBSSL_LDFLAGS@
> Cflags: -I${includedir}
>
> This is because configure script and all makefile.in has been updated to
> use and substitute LIBSSL_LIBS instead of LIBSSL_LDFLAGS, but
> libupsclient.pc.in has not been updated.
> By replacing LIBSSL_LDFLAGS with LIBSSL_LIBS in .in files, the generated
> .pc file is correct.
>

fully right, thanks for investigation and patch.
For the sake of completion, lib/libupsclient-config.in (a replacement when
pkg-config is not present) also need to be fixed.

I've just applied it upstream (in NUT, commit r2960) while waiting for a new
Debian upload (I may lag a bit more, considering my current workload...):
http://trac.networkupstools.org/projects/nut/changeset/2960

Note that the above link may not yet be active by the reception of this
mail.

cheers,
Arnaud
-- 
Linux / Unix Expert R&D - Eaton - http://powerquality.eaton.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.free.fr/

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to nut in Ubuntu.
https://bugs.launchpad.net/bugs/743484

Title:
  libupsclient.pc contains unresolved symbols

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs