[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
Confirmed that the following patch and changes works to fix the problem: https://github.com/jimi1283/cobbler/commit/41a92b11969ab9c30b749ab99be70566cd943093 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
** Changed in: cobbler (Ubuntu) Status: New = Confirmed ** Changed in: cobbler (Ubuntu) Importance: Undecided = High -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
Thanks, David. Pardon me for being unfamiliar with github, but can I just get a raw diff from that link? ** Changed in: cobbler (Ubuntu) Assignee: (unassigned) = Dustin Kirkland (kirkland) ** Changed in: cobbler (Ubuntu) Status: Confirmed = In Progress -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
Okay, I just cloned the branch and cherry picked it. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
David, Are you, or is the author of this patch upstreaming this to the cobbler project itself? -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
This bug was fixed in the package cobbler - 2.1.0-0ubuntu4 --- cobbler (2.1.0-0ubuntu4) natty; urgency=low * debian/patches/36_tainted_file_path.patch: cherry-pick fix to tainted file path errors, LP: #750402 -- Dustin Kirkland kirkl...@ubuntu.com Mon, 04 Apr 2011 13:14:13 -0500 ** Changed in: cobbler (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
Hi Dustin, The github repo appears to just be a working-copy of the upstream source tree for that particular devs work, so I can't say yes/no to it being committed upstream, or even if the copy on that particular repo is recent... It is maintained by jimi1283 which could be a handle for James Cammarata, one of the regular cobbler contributors. I can pursue this upstream if it's better suited there though? I can generate a diff based on the modifications I made to get it working though. Can you confirm that the latest Ubuntu package in Natty is built from recent upstream source? (this should save me having to pull it myself and test the newest source myself before submitting a patch). This is really the first bug-report I've ever filed for anything... so I am easy pleased to send it upstream rather than provide a ubuntu-only patch. Cheers for looking into this Dustin. It's most appreciated. David. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
Just saw https://launchpad.net/ubuntu/+source/cobbler/2.1.0-0ubuntu4 that has the patch. Will pull this and try now on my test system. Cheers, Dave. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
On Mon, Apr 4, 2011 at 4:15 PM, David Dyball 750...@bugs.launchpad.net wrote: Just saw https://launchpad.net/ubuntu/+source/cobbler/2.1.0-0ubuntu4 that has the patch. Will pull this and try now on my test system. Right, I did a quick sniff test and it seemed to work well for me, so I uploaded it. If you could confirm the fix, that would be phenomenal! -- :-Dustin -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
On Mon, Apr 4, 2011 at 4:05 PM, David Dyball 750...@bugs.launchpad.net wrote: The github repo appears to just be a working-copy of the upstream source tree for that particular devs work, so I can't say yes/no to it being committed upstream, or even if the copy on that particular repo is recent... It is maintained by jimi1283 which could be a handle for James Cammarata, one of the regular cobbler contributors. I can pursue this upstream if it's better suited there though? We would *greatly* appreciate it if you could report this bug upstream, pointing to the commit and just asking if upstream is aware of the issue, and intends on fixing it, and if the proposed patch is suitable or completely unacceptable for some reason. In Ubuntu, we do carry patches against Debian and/or upstream sources, but we really want to try and keep that delta to a minimum, and ensure that such fixes find their way into upstream eventually and over time, so that our delta does not increase uncontrollably. I can generate a diff based on the modifications I made to get it working though. Can you confirm that the latest Ubuntu package in Natty is built from recent upstream source? (this should save me having to pull it myself and test the newest source myself before submitting a patch). The Ubuntu package is built from the very recent Cobbler 2.1 GA release. No need to build, though, as a subsequent email from you confirms you found that I have uploaded this fix already. This is really the first bug-report I've ever filed for anything... so I am easy pleased to send it upstream rather than provide a ubuntu-only patch. :-) Welcome! Cheers for looking into this Dustin. It's most appreciated. You bet. Thanks for your contributions, testing, re-testing, and finding patches. Cheers! -- :-Dustin -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
Confirmed that 2.1.0-0ubuntu4 fixes this issue. Going to head upstream and try and make them aware of it, if they aren't already. Cheers, David. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 750402] Re: Editing Kickstarts/Snippets errors with tainted file location
Confirmed that jimi1283 is indeed James Cammarata and that he is one of the primary contributors for cobbler, so the aforementioned patches are indeed James' work and he is aware of the issue. Hopefully his patch will work its way into the upstream. Under these circumstances, what are the options? Will cobbler get built with patch-36 (tainted file location patch) for cobbler-2.1.0-0ubuntu4, or will we just make continuous checks of upstream to wait for them to fix the issue? I will run with the deb-source packages for ubuntu4 that you uploaded this evening though. On a side-note, this contributing thing is rather cool. Might have to keep it up ;-) David. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cobbler in Ubuntu. https://bugs.launchpad.net/bugs/750402 Title: Editing Kickstarts/Snippets errors with tainted file location -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
