[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
This bug was fixed in the package puppet - 2.7.11-1ubuntu1 --- puppet (2.7.11-1ubuntu1) precise; urgency=low [ Marc Cluet ] * debian/patches/puppet-12844: Cherry picked patch from upstream 2.7.12 to revert new agent lockfile behaviour as it breaks upgrades from versions 2.7.10. This feature has been pushed out to puppet 3.x by upstream. * debian/puppetmaster-passenger.postinst (LP: #948983) - Fixed rack directory location - Added proper enabling of apache2 headers mod * debian/puppetmaster-passenger.postinst (LP: #950183) - Make sure we error if puppet config print doesn't work [ James Page ] * debian/puppetmaster-passenger.postinst: - Ensure upgrades from = 2.7.11-1 fixup passenger apache configuration. -- Marc Cluet marc.cl...@ubuntu.com Fri, 16 Mar 2012 15:36:35 + ** Changed in: puppet (Ubuntu) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
** Changed in: puppet (Ubuntu) Assignee: (unassigned) = Marc Cluet (lynxman) ** Changed in: puppet (Ubuntu) Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
** Branch linked: lp:~lynxman/ubuntu/precise/puppet/puppetlabsfixbug12844 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
debdiff from 2.7.11-1 to 2.7.11-1ubuntu2 ** Patch added: puppet_2.7.11-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+attachment/2839127/+files/puppet_2.7.11-1ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
This is the proper one, apologies ** Patch removed: puppet_2.7.11-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+attachment/2839127/+files/puppet_2.7.11-1ubuntu2.debdiff ** Patch added: puppet_2.7.11-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+attachment/2839193/+files/puppet_2.7.11-1ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
The attachment puppet_2.7.11-1ubuntu2.debdiff of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu- sponsors team please also unsubscribe the team from this bug report. [This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
Hey Glen-- Thanks for reporting this and helping us make Ubuntu better! I believe the issue here is that 'puppet config print' returns 0 on failure. The maintainer script is 'set -e', but in this case the errors are not caught. I'm wondering the script should be attempting to parse err: from calls to config print and fail early, or we should work on a patch to puppet to properly return non-zero on those errors. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
** Changed in: puppet (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
Adem, I can confirm that if it returns 0 on failure, which is really bad behaviour. Its really sad that such simple things can cause so much trouble. For now the fastest fix is to see if err: is returned by puppet config print in the postinst before even doing anything and if so the postinst should exit the install, roll back any changes and give a message that puppet.conf should be fixed first before reinstalling. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
** Changed in: puppet (Ubuntu) Status: Confirmed = Triaged -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
Ok, I think the puppet config print variable should be changed to puppet --configprint variable: # puppet config print abc; echo $? err: Could not parse /etc/puppet/puppet.conf: Could not match line abc at /etc/puppet/puppet.conf:bla invalid parameter: abc 0 # puppet --configprint abc; echo $? invalid parameter: abc 1 # puppet config print certname; echo $? err: Could not parse /etc/puppet/puppet.conf: Could not match line abc at /etc/puppet/puppet.conf:bla host.example.com 0 # puppet --configprint certname; echo $? host.example.com 0 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error
Yeah, that does the trick. Replace puppet config print in the postinst with puppet --configprint and this bug can be resolved: root@host:/etc# dpkg -i puppetmaster-passenger_2.7.11-1_all.deb Selecting previously unselected package puppetmaster-passenger. (Reading database ... 25803 files and directories currently installed.) Unpacking puppetmaster-passenger (from puppetmaster-passenger_2.7.11-1_all.deb) ... Setting up puppetmaster-passenger (2.7.11-1) ... err: Could not parse /etc/puppet/puppet.conf: Could not match line bla at /etc/puppet/puppet.conf:bla notice: Signed certificate request for ca notice: Rebuilding inventory file notice: host.example.com has a waiting certificate request notice: Signed certificate request for host.example.com notice: Removing file Puppet::SSL::CertificateRequest host.example.com at '/etc/puppet/ssl/ca/requests/host.example.com.pem' notice: Removing file Puppet::SSL::CertificateRequest host.example.com at '/etc/puppet/ssl/certificate_requests/host.example.com.pem' Module ssl already enabled Enabling site puppetmaster. To activate the new configuration, you need to run: service apache2 reload * Restarting web server apache2 ... waiting Maybe someone else knows why the error is still in the output though? -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
