Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot
Review: Approve continuous-integration PASSED: Continuous integration, rev:20 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/45/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/15 SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/45 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/45/rebuild -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage/+merge/252962 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot
Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot. Commit message: Get initial data from storage to not block the UI thread. Requested reviews: Ubuntu Weather Developers (ubuntu-weather-dev) For more details, see: https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage/+merge/252962 Nik had noticed that the app is blank when it is started. I'm 99% sure that is due to the initial refresh blocking the UI. I had the same issue with both OWM and TWC today. Ideally this should be done in a workerscript, but the solution here is a good temporary workaround. -- Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot. === modified file 'app/ubuntu-weather-app.qml' --- app/ubuntu-weather-app.qml 2015-03-08 17:23:58 + +++ app/ubuntu-weather-app.qml 2015-03-13 23:40:05 + @@ -56,8 +56,11 @@ /* (re)load the pages on completion + TODO: Currently this is done from storage because the request blocks the +UI. Ideally the request to the APIs should be done via a +WorkerScript */ -Component.onCompleted: refreshData(); +Component.onCompleted: refreshData(true, false); /* Handle response data from data backend. Checks if a location -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot
Review: Approve Looks ok to me. Thanks -- https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/fixComplexStorage150131 into lp:ubuntu-calculator-app/reboot
Review: Needs Information These changes are already on trunk. Currently there is nothing to merge. Can we delete this merge proposal? -- https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixComplexStorage150131/+merge/248182 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Blueprint weather-reboot] Weather App Reboot
Blueprint changed by Victor Thompson: Work items changed: Work items: [popey] ping mail out to arrange next meeting time/day (wed evening?): DONE [nik90] Move all the design documents to one common google drive folder: DONE [popey] Create new blueprint and add work items / milestones: DONE [ahayzen] Create new launchpad branch called reboot: DONE [nik90] (also m-b-o, andrew-hayzen) Create new c++/qml/cmake project: DONE [martin-borho] Add backend code for openweathermap / twc: DONE [ahayzen] Build static prototype of 'main page': DONE [fginther] Get jenkins running on the new branch via cihelp in #ubuntu-ci-eng: DONE [vthompson] Set up translation framework: DONE [ahayzen] Debian packaging (necessary for autopkgtests): DONE [martin-borho] Fill static prototype components with real data: DONE [ahayzen] Create bottom edge to reveal locations: DONE [ahayzen] Migrate to settings API: DONE [ahayzen] Create settings page and children: DONE [martin-borho] Create component to show the hourly forecase when the image on 'home' is clicked/swiped: DONE [martin-borho] Put 'home' into a horizontal listview of the locations that are swipeable with snapping: DONE [ahayzen] Create add location page: DONE [ahayzen] Allow (multiselect) deletion on LocationsPage: DONE [martin-borho] Make bottom edge functional by loading locations after selecting: DONE [martin-borho] QML - Fix type assigning warnings after changing data provider: DONE + [martin-borho] Reimplement caching for provider calls: DONE + [vthompson] Add pull-to-refresh: DONE [martin-borho] migrate from geonames.org to ubuntu.geonames: INPROGRESS - [martin-borho] Reimplement caching for provider calls: DONESwitch translation focus from trunk to reboot: TODO [ahayzen] Set up testing framework: TODO [popey] Upload "Weather Reboot" to store when ready: TODO [popey] Retrieve SVGs of images from design: TODO [ahayzen] Modify the Day delegate to support expanding to reveal more info: TODO - [vthompson] Add pull-to-refresh: INPROGRESS [vthompson] Add current temps to the Locations page: INPROGRESS Make hourly forecast visible when 'swiping' the main image (see spec): TODO Add today's detail (shown where the current temp is when the hourly is shown): TODO Empty states (use current location): TODO Location detection for current location: TODO + Switch translation focus from trunk to reboot: TODO -- Weather App Reboot https://blueprints.launchpad.net/ubuntu-weather-app/+spec/weather-reboot -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:222 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/628/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2342 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2342/artifact/work/output/*zip*/output.zip Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-clock-app-ci/628/rebuild -- https://code.launchpad.net/~nik90/ubuntu-clock-app/improve-setting-listitem/+merge/252930 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:128 http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/125/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2341 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2341/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-utopic-amd64-ci/18 SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-vivid-amd64-ci/125 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/125/rebuild -- https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot
Should be ok now, sorry again -- https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Blueprint alarms-2.0] Alarms 2.0
Blueprint changed by Nekhelesh Ramananthan: Definition Status: New => Drafting -- Alarms 2.0 https://blueprints.launchpad.net/ubuntu-clock-app/+spec/alarms-2.0 -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:221 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/627/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2340/console Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-clock-app-ci/627/rebuild -- https://code.launchpad.net/~nik90/ubuntu-clock-app/improve-setting-listitem/+merge/252930 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app.
Commit message:
Made the expandable list item used in AlarmSettings.qml into a generic
component to avoid code duplication and also polished its visual style (related
to side anchors and tick to indicate selected setting).
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/improve-setting-listitem/+merge/252930
Made the expandable list item used in AlarmSettings.qml into a generic
component to avoid code duplication and also polished its visual style (related
to side anchors and tick to indicate selected setting).
--
Your team Ubuntu Clock Developers is requested to review the proposed merge of
lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app.
=== modified file 'app/alarm/AlarmSettingsPage.qml'
--- app/alarm/AlarmSettingsPage.qml 2015-03-12 23:22:12 +
+++ app/alarm/AlarmSettingsPage.qml 2015-03-13 17:01:12 +
@@ -116,140 +116,58 @@
}
}
-ListItem.Expandable {
+ExpandableListItem {
id: _alarmDuration
-anchors {
-left: parent.left
-right: parent.right
-}
-
-collapseOnClick: true
-expandedHeight: _contentColumn.height + units.gu(1)
-
-Column {
-id: _contentColumn
-
-anchors {
-left: parent.left
-right: parent.right
-margins: units.gu(-2)
-}
-
-Item {
-width: parent.width
-height: _alarmDuration.collapsedHeight
-
-SubtitledListItem {
-id: _header
-text: i18n.tr("Silence after")
-subText: i18n.tr("%1 minute", "%1 minutes", alarmSettings.duration).arg(alarmSettings.duration)
-onClicked: _alarmDuration.expanded = true
-
-Icon {
-id: _upArrow
-
-width: units.gu(2)
-height: width
-anchors.right: parent.right
-anchors.rightMargin: units.gu(2)
-anchors.verticalCenter: parent.verticalCenter
-
-name: "go-down"
-color: "Grey"
-rotation: _alarmDuration.expanded ? 180 : 0
-
-Behavior on rotation {
-UbuntuNumberAnimation {}
-}
-}
-}
-}
-
-ListView {
-id: _resultsList
-
-interactive: false
-model: durationModel
-width: parent.width
-height: units.gu(24)
-
-delegate: ListItem.Standard {
-text: model.text
-onClicked: {
-alarmSettings.duration = duration
-_alarmDuration.expanded = false
-}
-}
+listViewHeight: units.gu(24)
+text: i18n.tr("Silence after")
+subText: i18n.tr("%1 minute", "%1 minutes", alarmSettings.duration).arg(alarmSettings.duration)
+
+model: durationModel
+
+delegate: ListItem.Standard {
+text: model.text
+onClicked: {
+alarmSettings.duration = duration
+_alarmDuration.expanded = false
+}
+
+Icon {
+width: units.gu(2)
+height: width
+name: "ok"
+visible: alarmSettings.duration === duration
+anchors.right: parent.right
+anchors.rightMargin: units.gu(2)
+anchors.verticalCenter: parent.verticalCenter
}
}
}
-ListItem.Expandable {
+ExpandableListItem {
id: _alarmSnooze
-anchors {
-left: parent.left
-right: parent.right
-}
-
-collapseOnClick: true
-expandedHeight: _snoozeContentColumn.height + units.gu(1)
-
-Column {
-id: _snoozeContentCol
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-add-temp-to-locations into lp:ubuntu-weather-app/reboot
Review: Approve continuous-integration PASSED: Continuous integration, rev:19 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/41/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/11 SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/41 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/41/rebuild -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-add-temp-to-locations/+merge/252919 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-add-temp-to-locations into lp:ubuntu-weather-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Blueprint weather-reboot] Weather App Reboot
Blueprint changed by Victor Thompson: Work items changed: Work items: [popey] ping mail out to arrange next meeting time/day (wed evening?): DONE [nik90] Move all the design documents to one common google drive folder: DONE [popey] Create new blueprint and add work items / milestones: DONE [ahayzen] Create new launchpad branch called reboot: DONE [nik90] (also m-b-o, andrew-hayzen) Create new c++/qml/cmake project: DONE [martin-borho] Add backend code for openweathermap / twc: DONE [ahayzen] Build static prototype of 'main page': DONE [fginther] Get jenkins running on the new branch via cihelp in #ubuntu-ci-eng: DONE [vthompson] Set up translation framework: DONE [ahayzen] Debian packaging (necessary for autopkgtests): DONE [martin-borho] Fill static prototype components with real data: DONE [ahayzen] Create bottom edge to reveal locations: DONE [ahayzen] Migrate to settings API: DONE [ahayzen] Create settings page and children: DONE [martin-borho] Create component to show the hourly forecase when the image on 'home' is clicked/swiped: DONE [martin-borho] Put 'home' into a horizontal listview of the locations that are swipeable with snapping: DONE [ahayzen] Create add location page: DONE [ahayzen] Allow (multiselect) deletion on LocationsPage: DONE [martin-borho] Make bottom edge functional by loading locations after selecting: DONE [martin-borho] QML - Fix type assigning warnings after changing data provider: DONE [martin-borho] migrate from geonames.org to ubuntu.geonames: INPROGRESS [martin-borho] Reimplement caching for provider calls: DONESwitch translation focus from trunk to reboot: TODO [ahayzen] Set up testing framework: TODO [popey] Upload "Weather Reboot" to store when ready: TODO [popey] Retrieve SVGs of images from design: TODO [ahayzen] Modify the Day delegate to support expanding to reveal more info: TODO [vthompson] Add pull-to-refresh: INPROGRESS + [vthompson] Add current temps to the Locations page: INPROGRESS Make hourly forecast visible when 'swiping' the main image (see spec): TODO Add today's detail (shown where the current temp is when the hourly is shown): TODO Empty states (use current location): TODO Location detection for current location: TODO -- Weather App Reboot https://blueprints.launchpad.net/ubuntu-weather-app/+spec/weather-reboot -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-add-temp-to-locations into lp:ubuntu-weather-app/reboot
Victor Thompson has proposed merging
lp:~vthompson/ubuntu-weather-app/reboot-add-temp-to-locations into
lp:ubuntu-weather-app/reboot.
Commit message:
Add current temps to the Locations page.
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-add-temp-to-locations/+merge/252919
This change uses the data on the HomePages to place the current conditions on
the LocationsPage.
--
Your team Ubuntu Weather Developers is requested to review the proposed merge
of lp:~vthompson/ubuntu-weather-app/reboot-add-temp-to-locations into
lp:ubuntu-weather-app/reboot.
=== modified file 'app/ui/LocationsPage.qml'
--- app/ui/LocationsPage.qml 2015-03-06 14:15:29 +
+++ app/ui/LocationsPage.qml 2015-03-13 15:55:52 +
@@ -63,6 +63,7 @@
id: locationsModel
}
delegate: WeatherListItem {
+id: locationsListItem
leftSideAction: Remove {
onTriggered: storage.removeLocation(index)
}
@@ -79,16 +80,46 @@
storage.moveLocation(from, to);
}
-Label {
-anchors {
+Row {
+anchors{
+top: parent.top
left: parent.left
leftMargin: units.gu(2)
right: parent.right
rightMargin: units.gu(2)
-verticalCenter: parent.verticalCenter
-}
-elide: Text.ElideRight
-text: model.location.name
+bottom: parent.bottom
+}
+spacing: units.gu(2)
+
+Label {
+elide: Text.ElideRight
+height: locationsListItem.height
+text: model.location.name
+verticalAlignment: Text.AlignVCenter
+}
+
+Image {
+id: weatherImage
+anchors {
+centerIn: parent
+}
+height: units.gu(3)
+source: locationPage.iconMap[locationPages.contentItem.children[index].iconName]
+width: units.gu(3)
+}
+
+Label {
+id: nowLabel
+anchors {
+right: parent.right
+}
+color: UbuntuColors.orange
+font.pixelSize: units.gu(4)
+font.weight: Font.Light
+height: units.gu(6)
+text: locationPages.contentItem.children[index].currentTemp + settings.tempScale[1]
+verticalAlignment: Text.AlignVCenter
+}
}
ListItem.ThinDivider {
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Blueprint weather-reboot] Weather App Reboot
Blueprint changed by Victor Thompson: Work items changed: Work items: [popey] ping mail out to arrange next meeting time/day (wed evening?): DONE [nik90] Move all the design documents to one common google drive folder: DONE [popey] Create new blueprint and add work items / milestones: DONE [ahayzen] Create new launchpad branch called reboot: DONE [nik90] (also m-b-o, andrew-hayzen) Create new c++/qml/cmake project: DONE [martin-borho] Add backend code for openweathermap / twc: DONE [ahayzen] Build static prototype of 'main page': DONE [fginther] Get jenkins running on the new branch via cihelp in #ubuntu-ci-eng: DONE [vthompson] Set up translation framework: DONE [ahayzen] Debian packaging (necessary for autopkgtests): DONE [martin-borho] Fill static prototype components with real data: DONE [ahayzen] Create bottom edge to reveal locations: DONE [ahayzen] Migrate to settings API: DONE [ahayzen] Create settings page and children: DONE [martin-borho] Create component to show the hourly forecase when the image on 'home' is clicked/swiped: DONE [martin-borho] Put 'home' into a horizontal listview of the locations that are swipeable with snapping: DONE [ahayzen] Create add location page: DONE [ahayzen] Allow (multiselect) deletion on LocationsPage: DONE [martin-borho] Make bottom edge functional by loading locations after selecting: DONE [martin-borho] QML - Fix type assigning warnings after changing data provider: DONE [martin-borho] migrate from geonames.org to ubuntu.geonames: INPROGRESS [martin-borho] Reimplement caching for provider calls: DONESwitch translation focus from trunk to reboot: TODO [ahayzen] Set up testing framework: TODO [popey] Upload "Weather Reboot" to store when ready: TODO [popey] Retrieve SVGs of images from design: TODO [ahayzen] Modify the Day delegate to support expanding to reveal more info: TODO + [vthompson] Add pull-to-refresh: INPROGRESS Make hourly forecast visible when 'swiping' the main image (see spec): TODO Add today's detail (shown where the current temp is when the hourly is shown): TODO - [vthompson] Add pull-to-refresh: INPROGRESS Empty states (use current location): TODO Location detection for current location: TODO -- Weather App Reboot https://blueprints.launchpad.net/ubuntu-weather-app/+spec/weather-reboot -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Blueprint weather-reboot] Weather App Reboot
Blueprint changed by Victor Thompson: Work items changed: Work items: [popey] ping mail out to arrange next meeting time/day (wed evening?): DONE [nik90] Move all the design documents to one common google drive folder: DONE [popey] Create new blueprint and add work items / milestones: DONE [ahayzen] Create new launchpad branch called reboot: DONE [nik90] (also m-b-o, andrew-hayzen) Create new c++/qml/cmake project: DONE [martin-borho] Add backend code for openweathermap / twc: DONE [ahayzen] Build static prototype of 'main page': DONE [fginther] Get jenkins running on the new branch via cihelp in #ubuntu-ci-eng: DONE [vthompson] Set up translation framework: DONE [ahayzen] Debian packaging (necessary for autopkgtests): DONE [martin-borho] Fill static prototype components with real data: DONE [ahayzen] Create bottom edge to reveal locations: DONE [ahayzen] Migrate to settings API: DONE [ahayzen] Create settings page and children: DONE [martin-borho] Create component to show the hourly forecase when the image on 'home' is clicked/swiped: DONE [martin-borho] Put 'home' into a horizontal listview of the locations that are swipeable with snapping: DONE [ahayzen] Create add location page: DONE [ahayzen] Allow (multiselect) deletion on LocationsPage: DONE [martin-borho] Make bottom edge functional by loading locations after selecting: DONE [martin-borho] QML - Fix type assigning warnings after changing data provider: DONE [martin-borho] migrate from geonames.org to ubuntu.geonames: INPROGRESS [martin-borho] Reimplement caching for provider calls: DONESwitch translation focus from trunk to reboot: TODO [ahayzen] Set up testing framework: TODO [popey] Upload "Weather Reboot" to store when ready: TODO [popey] Retrieve SVGs of images from design: TODO [ahayzen] Modify the Day delegate to support expanding to reveal more info: TODO Make hourly forecast visible when 'swiping' the main image (see spec): TODO Add today's detail (shown where the current temp is when the hourly is shown): TODO - Add header action for refresh: TODO + [vthompson] Add pull-to-refresh: INPROGRESS Empty states (use current location): TODO Location detection for current location: TODO -- Weather App Reboot https://blueprints.launchpad.net/ubuntu-weather-app/+spec/weather-reboot -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app
thanks a lot! -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app
Review: Approve
Looks good to me, just added two notes.
Diff comments:
> === modified file 'app/alarm/AlarmSettingsPage.qml'
> --- app/alarm/AlarmSettingsPage.qml 2014-10-16 19:03:51 +
> +++ app/alarm/AlarmSettingsPage.qml 2015-03-12 23:25:02 +
> @@ -50,10 +50,10 @@
> Component.onCompleted: initialise()
>
> function initialise() {
> -durationModel.append({ "duration": 10, "text": i18n.tr("%1
> minutes").arg(10) })
> -durationModel.append({ "duration": 20, "text": i18n.tr("%1
> minutes").arg(20) })
> -durationModel.append({ "duration": 30, "text": i18n.tr("%1
> minutes").arg(30) })
> -durationModel.append({ "duration": 60, "text": i18n.tr("%1
> minutes").arg(60) })
> +durationModel.append({ "duration": 10, "text": i18n.tr("%1
> minute", "%1 minutes", 10).arg(10) })
> +durationModel.append({ "duration": 20, "text": i18n.tr("%1
> minute", "%1 minutes", 20).arg(20) })
> +durationModel.append({ "duration": 30, "text": i18n.tr("%1
> minute", "%1 minutes", 30).arg(30) })
> +durationModel.append({ "duration": 60, "text": i18n.tr("%1
> minute", "%1 minutes", 60).arg(60) })
> }
It's a bit of a strange case, as the string will always be plural, but I think
it's better like this, as this way we'll leave the plural handling of gettext
manage which plural form to use for those languages with more complex plural
requirements.
> }
>
> @@ -62,10 +62,10 @@
> Component.onCompleted: initialise()
>
> function initialise() {
> -snoozeModel.append({ "duration": 2, "text": i18n.tr("%1
> minutes").arg(2) })
> -snoozeModel.append({ "duration": 4, "text": i18n.tr("%1
> minutes").arg(4) })
> -snoozeModel.append({ "duration": 5, "text": i18n.tr("%1
> minutes").arg(5) })
> -snoozeModel.append({ "duration": 10, "text": i18n.tr("%1
> minutes").arg(10) })
> +snoozeModel.append({ "duration": 2, "text": i18n.tr("%1 minute",
> "%1 minutes", 2).arg(2) })
> +snoozeModel.append({ "duration": 4, "text": i18n.tr("%1 minute",
> "%1 minutes", 4).arg(4) })
> +snoozeModel.append({ "duration": 5, "text": i18n.tr("%1 minute",
> "%1 minutes", 5).arg(5) })
> +snoozeModel.append({ "duration": 10, "text": i18n.tr("%1
> minute", "%1 minutes", 10).arg(10) })
> }
Same as the comment above
> }
>
> @@ -143,7 +143,7 @@
> SubtitledListItem {
> id: _header
> text: i18n.tr("Silence after")
> -subText: i18n.tr("%1
> minutes").arg(alarmSettings.duration)
> +subText: i18n.tr("%1 minute", "%1 minutes",
> alarmSettings.duration).arg(alarmSettings.duration)
> onClicked: _alarmDuration.expanded = true
>
> Icon {
> @@ -212,7 +212,7 @@
> SubtitledListItem {
> id: _snoozeHeader
> text: i18n.tr("Snooze for")
> -subText: i18n.tr("%1
> minutes").arg(alarmSettings.snoozeDuration)
> +subText: i18n.tr("%1 minute", "%1 minutes",
> alarmSettings.snoozeDuration).arg(alarmSettings.snoozeDuration)
> onClicked: _alarmSnooze.expanded = true
>
> Icon {
>
> === modified file 'debian/changelog'
> --- debian/changelog 2015-03-06 17:12:24 +
> +++ debian/changelog 2015-03-12 23:25:02 +
> @@ -10,7 +10,8 @@
>* Fixed predefined cities and countries not being translatable in the
> timezone
> selection dialog (LP: #1354466)
>* Fixed empty state description not wrapping (LP: #1428165)
> - * Fixed edit alarm crash issue in vivid (thanks to Zsombor)
> + * Fixed edit alarm crash issue in vivid (thanks to Zsombor) (LP: #1429273)
> + * Fixed strings not following gettext-style plural forms. (LP: #1431446)
>
>[Brendan Donegan]
>* Fixed AP failure by waiting for the bottom edge tip visible property to
> be true
>
> === modified file 'po/com.ubuntu.clock.pot'
> --- po/com.ubuntu.clock.pot 2015-03-06 17:11:42 +
> +++ po/com.ubuntu.clock.pot 2015-03-12 23:25:02 +
> @@ -8,7 +8,7 @@
> msgstr ""
> "Project-Id-Version: \n"
> "Report-Msgid-Bugs-To: \n"
> -"POT-Creation-Date: 2015-03-06 17:09+\n"
> +"POT-Creation-Date: 2015-03-13 00:18+0100\n"
> "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
> "Last-Translator: FULL NAME \n"
> "Language-Team: LANGUAGE \n"
> @@ -16,6 +16,7 @@
> "MIME-Version: 1.0\n"
> "Content-Type: text/plain; charset=UTF-8\n"
> "Content-Transfer-Encoding: 8bit\n"
> +"Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
>
> #: ../app/alarm/AlarmLabel.qml:30 ../app/alarm/AlarmLabel.qml:56
> #: ../app/alarm/EditAlarmPage.qml:291
> @@ -71,8 +72,
