Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app
Review: Approve LGTM -- https://code.launchpad.net/~mzanetti/reminders-app/fix-renderwidth/+merge/258564 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: http://91.189.93.70:8080/job/reminders-app-autolanding/435/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2725 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2725/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/213 SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/157 -- https://code.launchpad.net/~mzanetti/reminders-app/fix-renderwidth/+merge/258564 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-renderwidth/+merge/258564 -- Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve
+1 from me, but do change the logger.warn to something else before top
approving.
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-06 20:12:16 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Report-Msgid-Bugs-To: \n
-POT-Creation-Date: 2015-04-27 18:02+0200\n
+POT-Creation-Date: 2015-05-04 21:48+0200\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME EMAIL@ADDRESS\n
Language-Team: LANGUAGE l...@li.org\n
@@ -34,7 +34,7 @@
#: ../src/app/docviewer-application.cpp:164
#: ../src/app/qml/documentPage/DocumentPage.qml:25
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#:
/home/letozaf/autopilot-tests/build-test-toc-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
msgid Document Viewer
msgstr
@@ -257,12 +257,12 @@
msgstr
#. TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:26
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
#: ../src/app/qml/pdfView/PdfView.qml:37
msgid Contents
msgstr
-#: ../src/app/qml/pdfView/PdfContentsPage.qml:32
+#: ../src/app/qml/pdfView/PdfContentsPage.qml:38
msgid Hide table of contents
msgstr
@@ -319,6 +319,6 @@
msgid Open
msgstr
-#:
/home/stefano/tmp/build-ch-imported-documents-name-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#:
/home/letozaf/autopilot-tests/build-test-toc-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
msgid documents;viewer;pdf;reader;
msgstr
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml 2015-04-16 12:58:29 +
+++ src/app/qml/pdfView/PdfContentsPage.qml 2015-05-06 20:12:16 +
@@ -22,6 +22,12 @@
import ../upstreamComponents
Page {
+id: pdfContents
+objectName: pdfcontents
+
+// this property will have to be removed when bug #1341671 will be fixed.
+property string testProperty: for page name issue
+
// TRANSLATORS: Contents refers to the Table of Contents of a PDF
document.
title: i18n.tr(Contents)
@@ -57,6 +63,7 @@
ListView {
id: view
+objectName: view
anchors.fill: parent
clip: true
@@ -64,6 +71,7 @@
delegate: ListItemWithActions {
id: delegate
+objectName: delegate + index
width: parent.width
height: (model.level === 0) ? units.gu(7) : units.gu(6)
@@ -73,6 +81,7 @@
:
Theme.palette.normal.background
AbstractButton {
+objectName: abstractbutton
anchors.fill: parent
onClicked: {
@@ -91,6 +100,7 @@
spacing: units.gu(1)
Label {
+objectName: content
Layout.fillWidth: true
text: model.title
@@ -102,6 +112,7 @@
}
Label {
+objectName: pageindex
text: model.pageIndex + 1
font.weight: model.level == 0 ? Font.DemiBold :
Font.Normal
color: (model.level === 0) ? UbuntuColors.midAubergine
=== modified file 'tests/autopilot/ubuntu_docviewer_app/__init__.py'
--- tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-04-14 15:37:06
+
+++ tests/autopilot/ubuntu_docviewer_app/__init__.py 2015-05-06 20:12:16
+
@@ -20,6 +20,7 @@
from autopilot import logging as autopilot_logging
logger = logging.getLogger(__name__)
+from autopilot.introspection import dbus
import ubuntuuitoolkit
@@ -58,10 +59,20 @@
return self.wait_select_single(PdfView)
@autopilot_logging.log_action(logger.info)
+def open_PdfContentsPage(self):
+Open the PdfContents Page.
+
+:return the PdfContents Page
+
+
+return self.wait_select_single(PdfContentsPage)
+
+@autopilot_logging.log_action(logger.info)
def get_PdfViewGotoDialog(self):
Return a dialog emulator
return self.wait_select_single(objectName=PdfViewGotoDialog)
+@autopilot_logging.log_action(logger.info)
def go_to_page_from_dialog(self, page_no):
Go to page from get_PfdViewGotoDialog
textfield = self.wait_select_single(
@@ -70,6 +81,12 @@
go_button = self.wait_select_single(Button, objectName=GOButton)
self.pointing_device.click_object(go_button)
+@autopilot_logging.log_action(logger.info)
+def click_go_to_page_button(self):
+Click the go_to_page header button.
+header = self.get_header()
+
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:430 http://91.189.93.70:8080/job/reminders-app-ci/743/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2726 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2726/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/345 SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/165 Click here to trigger a rebuild: http://91.189.93.70:8080/job/reminders-app-ci/743/rebuild -- https://code.launchpad.net/~canonical-platform-qa/reminders-app/update_token/+merge/258646 Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-renderwidth/+merge/258564 -- Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app
Review: Approve continuous-integration -- https://code.launchpad.net/~mzanetti/reminders-app/fix-renderwidth/+merge/258564 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/update_token/+merge/258646 -- Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app has been updated. Description changed to: Before: $ autopilot3 run reminders.tests.test_evernote ... Ran 6 tests in 8.306s FAILED (failures=6) After: Ran 6 tests in 69.557s OK For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/update_token/+merge/258646 -- Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/update_token/+merge/258646 -- Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app
Review: Approve pass! -- https://code.launchpad.net/~canonical-platform-qa/reminders-app/update_token/+merge/258646 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/still-that-focus/+merge/258566 -- Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app
Review: Approve continuous-integration -- https://code.launchpad.net/~mzanetti/reminders-app/still-that-focus/+merge/258566 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/still-that-focus/+merge/258566 -- Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:146 http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/216/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2730 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2730/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/113 SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-vivid-amd64-ci/119 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/216/rebuild -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-update-settings-text into lp:ubuntu-weather-app/reboot
Review: Approve continuous-integration PASSED: Continuous integration, rev:38 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/86/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/56 SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/86 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/86/rebuild -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-update-settings-text/+merge/258701 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-update-settings-text into lp:ubuntu-weather-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/WeekNumber into lp:ubuntu-calendar-app
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/WeekNumber into lp:ubuntu-calendar-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/WeekNumber/+merge/255078 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ken-vandine/ubuntu-calendar-app/url_settings_fix into lp:ubuntu-calendar-app
Review: Approve looks fine to me -- https://code.launchpad.net/~ken-vandine/ubuntu-calendar-app/url_settings_fix/+merge/257571 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into lp:ubuntu-calendar-app
Originally we were destroying Pages to conserve memory, but it that's not issue anymore. Then this MR looks good to me. I will test some more and approve it. Thanks for MR and taking your time to improve calendar -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning/+merge/258449 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/WeekNumber into lp:ubuntu-calendar-app
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/WeekNumber into lp:ubuntu-calendar-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/WeekNumber/+merge/255078 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent into lp:ubuntu-calendar-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:630 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1161/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2732/console FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/632/console FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/158/console Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1161/rebuild -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefReminderTime into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:640 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1162/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2734 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2734/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/633 SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/159 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1162/rebuild -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefReminderTime/+merge/257743 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefReminderTime into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-start-add-location into lp:ubuntu-weather-app/reboot
Review: Approve continuous-integration PASSED: Continuous integration, rev:39 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/83/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/53 SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/83 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/83/rebuild -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-start-add-location/+merge/258685 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-start-add-location into lp:ubuntu-weather-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:631 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1163/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2735 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2735/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/634 SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/160 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1163/rebuild -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-fix-first-delegate-spacing into lp:ubuntu-weather-app/reboot
Here's a before screenshot with some markup text to point out the issue: http://i.imgur.com/KMR7xqO.png -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-fix-first-delegate-spacing/+merge/258703 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-fix-first-delegate-spacing into lp:ubuntu-weather-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-fix-first-delegate-spacing into lp:ubuntu-weather-app/reboot
Victor Thompson has proposed merging
lp:~vthompson/ubuntu-weather-app/reboot-fix-first-delegate-spacing into
lp:ubuntu-weather-app/reboot.
Commit message:
* Fix spacing/margin of first DayDelegate.
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-fix-first-delegate-spacing/+merge/258703
* Fix spacing/margin of first DayDelegate.
--
Your team Ubuntu Weather Developers is requested to review the proposed merge
of lp:~vthompson/ubuntu-weather-app/reboot-fix-first-delegate-spacing into
lp:ubuntu-weather-app/reboot.
=== modified file 'app/ui/LocationPane.qml'
--- app/ui/LocationPane.qml 2015-04-29 14:09:55 +
+++ app/ui/LocationPane.qml 2015-05-09 03:24:52 +
@@ -175,8 +175,9 @@
anchors {
top: locationTop.bottom
left: parent.left
+leftMargin: units.gu(2)
right: parent.right
-margins: units.gu(2)
+rightMargin: units.gu(2)
}
Repeater {
id: mainPageWeekdayListView
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely into lp:ubuntu-weather-app/reboot
Victor Thompson has proposed merging
lp:~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely into
lp:ubuntu-weather-app/reboot.
Commit message:
* Fix migration of kmh to kph
* Add migration fixes for when the settings have not been added/changed
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely/+merge/258699
* Fix migration of kmh to kph
* Add migration fixes for when the settings have not been added/changed
This fixes the migration of using kmh to using kph and also adds fixes for
migrating settings data that hadn't been changed from the defaults. When a
setting is not changed it is not in the db.
--
Your team Ubuntu Weather Developers is requested to review the proposed merge
of lp:~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely into
lp:ubuntu-weather-app/reboot.
=== modified file 'app/data/Storage.qml'
--- app/data/Storage.qml 2015-03-03 18:37:59 +
+++ app/data/Storage.qml 2015-05-09 00:46:01 +
@@ -70,13 +70,32 @@
console.debug(Migrating old data:, JSON.stringify(oldSettings))
+var metric = Qt.locale().measurementSystem === Locale.MetricSystem
+
// Move to new Settings API
settings.migrated = true
-settings.precipUnits = oldSettings[precip_units]
-settings.service = oldSettings[service]
-settings.tempScale = ° + (oldSettings[units] === metric ? C : F)
-settings.units = oldSettings[units]
-settings.windUnits = oldSettings[wind_units]
+settings.service = oldSettings[service] === undefined ? weatherchannel : oldSettings[service]
+
+if (oldSettings[precip_units] !== undefined) {
+settings.precipUnits = oldSettings[precip_units]
+} else {
+ settings.precipUnits = metric ? mm : in
+}
+
+if (oldSettings[units] !== undefined) {
+settings.tempScale = oldSettings[units] === metric ? °C : °F
+settings.units = oldSettings[units]
+} else {
+settings.tempScale = metric ? °C : °F
+settings.units = metric ? metric : imperial
+}
+
+if (oldSettings[units] !== undefined) {
+// If old wind speed was in kmh use kph instead
+settings.windUnits = oldSettings[wind_units] === kmh ? kph : oldSettings[wind_units]
+} else {
+settings.windUnits = metric ? kph : mph
+}
/*
TODO: uncomment when reboot is ready to replace existing app
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-update-settings-text into lp:ubuntu-weather-app/reboot
Victor Thompson has proposed merging
lp:~vthompson/ubuntu-weather-app/reboot-update-settings-text into
lp:ubuntu-weather-app/reboot.
Commit message:
* Display a more readable version of the data provider names
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-update-settings-text/+merge/258701
* Display a more readable version of the data provider names
--
Your team Ubuntu Weather Developers is requested to review the proposed merge
of lp:~vthompson/ubuntu-weather-app/reboot-update-settings-text into
lp:ubuntu-weather-app/reboot.
=== modified file 'app/ui/settings/DataProviderPage.qml'
--- app/ui/settings/DataProviderPage.qml 2015-03-20 00:36:07 +
+++ app/ui/settings/DataProviderPage.qml 2015-05-09 01:17:16 +
@@ -26,8 +26,8 @@
ListModel {
id: dataProviderModel
-ListElement { text: openweathermap }
-ListElement { text: weatherchannel }
+ListElement { text: OpenWeatherMap }
+ListElement { text: The Weather Channel }
}
ExpandableListItem {
@@ -36,12 +36,16 @@
listViewHeight: dataProviderModel.count*units.gu(6) - units.gu(1)
model: dataProviderModel
text: i18n.tr(Provider)
-subText: settings.service
+subText: settings.service === weatherchannel ? The Weather Channel : OpenWeatherMap
delegate: ListItem.Standard {
text: model.text
onClicked: {
-settings.service = model.text
+if (model.text === The Weather Channel) {
+settings.service = weatherchannel
+} else {
+settings.service = openweathermap
+}
refreshData(false, true)
}
@@ -49,7 +53,7 @@
width: units.gu(2)
height: width
name: ok
-visible: settings.service === model.text
+visible: dataProviderSetting.subText === model.text
anchors.right: parent.right
anchors.rightMargin: units.gu(2)
anchors.verticalCenter: parent.verticalCenter
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely into lp:ubuntu-weather-app/reboot
Review: Approve continuous-integration PASSED: Continuous integration, rev:38 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/84/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/54 SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/84 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/84/rebuild -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely/+merge/258699 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely into lp:ubuntu-weather-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely into lp:ubuntu-weather-app/reboot
Review: Approve continuous-integration PASSED: Continuous integration, rev:39 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/85/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/55 SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/85 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/85/rebuild -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely/+merge/258699 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-migrate-to-kph-nicely into lp:ubuntu-weather-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
