Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into lp:ubuntu-calendar-app
sorry forgot about this MR, I will test this today night before calendar meeting and approve. -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning/+merge/258449 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into lp:ubuntu-calendar-app
Kunal, have u fun with this MR. Still two clear UI bugs has been fixed. Pls approve. BTW: Have u check this one on ur devices? it's marked as FIX COMMITTED. https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1438910 I can see it's still exciting with latest repo on 15.04(r211) -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning/+merge/258449 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/refactor-readme-update into lp:music-app/refactor
Review: Approve continuous-integration PASSED: Continuous integration, rev:858 http://91.189.93.70:8080/job/music-app-refactor-ci/79/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2739 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2739/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-utopic-amd64-ci/37 SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/79 Click here to trigger a rebuild: http://91.189.93.70:8080/job/music-app-refactor-ci/79/rebuild -- https://code.launchpad.net/~vthompson/music-app/refactor-readme-update/+merge/259061 Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/refactor-readme-update into lp:music-app/refactor. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/refactor-readme-update into lp:music-app/refactor
Victor Thompson has proposed merging lp:~vthompson/music-app/refactor-readme-update into lp:music-app/refactor. Commit message: * Update autopilot readme for new app structure. Requested reviews: Music App Developers (music-app-dev) For more details, see: https://code.launchpad.net/~vthompson/music-app/refactor-readme-update/+merge/259061 * Update autopilot readme for new app structure. -- Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/refactor-readme-update into lp:music-app/refactor. === modified file 'README.autopilot' --- README.autopilot 2014-11-13 00:54:17 + +++ README.autopilot 2015-05-13 23:52:26 + @@ -33,7 +33,7 @@ $ autopilot3 run -vv music_app.tests.test_music.TestMainWindow.test_swipe_to_delete_song Debugging tests using autopilot vis -$ autopilot3 launch -i Qt qmlscene music-app.qml +$ autopilot3 launch -i Qt qmlscene app/music-app.qml $ autopilot3 vis -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/misc-debug into lp:help-app
The proposal to merge lp:~dholbach/help-app/misc-debug into lp:help-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~dholbach/help-app/misc-debug/+merge/259011 -- Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/misc-debug into lp:help-app
The proposal to merge lp:~dholbach/help-app/misc-debug into lp:help-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/misc-debug/+merge/259011 -- Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433525 into lp:help-app
The proposal to merge lp:~dholbach/help-app/1433525 into lp:help-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~dholbach/help-app/1433525/+merge/258866 -- Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/misc-debug into lp:help-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:144 http://91.189.93.70:8080/job/help-app-ci/33/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/33 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/35 Click here to trigger a rebuild: http://91.189.93.70:8080/job/help-app-ci/33/rebuild -- https://code.launchpad.net/~dholbach/help-app/misc-debug/+merge/259011 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/misc-debug into lp:help-app
Review: Approve LGTM. -- https://code.launchpad.net/~dholbach/help-app/misc-debug/+merge/259011 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433525 into lp:help-app
The proposal to merge lp:~dholbach/help-app/1433525 into lp:help-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/1433525/+merge/258866 -- Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433525 into lp:help-app
Review: Approve LGTM. Couldn't check on device; will do before release. -- https://code.launchpad.net/~dholbach/help-app/1433525/+merge/258866 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1436316 into lp:help-app
The proposal to merge lp:~dholbach/help-app/1436316 into lp:help-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~dholbach/help-app/1436316/+merge/259007 -- Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1436316 into lp:help-app
The proposal to merge lp:~dholbach/help-app/1436316 into lp:help-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/1436316/+merge/259007 -- Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1436316 into lp:help-app
Review: Approve LGTM. -- https://code.launchpad.net/~dholbach/help-app/1436316/+merge/259007 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/misc-debug into lp:help-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:143 http://91.189.93.70:8080/job/help-app-ci/32/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/32 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/34 Click here to trigger a rebuild: http://91.189.93.70:8080/job/help-app-ci/32/rebuild -- https://code.launchpad.net/~dholbach/help-app/misc-debug/+merge/259011 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/misc-debug into lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/misc-debug into lp:help-app
Daniel Holbach has proposed merging lp:~dholbach/help-app/misc-debug into lp:help-app with lp:~dholbach/help-app/1433525 as a prerequisite. Commit message: Add --inspector arg for ubuntu-html5-app-launcher to DEBUG=1 case in Makefile, document it and pelican's more verbose output. Requested reviews: Ubuntu Help app developers (help-app-dev) For more details, see: https://code.launchpad.net/~dholbach/help-app/misc-debug/+merge/259011 Add --inspector arg for ubuntu-html5-app-launcher to DEBUG=1 case in Makefile, document it and pelican's more verbose output. -- Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/misc-debug into lp:help-app. === modified file 'HACKING' --- HACKING 2015-05-13 15:15:10 + +++ HACKING 2015-05-13 15:15:10 + @@ -163,6 +163,23 @@ make check +Debugging +- + +Did you find a bug and you're not sure how to debug it? + +Adding DEBUG=1 to the make command will give you additional information +in a few cases. For example will + + - pelican print out debug information, which is very useful if you + are changing pelican configuration options or are playing around + with markdown extensions. + - 'make launch' will add the --inspector argument to + ubuntu-html5-app-launcher. This will allow you to point your webkit- + enabled browser to http://:9221 to examine some of the + web attributes of the app. + + Running the app on a phone -- === modified file 'Makefile' --- Makefile 2015-03-31 08:24:35 + +++ Makefile 2015-05-13 15:15:10 + @@ -1,6 +1,7 @@ PY?=python PELICAN?=pelican PELICANOPTS= +APP_ARGS= BASEDIR=$(CURDIR) INTERNALS_DIR=$(BASEDIR)/internals @@ -21,6 +22,7 @@ DEBUG ?= 0 ifeq ($(DEBUG), 1) PELICANOPTS += -D + APP_ARGS += --inspector endif MD_FILES=$(wildcard $(INPUTDIR)/pages/*.md) @@ -75,7 +77,7 @@ cd $(APP_DIR) && click build . && mv *.click $(BASEDIR) launch: app - cd $(APP_DIR); `grep '^Exec' help.desktop | tail -1 | sed 's/^Exec=//' | sed 's/%.//'` & + cd $(APP_DIR); `grep '^Exec' help.desktop | tail -1 | sed 's/^Exec=//' | sed 's/%.//'` $(APP_ARGS) & update-pot: cd $(INTERNALS_DIR) && ./generate-pot === modified file 'internals/pelicanconf.py' --- internals/pelicanconf.py 2015-05-13 15:15:10 + +++ internals/pelicanconf.py 2015-05-13 15:15:10 + @@ -54,7 +54,8 @@ TAG_SAVE_AS = '' THEME = TOP_LEVEL_DIR+'static/themes/app/' -MD_EXTENSIONS = ['local.q-and-a', 'local.external-links', 'attr_list', 'toc'] +MD_EXTENSIONS = ['local.q-and-a', 'local.external-links', + 'attr_list', 'toc'] META_TAGS = [ '[TOC]', -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1436316 into lp:help-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:134 http://91.189.93.70:8080/job/help-app-ci/31/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/31 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/33 Click here to trigger a rebuild: http://91.189.93.70:8080/job/help-app-ci/31/rebuild -- https://code.launchpad.net/~dholbach/help-app/1436316/+merge/259007 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/1436316 into lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1436316 into lp:help-app
Daniel Holbach has proposed merging lp:~dholbach/help-app/1436316 into lp:help-app. Commit message: Don't sys.exit() if Markdown instatiation fails, catch error in tests and elsewhere. Requested reviews: Ubuntu Help app developers (help-app-dev) Related bugs: Bug #1436316 in Ubuntu Help App: "Don't sys.exit() in Markdown() instantiation" https://bugs.launchpad.net/help-app/+bug/1436316 For more details, see: https://code.launchpad.net/~dholbach/help-app/1436316/+merge/259007 Don't sys.exit() if Markdown instatiation fails, catch error in tests and elsewhere. -- Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/1436316 into lp:help-app. === modified file 'internals/tests/test_markdown.py' --- internals/tests/test_markdown.py 2015-03-23 15:53:43 + +++ internals/tests/test_markdown.py 2015-05-13 14:35:20 + @@ -10,14 +10,22 @@ TestCase.__init__(self, *args) def test_load_extensions(self): -md = utils.Markdown() +try: +md = utils.Markdown() +except ImportError: +md = None +self.assertIsNotNone(md) for ext in MD_EXTENSIONS: self.assertTrue(ext in md.md.treeprocessors or ext in [q.__module__ for q in md.md.registeredExtensions]) def test_convert_all_docs(self): -md = utils.Markdown() +try: +md = utils.Markdown() +except ImportError: +md = None +self.assertIsNotNone(md) docs = Documents() self.assertEqual(len(docs.docs), len([md.can_convert_md_file(fn) for fn === modified file 'internals/translations/build.py' --- internals/translations/build.py 2015-03-31 11:38:30 + +++ internals/translations/build.py 2015-05-13 14:35:20 + @@ -233,9 +233,15 @@ class Documents(object): def __init__(self): -md = Markdown() -self.docs = [fn for fn in self.find_docs() - if verify_file_type(fn) and md.can_convert_md_file(fn)] +try: +md = Markdown() +except ImportError: +md = None +self.docs = [] +if md: +self.docs = \ +[fn for fn in self.find_docs() + if verify_file_type(fn) and md.can_convert_md_file(fn)] def find_docs(self): docs = [] === modified file 'internals/translations/utils.py' --- internals/translations/utils.py 2015-03-31 07:57:56 + +++ internals/translations/utils.py 2015-05-13 14:35:20 + @@ -69,10 +69,10 @@ try: self.md = markdown.Markdown(extensions=MD_EXTENSIONS) except ImportError: +print('Could not load all markdown extensions.') +raise +finally: os.chdir(pwd) -print('Could not load all markdown extensions.') -sys.exit(1) -os.chdir(pwd) def can_convert_md_file(self, fn): (ret, tmp) = tempfile.mkstemp() -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433525 into lp:help-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:141 http://91.189.93.70:8080/job/help-app-ci/30/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/30 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/32 Click here to trigger a rebuild: http://91.189.93.70:8080/job/help-app-ci/30/rebuild -- https://code.launchpad.net/~dholbach/help-app/1433525/+merge/258866 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/1433525 into lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433525 into lp:help-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:140 http://91.189.93.70:8080/job/help-app-ci/29/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/29 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/31 Click here to trigger a rebuild: http://91.189.93.70:8080/job/help-app-ci/29/rebuild -- https://code.launchpad.net/~dholbach/help-app/1433525/+merge/258866 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/1433525 into lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433525 into lp:help-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:139 http://91.189.93.70:8080/job/help-app-ci/28/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/28 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/30 Click here to trigger a rebuild: http://91.189.93.70:8080/job/help-app-ci/28/rebuild -- https://code.launchpad.net/~dholbach/help-app/1433525/+merge/258866 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/1433525 into lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433525 into lp:help-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:138 http://91.189.93.70:8080/job/help-app-ci/27/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/27/console FAILURE: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/29/console Click here to trigger a rebuild: http://91.189.93.70:8080/job/help-app-ci/27/rebuild -- https://code.launchpad.net/~dholbach/help-app/1433525/+merge/258866 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/1433525 into lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp