Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02 into lp:ubuntu-filemanager-app

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:461
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/549/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/171

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/549/rebuild

-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02/+merge/270335
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/fix-1490040 into lp:ubuntu-weather-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:126
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/251/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/221
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/251

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/251/rebuild

-- 
https://code.launchpad.net/~vthompson/ubuntu-weather-app/fix-1490040/+merge/271741
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~vthompson/ubuntu-weather-app/fix-1490040 into 
lp:ubuntu-weather-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/fix-1490040 into lp:ubuntu-weather-app/reboot

[Victor Thompson]

Victor Thompson has proposed merging 
lp:~vthompson/ubuntu-weather-app/fix-1490040 into lp:ubuntu-weather-app/reboot.

Commit message:
* Show the bottom loading animation (LoadingIndicator) on the LocationsPage.

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
  Bug #1490040 in Ubuntu Weather App: "[reboot] Locations list page should show 
bouncing animation"
  https://bugs.launchpad.net/ubuntu-weather-app/+bug/1490040

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/fix-1490040/+merge/271741

* Show the bottom loading animation (LoadingIndicator) on the LocationsPage.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~vthompson/ubuntu-weather-app/fix-1490040 into 
lp:ubuntu-weather-app/reboot.
=== modified file 'app/ui/LocationsPage.qml'
--- app/ui/LocationsPage.qml	2015-09-10 23:43:49 +
+++ app/ui/LocationsPage.qml	2015-09-19 22:57:09 +
@@ -258,6 +258,10 @@
 }
 }
 
+LoadingIndicator {
+id: loadingIndicator
+}
+
 Loader {
 active: locationsList === null || locationsList.length === 0
 anchors {

=== modified file 'debian/changelog'
--- debian/changelog	2015-09-14 19:59:26 +
+++ debian/changelog	2015-09-19 22:57:09 +
@@ -26,6 +26,7 @@
   * Add a Network Error State Component for when a connection error takes place.
   * Allow the LocationsPage to be flickable. (LP: #1490044)
   * Make sure the text elides on the LocationsPage and the AddLocationPage. (LP: #1469460)
+  * Show the bottom loading animation (LoadingIndicator) on the LocationsPage. (LP: #1490040)
 
   [ Andrew Hayzen ]
   * Add mocked locations for autopilot and add a test using the data

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:177
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/34/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/34

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/34/rebuild

-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis/+merge/271466
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

Huh, I got it.

I tried to avoid to import Ubuntu.Content module in the views.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis/+merge/271466
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

> Should be rewritten as:
> property bool multipleSelection: !activeTransfer || 
> activeTransfer.selectionType !== ContentTransfer.Single
> But looks strange anyway. Why do we allow multiple selection when transfer 
> isn't acitve?

Good point.

Also, in DocumentGridView.qml and DocumentGrid|List)View.qml I wrote:
multipleSelection: contentHubProxy.multipleSelection ? 
contentHubProxy.multipleSelection : false

That "false" is completely dumb.

We allow multiple selection to delete more files at once in the documents 
browser.
In the attempt of using a single property to set the multipleSelection value in 
the views, I've added the check for an active transfer in the ContentHubProxy.

Then I presume I forgot that ContentHubProxy is loaded asynchronously, and 
added that false in the views code.

I'll rewrite this piece of code, removing the property from ContentHubProxy, 
and setting everything directly in the views, keeping it more verbose.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis/+merge/271466
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1379726] Re: Need an images cache plugin

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1379726

Title:
  Need an images cache plugin

Status in Ubuntu Shorts App:
  Fix Released

Bug description:
  We need to cache the article images we get from the net, so that we
  don't incur on data charges every time we read the same article. This
  probably can't be done with QML alone, and it might be worth exploring
  the creation of a QML plugin in C++ that does that caching, and if
  there is any way we can take advantage of any existing services to
  help with that (e.g. the Thumbnailer service).

  In Unity 8, here's how they do caching:

  http://bazaar.launchpad.net/~unity-
  team/unity8/trunk/view/head:/src/Dash/main.cpp#L103

  Cheers,
  David.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1379726/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1272627] Re: The "Add online accounts" and "Import subscriptions" actions should be removed until implemented

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1272627

Title:
  The "Add online accounts" and "Import subscriptions" actions should be
  removed until implemented

Status in Ubuntu Shorts App:
  Fix Released

Bug description:
  Both these actions could cause confusion as they do not do anything at
  the moment. Until these are implemented, it would make else to not
  display these options.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1272627/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1467001] Re: [Reboot] Delete text overlaps topic label

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Importance: Undecided => Low

** Changed in: ubuntu-rssreader-app
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1467001

Title:
  [Reboot] Delete text overlaps topic label

Status in Ubuntu Shorts App:
  Fix Released

Bug description:
  When deleting a topic by swiping to the right/left, the "Remove" text
  overlaps the topic label. Attached is a screenshot which shows the
  overlapping issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1467001/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1311800] Re: Remove custom swipe to delete

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Status: Confirmed => Fix Released

** Changed in: ubuntu-rssreader-app
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1311800

Title:
  Remove custom swipe to delete

Status in Ubuntu Music App:
  Fix Released
Status in Ubuntu Shorts App:
  Fix Released

Bug description:
  According to ahayzen we have a custom swipe to delete because you
  cannot do reordering with the SDK swipedelete due to the mouse focus
  being stolen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/music-app/+bug/1311800/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1267870] Re: Adjust "add feed" screen for desktop usage

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Importance: Low => Wishlist

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1267870

Title:
  Adjust "add feed" screen for desktop usage

Status in Ubuntu Shorts App:
  Confirmed

Bug description:
  Add feed takes up full screen and could probably benefit from being a
  sheet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1267870/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1219301] Re: Allow sharing articles using the friends api

[Roman Shchekin]

Solved via contenthub.

** Changed in: ubuntu-rssreader-app
   Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1219301

Title:
  Allow sharing articles using the friends api

Status in Ubuntu Shorts App:
  Fix Released
Status in Ubuntu UX:
  Fix Committed

Bug description:
  Not sure if this is the kind of thing that needs design input or not,
  but sharing an article is a basic task expected in an RSS app. The
  Friends API makes this simple on Ubuntu.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1219301/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1228576] Re: Slider's tooltip cropped by parent popover

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1228576

Title:
  Slider's tooltip cropped by parent popover

Status in Ubuntu Shorts App:
  Fix Released
Status in ubuntu-ui-toolkit package in Ubuntu:
  Confirmed

Bug description:
  Look screenshot

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1228576/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1467007] Re: [Reboot] Changed the Saved Tab into a HeaderSection filter

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Importance: Undecided => Wishlist

** Changed in: ubuntu-rssreader-app
   Status: New => Opinion

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1467007

Title:
  [Reboot] Changed the Saved Tab into a HeaderSection filter

Status in Ubuntu Shorts App:
  Opinion

Bug description:
  Personally I feel that instead of having a dedicated "Saved tab" it
  would better if it is changed into a header section [1] since it is
  after all a special filter. My proposed design is,

  In the "Shorts tab", having two header sections ["All", "Saved"]. As
  the name suggests "All" shows all article while "Saved" shows the
  saved articles.

  [1]
  
https://developer.ubuntu.com/api/apps/qml/sdk-15.04/Ubuntu.Components.PageHeadSections/

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1467007/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1467003] Re: [Reboot] ListItem delete action uses the old design

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Importance: Undecided => Low

** Changed in: ubuntu-rssreader-app
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1467003

Title:
  [Reboot] ListItem delete action uses the old design

Status in Ubuntu Shorts App:
  Fix Released

Bug description:
  When deleting a topic or feed, I noticed that shorts reboot uses the
  old design for list item deletion. Please switch to the new listitems
  provided by the Ubuntu SDK and follow the new design pattern which
  involves showing a trash icon against a red background for consistency
  purposes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1467003/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1492643] Re: no clear way to remove feeds in shorts

[Roman Shchekin]

** Changed in: ubuntu-rssreader-app
   Importance: Undecided => Wishlist

** Changed in: ubuntu-rssreader-app
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1492643

Title:
  no clear way to remove feeds in shorts

Status in Ubuntu Shorts App:
  Fix Released

Bug description:
  I've spent 30 minutes trying to find a way to remove feeds in shorts,
  and I can't find a way to do it... searching online seems to reveal
  only comments from people who had similar problems and some launchpad
  pages detailing delete feed code being removed... I'm sure this is not
  correct, but I'm at a loss, something must be wrong with the UI design
  if no one can figure out how to do this...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1492643/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported into lp:ubuntu-docviewer-app/reboot

[Roman Shchekin]

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported
 into lp:ubuntu-docviewer-app/reboot has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported/+merge/271468
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported
 into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations into lp:ubuntu-docviewer-app/reboot

[Roman Shchekin]

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations
 into lp:ubuntu-docviewer-app/reboot has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations/+merge/271467
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations
 into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06 into lp:ubuntu-filemanager-app

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:466
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/548/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/170

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/548/rebuild

-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06/+merge/271738
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06 into 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Roman Shchekin]

Review: Approve

Left few comments in code. Overall feeling - ok.

Diff comments:

> 
> === added file 'src/app/qml/common/ContentHubProxy.qml'
> --- src/app/qml/common/ContentHubProxy.qml1970-01-01 00:00:00 +
> +++ src/app/qml/common/ContentHubProxy.qml2015-09-19 15:40:39 +
> @@ -0,0 +1,137 @@
> +/*
> + * Copyright (C) 2012-2014 Canonical, Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 3.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see .
> + */
> +
> +import QtQuick 2.3
> +import Ubuntu.Content 1.1
> +import DocumentViewer 1.0
> +
> +// TODO: Show a dialog asking for the destination (internal storage or SD 
> card)
> +
> +Item {
> +id: contentHubProxy
> +
> +property var activeTransfer
> +
> +property alias rejectedDocuments: rejectedDocsModel
> +property alias importedDocuments: importedDocsModel
> +
> +property bool multipleSelection: activeTransfer ? 
> (activeTransfer.selectionType !== ContentTransfer.Single) : true

Should be rewritten as:
property bool multipleSelection: !activeTransfer || 
activeTransfer.selectionType !== ContentTransfer.Single
But looks strange anyway. Why do we allow multiple selection when transfer 
isn't acitve?

> +
> +ListModel { id: rejectedDocsModel }
> +ListModel { id: importedDocsModel }
> +
> +ContentTransferHint {
> +activeTransfer: contentHubProxy.activeTransfer
> +}
> +
> +Connections {
> +target: ContentHub
> +
> +onImportRequested: {
> + activeTransfer = transfer;

We do not use semicolons, so it's better to remove here too.

> +
> +if (activeTransfer.state === ContentTransfer.Charged) {
> +mainView.switchToBrowseMode()
> +
> +internal.clearModels()
> +
> +for (var i=0; i +var sourcePath = 
> internal.getPathFromUrl(activeTransfer.items[i].url)
> +
> +if (DocumentViewer.isFileSupported(sourcePath)) {
> +var documentsLocation = 
> DocumentViewer.getXdgDocumentsLocation()
> +var destPath = 
> DocumentViewer.buildDestinationPath(documentsLocation, sourcePath);
> +
> +internal.importDocument(sourcePath, destPath)
> +
> +} else {
> +// Document is not supported, append its entry into 
> the
> +// rejected documents model, so that we can inform 
> the
> +// user of what happened.
> +rejectedDocsModel.append({ path: sourcePath })
> +}
> +}
> +
> +internal.finalizeImport()
> +
> +internal.handleNotifications()
> +}
> +}
> +
> +onExportRequested: {
> +activeTransfer = transfer;

And here.

> +mainView.switchToPickMode()
> +}
> +}
> +
> +QtObject {
> +id: internal
> +
> +function __openDocument() {
> +if (contentHubProxy.importedDocuments.count > 1) {
> +// If it has been imported more than a document, show
> +// a file picker when user taps the "open" action.
> +PopupUtils.open(
> +Qt.resolvedUrl("common/PickImportedDialog.qml"),
> +mainView,
> +{
> +parent: mainView,
> +model: contentHubProxy.importedDocuments
> +});
> +} else {
> +// It has been imported just a document, open it when
> +// user taps the action button.
> +
> mainView.openDocument(contentHubProxy.importedDocuments.get(0).path);
> +}
> +}
> +
> +function clearModels() {
> +rejectedDocsModel.clear()
> +importedDocsModel.clear()
> +}
> +
> +function getPathFromUrl(url) {
> +return url.toString().replace("file://", "")
> +}
> +
> +function importDocument(sourcePath, destPath) {
> +DocumentViewer.copy(sourcePath, destPath);
> +importedDocsModel.append({ path: destPath })
> +}
> +
> +function finalizeImport() {
> +activeTransfer.finalize()
> +}
> +
> +function handleNotifications() {
> +// Check if there's any

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06 into lp:ubuntu-filemanager-app

[Carlos Jose Mazieri]

Carlos Jose Mazieri has proposed merging 
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06 into 
lp:ubuntu-filemanager-app with 
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 as a prerequisite.

Commit message:
Fixed problems in the Authentication and using saved Password

Requested reviews:
  Ubuntu File Manager Developers (ubuntu-filemanager-dev)

For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06/+merge/271738

Fixed problems in the Authentication and using saved Password
-- 
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06 into 
lp:ubuntu-filemanager-app.
=== modified file 'src/plugin/folderlistmodel/diriteminfo.cpp'
--- src/plugin/folderlistmodel/diriteminfo.cpp	2015-09-19 16:16:16 +
+++ src/plugin/folderlistmodel/diriteminfo.cpp	2015-09-19 16:16:16 +
@@ -407,7 +407,7 @@
 
 QString DirItemInfo::authenticationPath() const
 {
-return QLatin1String(0);
+return  d_ptr->_authenticationPath;
 }
 
 

=== modified file 'src/plugin/folderlistmodel/diriteminfo.h'
--- src/plugin/folderlistmodel/diriteminfo.h	2015-09-19 16:16:16 +
+++ src/plugin/folderlistmodel/diriteminfo.h	2015-09-19 16:16:16 +
@@ -176,6 +176,7 @@
 QString   _path;
 QString   _fileName;
 QString   _normalizedPath;
+QString   _authenticationPath;
 
 static QMimeDatabase mimeDatabase;
 };

=== modified file 'src/plugin/folderlistmodel/dirmodel.cpp'
--- src/plugin/folderlistmodel/dirmodel.cpp	2015-09-19 16:16:16 +
+++ src/plugin/folderlistmodel/dirmodel.cpp	2015-09-19 16:16:16 +
@@ -978,11 +978,24 @@
 bool  DirModel::cdIntoItem(const DirItemInfo &fi)
 {
 bool ret = false;
+const DirItemInfo *item = &fi;
+DirItemInfo *created_itemInfo = 0;
 if (fi.isBrowsable())
-{
-bool authentication = fi.needsAuthentication() &&
-  !mCurLocation->useAuthenticationDataIfExists(fi);
-if (authentication)
+{  
+bool needs_authentication = fi.needsAuthentication();
+if (needs_authentication)
+{
+   if (mCurLocation->useAuthenticationDataIfExists(fi))
+   {
+   //there is a password stored to try
+   created_itemInfo = mCurLocation->newItemInfo(fi.urlPath());
+   item = created_itemInfo;
+   needs_authentication = item->needsAuthentication();
+   }
+}
+//item needs authentication and there is no user/password to try
+// or there is a user/password already used but failed
+if (needs_authentication)
 {
 mCurLocation->notifyItemNeedsAuthentication(&fi);
 //return true to avoid any error message to appear
@@ -990,15 +1003,23 @@
 ret = true;
 }
 else
-{
-if (fi.isContentReadable())
+{  
+if (item->isContentReadable())
 {
-mCurLocation->setInfoItem(fi);
+mCurLocation->setInfoItem(*item);
 setPathFromCurrentLocation();
 ret = true;
 }
+else
+{
+//some other error
+}
 }
 }
+if (created_itemInfo != 0)
+{
+delete created_itemInfo;
+}
 return ret;
 }
 

=== modified file 'src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.cpp'
--- src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.cpp	2015-07-13 20:41:48 +
+++ src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.cpp	2015-09-19 16:16:16 +
@@ -92,14 +92,11 @@
 break;
 }
 //all the information should be in place now
-fillFromStatBuf(st);
-}
-
-
-QString SmbItemInfo::authenticationPath() const
-{
-return sharePath();
-}
+fillFromStatBuf(st);
+//set the field here to use on any DirItemInfo object
+d_ptr->_authenticationPath = sharePath();
+}
+
 
 /*!
  * \brief SmbItemInfo::sharePath() returns the share part of the item

=== modified file 'src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.h'
--- src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.h	2015-03-14 17:38:50 +
+++ src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.h	2015-09-19 16:16:16 +
@@ -41,8 +41,7 @@
 
 public:
 QString  sharePath() const;
-void setAsShare();
-virtual QString  authenticationPath() const;
+void setAsShare();  
 virtual void setFile(const QString &dir, const QString & file);
 
 protected:

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:176
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/33/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/33

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/33/rebuild

-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis/+merge/271466
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis
 into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into lp:ubuntu-docviewer-app/reboot

[noreply]

The proposal to merge 
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into 
lp:ubuntu-docviewer-app/reboot has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading/+merge/271737
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-use-device-dpis into lp:ubuntu-docviewer-app/reboot

[noreply]

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-use-device-dpis into 
lp:ubuntu-docviewer-app/reboot has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-use-device-dpis/+merge/270850
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

Review: Approve

LGTM
-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading/+merge/271737
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

The proposal to merge 
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into 
lp:ubuntu-docviewer-app/reboot has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading/+merge/271737
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into lp:ubuntu-docviewer-app/reboot

[noreply]

The proposal to merge 
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into 
lp:ubuntu-docviewer-app/reboot has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine/+merge/271733
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:175
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/32/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/32

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/32/rebuild

-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis/+merge/271466
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis
 into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

Review: Needs Fixing

It works well, just move the header states outside the component.

Diff comments:

> 
> === added file 'src/app/qml/loView/LOViewPage.qml'
> --- src/app/qml/loView/LOViewPage.qml 1970-01-01 00:00:00 +
> +++ src/app/qml/loView/LOViewPage.qml 2015-09-19 14:21:26 +
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright (C) 2013-2015 Canonical, Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 3.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see .
> + */
> +
> +import QtQuick 2.3
> +import Ubuntu.Components 1.1
> +import DocumentViewer.LibreOffice 1.0 as LO
> +
> +import "../common/utils.js" as Utils
> +import "../upstreamComponents"
> +
> +Page {
> +id: loPage
> +title: Utils.getNameOfFile(file.path);
> +
> +// Disable header auto-hide.
> +flickable: null
> +
> +Loader {
> +id: contentLoader
> +
> +asynchronous: true
> +anchors.fill: parent
> +sourceComponent: loPageContentComponent
> +}
> +
> +ActivityIndicator {
> +running: contentLoader.status != Loader.Ready
> +visible: running
> +anchors.centerIn: parent
> +}
> +
> +Component {
> +id: loPageContentComponent
> +
> +Item {
> +property alias loDocument: loView.document
> +
> +LO.Viewer {
> +id: loView
> +objectName: "loView"
> +anchors.fill: parent
> +
> +clip: true
> +documentPath: file.path
> +
> +Component.onCompleted: {
> +// WORKAROUND: Fix for wrong grid unit size
> +flickDeceleration = 1500 * units.gridUnit / 8
> +maximumFlickVelocity = 2500 * units.gridUnit / 8
> +}
> +}
> +
> +Scrollbar { flickableItem: loView }
> +Scrollbar { flickableItem: loView; align: Qt.AlignBottom }
> +
> +// *** HEADER ***

Header states should stay outside the component.

> +state: "default"
> +states: LOViewDefaultHeader {
> +name: "default"
> +targetPage: loPage
> +}
> +}
> +}
> +}


-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading/+merge/271737
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:174
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/31/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/31

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/31/rebuild

-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis/+merge/271466
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis
 into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-use-device-dpis into lp:ubuntu-docviewer-app/reboot

[Roman Shchekin]

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-use-device-dpis into 
lp:ubuntu-docviewer-app/reboot has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-use-device-dpis/+merge/270850
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

The proposal to merge 
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into 
lp:ubuntu-docviewer-app/reboot has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine/+merge/271733
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

Review: Approve

Now it looks good to me, thank you!
-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine/+merge/271733
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:188
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/30/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/30

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/30/rebuild

-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading/+merge/271737
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:185
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/29/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/29

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/29/rebuild

-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine/+merge/271733
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into lp:ubuntu-docviewer-app/reboot

[Roman Shchekin]

Roman Shchekin has proposed merging 
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into 
lp:ubuntu-docviewer-app/reboot.

Commit message:
Async lok loading 

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1495069 in Ubuntu Document Viewer App: "Load LibreOffice program 
asynchronously"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1495069

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading/+merge/271737

Async lok loading (Must be merged after 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine/+merge/271733)
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-async-lok-loading into 
lp:ubuntu-docviewer-app/reboot.
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot	2015-09-16 19:13:16 +
+++ po/com.ubuntu.docviewer.pot	2015-09-19 14:21:26 +
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-09-09 19:15+0200\n"
+"POT-Creation-Date: 2015-09-19 17:18+0300\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME \n"
 "Language-Team: LANGUAGE \n"
@@ -33,7 +33,7 @@
 msgstr ""
 
 #: ../src/app/docviewer-application.cpp:171
-#: /tmp/build-reboot-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#: /home/qtros/dev/build-ubuntu-docviewer-app-async-lok-loading-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
 msgid "Document Viewer"
 msgstr ""
 
@@ -323,13 +323,6 @@
 msgid "Reverse order"
 msgstr ""
 
-#. TRANSLATORS: the first argument (%1) refers to the page currently shown on the screen,
-#. while the second one (%2) refers to the total pages count.
-#: ../src/app/qml/loView/LOView.qml:34 ../src/app/qml/pdfView/PdfView.qml:34
-#, qt-format
-msgid "Page %1 of %2"
-msgstr ""
-
 #: ../src/app/qml/loView/LOViewDefaultHeader.qml:57
 msgid "LibreOffice text document"
 msgstr ""
@@ -397,6 +390,13 @@
 msgid "Hide table of contents"
 msgstr ""
 
+#. TRANSLATORS: the first argument (%1) refers to the page currently shown on the screen,
+#. while the second one (%2) refers to the total pages count.
+#: ../src/app/qml/pdfView/PdfView.qml:34
+#, qt-format
+msgid "Page %1 of %2"
+msgstr ""
+
 #: ../src/app/qml/textView/TextView.qml:42
 msgid "Loading..."
 msgstr ""
@@ -411,6 +411,6 @@
 msgid "Open"
 msgstr ""
 
-#: /tmp/build-reboot-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#: /home/qtros/dev/build-ubuntu-docviewer-app-async-lok-loading-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:2
 msgid "documents;viewer;pdf;reader;"
 msgstr ""

=== modified file 'src/app/qml/common/loadComponent.js'
--- src/app/qml/common/loadComponent.js	2015-07-14 01:35:59 +
+++ src/app/qml/common/loadComponent.js	2015-09-19 14:21:26 +
@@ -35,7 +35,7 @@
 || mimetype === "application/msword"
 || mimetype === "application/vnd.ms-excel"
 || mimetype === "application/vnd.ms-powerpoint")
-qmlToLoad = Qt.resolvedUrl("../loView/LOView.qml")
+qmlToLoad = Qt.resolvedUrl("../loView/LOViewPage.qml")
 
 if (qmlToLoad != "") {
pageStack.push(qmlToLoad);

=== removed file 'src/app/qml/loView/LOView.qml'
--- src/app/qml/loView/LOView.qml	2015-07-04 16:00:33 +
+++ src/app/qml/loView/LOView.qml	1970-01-01 00:00:00 +
@@ -1,82 +0,0 @@
-/*
- * Copyright (C) 2013-2015 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see .
- */
-
-import QtQuick 2.3
-import Ubuntu.Components 1.1
-import DocumentViewer.LibreOffice 1.0 as LO
-
-import "../common/utils.js" as Utils
-import "../upstreamComponents"
-
-Page {
-id: loPage
-title: Utils.getNameOfFile(file.path);
-
-// Disable header auto-hide.
-// TODO: Show/hide header if a user taps the page
-flickable: null
-
-// TRANSLATORS: the first argument (%1) refers to the page currently shown on the screen,
-// while the second one (%2) refers to the total pages count.
-property string currentPage: i18n.tr("Page %1 of %2").arg(loView.currentPageIndex + 1).arg(loView.count)
-
-// Reset night mode shader settings when closing the page
-// Component.onDestruct

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:184
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/28/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/28

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/28/rebuild

-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine/+merge/271733
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:173
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/27/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/27

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/27/rebuild

-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis/+merge/271466
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis
 into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:174
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/25/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/25

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/25/rebuild

-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported/+merge/271468
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported
 into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:175
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/26/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/26

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/26/rebuild

-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations/+merge/271467
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations
 into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported
 into lp:ubuntu-docviewer-app/reboot with 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis
 as a prerequisite.

Commit message:
[ContentHub] Check if a file has been already imported in the past, and don't 
import it if that's the case

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1432394 in Ubuntu Document Viewer App: "[content-hub] Do not create new 
copy of a document, if it already exists in $HOME/Documents"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1432394

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported/+merge/271468

[ContentHub] Check if a file has been already imported in the past, and don't 
import it if that's the case
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/30-reboot-contenthub-dont-import-if-already-imported
 into lp:ubuntu-docviewer-app/reboot.
=== modified file 'src/app/qml/common/ContentHubProxy.qml'
--- src/app/qml/common/ContentHubProxy.qml	2015-09-19 11:56:00 +
+++ src/app/qml/common/ContentHubProxy.qml	2015-09-19 11:56:00 +
@@ -53,10 +53,20 @@
 
 if (DocumentViewer.isFileSupported(sourcePath)) {
 var documentsLocation = DocumentViewer.getXdgDocumentsLocation()
-var destPath = DocumentViewer.buildDestinationPath(documentsLocation, sourcePath);
-
-internal.importDocument(sourcePath, destPath)
-
+
+// Check if we have already imported the same document in the past.
+var earlierImportedFile = DocumentViewer.checkIfFileAlreadyImported(sourcePath, [documentsLocation])
+if (earlierImportedFile.length > 0) {
+// Document has been already imported in the past.
+// Append the path of the earlier copy of the
+// document in our model, so we can open it instead.
+importedDocsModel.append({ path: earlierImportedFile })
+} else {
+// No document has been found, so we can safely copy it.
+var destPath = DocumentViewer.buildDestinationPath(documentsLocation, sourcePath);
+
+internal.importDocument(sourcePath, destPath)
+}
 } else {
 // Document is not supported, append its entry into the
 // rejected documents model, so that we can inform the

=== modified file 'src/plugin/file-qml-plugin/documentviewersingleton.cpp'
--- src/plugin/file-qml-plugin/documentviewersingleton.cpp	2015-09-19 11:56:00 +
+++ src/plugin/file-qml-plugin/documentviewersingleton.cpp	2015-09-19 11:56:00 +
@@ -20,6 +20,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 bool DocumentViewerSingleton::exists(const QString &path)
 {
@@ -119,3 +121,39 @@
 
 return destination;
 }
+
+// Return the path of the file, if found in the storageLocation paths,
+// otherwise return an empty string.
+// Used for prevent importing of a second copy of a file through ContentHub.
+QString DocumentViewerSingleton::checkIfFileAlreadyImported(const QString &filePath, const QStringList &storageLocationList)
+{
+QFileInfo fi(filePath);
+QStringList files;
+
+// Get the list of all the files in the watched folders
+Q_FOREACH(const QString &storageLocation, storageLocationList) {
+QDirIterator dir(storageLocation, QDir::Files | QDir::NoDotAndDotDot | QDir::Readable,
+ QDirIterator::Subdirectories);
+
+while (dir.hasNext())
+{
+dir.next();
+files.append(dir.filePath());
+}
+}
+
+// Check if there's a file with the same name in the list
+Q_FOREACH(const QString &file, files) {
+if (file.endsWith(fi.fileName())) {
+// Seems there could be already the same file in the watched
+// folders. Check also size and lastModified date.
+QFileInfo fileToCheck(file);
+
+if (fi.size() == fileToCheck.size() &&
+fi.lastModified() == fileToCheck.lastModified())
+return file;
+}
+}
+
+return QString();
+}

=== modified file 'src/plugin/file-qml-plugin/documentviewersingleton.h'
--- src/plugin/file-qml-plugin/documentviewersingleton.h	2015-09-19 11:56:00 +
+++ src/plugin/file-qml-plugin/documentviewersingleton.h	2015-09-19 11:56:00 +
@@ -32,6 +32,8 @@
 Q_INVOKABLE static QString getXdgDocumentsLocation();
 
 Q_INVOKABLE 

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations
 into lp:ubuntu-docviewer-app/reboot with 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis
 as a prerequisite.

Commit message:
Updated translation template

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations/+merge/271467

Updated translation template
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/20-reboot-contenthub-update-translations
 into lp:ubuntu-docviewer-app/reboot.
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot	2015-09-16 19:13:16 +
+++ po/com.ubuntu.docviewer.pot	2015-09-19 11:53:58 +
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-09-09 19:15+0200\n"
+"POT-Creation-Date: 2015-09-19 13:53+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME \n"
 "Language-Team: LANGUAGE \n"
@@ -18,22 +18,8 @@
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
 
-#. TRANSLATORS: This string is used for renaming a copied file,
-#. when a file with the same name already exists in user's
-#. Documents folder.
-#.
-#. e.g. "Manual_Aquaris_E4.5_ubuntu_EN.pdf" will become
-#. "Manual_Aquaris_E4.5_ubuntu_EN (copy 2).pdf"
-#.
-#. where "2" is given by the argument "%1"
-#.
-#: ../src/app/content-communicator.cpp:105
-#, qt-format
-msgid "copy %1"
-msgstr ""
-
-#: ../src/app/docviewer-application.cpp:171
-#: /tmp/build-reboot-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#: ../src/app/docviewer-application.cpp:162
+#: /home/stefano/Progetti/docviewer/LAUNCHPAD/build-20-reboot-contenthub-update-translations-Desktop-Default/po/com.ubuntu.docviewer.desktop.in.in.h:1
 msgid "Document Viewer"
 msgstr ""
 
@@ -103,10 +89,6 @@
 msgstr[0] ""
 msgstr[1] ""
 
-#: ../src/app/qml/common/ToastWithAction.qml:97
-msgid "Dismiss"
-msgstr ""
-
 #: ../src/app/qml/common/UnknownTypeDialog.qml:26
 msgid "Unknown file type"
 msgstr ""
@@ -168,7 +150,7 @@
 msgstr[1] ""
 
 #: ../src/app/qml/documentPage/DeleteFileDialog.qml:44
-#: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:27
+#: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:28
 #: ../src/app/qml/loView/LOViewGotoDialog.qml:52
 #: ../src/app/qml/pdfView/PdfViewGotoDialog.qml:52
 msgid "Cancel"
@@ -225,23 +207,23 @@
 msgid "dd-MM- hh:mm"
 msgstr ""
 
-#: ../src/app/qml/documentPage/DocumentListView.qml:157
+#: ../src/app/qml/documentPage/DocumentListView.qml:159
 msgid "Today"
 msgstr ""
 
-#: ../src/app/qml/documentPage/DocumentListView.qml:160
+#: ../src/app/qml/documentPage/DocumentListView.qml:162
 msgid "Yesterday"
 msgstr ""
 
-#: ../src/app/qml/documentPage/DocumentListView.qml:163
+#: ../src/app/qml/documentPage/DocumentListView.qml:165
 msgid "Earlier this week"
 msgstr ""
 
-#: ../src/app/qml/documentPage/DocumentListView.qml:166
+#: ../src/app/qml/documentPage/DocumentListView.qml:168
 msgid "Earlier this month"
 msgstr ""
 
-#: ../src/app/qml/documentPage/DocumentListView.qml:168
+#: ../src/app/qml/documentPage/DocumentListView.qml:170
 msgid "Even earlier..."
 msgstr ""
 
@@ -258,16 +240,16 @@
 msgstr ""
 
 #: ../src/app/qml/documentPage/DocumentPageDefaultHeader.qml:46
-#: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:35
+#: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:41
 msgid "Switch to single column list"
 msgstr ""
 
 #: ../src/app/qml/documentPage/DocumentPageDefaultHeader.qml:46
-#: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:35
+#: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:41
 msgid "Switch to grid"
 msgstr ""
 
-#: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:43
+#: ../src/app/qml/documentPage/DocumentPagePickModeHeader.qml:49
 msgid "Pick"
 msgstr ""
 
@@ -401,16 +383,20 @@
 msgid "Loading..."
 msgstr ""
 
-#: ../src/app/qml/ubuntu-docviewer-app.qml:240
-msgid "Document successfully imported!"
-msgid_plural "Documents successfully imported!"
-msgstr[0] ""
-msgstr[1] ""
-
-#: ../src/app/qml/ubuntu-docviewer-app.qml:243
-msgid "Open"
+#. TRANSLATORS: This string is used for renaming a copied file,
+#. when a file with the same name already exists in user's
+#. Documents folder.
+#.
+#. e.g. "Manual_Aquaris_E4.5_ubuntu_EN.pdf" will become
+#. "Manual_Aquaris_E4.5_ubuntu_EN (copy 2).pdf"
+#.
+#. where "2" is given by the argument "%1"
+#.
+#: ../src/plugin/file-qml-plugin/documentviewersingleton.cpp:99
+#, qt-format
+msgid "copy %1"
 msgstr ""
 
-#: /tmp/build-reboot-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/po/com.ubuntu.docvie

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis
 into lp:ubuntu-docviewer-app/reboot.

Commit message:
* Use QML APIs for Content Hub
* Remove toast notifications for imported documents (open documents 
automatically)

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1469422 in Ubuntu Document Viewer App: "[Doc Viewer] Opening a file from 
content-hub should open the file or the notfication timeout should be increased"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1469422

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis/+merge/271466

* Use QML APIs for Content Hub
* Remove toast notifications for imported documents (open documents 
automatically)

*** NOTE ***
In DocviewerApplication and CommandLineParser classes, the argument 
"--pickMode" is broken.

Since we are going to move the arguments parser in QML too, that will be solved 
with a future commit.

At the moment, that argument is not used by Autopilot tests and the "reboot" 
branch is not released yet, therefore no relevant issue has been introduced.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/10-reboot-contenthub-switch-to-qml-apis
 into lp:ubuntu-docviewer-app/reboot.
=== modified file 'src/app/CMakeLists.txt'
--- src/app/CMakeLists.txt	2015-09-02 11:31:45 +
+++ src/app/CMakeLists.txt	2015-09-19 11:41:47 +
@@ -10,7 +10,6 @@
 
 set(docviewer_SRCS
 main.cpp
-content-communicator.cpp
 command-line-parser.cpp
 docviewer-application.cpp
 urlhandler.cpp

=== removed file 'src/app/content-communicator.cpp'
--- src/app/content-communicator.cpp	2015-07-14 01:35:59 +
+++ src/app/content-communicator.cpp	1970-01-01 00:00:00 +
@@ -1,257 +0,0 @@
-/*
- * Copyright (C) 2013 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see .
- *
- */
-
-#include "content-communicator.h"
-
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include 
-#include 
-#include 
-
-
-using namespace com::ubuntu::content;
-
-/*!
- * \brief ContentCommunicator::ContentCommunicator
- * \param parent
- */
-ContentCommunicator::ContentCommunicator(QObject *parent)
-: ImportExportHandler(parent),
-  m_transfer(nullptr)
-{
-}
-
-/*!
- * \brief ContentCommunicator::registerWithHub Register the handlers provided
- * by ContentCommunicator with the content hub
- */
-void ContentCommunicator::registerWithHub()
-{
-Hub *hub = Hub::Client::instance();
-hub->register_import_export_handler(this);
-}
-
-/*!
- * \brief \reimp
- */
-void ContentCommunicator::handle_import(content::Transfer *transfer)
-{
-// FIXME: If a file is imported from $HOME/Documents, a new copy of the file is created.
-//   Could be use md5? http://doc.qt.io/qt-5/qml-qtqml-qt.html#md5-method
-QVariantList importedDocuments;
-QVector transferedItems = transfer->collect();
-foreach (const Item &hubItem, transferedItems) {
-QFileInfo fi(hubItem.url().toLocalFile());
-
-QString dir;
-QString destination;
-bool rejected = false;
-
-QMimeDatabase mdb;
-QMimeType mt = mdb.mimeTypeForFile(hubItem.url().toLocalFile());
-
-// Check if the item is supported by Ubuntu Document Viewer
-if (isSupportedMimetype(mt.name())) {
-/* We don't support formats that use a double extension
-   (e.g. tar.gz), so we can safely use completeBaseName() and
-   suffix() functions, in order to properly detect the name of
-   the document even when there's a dot in the middle of the name.*/
-QString suffix = fi.suffix();
-QString filenameWithoutSuffix = fi.completeBaseName();
-
-if(suffix.isEmpty()) {
-// If the filename doesn't have an extension add one from the
-// detected mimetype
-if(!mt.preferredSuffix().isEmpty()) {
-suffix = mt.preferredSuffix();
-}
-}
-
-dir = QStandardPaths::writableLocation(QStandardPaths::DocumentsLocation) + QDir::separator();
-destination = QString("%1.%2").arg(dir + filenameWithoutSuffix, suffix);
-
-// If we already 

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into lp:ubuntu-docviewer-app/reboot

[Stefano Verzegnassi]

Review: Needs Fixing

It is definitely more stable than before. Anyway I've been able to make it 
crash.

Here's the log: http://paste.ubuntu.com/12465531/
Steps to reproduce it:
1) Open Document Viewer
2) Open a LibreOffice text document (.odt, .doc, .docx). It needs to contain 
more than one page.
3) Scroll the flickable.
4) When the flickable is still scrolling, close the viewer and go back to the 
"browser" page.
5) LibreOffice crashes.

It does not seem to happen with all the documents (they need to be a lot 
complex - e.g. tables, images, etc.).
I'll provide you the document I tested privately (since it's supposed to be 
confidential).

Anyway, having a look at the log, it doesn't seem to be caused by the changes 
proposed in this MP, so it's not a valid reason to delay the merging of this 
branch.

We will probably need to do further investigation on LibreOfficeKit, in order 
to see if there's a way to prevent the crash.



I've left 7 inline comments, about things that may require a fix.
I'm sorry for being so pedantic, don't hate me for this. :P

That said, it looks already great and that RenderEngine class helps me a lot in 
implementing some change for the lok::part thumbnailer.



Diff comments:

> 
> === modified file 'src/plugin/libreofficetoolkit-qml-plugin/loview.cpp'
> --- src/plugin/libreofficetoolkit-qml-plugin/loview.cpp   2015-09-11 
> 12:35:10 +
> +++ src/plugin/libreofficetoolkit-qml-plugin/loview.cpp   2015-09-19 
> 08:53:46 +
> @@ -69,21 +70,28 @@
>  Q_EMIT parentFlickableChanged();
>  }
>  
> +void LOView::initializeDocument(const QString &path)
> +{
> +m_document = QSharedPointer(new LODocument());
> +m_document->setPath(path);
> +Q_EMIT documentChanged();
> +}
> +
>  // Return the LODocument rendered by this class
>  LODocument* LOView::document() const
>  {
> -return m_document;
> +return m_document.data();
>  }
>  
>  // Set the LODocument
> -void LOView::setDocument(LODocument *doc)
> -{
> -if (m_document == doc)
> -return;
> +//void LOView::setDocument(LODocument *doc)

Can we remove the commented lines?

> +//{
> +//if (m_document == doc)
> +//return;
>  
> -m_document = doc;
> -Q_EMIT documentChanged();
> -}
> +//m_document = QSharedPointer(doc);
> +//Q_EMIT documentChanged();
> +//}
>  
>  // Not used yet.
>  qreal LOView::zoomFactor() const
> 
> === modified file 'src/plugin/libreofficetoolkit-qml-plugin/loview.h'
> --- src/plugin/libreofficetoolkit-qml-plugin/loview.h 2015-09-11 12:42:47 
> +
> +++ src/plugin/libreofficetoolkit-qml-plugin/loview.h 2015-09-19 08:53:46 
> +
> @@ -41,8 +44,11 @@
>  QQuickItem* parentFlickable() const;
>  voidsetParentFlickable(QQuickItem* flickable);
>  
> +Q_INVOKABLE void initializeDocument(const QString& path);
> +
> +// TODO REWORK

Has it been done? If yes, please remove the TODO comment.

>  LODocument* document() const;
> -voidsetDocument(LODocument* doc);
> +//voidsetDocument(LODocument* doc);

Remove comment.

>  
>  qreal   zoomFactor() const;
>  voidsetZoomFactor(qreal zoom);
> @@ -60,23 +66,24 @@
>  void updateViewSize();
>  void updateVisibleRect();
>  void scheduleVisibleRectUpdate();
> +void renderResultReceived(int id, QImage img);
>  
>  private:
> -QQuickItem* m_parentFlickable;
> -LODocument* m_document;
> -
> -qreal   m_zoomFactor;
> -int m_cacheBuffer;
> -
> -QRect   m_visibleArea;
> -QRect   m_bufferArea;
> -
> -QTimer  m_updateTimer;
> -
> -QMapm_tiles;
> -
> -voidgenerateTiles(int x1, int y1, int x2, int y2, 
> int tilesPerWidth);
> -voidcreateTile(int index, QRect rect);
> +QQuickItem* m_parentFlickable;
> +QSharedPointer  m_document;
> +
> +qreal   m_zoomFactor;
> +int m_cacheBuffer;
> +
> +QRect   m_visibleArea;
> +QRect   m_bufferArea;
> +
> +QTimer  m_updateTimer;
> +
> +QMap  m_tiles;
> +
> +void generateTiles(int x1, int y1, int x2, int y2, int tilesPerWidth);

Thank you for re-aligning this. Looks better now! :)

> +void createTile(int index, QRect rect);
>  };
>  
>  #endif // LOVIEW_H
> 
> === modified file 'src/plugin/libreofficetoolkit-qml-plugin/qml/Viewer.qml'
> --- src/plugin/libreofficetoolkit-qml-plugin/qml/Viewer.qml   2015-09-10 
> 12:22:49 +
> +++ src/plugin/libreofficetoolkit-qml-plugin/qml/Viewer.qml   2015-09-19 
> 08:53:46 +
> @@ -24,6 +24,13 @@
>  property alias zoomFactor:  view.zoomFactor
>  property alias cacheBuffer: view.cacheBuffer
>  
> +property string documentPath: ""

Could this be done from C++, or there's a specific reason?

In case, 

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into lp:ubuntu-docviewer-app/reboot

[Ubuntu Phone Apps Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:183
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/24/
Executed test runs:
SUCCESS: 
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/24

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/24/rebuild

-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine/+merge/271733
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine 
into lp:ubuntu-docviewer-app/reboot.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into lp:ubuntu-docviewer-app/reboot

[Roman Shchekin]

Roman Shchekin has proposed merging 
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine into 
lp:ubuntu-docviewer-app/reboot.

Commit message:
New method of multithreaded rendering.

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine/+merge/271733

New method of multithreaded rendering.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-render-engine 
into lp:ubuntu-docviewer-app/reboot.
=== modified file 'src/app/qml/loView/LOView.qml'
--- src/app/qml/loView/LOView.qml	2015-07-04 16:00:33 +
+++ src/app/qml/loView/LOView.qml	2015-09-19 08:53:46 +
@@ -33,8 +33,7 @@
 // while the second one (%2) refers to the total pages count.
 property string currentPage: i18n.tr("Page %1 of %2").arg(loView.currentPageIndex + 1).arg(loView.count)
 
-// Reset night mode shader settings when closing the page
-// Component.onDestruction: mainView.nightModeEnabled = false
+property alias loDocument: loView.document
 
 LO.Viewer {
 id: loView
@@ -42,7 +41,7 @@
 anchors.fill: parent
 
 clip: true
-document: loDocument
+documentPath: file.path
 
 Component.onCompleted: {
 // WORKAROUND: Fix for wrong grid unit size
@@ -54,29 +53,10 @@
 Scrollbar { flickableItem: loView }
 Scrollbar { flickableItem: loView; align: Qt.AlignBottom }
 
-LO.Document {
-id: loDocument
-
-property bool isLoading: true
-path: file.path
-
-   /* onPagesLoaded: {
-isLoading = false;
-
-var title = getDocumentInfo("Title")
-if (title !== "")
-loPage.title = title;
-
-// Hide header when the document is ready
-mainView.setHeaderVisibility(false);
-}*/
-}
-
 // *** HEADER ***
 state: "default"
 states: LOViewDefaultHeader {
 name: "default"
 targetPage: loPage
-//activityRunning: loView.currentPageItem.status == Image.Loading || loDocument.isLoading
 }
 }

=== modified file 'src/plugin/libreofficetoolkit-qml-plugin/CMakeLists.txt'
--- src/plugin/libreofficetoolkit-qml-plugin/CMakeLists.txt	2015-09-10 12:22:49 +
+++ src/plugin/libreofficetoolkit-qml-plugin/CMakeLists.txt	2015-09-19 08:53:46 +
@@ -17,6 +17,7 @@
 lodocument.cpp
 loview.cpp
 sgtileitem.cpp
+renderengine.cpp
 ${QML_SRCS}
 )
 

=== modified file 'src/plugin/libreofficetoolkit-qml-plugin/lodocument.cpp'
--- src/plugin/libreofficetoolkit-qml-plugin/lodocument.cpp	2015-09-02 11:31:45 +
+++ src/plugin/libreofficetoolkit-qml-plugin/lodocument.cpp	2015-09-19 08:53:46 +
@@ -48,7 +48,7 @@
 }
 
 // Set the path of the document, then it tries to load it.
-void LODocument::setPath(QString &pathName)
+void LODocument::setPath(const QString& pathName)
 {
 if (pathName.isEmpty())
 return;
@@ -61,7 +61,7 @@
 }
 
 // Load the document
-bool LODocument::loadDocument(QString &pathName)
+bool LODocument::loadDocument(const QString &pathName)
 {
 qDebug() << "Loading document...";
 
@@ -106,7 +106,7 @@
 
 // Paint a tile, with size=canvasSize, of the part of the document defined by
 // the rect tileSize.
-QImage LODocument::paintTile(QSize canvasSize, QRect tileSize)
+QImage LODocument::paintTile(const QSize& canvasSize, const QRect& tileSize)
 {
 QImage result = QImage(canvasSize.width(), canvasSize.height(),  QImage::Format_RGB32);
 
@@ -152,4 +152,7 @@
 LODocument::~LODocument()
 {
 delete m_document;
+#ifdef DEBUG_VERBOSE
+qDebug() << "  ~LODocument";
+#endif
 }

=== modified file 'src/plugin/libreofficetoolkit-qml-plugin/lodocument.h'
--- src/plugin/libreofficetoolkit-qml-plugin/lodocument.h	2015-07-23 01:05:20 +
+++ src/plugin/libreofficetoolkit-qml-plugin/lodocument.h	2015-09-19 08:53:46 +
@@ -47,12 +47,12 @@
 };
 
 QString path() const;
-void setPath(QString &pathName);
+void setPath(const QString& pathName);
 
 DocumentType documentType() const;
 
 QSize documentSize() const;
-QImage paintTile(QSize canvasSize, QRect tileSize);
+QImage paintTile(const QSize& canvasSize, const QRect& tileSize);
 
 Q_INVOKABLE bool saveAs(QString url, QString format, QString filterOptions);
 
@@ -64,7 +64,7 @@
 QString m_path;
 DocumentType m_docType;
 
-bool loadDocument(QString &pathNAme);
+bool loadDocument(const QString &pathNAme);
 
 lok::Document *m_document;
 

=== modified file 'src/plugin/libreofficetoolkit-qml-plugin/loview.cpp'
--- src/plugin/libreofficetoolkit-qml-plugin/loview.cpp	2015-09-11 12:35:10 +
+++ src/plugin/libreofficetoolkit-qml-plugin/loview.cpp	2015-09-19 08:53:46 +
@@ -41,6 +41,7 @@
 connect(this, SIGNAL(parentFlickableChanged()), this, SLOT(updateVisib