Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/add-click-deps into lp:ubuntu-filemanager-app

2015-09-26 Thread Carlos Jose Mazieri
Review: Needs Information

Hello,

I did a first test without removing my Samba libraries.

On desktop it downloaded the libraries but on armhf it did not.

See some output:
-- Setting BZR_SOURCE to lp:ubuntu-filemanager-app
Grabbing upstream libs to 
/home/carlos/ubuntu_work/build-add-click-deps-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/upstream-libs
Installing upstream libs from 
/home/carlos/ubuntu_work/build-add-click-deps-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/upstream-libs/usr/lib/arm-linux-gnueabihf/
 to /lib/arm-linux-gnueabihf
Following files to install:-

-- Found PkgConfig: arm-linux-gnueabihf-pkg-config (found version "0.28")
-- samba include=/usr/include/samba-4.0
-- samba 
lib=/usr/lib/arm-linux-gnueabihf/libsmbclient.so=/usr/lib/arm-linux-gnueabihf/libsmbclient.so
-- Found samba: include=/usr/include/samba-4.0  
library=/usr/lib/arm-linux-gnueabihf/libsmbclient.so


Questions:
   1. Did I do something wrong?
   2. Cmake still found my installed samba libraries, should not it be changed 
to find downloaded stuff including libsmbclient.h which I think is missed from 
download script?
   3. I am wondering how is the mechanism used to load local libraries in the 
click package, can anyone tell how it works?



-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/add-click-deps/+merge/270287
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp


Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/add-manual-tests-001 into lp:music-app

2015-09-26 Thread Victor Thompson
Review: Approve

This looks good to me. I'd like to get balloon's final opinion prior to 
merging, however.
-- 
https://code.launchpad.net/~ahayzen/music-app/add-manual-tests-001/+merge/272050
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp