Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1236/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/233 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1236/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/add_prefix/+merge/267317 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1235/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/232 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1235/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/optimization_tab_change/+merge/268873 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/12/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/71/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/12/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/add_prefix/+merge/267317 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/11/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/70/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/11/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/optimization_tab_change/+merge/268873 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1234/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/231 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1234/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/10/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/69/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/10/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/275832 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-use-sdk-listitems into lp:music-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:885 http://91.189.93.70:8080/job/music-app-ci/1400/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/252 Click here to trigger a rebuild: http://91.189.93.70:8080/job/music-app-ci/1400/rebuild -- https://code.launchpad.net/~ahayzen/music-app/refactor-use-sdk-listitems/+merge/274829 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/275831 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
I'll note, I only disabled the autolanding job, so it will still try and build. you can ignore any failures. Top approving will allow it to land. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
Blast that libsmbclient . . . I'll keep working on it guys! In the interim, I've disabled builds so you can land using the old bot. hopefully tomorrow will find success. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/detect-qtmm-version into lp:ubuntu-clock-app
Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner. -- https://code.launchpad.net/~mzanetti/ubuntu-clock-app/detect-qtmm-version/+merge/275177 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app
Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner. -- https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes/+merge/275625 Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefView into lp:ubuntu-calendar-app
Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner. -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefView/+merge/274062 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefView into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into lp:ubuntu-calculator-app
Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner. -- https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade/+merge/274958 Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app
The proposal to merge lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app
Review: Approve continuous-integration -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app
The proposal to merge lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 -- Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app
Review: Approve -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-autolanding/2/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5/console -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:411 https://core-apps-jenkins.ubuntu.com/job/shorts-app-ci/7/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/68/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/shorts-app-ci/7/rebuild -- https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes/+merge/275625 Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:411 https://core-apps-jenkins.ubuntu.com/job/shorts-app-ci/6/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/67/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/shorts-app-ci/6/rebuild -- https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes/+merge/275625 Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/detect-qtmm-version into lp:ubuntu-clock-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:404 https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/14/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/66/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/14/rebuild -- https://code.launchpad.net/~mzanetti/ubuntu-clock-app/detect-qtmm-version/+merge/275177 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into lp:ubuntu-calculator-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:230 https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/7/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/65/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/7/rebuild -- https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade/+merge/274958 Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefView into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:719 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/9/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/64/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/9/rebuild -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefView/+merge/274062 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefView into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix into lp:ubuntu-clock-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:403 https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/13/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/62/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/13/rebuild -- https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix/+merge/275932 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix into lp:ubuntu-clock-app
Bartosz Kosiorek has proposed merging
lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix into
lp:ubuntu-clock-app.
Commit message:
Fix alarm difference time description, during DST change (LP: #1510694)
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
Bug #1510694 in Ubuntu Clock App: " Alarm description are always "Alarm
passed", during first hour of DST change."
https://bugs.launchpad.net/ubuntu-clock-app/+bug/1510694
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix/+merge/275932
Fix alarm difference time description, during DST change (LP: #1510694)
--
Your team Ubuntu Clock Developers is requested to review the proposed merge of
lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix into
lp:ubuntu-clock-app.
=== modified file 'app/alarm/AlarmDelegate.qml'
--- app/alarm/AlarmDelegate.qml 2015-10-16 07:38:33 +
+++ app/alarm/AlarmDelegate.qml 2015-10-27 22:54:00 +
@@ -88,7 +88,7 @@
visible: !(type === Alarm.OneTime && !model.enabled)
elide: Text.ElideRight
text: type === Alarm.Repeating ? alarmUtils.format_day_string(daysOfWeek, type)
- : model.enabled ? alarmUtils.get_time_to_next_alarm(model.date - localTime)
+ : model.enabled ? alarmUtils.get_time_to_alarm(model.date, localTime)
: "Alarm Disabled"
function animateTextChange() {
@@ -107,7 +107,7 @@
ScriptAction {
script: alarmSubtitle.text = showAlarmFrequency ? alarmUtils.format_day_string(daysOfWeek, type)
-: alarmUtils.get_time_to_next_alarm(model.date - localTime)
+: alarmUtils.get_time_to_alarm(model.date, localTime)
}
PropertyAnimation {
=== modified file 'app/alarm/AlarmUtils.qml'
--- app/alarm/AlarmUtils.qml 2015-10-08 21:49:48 +
+++ app/alarm/AlarmUtils.qml 2015-10-27 22:54:00 +
@@ -79,12 +79,26 @@
return bottom_edge_title
}
-bottom_edge_title = i18n.tr("Next Alarm %1").arg(get_time_to_next_alarm(activeAlarmDate - clockTime))
+bottom_edge_title = i18n.tr("Next Alarm %1").arg(get_time_to_alarm(activeAlarmDate, clockTime))
return bottom_edge_title
}
-// Function to format the time to next alarm into a string
-function get_time_to_next_alarm(totalTime) {
+function get_utc_time(dateTime) {
+return new Date(dateTime.getUTCFullYear(),
+dateTime.getUTCMonth(),
+dateTime.getUTCDate(),
+dateTime.getUTCHours(),
+dateTime.getUTCMinutes(),
+dateTime.getUTCSeconds(),
+dateTime.getUTCMilliseconds())
+}
+
+// Function to format the time to specific alarm into a string
+function get_time_to_alarm(alarmDate, currentDateTime) {
+// Discard the time and time-zone information, so it will be properly calculate time,
+// even with different timezones (eg. during daylight saving change)
+var totalTime = get_utc_time(alarmDate) - get_utc_time(currentDateTime);
+
if(totalTime < 0) {
return i18n.tr("Alarm Passed")
}
=== modified file 'debian/changelog'
--- debian/changelog 2015-10-16 05:58:01 +
+++ debian/changelog 2015-10-27 22:54:00 +
@@ -1,4 +1,11 @@
-ubuntu-clock-app (3.6) UNRELEASED; urgency=medium
+ubuntu-clock-app (3.7) UNRELEASED; urgency=medium
+
+ [ Bartosz Kosiorek ]
+ * Fix alarm difference time description, during DST change (LP: #1510694)
+
+ -- Bartosz Kosiorek Tue, 27 Oct 2015 23:49:19 +0100
+
+ubuntu-clock-app (3.6) vivid; urgency=medium
[ Nekhelesh Ramananthan ]
* Bumped version to 3.6
=== modified file 'tests/unit/tst_alarm.qml'
--- tests/unit/tst_alarm.qml 2015-09-17 06:28:20 +
+++ tests/unit/tst_alarm.qml 2015-10-27 22:54:00 +
@@ -65,13 +65,16 @@
//delete all current alarms
waitForRendering(alarmPage)
var alarmsList = findChild(alarmPage, "alarmListView")
-verify(alarmsList != null)
+verify(alarmsList !== null)
print("Found " + alarmsList.count + " pre-existing alarms")
for (var i=0; i--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/275832 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/275832 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/275831 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/275831 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-autolanding/1/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/4/console -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app
Review: Approve getStat()'s return value is always casted to StatReturn, so it would seem to me that it'd be better to have getStat() rturn always StatReturn so that the casting would be in one place and not dispersed around code. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app
Andrew Hayzen has proposed merging
lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app.
Commit message:
* Add support for media-hub background playlists
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1251624 in Ubuntu Music App: "back button should not be random when in
shuffle mode"
https://bugs.launchpad.net/music-app/+bug/1251624
Bug #1480280 in Ubuntu Music App: "Songs repeated when listening in shuffle
mode"
https://bugs.launchpad.net/music-app/+bug/1480280
Bug #1500457 in Ubuntu Music App: "Pressing previous button sets duration to
0"
https://bugs.launchpad.net/music-app/+bug/1500457
For more details, see:
https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912
* Add support for media-hub background playlists
JUST NEED THIS FOR DIFF
--
Your team Music App Developers is requested to review the proposed merge of
lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app.
=== modified file 'app/components/BlurredBackground.qml'
--- app/components/BlurredBackground.qml 2015-05-03 16:22:31 +
+++ app/components/BlurredBackground.qml 2015-10-27 19:27:27 +
@@ -25,7 +25,7 @@
Item {
width: parent.width
-property string art // : player.currentMetaFile === "" ? Qt.resolvedUrl("../graphics/music-app-co...@30.png") : player.currentMetaArt
+property string art
// dark layer
Rectangle {
=== modified file 'app/components/HeadState/MultiSelectHeadState.qml'
--- app/components/HeadState/MultiSelectHeadState.qml 2015-06-27 21:06:26 +
+++ app/components/HeadState/MultiSelectHeadState.qml 2015-10-27 19:27:27 +
@@ -41,7 +41,12 @@
var items = []
for (var i=0; i < listview.selectedItems.length; i++) {
-items.push(makeDict(listview.model.get(listview.selectedItems[i], listview.model.RoleModelData)));
+// TODO: improve! probably take outside of the for loop or try and make playlist accept .get()
+if (listview.model === newPlayer.mediaPlayer.playlist) {
+items.push(makeDict(newPlayer.metaForSource(listview.model.source(listview.selectedItems[i];
+} else {
+items.push(makeDict(listview.model.get(listview.selectedItems[i], listview.model.RoleModelData)));
+}
}
mainPageStack.push(Qt.resolvedUrl("../../ui/AddToPlaylist.qml"),
@@ -57,13 +62,13 @@
visible: addToQueue
onTriggered: {
-var items = []
+var sources = [];
for (var i=0; i < listview.selectedItems.length; i++) {
-items.push(listview.model.get(listview.selectedItems[i], listview.model.RoleModelData));
+sources.push(Qt.resolvedUrl(listview.model.get(listview.selectedItems[i], listview.model.RoleModelData).filename));
}
-trackQueue.appendList(items)
+newPlayer.mediaPlayer.playlist.addSources(sources);
listview.closeSelection()
}
=== modified file 'app/components/Helpers/ContentHubHelper.qml'
--- app/components/Helpers/ContentHubHelper.qml 2015-08-18 21:08:05 +
+++ app/components/Helpers/ContentHubHelper.qml 2015-10-27 19:27:27 +
@@ -220,12 +220,12 @@
else {
stopTimer();
-trackQueue.clear();
+newPlayer.mediaPlayer.playlist.clear();
for (i=0; i < searchPaths.length; i++) {
model = musicStore.lookup(decodeFileURI(searchPaths[i]))
-trackQueue.append(makeDict(model));
+newPlayer.mediaPlayer.playlist.addSource(Qt.resolvedUrl(decodeURIComponent(searchPaths[i])));
}
trackQueueClick(0);
=== modified file 'app/components/Helpers/UriHandlerHelper.qml'
--- app/components/Helpers/UriHandlerHelper.qml 2015-06-28 03:06:49 +
+++ app/components/Helpers/UriHandlerHelper.qml 2015-10-27 19:27:27 +
@@ -38,14 +38,6 @@
}
function processAlbum(uri) {
-// Stop queue loading in the background
-queueLoaderWorker.canLoad = false
-
-if (queueLoaderWorker.processing > 0) {
-waitForWorker.workerStop(queueLoaderWorker, processAlbum, [uri])
-return;
-}
-
selectedAlbum = true;
var split = uri.split("/");
@@ -60,34 +52,26 @@
}
function processFile(uri, play) {
-// Stop queue loading in the background
-queueLoaderWorker.canLoad = false
-
-if (queueLoaderWorker.processing > 0) {
-waitForWorker.workerStop(queueLoaderWorker, processFile, [uri, play])
-return;
-}
-
// Lookup track in songs model
var track = musicStore.lookup(decodeFileURI(uri));
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app
The proposal to merge lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912 -- Your team Music App Developers is requested to review the proposed merge of lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:196 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/53/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/53/console Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/53/rebuild -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor/+merge/275903 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:195 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/52/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/52/console Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/52/rebuild -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor/+merge/275903 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor/+merge/275186 -- Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into
lp:ubuntu-docviewer-app/reboot with
lp:~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps as a prerequisite.
Commit message:
* Changes to the project structure
* Provide DocViewer plugins as separate .deb packages
* Added exception for '*.user.*' in .bzrignore file
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor/+merge/275903
* Changes to the project structure
* Provide DocViewer plugins as separate .deb packages
* Added exception for '*.user.*' in .bzrignore file
--
Your team Ubuntu Document Viewer Developers is requested to review the proposed
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor
into lp:ubuntu-docviewer-app/reboot.
=== modified file '.bzrignore'
--- .bzrignore 2014-10-28 22:10:16 +
+++ .bzrignore 2015-10-27 18:49:01 +
@@ -1,11 +1,11 @@
Makefile
ubuntu-docviewer-app
*.user
+*.user.*
moc_file.cpp
launcher/build-docviewer-launcher-Desktop-Debug/
launcher/build-docviewer-launcher-Desktop-Release/
launcher/src/docviewer-launcher.pro.user
-*.cmake
CMakeFiles
*_automoc.cpp
moc_*
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-10-27 18:49:01 +
+++ CMakeLists.txt 2015-10-27 18:49:01 +
@@ -1,34 +1,23 @@
project(com.ubuntu.docviewer C CXX)
cmake_minimum_required(VERSION 2.8.9)
-find_program(INTLTOOL_MERGE intltool-merge)
-if(NOT INTLTOOL_MERGE)
- message(FATAL_ERROR "Could not find intltool-merge, please install the intltool package")
-endif(NOT INTLTOOL_MERGE)
-
-find_program(INTLTOOL_EXTRACT intltool-extract)
-if(NOT INTLTOOL_EXTRACT)
- message(FATAL_ERROR "Could not find intltool-extract, please install the intltool package")
-endif(NOT INTLTOOL_EXTRACT)
-
+set(UBUNTU_MANIFEST_PATH "click/manifest.json.in" CACHE INTERNAL "Relative path to the manifest file")
+set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
set(CMAKE_AUTOMOC ON)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-permissive -pedantic -Wall -Wextra -fPIC")
include(FindPkgConfig)
-# Standard install paths
include(GNUInstallDirs)
-option(INSTALL_TESTS "Install the tests on make install" on)
-option(CLICK_MODE "Installs to a contained location" on)
+option(INSTALL_TESTS"Install the tests on make install" on)
+option(CLICK_MODE "Installs to a contained location" on)
-set(APP_NAME ubuntu-docviewer-app)
-set(DESKTOP_FILE "${PROJECT_NAME}.desktop")
-set(URLS_FILE "${PROJECT_NAME}.url-dispatcher")
-set(LP_PROJECT ubuntu-docviewer-app)
-set(ICON_FILE docvie...@30.png)
-set(AUTOPILOT_DIR ubuntu_docviewer_app)
-set(EXEC "${APP_NAME}")
-set(UBUNTU_MANIFEST_PATH "manifest.json.in" CACHE INTERNAL "Relative path to the manifest file")
+set(APP_NAMEubuntu-docviewer-app)
+set(DESKTOP_FILE"${PROJECT_NAME}.desktop")
+set(URLS_FILE "${PROJECT_NAME}.url-dispatcher")
+set(LP_PROJECT ubuntu-docviewer-app)
+set(ICON_FILE docvie...@30.png)
+set(AUTOPILOT_DIR ubuntu_docviewer_app)
# Sets BZR_REVNO
execute_process(
@@ -37,112 +26,26 @@
OUTPUT_STRIP_TRAILING_WHITESPACE
)
-if(CLICK_MODE)
-if(NOT DEFINED BZR_SOURCE)
-set(BZR_SOURCE "lp:${LP_PROJECT}")
-message("-- Setting BZR_SOURCE to ${BZR_SOURCE}")
-endif(NOT DEFINED BZR_SOURCE)
-
-if(NOT BZR_REVNO)
-set(BZR_REVNO "latest")
-endif(NOT BZR_REVNO)
-
-# Find out the architecture for package building
-# to determine the plugin's installation path
-execute_process(
-COMMAND dpkg-architecture -qDEB_HOST_MULTIARCH
-OUTPUT_VARIABLE ARCH_TRIPLET
-OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-execute_process(
- COMMAND dpkg-architecture -qDEB_HOST_ARCH
- OUTPUT_VARIABLE CLICK_ARCH
- OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-set(CMAKE_INSTALL_PREFIX /)
-set(QT_IMPORTS_DIR "/lib/${ARCH_TRIPLET}")
-set(BIN_DIR /lib/${ARCH_TRIPLET}/bin)
-set(DATA_DIR /)
-set(ICON ${ICON_FILE})
-set(DESKTOP_DIR ${DATA_DIR})
-set(URLS_DIR ${DATA_DIR})
-configure_file(manifest.json.in ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json docviewer.apparmor docviewer-content.json ${URLS_FILE}
-DESTINATION ${CMAKE_INSTALL_PREFIX})
-# Make the click files visible in Qt Creator
-file(GLOB CLICK_FILES
- RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
- *.json *.json.in *.apparmor)
-
-add_custom_target(com_ubuntu_docviewer_CLICKFiles ALL SOURCES ${CLICK_FILES})
-else(CLICK_MODE)
-# components PATH
-execute_process(
-COMMAND qmake -query QT_INSTALL_QML
-OUTPUT_VARIABLE QT_IMPORTS_DIR
-OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-set(DATA_DIR ${CMAKE_INSTALL_DATAD
[Ubuntu-touch-coreapps-reviewers] [Bug 1510211] Re: Phone app shows all number types under "recent" as "Mobile"
** Changed in: ubuntu-filemanager-app Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1510211 Title: Phone app shows all number types under "recent" as "Mobile" Status in Ubuntu File Manager App: Invalid Bug description: Steps to reproduce: Open phone app, go to the "Recent" list. All shown numbers show "Mobile" below the name. Select one. Open the "Recent" list again. Now the numbers show "Home", "Work" etc. The real type of the number should be shown at the first call. By the way, I didn't find a category for the phone app, therefore I posted it here. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1510211/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration into lp:ubuntu-weather-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:79 https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/7/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/61/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/7/rebuild -- https://code.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration/+merge/266981 Your team Ubuntu Weather Developers is subscribed to branch lp:~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3
Victor, You are right, there is one header per application. Which means that all pages in an application use that header. However that would be broken when you'd use the AdaptivePageLayout, which has as many headers as columns. Therefore we are preparing to move the header in the page, so each page will get a header of its own. Yet we have both solutions in place, thats' why you still see a header even if you don't set one on the Page. So, in the future of 1.3, you will have to set the header of the page yourself. Which means there will be as many headers as many pages require one. The one from MainView will disappear once we finish all the work we have for the header and its subcomponents. When you say "With the updated imports to UITK 1.3 we are unable to do things like the following: edgeLoader.item.flickable.contentY = -page.header.height" - I am sorry to say that the Page.header property was never documented, and used for private purposes. We do not promise any compatibility for private or undocumented properties, especially when the property comes from a super type, which is also internal. Whilst it is a regression, switching to 1.3 would anyways require you to go with the way I described before - specifying the header for your page within the page. -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1508363 Title: Coordinated migration to UITK 1.3 Status in Canonical System Image: In Progress Status in Ubuntu Music App: In Progress Status in Ubuntu Notes app: New Status in Ubuntu Calculator App: In Progress Status in Ubuntu Calendar App: New Status in Ubuntu Clock App: In Progress Status in Ubuntu Document Viewer App: In Progress Status in Ubuntu Shorts App: In Progress Status in Ubuntu Weather App: Triaged Status in Weather: New Status in address-book-app package in Ubuntu: In Progress Status in calendar-app package in Ubuntu: Confirmed Status in camera-app package in Ubuntu: Fix Released Status in dialer-app package in Ubuntu: In Progress Status in gallery-app package in Ubuntu: In Progress Status in messaging-app package in Ubuntu: In Progress Status in music-app package in Ubuntu: Confirmed Status in reminders-app package in Ubuntu: Fix Committed Status in ubuntu-clock-app package in Ubuntu: Confirmed Status in ubuntu-system-settings package in Ubuntu: Fix Released Status in ubuntu-system-settings-online-accounts package in Ubuntu: In Progress Status in ubuntu-weather-app package in Ubuntu: Confirmed Status in unity8 package in Ubuntu: In Progress Status in webbrowser-app package in Ubuntu: Fix Released Bug description: The migration to 1.3 needs to happen in a coordinated way, so that shell and all apps we care of migrate within the same OTA window to reduce visual inconsistencies to a minimum. This bug is a means to collect all the projects affected and keep tabs on what's happening. NOTES: - The toolkit has the following modules: Ubuntu.Components 1.3 Ubuntu.Components.ListItems 1.3 Ubuntu.Components.Pickers 1.3 Ubuntu.Components.Popups 1.3 Ubuntu.Components.Styles 1.3 Ubuntu.Components.Themes 1.3 Ubuntu.Components.Themes.Ambiance 1.3 Ubuntu.Components.Themes.SuruDark 1.3 - The following modules were not altered recently: Ubuntu.Layouts 1.0 Ubuntu.PerformanceMetrics 1.0 - Theme is now theme (lowercase) - PageHeadStyle now has a "config" property In manifest.json file use: "framework": "ubuntu-sdk-15.04.1-qml" To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1508363/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps into lp:ubuntu-docviewer-app/reboot
Review: Approve continuous-integration PASSED: Continuous integration, rev:179 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/51/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/51 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/51/rebuild -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps/+merge/275848 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps into lp:ubuntu-docviewer-app/reboot
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps into
lp:ubuntu-docviewer-app/reboot.
Commit message:
Automatically fetch dependencies for LibreOffice viewer and put them inside the
.click package.
Requested reviews:
Alan Pope (popey)
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps/+merge/275848
Automatically fetch dependencies for LibreOffice viewer and put them inside the
.click package.
--
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app/reboot.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-06-24 20:50:40 +
+++ CMakeLists.txt 2015-10-27 13:36:27 +
@@ -121,3 +121,28 @@
add_subdirectory(src)
add_subdirectory(tests)
add_subdirectory(po)
+
+# If running in CLICK_MODE, include binary dependencies of docviewer
+if(CLICK_MODE)
+MESSAGE("Grabbing upstream libs to ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs")
+execute_process(
+COMMAND mkdir ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
+COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/get-click-deps -d ${CMAKE_CURRENT_SOURCE_DIR}/docviewer-libs.json ${CLICK_ARCH} ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs
+)
+
+MESSAGE("Installing upstream libs from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
+file(GLOB_RECURSE UPSTREAM_LIBS "${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/usr/lib/${ARCH_TRIPLET}/*")
+foreach(ITEM ${UPSTREAM_LIBS})
+IF( IS_DIRECTORY "${ITEM}" )
+LIST( APPEND DIRS_TO_DEPLOY "${ITEM}" )
+ELSE()
+LIST( APPEND FILES_TO_DEPLOY "${ITEM}" )
+ENDIF()
+endforeach()
+MESSAGE("Following files to install:- ${FILES_TO_DEPLOY}")
+INSTALL( FILES ${FILES_TO_DEPLOY} DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET} )
+
+
+MESSAGE("Installing LibreOffice from ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/opt/libreoffice/lib/libreoffice to ${DATA_DIR}lib/${ARCH_TRIPLET}/libreoffice")
+INSTALL( DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/upstream-libs/opt/libreoffice/lib/libreoffice/ DESTINATION ${DATA_DIR}lib/${ARCH_TRIPLET}/libreoffice )
+endif(CLICK_MODE)
=== added file 'docviewer-libs.json'
--- docviewer-libs.json 1970-01-01 00:00:00 +
+++ docviewer-libs.json 2015-10-27 13:36:27 +
@@ -0,0 +1,94 @@
+{
+"armhf": [
+{
+"url": "http://ports.ubuntu.com/ubuntu-ports";,
+"dist": "vivid",
+"component": "main",
+"packages": [
+"libboost-date-time1.55.0",
+"libgl1-mesa-glx",
+"libxcb-dri3-0",
+"libxcb-glx0",
+"libxcb-present0",
+"libxshmfence1",
+"libxslt1.1",
+"libxt6",
+"libxxf86vm1",
+"gconf-service",
+"gconf-service-backend",
+"gconf2-common",
+"libgconf-2-4"
+]
+},
+{
+"url": "http://ppa.launchpad.net/canonical-community/ppa/ubuntu";,
+"dist": "vivid",
+"component": "main",
+"packages": [
+"libreoffice-vanilla"
+]
+}
+],
+
+"i386": [
+{
+"url": "http://archive.ubuntu.com/ubuntu";,
+"dist": "vivid",
+"component": "main",
+"packages": [
+"libboost-date-time1.55.0",
+"libgl1-mesa-glx",
+"libxcb-dri3-0",
+"libxcb-glx0",
+"libxcb-present0",
+"libxshmfence1",
+"libxslt1.1",
+"libxt6",
+"libxxf86vm1",
+"gconf-service",
+"gconf-service-backend",
+"gconf2-common",
+"libgconf-2-4"
+]
+},
+{
+"url": "http://ppa.launchpad.net/canonical-community/ppa/ubuntu";,
+"dist": "vivid",
+"component": "main",
+"packages": [
+"libreoffice-vanilla"
+]
+}
+],
+
+"amd64": [
+{
+"url": "http://archive.ubuntu.com/ubuntu";,
+"dist": "vivid",
+"component": "main",
+"packages": [
+"libboost-date-time1.55.0",
+"libgl1-mesa-glx",
+"libxcb-dri3-0",
+"libxcb-glx0",
+"libxcb-present0",
+"libxshmfence1",
+"libxslt1.1",
+"libxt6",
+"libxxf86vm1",
+"gconf-service",
+"gconf-service-backend",
+"gconf2-common",
+"libgconf-2-4"
+]
+},
+{
+"url": "http://ppa.launchpad.net/canonical-community/ppa/ubuntu";,
+"dist": "vivid
[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3
Zsombor, Functionally, there already is a header, so why should a developer need to define one explicitly? Won't explicitly defining one override the already visible header? What I'm asking for is simply a means of ascertaining the current header's height. I believe the inability to do so, currently, is a regression. -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1508363 Title: Coordinated migration to UITK 1.3 Status in Canonical System Image: In Progress Status in Ubuntu Music App: In Progress Status in Ubuntu Notes app: New Status in Ubuntu Calculator App: In Progress Status in Ubuntu Calendar App: New Status in Ubuntu Clock App: In Progress Status in Ubuntu Document Viewer App: In Progress Status in Ubuntu Shorts App: In Progress Status in Ubuntu Weather App: Triaged Status in Weather: New Status in address-book-app package in Ubuntu: In Progress Status in calendar-app package in Ubuntu: Confirmed Status in camera-app package in Ubuntu: Fix Released Status in dialer-app package in Ubuntu: In Progress Status in gallery-app package in Ubuntu: In Progress Status in messaging-app package in Ubuntu: In Progress Status in music-app package in Ubuntu: Confirmed Status in reminders-app package in Ubuntu: Fix Committed Status in ubuntu-clock-app package in Ubuntu: Confirmed Status in ubuntu-system-settings package in Ubuntu: Fix Released Status in ubuntu-system-settings-online-accounts package in Ubuntu: In Progress Status in ubuntu-weather-app package in Ubuntu: Confirmed Status in unity8 package in Ubuntu: In Progress Status in webbrowser-app package in Ubuntu: Fix Released Bug description: The migration to 1.3 needs to happen in a coordinated way, so that shell and all apps we care of migrate within the same OTA window to reduce visual inconsistencies to a minimum. This bug is a means to collect all the projects affected and keep tabs on what's happening. NOTES: - The toolkit has the following modules: Ubuntu.Components 1.3 Ubuntu.Components.ListItems 1.3 Ubuntu.Components.Pickers 1.3 Ubuntu.Components.Popups 1.3 Ubuntu.Components.Styles 1.3 Ubuntu.Components.Themes 1.3 Ubuntu.Components.Themes.Ambiance 1.3 Ubuntu.Components.Themes.SuruDark 1.3 - The following modules were not altered recently: Ubuntu.Layouts 1.0 Ubuntu.PerformanceMetrics 1.0 - Theme is now theme (lowercase) - PageHeadStyle now has a "config" property In manifest.json file use: "framework": "ubuntu-sdk-15.04.1-qml" To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1508363/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:480 http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/565/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/187 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/565/rebuild -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/275832 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:479 http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/566/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/188 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/566/rebuild -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/275831 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:480 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/18/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/58/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/18/rebuild -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/275832 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 as a
prerequisite.
Commit message:
improved SmbUtil::findSmBServer()
Requested reviews:
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/275832
improved SmbUtil::findSmBServer()
--
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into
lp:ubuntu-filemanager-app.
=== modified file 'src/plugin/folderlistmodel/smb/qsambaclient/src/smbutil.cpp'
--- src/plugin/folderlistmodel/smb/qsambaclient/src/smbutil.cpp 2015-10-27 11:09:54 +
+++ src/plugin/folderlistmodel/smb/qsambaclient/src/smbutil.cpp 2015-10-27 11:09:54 +
@@ -716,21 +716,25 @@
*/
QString SmbUtil::findSmBServer(const smbc_dirent & dirent)
{
-QString host("localhost");
+QString host;
if (dirent.name[0] != 0)
{
QString name(dirent.name);
host = name;
-QString comment(dirent.comment);
-if (!comment.isEmpty())
+}
+QString comment(dirent.comment);
+if (!comment.isEmpty())
+{
+QString fullName = comment.split(QLatin1Char(' '), QString::SkipEmptyParts).first();
+if (!fullName.isEmpty())
{
-QString fullName = comment.split(QLatin1Char(' '), QString::SkipEmptyParts).first();
-if (!fullName.isEmpty() && fullName.startsWith(name), Qt::CaseSensitive)
-{
-host = fullName;
-}
+host = fullName;
}
}
+if (host.isEmpty())
+{
+host = QLatin1String("localhost");
+}
return host.toLower();
}
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:479 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/17/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/57/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/17/rebuild -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/275831 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 as a
prerequisite.
Commit message:
some cleanup in SmbItemInfo::setInfo(), work around for directories is not
necessary after fixing stat problem on device
Requested reviews:
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/275831
some cleanup in SmbItemInfo::setInfo(), work around for directories is not
necessary after fixing stat problem on device
--
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into
lp:ubuntu-filemanager-app.
=== modified file 'src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.cpp'
--- src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.cpp 2015-09-13 14:20:30 +
+++ src/plugin/folderlistmodel/smb/qsambaclient/src/smbiteminfo.cpp 2015-10-27 11:06:41 +
@@ -50,9 +50,8 @@
void SmbItemInfo::setInfo(const QString& smb_path)
{
SmbUtil *smb = const_cast (m_smb);
-//getStatInfo() is supposed to clear the struct stat unless the item does not exist
+//getStatInfo() is supposed to clear the struct stat
struct stat st;
-::memset(&st, 0, sizeof(struct stat));
int ret = smb->getStatInfo(smb_path, &st);
//lets start with true
d_ptr->_exists = d_ptr->_isReadable = true;
@@ -64,16 +63,7 @@
d_ptr->_isHost = false;
d_ptr->_exists = d_ptr->_isReadable = false;
break;
-case SmbUtil::StatDir:
-//if directories does not have permissions lets set default
-//some smb stat functions does not work, this code will not hurt
-if ((st.st_mode & S_IFMT) == 0)
-{
-st.st_mode |= S_IRUSR | S_IWUSR | S_IXUSR |
- S_IRGRP | S_IWGRP | S_IXGRP |
- S_IROTH | S_IXOTH;
-}
-st.st_mode |= S_IFDIR;
+case SmbUtil::StatDir:
break;
case SmbUtil::StatHost:
d_ptr->_isHost = true;
=== modified file 'src/plugin/folderlistmodel/smb/qsambaclient/src/smblocationitemfile.cpp'
--- src/plugin/folderlistmodel/smb/qsambaclient/src/smblocationitemfile.cpp 2015-08-15 18:38:28 +
+++ src/plugin/folderlistmodel/smb/qsambaclient/src/smblocationitemfile.cpp 2015-10-27 11:06:41 +
@@ -232,13 +232,16 @@
SmbUtil::StatReturn ret = SmbUtil::StatInvalid;
if (isOpen())
{
-ret = smbObj()->getFstat(m_context,m_fd, &st);
+ret = static_cast (smbObj()->getFstat(m_context,m_fd,&st));
}
else
{
-SmbLocationItemFile *mySelf = const_cast (this);
-mySelf->createContext();
-ret = smbObj()->getStat(m_context,cleanUrl(), &st);
+if (m_context != 0) {
+ret = static_cast (smbObj()->getStat(m_context,cleanUrl(),&st));
+}
+else {
+ret = smbObj()->getStatInfo(cleanUrl(),&st);
+}
}
if(ret == SmbUtil::StatDone)
{
=== modified file 'src/plugin/folderlistmodel/smb/qsambaclient/src/smbutil.cpp'
--- src/plugin/folderlistmodel/smb/qsambaclient/src/smbutil.cpp 2015-10-27 11:06:41 +
+++ src/plugin/folderlistmodel/smb/qsambaclient/src/smbutil.cpp 2015-10-27 11:06:41 +
@@ -38,11 +38,17 @@
#if defined(SHOW_MESSAGES)
# define DBG(more_items) qDebug() << Q_FUNC_INFO more_items
+# define DBG_STAT(ret) qDebug() << Q_FUNC_INFO \
+ << "return:" << ret \
+ << "mode:" << st->st_mode \
+ << "mtime:" << st->st_mtime \
+ << "size:" << st->st_size
#else
#define DBG(none)
+#define DBG_STAT(ret)
#endif
-#define SHOW_ERRNO(path)if (errno != 0 && errno != ENOENT) \
+#define SHOW_ERRNO(path)if (errno != 0) \
{ \
qWarning() << Q_FUNC_INFO << "path:" << path << "errno:" << errno << strerror(errno); \
}
@@ -358,7 +364,7 @@
else if (errno != EACCES && errno != ECONNREFUSED) // perhaps is a file
{
errno = 0;
-ret = getStat(context, smb_path,st);
+ret = static_cast (getStat(context, smb_path,st));
}
if (errno != 0)
@@ -740,19 +746,22 @@
}
-SmbUtil::StatReturn
+int
SmbUtil::getFstat(Smb::Context context, Smb::FileHandler fd, struct stat* st)
{
::memset(st,0,sizeof(struct stat));
int ret = ::smbc_getFunctionFstat(context)(context,fd, st);
- return static_cast (ret);
+ DBG_STAT(ret);
+ return ret;
}
-SmbUtil::StatReturn
+int
SmbUtil::getStat(Smb::Context context, const QString& smb_path, struct stat*
[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3
Victor and others, in order to get the header height you need to set the
Page.header first. Page.header is null by default, so no wonder you
cannot get the height. You can do something like
Page {
header: PageHeader {
}
}
Then you will have the header set and you can use that to get the
height. The component is present in UITK trunk, however I do not see its
documentation under d.u.c...
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1508363
Title:
Coordinated migration to UITK 1.3
Status in Canonical System Image:
In Progress
Status in Ubuntu Music App:
In Progress
Status in Ubuntu Notes app:
New
Status in Ubuntu Calculator App:
In Progress
Status in Ubuntu Calendar App:
New
Status in Ubuntu Clock App:
In Progress
Status in Ubuntu Document Viewer App:
In Progress
Status in Ubuntu Shorts App:
In Progress
Status in Ubuntu Weather App:
Triaged
Status in Weather:
New
Status in address-book-app package in Ubuntu:
In Progress
Status in calendar-app package in Ubuntu:
Confirmed
Status in camera-app package in Ubuntu:
Fix Released
Status in dialer-app package in Ubuntu:
In Progress
Status in gallery-app package in Ubuntu:
In Progress
Status in messaging-app package in Ubuntu:
In Progress
Status in music-app package in Ubuntu:
Confirmed
Status in reminders-app package in Ubuntu:
Fix Committed
Status in ubuntu-clock-app package in Ubuntu:
Confirmed
Status in ubuntu-system-settings package in Ubuntu:
Fix Released
Status in ubuntu-system-settings-online-accounts package in Ubuntu:
In Progress
Status in ubuntu-weather-app package in Ubuntu:
Confirmed
Status in unity8 package in Ubuntu:
In Progress
Status in webbrowser-app package in Ubuntu:
Fix Released
Bug description:
The migration to 1.3 needs to happen in a coordinated way, so that
shell and all apps we care of migrate within the same OTA window to
reduce visual inconsistencies to a minimum.
This bug is a means to collect all the projects affected and keep tabs
on what's happening.
NOTES:
- The toolkit has the following modules:
Ubuntu.Components 1.3
Ubuntu.Components.ListItems 1.3
Ubuntu.Components.Pickers 1.3
Ubuntu.Components.Popups 1.3
Ubuntu.Components.Styles 1.3
Ubuntu.Components.Themes 1.3
Ubuntu.Components.Themes.Ambiance 1.3
Ubuntu.Components.Themes.SuruDark 1.3
- The following modules were not altered recently:
Ubuntu.Layouts 1.0
Ubuntu.PerformanceMetrics 1.0
- Theme is now theme (lowercase)
- PageHeadStyle now has a "config" property
In manifest.json file use:
"framework": "ubuntu-sdk-15.04.1-qml"
To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1508363/+subscriptions
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3
This bug was fixed in the package ubuntu-system-settings - 0.3+16.04.20151023.1-0ubuntu1 --- ubuntu-system-settings (0.3+16.04.20151023.1-0ubuntu1) xenial; urgency=medium [ CI Train Bot ] * New rebuild forced. [ Ken VanDine ] * Bump Ubuntu.Components imports to 1.3 and fixed UbuntuShape deprecations (LP: #1508363) [ jonas-drange ] * re-add silentMode property to repair the silent mode switch -- ci-train-...@canonical.com (Jonas G. Drange) Fri, 23 Oct 2015 14:57:29 + ** Changed in: ubuntu-system-settings (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1508363 Title: Coordinated migration to UITK 1.3 Status in Canonical System Image: In Progress Status in Ubuntu Music App: In Progress Status in Ubuntu Notes app: New Status in Ubuntu Calculator App: In Progress Status in Ubuntu Calendar App: New Status in Ubuntu Clock App: In Progress Status in Ubuntu Document Viewer App: In Progress Status in Ubuntu Shorts App: In Progress Status in Ubuntu Weather App: Triaged Status in Weather: New Status in address-book-app package in Ubuntu: In Progress Status in calendar-app package in Ubuntu: Confirmed Status in camera-app package in Ubuntu: Fix Released Status in dialer-app package in Ubuntu: In Progress Status in gallery-app package in Ubuntu: In Progress Status in messaging-app package in Ubuntu: In Progress Status in music-app package in Ubuntu: Confirmed Status in reminders-app package in Ubuntu: Fix Committed Status in ubuntu-clock-app package in Ubuntu: Confirmed Status in ubuntu-system-settings package in Ubuntu: Fix Released Status in ubuntu-system-settings-online-accounts package in Ubuntu: In Progress Status in ubuntu-weather-app package in Ubuntu: Confirmed Status in unity8 package in Ubuntu: In Progress Status in webbrowser-app package in Ubuntu: Fix Released Bug description: The migration to 1.3 needs to happen in a coordinated way, so that shell and all apps we care of migrate within the same OTA window to reduce visual inconsistencies to a minimum. This bug is a means to collect all the projects affected and keep tabs on what's happening. NOTES: - The toolkit has the following modules: Ubuntu.Components 1.3 Ubuntu.Components.ListItems 1.3 Ubuntu.Components.Pickers 1.3 Ubuntu.Components.Popups 1.3 Ubuntu.Components.Styles 1.3 Ubuntu.Components.Themes 1.3 Ubuntu.Components.Themes.Ambiance 1.3 Ubuntu.Components.Themes.SuruDark 1.3 - The following modules were not altered recently: Ubuntu.Layouts 1.0 Ubuntu.PerformanceMetrics 1.0 - Theme is now theme (lowercase) - PageHeadStyle now has a "config" property In manifest.json file use: "framework": "ubuntu-sdk-15.04.1-qml" To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1508363/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3
@Saviq: my question still stands :) -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1508363 Title: Coordinated migration to UITK 1.3 Status in Canonical System Image: In Progress Status in Ubuntu Music App: In Progress Status in Ubuntu Notes app: New Status in Ubuntu Calculator App: In Progress Status in Ubuntu Calendar App: New Status in Ubuntu Clock App: In Progress Status in Ubuntu Document Viewer App: In Progress Status in Ubuntu Shorts App: In Progress Status in Ubuntu Weather App: Triaged Status in Weather: New Status in address-book-app package in Ubuntu: In Progress Status in calendar-app package in Ubuntu: Confirmed Status in camera-app package in Ubuntu: Fix Released Status in dialer-app package in Ubuntu: In Progress Status in gallery-app package in Ubuntu: In Progress Status in messaging-app package in Ubuntu: In Progress Status in music-app package in Ubuntu: Confirmed Status in reminders-app package in Ubuntu: Fix Committed Status in ubuntu-clock-app package in Ubuntu: Confirmed Status in ubuntu-system-settings package in Ubuntu: In Progress Status in ubuntu-system-settings-online-accounts package in Ubuntu: In Progress Status in ubuntu-weather-app package in Ubuntu: Confirmed Status in unity8 package in Ubuntu: In Progress Status in webbrowser-app package in Ubuntu: Fix Released Bug description: The migration to 1.3 needs to happen in a coordinated way, so that shell and all apps we care of migrate within the same OTA window to reduce visual inconsistencies to a minimum. This bug is a means to collect all the projects affected and keep tabs on what's happening. NOTES: - The toolkit has the following modules: Ubuntu.Components 1.3 Ubuntu.Components.ListItems 1.3 Ubuntu.Components.Pickers 1.3 Ubuntu.Components.Popups 1.3 Ubuntu.Components.Styles 1.3 Ubuntu.Components.Themes 1.3 Ubuntu.Components.Themes.Ambiance 1.3 Ubuntu.Components.Themes.SuruDark 1.3 - The following modules were not altered recently: Ubuntu.Layouts 1.0 Ubuntu.PerformanceMetrics 1.0 - Theme is now theme (lowercase) - PageHeadStyle now has a "config" property In manifest.json file use: "framework": "ubuntu-sdk-15.04.1-qml" To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1508363/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
