[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56 into lp:~music-app-dev/music-app/media-hub-bg-playlists-rework

[Andrew Hayzen]

Andrew Hayzen has proposed merging 
lp:~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56 into 
lp:~music-app-dev/music-app/media-hub-bg-playlists-rework.

Commit message:
* Bump QtMultimedia import to 5.6 and remove unused ones

Requested reviews:
  Jim Hodapp (jhodapp)
  Music App Developers (music-app-dev)

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56/+merge/281145

* Bump QtMultimedia import to 5.6 and remove unused ones

Separate branch, as this isn't yet in the repositories :-)
-- 
Your team Music App Developers is requested to review the proposed merge of 
lp:~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56 into 
lp:~music-app-dev/music-app/media-hub-bg-playlists-rework.
=== modified file 'app/components/NewPlayer.qml'
--- app/components/NewPlayer.qml	2015-12-17 02:14:38 +
+++ app/components/NewPlayer.qml	2015-12-21 20:10:14 +
@@ -16,7 +16,7 @@
  * along with this program.  If not, see .
  */
 
-import QtMultimedia 5.4
+import QtMultimedia 5.6
 import QtQuick 2.4
 import Qt.labs.settings 1.0
 

=== modified file 'app/components/NowPlayingToolbar.qml'
--- app/components/NowPlayingToolbar.qml	2015-11-23 02:08:11 +
+++ app/components/NowPlayingToolbar.qml	2015-12-21 20:10:14 +
@@ -17,7 +17,7 @@
  * along with this program.  If not, see .
  */
 
-import QtMultimedia 5.0
+import QtMultimedia 5.6
 import QtQuick 2.4
 import Ubuntu.Components 1.3
 

=== modified file 'app/music-app.qml'
--- app/music-app.qml	2015-12-17 02:14:38 +
+++ app/music-app.qml	2015-12-21 20:10:14 +
@@ -22,7 +22,7 @@
 import Ubuntu.Components.Popups 1.3
 import Ubuntu.MediaScanner 0.1
 import Qt.labs.settings 1.0
-import QtMultimedia 5.0
+import QtMultimedia 5.6
 import QtQuick.LocalStorage 2.0
 import QtGraphicalEffects 1.0
 import "logic/stored-request.js" as StoredRequest

=== modified file 'app/ui/AddToPlaylist.qml'
--- app/ui/AddToPlaylist.qml	2015-10-28 01:05:33 +
+++ app/ui/AddToPlaylist.qml	2015-12-21 20:10:14 +
@@ -17,7 +17,6 @@
  * along with this program.  If not, see .
  */
 
-import QtMultimedia 5.0
 import QtQuick 2.4
 import Ubuntu.Components 1.3
 import QtQuick.LocalStorage 2.0

=== modified file 'app/ui/Playlists.qml'
--- app/ui/Playlists.qml	2015-10-28 01:05:33 +
+++ app/ui/Playlists.qml	2015-12-21 20:10:14 +
@@ -20,7 +20,6 @@
 
 import QtQuick 2.4
 import Ubuntu.Components 1.3
-import QtMultimedia 5.0
 import QtQuick.LocalStorage 2.0
 import "../logic/playlists.js" as Playlists
 import "../components"

=== modified file 'app/ui/Recent.qml'
--- app/ui/Recent.qml	2015-10-28 01:05:33 +
+++ app/ui/Recent.qml	2015-12-21 20:10:14 +
@@ -21,7 +21,6 @@
 import Ubuntu.Components 1.3
 import Ubuntu.MediaScanner 0.1
 import Ubuntu.Thumbnailer 0.1
-import QtMultimedia 5.0
 import QtQuick.LocalStorage 2.0
 import "../logic/meta-database.js" as Library
 import "../logic/playlists.js" as Playlists

=== modified file 'app/ui/Songs.qml'
--- app/ui/Songs.qml	2015-12-17 02:14:38 +
+++ app/ui/Songs.qml	2015-12-21 20:10:14 +
@@ -21,7 +21,6 @@
 import Ubuntu.Components 1.3
 import Ubuntu.MediaScanner 0.1
 import Ubuntu.Thumbnailer 0.1
-import QtMultimedia 5.0
 import QtQuick.LocalStorage 2.0
 import "../logic/playlists.js" as Playlists
 import "../components"

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/add-non-google-support into lp:ubuntu-rssreader-app

[Roman Shchekin]

The proposal to merge lp:~qqworini/ubuntu-rssreader-app/add-non-google-support 
into lp:ubuntu-rssreader-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/add-non-google-support/+merge/280614
-- 
Your team Ubuntu Shorts Developers is subscribed to branch 
lp:ubuntu-rssreader-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into lp:ubuntu-docviewer-app

[Stefano Verzegnassi]

The proposal to merge lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into lp:ubuntu-docviewer-app

[noreply]

The proposal to merge lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into 
lp:ubuntu-docviewer-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into lp:ubuntu-docviewer-app

[Jenkins Bot]

Review: Approve continuous-integration


-- 
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

[Vamshi Balanaga]

I didn't make any changes to the .db files. All I did was change the
schemaVersion in the .sql files to 10. I tried converting those .sql files
to .db files but I got some errors and when I told Nicholas he said that I
don't need to do that, and that I should leave the .db files as they are.

Vamshi Balanaga

On Mon, Dec 21, 2015 at 7:21 AM, Andrew Hayzen  wrote:

> The error is "Could not initialise media store: Tried to open a db with
> schema version 9, while supported version is 10."
>
> bzr thinks that the mediastore.db has been modified, so what changes have
> been made to that?
>
> === modified file
> 'tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db'
> Binary files
> tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db 2015-11-01
> 16:17:33 + and
> tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db 2015-12-20
> 00:11:18 + differ
> --
>
> https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794
> You are the owner of lp:~vamrocks602/music-app/test-empty-library.
>

-- 
https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into lp:ubuntu-docviewer-app

[Stefano Verzegnassi]

Review: Approve

LGTM. Good job, thanks!
-- 
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/music-app/READMEs into lp:music-app

[Jenkins Bot]

Review: Approve continuous-integration


-- 
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/music-app/READMEs into lp:music-app

[Andrew Hayzen]

The proposal to merge lp:~emailgirishrawat/music-app/READMEs into lp:music-app 
has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

[Victor Thompson]

Review: Needs Fixing

Vamshi,

It seems that the test you added is failing: http://paste.ubuntu.com/14134202/

Should "get_LibraryEmptyState" actually be "get_library_empty_state_page" or 
something else perhaps?
-- 
https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app

[Girish]

Girish has proposed merging lp:~emailgirishrawat/ubuntu-calculator-app/READMEs 
into lp:ubuntu-calculator-app.

Commit message:
Updated and extended READMEs.

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)

For more details, see:
https://code.launchpad.net/~emailgirishrawat/ubuntu-calculator-app/READMEs/+merge/281174

Updated and extended READMEs.
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed 
merge of lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into 
lp:ubuntu-calculator-app.
=== removed file 'README'
--- README	2015-11-27 11:57:09 +
+++ README	1970-01-01 00:00:00 +
@@ -1,83 +0,0 @@
-# Ubuntu Calculator App
-Default Calculator application for Ubuntu devices.
-
-# Useful links
-- Project page: https://launchpad.net/ubuntu-calculator-app
-- Design page:
-  https://docs.google.com/presentation/d/1EiIELGizPHrd0TY7JdNwULbiqPYfOyEEI5CS87n7QlY/edit
-
-
-# How to develop
-
-
-## Calculation engine.
-
-Current calculation engine is math.js version 1.1.0. 
-You could download latest version from webpage:
-http://mathjs.org
-
-The engine was sligtly modified to properly work with Ubuntu-Calculator-App.
-
-
-## Style guide
-
-General idea above style guide is:
-"All code in any code-base should look like a single person typed it, no matter how many people contributed."
-
-If you're editing code, take a few minutes to look at the code around you and determine its style. If they use spaces around all their arithmetic operators, you should too. If their comments have little boxes of hash marks around them, make your comments have little boxes of hash marks around them too.
-
-The point of having style guidelines is to have a common vocabulary of coding so people can concentrate on what you're saying rather than on how you're saying it. If code you add to a file looks drastically different from the existing code around it, it throws readers out of their rhythm when they go to read it. Avoid this.
-
-More information about style guides, and why we need it:
-http://addyosmani.com/blog/javascript-style-guides-and-beautifiers/
-
-Curent style guide for ubuntu-calculator-app is:
-https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml
-
-
-## Clean/Beautiful Code
-
-When you creating code, every function/variable name should be meaningful and has easy to understand form. The names should reveal intent of creator. With good names you even do not need an comments. The code is documentting itself. We should avoid comments if it is not necessary.
-If someone during review, ask you to add comment then you should check if names are reveal your intent.
-
-More information about clean/beautiful code is available in books:
- * Clean Code: A Handbook of Agile Software Craftsmanship Paperback, by Robert C. Martin
- * Beautiful Code: Leading Programmers Explain How They Think, by Andy Oram
-
-
-## Run the autopilot tests
-
-Prerequisites:
-sudo apt-get install ubuntu-ui-toolkit-autopilot
-
-Once the app has been built, you can go to the build directory and run:
-
-cd tests/autopilot
-autopilot run ubuntu_calculator_app
-
-
-## Profiling calculator
-
-To successfuly run profiler on your device, you must modify ubuntu-calculator-app.apparmor file,
-and add "networking" policy group:
-
- "policy_groups": [
-"networking"
- ],
-
-The bug was already submitted at:
-https://bugs.launchpad.net/ubuntu-sdk-ide/+bug/1520551
-
-Next you will need follow instruction:
-
- 1. Connect your device to PC and make sure it is unlocked, and Developer Mode is enable
- 2. Run Ubuntu SDK IDE
- 3. Open Calculator project and generate Unix Makefiles for Arm.
- 4. Select Analyze > QML Profiler 
- 5. Select the Start button to start Calculator from the QML Profiler.
- 6. After reproduce issue you must press Stop button.
-
-More information about profiling is available at:
-http://doc.qt.io/qtcreator/creator-qml-performance-monitor.html
-
-

=== added file 'README-Autopilot.md'
--- README-Autopilot.md	1970-01-01 00:00:00 +
+++ README-Autopilot.md	2015-12-22 06:35:00 +
@@ -0,0 +1,79 @@
+Running Autopilot tests
+===
+
+The calculator app follows a test driven development where autopilot tests are run before every merge into trunk. If you are submitting your bugfix/patch to the calculator app, please follow the following steps below to ensure that all tests pass before proposing a merge request.
+
+If you are looking for more info about Autopilot or writing AP tests for the calculator app, here are some useful links to help you:
+
+- [Ubuntu - Quality](http://developer.ubuntu.com/start/quality)
+- [Ubuntu - Autopilot](https://developer.ubuntu.com/api/autopilot/python/1.5.0/)
+
+For help and options on running tests, see:
+
+- [Autopilot Tests](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/)
+
+Prerequisites
+=
+
+Install the following autopilot packages required to run the tests,
+

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/music-app/READMEs into lp:music-app

[Victor Thompson]

Review: Approve

LGTM! Thanks! Don't forget to add a commit message.
-- 
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/music-app/READMEs into lp:music-app

[Andrew Hayzen]

Review: Needs Fixing

LGTM, just one comment

1) Could you update the design doc link, as you did with weather?

Diff comments:

> 
> === added file 'README.md'
> --- README.md 1970-01-01 00:00:00 +
> +++ README.md 2015-12-18 17:05:23 +
> @@ -0,0 +1,25 @@
> +ReadMe - Ubuntu Music App
> +===
> +Ubuntu Music App is the official music app for Ubuntu Touch. We follow an 
> open
> +source model where the code is available to anyone to branch and hack on. The
> +ubuntu music app follows a test driven development (TDD) where tests are
> +written in parallel to feature implementation to help spot regressions 
> easier.
> +
> +Dependencies
> +
> +**DEPENDENCIES ARE NEEDED TO BE INSTALLED TO BUILD AND RUN THE APP**.
> +
> +A complete list of dependencies for the project can be found in 
> music-app/debian/control
> +
> +The following essential packages are also required to develop this app:
> +* [ubuntu-sdk](http://developer.ubuntu.com/start)
> +* intltool   - run  `sudo apt-get install intltool` 
> +
> +Useful Links
> +
> +Here are some useful links with regards to the Music App development.
> +
> +* [Home Page](https://developer.ubuntu.com/en/community/core-apps/music/)
> +* [Music App Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Music)
> +* 
> [Designs](https://docs.google.com/presentation/d/1L3eGhOe-0eEmKtUurthpUEaweFradSFb3t6W-KiIZMU/edit#slide=id.g3e005603e_420)

Could you update the design doc link, as you did with weather?

> +* [Project page](https://launchpad.net/music-app) 


-- 
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/music-app/READMEs into lp:music-app

[Andrew Hayzen]

Review: Approve

LGTM, thanks for the changes :-)
-- 
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/music-app/READMEs into lp:music-app

[Andrew Hayzen]

The proposal to merge lp:~emailgirishrawat/music-app/READMEs into lp:music-app 
has been updated.

Commit Message changed to:

Expanded and updated READMEs.

For more details, see:
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/music-app/READMEs into lp:music-app

[Girish]

The proposal to merge lp:~emailgirishrawat/music-app/READMEs into lp:music-app 
has been updated.

Commit Message changed to:

Updated design section in README.md

For more details, see:
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app

[Gary.Wang]

leave a comment for Kunal's suggestion.

Diff comments:

> 
> === modified file 'TimeLineBase.qml'
> --- TimeLineBase.qml  2015-08-20 12:27:59 +
> +++ TimeLineBase.qml  2015-11-27 01:49:25 +
> @@ -221,28 +221,27 @@
>  if (event.endDateTime - day  == 0)
>  return;
>  
> -if (event.endDateTime.getDate() - day.getDate() == 0 &&
> -event.startDateTime.getDate() - day.getDate() == 0) {
> +if (event.endDateTime.isSameDay(day) &&
> +event.endDateTime.isSameDay(event.startDateTime)) {
>  hour = event.startDateTime.getHours();
>  yPos = (( event.startDateTime.getMinutes() * hourHeight) / 60) + 
> hour * hourHeight
> -durationMin = (event.endDateTime.getHours() - 
> event.startDateTime.getHours()) * 60;
> -durationMin += (event.endDateTime.getMinutes() - 
> event.startDateTime.getMinutes());
> +durationMin = (event.endDateTime - event.startDateTime)  / 
> Date.msPerMin;
>  }
> -if (event.endDateTime.getDate() - day.getDate() == 0 &&
> -event.startDateTime - day < 0) {
> +if (!event.startDateTime.isSameDay(day) &&
> +event.endDateTime.isSameDay(day)) {
>  hour = 0;
>  yPos = 0;
>  durationMin = event.endDateTime.getHours() * 60;
>  durationMin += event.endDateTime.getMinutes();
>  }
> -if (event.startDateTime.getDate() - day.getDate() == 0 &&
> -event.endDateTime - day >= Date.msPerDay) {
> +if (event.startDateTime.isSameDay(day) &&
> +!event.endDateTime.isSameDay(day)) {
>  hour = event.startDateTime.getHours();
>  yPos = (( event.startDateTime.getMinutes() * hourHeight) / 60) + 
> hour * hourHeight
>  durationMin = (24 - event.startDateTime.getHours()) * 60;
>  }
> -if (event.endDateTime - day  >= Date.msPerDay &&
> -event.startDateTime- day <= 0) {
> +if (!event.startDateTime.isSameDay(day) &&

@Kunal, Sorry for the late reply. 
Thanks for your comment.
This MR is mainly about issues lp #1515722 and lp #1523594
If these two issues are fixed with this MR. It's better we can merge it.

For UI, personally I prefer to keep current implementation(filling whole 
timeline) since we have it for a period of time. This is a minor issue.But 
anyway please have a check with UX team about it.
We can create another bug for this if UX team think "event displays in whole 
day section" is a better user experience.
But currently we're blocked by this *minor* issue.
Thanks. How about your ideas?

> +!event.endDateTime.isSameDay(day)) {
>  hour = 0;
>  yPos = 0;
>  durationMin = 24 * 60;


-- 
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1515722/+merge/278759
Your team Ubuntu Calendar Developers is requested to review the proposed merge 
of lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/add-non-google-support into lp:ubuntu-rssreader-app

[noreply]

The proposal to merge lp:~qqworini/ubuntu-rssreader-app/add-non-google-support 
into lp:ubuntu-rssreader-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/add-non-google-support/+merge/280614
-- 
Your team Ubuntu Shorts Developers is subscribed to branch 
lp:ubuntu-rssreader-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/music-app/READMEs into lp:music-app

[noreply]

The proposal to merge lp:~emailgirishrawat/music-app/READMEs into lp:music-app 
has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

[Victor Thompson]

The proposal to merge lp:~vamrocks602/music-app/test-empty-library into 
lp:music-app has been updated.

Commit Message changed to:

* Add test to make sure that the LibraryEmptyState page is visible when no 
music is detected on the device.

For more details, see:
https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

[Andrew Hayzen]

The error is "Could not initialise media store: Tried to open a db with schema 
version 9, while supported version is 10."

bzr thinks that the mediastore.db has been modified, so what changes have been 
made to that?

=== modified file 
'tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db'
Binary files tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db 
2015-11-01 16:17:33 + and 
tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db 2015-12-20 
00:11:18 + differ
-- 
https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into lp:ubuntu-docviewer-app

[Girish]

Fixed.
-- 
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into lp:ubuntu-docviewer-app

[Stefano Verzegnassi]

Review: Needs Fixing

Hi,

Thanks for this big improvement!

I had a look at your MP and overall it looks very good.
However, some minor change is required in order to reflect the current status 
of the project.

* Some of the Autopilot tests are currently broken.
  It may be worth to point that out in the 'README-Mergeproposal.md' file, 
explaining that they aren't strictly required at the moment. The same goes for 
'README-Autopilot.md' file.

* In the 'README-Developers.md' file, we mention that LibreOffice 5.0 is not 
available in the archive. This is no longer true, since it's available in 
Ubuntu 15.10 archives.
  For earlier release, we may want to refer to the following PPA, which 
includes only stable releases: 
 ppa:libreoffice/libreoffice-5-0

* Still in the same file, in the 'Compiling" section, it may be useful to 
specify that a working internet connection is required in order to build the 
project, since a number of Debian packages are downloaded when the project is 
loaded the first time through (e.g.) QtCreator.

* Still a small correction to 'README-Mergeproposal'.
  The line:
"Does the MP change the UI? If Yes, has it been approved by design?"
  does not reflect our current workflow, since a large part of the UI hasn't 
been approved by the design team (it has been approved by the devs instead).
  Please replace that line with:
"Does the MP change the UI? If Yes, has it been approved by design, or 
discussed with some of the DocViewer developers?"

Thanks again!

-- 
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp