Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-weather-app/fix-control-depends-01 into lp:ubuntu-weather-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Continuous integration, rev:196
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/84/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/350/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/84/rebuild

-- 
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/fix-control-depends-01/+merge/282241
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~ahayzen/ubuntu-weather-app/fix-control-depends-01 into 
lp:ubuntu-weather-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/ubuntu-weather-app/fix-control-depends-01 into lp:ubuntu-weather-app

[Andrew Hayzen]

Andrew Hayzen has proposed merging 
lp:~ahayzen/ubuntu-weather-app/fix-control-depends-01 into 
lp:ubuntu-weather-app.

Commit message:
* Fixes for missing packages in debian/control

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/fix-control-depends-01/+merge/282241

* Fixes for missing packages in debian/control

On a blank install in Wily I had to manually install these packages to get the 
weather-app to run.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge 
of lp:~ahayzen/ubuntu-weather-app/fix-control-depends-01 into 
lp:ubuntu-weather-app.
=== modified file 'debian/changelog'
--- debian/changelog	2015-12-17 02:29:07 +
+++ debian/changelog	2016-01-12 00:13:20 +
@@ -2,6 +2,7 @@
 
   [ Andrew Hayzen ]
   * Release 3.1 and bump version to 3.2
+  * Fixes for missing packages in debian/control
 
   [ Girish Rawat ]
   * Added new READMEs

=== modified file 'debian/control'
--- debian/control	2015-02-09 16:36:43 +
+++ debian/control	2016-01-12 00:13:20 +
@@ -22,6 +22,8 @@
 Depends: qmlscene,
  qtdeclarative5-localstorage-plugin,
  qml-module-qt-labs-settings,
+ qtdeclarative5-qtlocation-plugin,
+ qtdeclarative5-qtpositioning-plugin,
  qtdeclarative5-qtquick2-plugin,
  qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
  suru-icon-theme | ubuntu-mobile-icons,

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/cards-use-gridview into lp:music-app

[Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:963
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/85/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/351/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/85/rebuild

-- 
https://code.launchpad.net/~ahayzen/music-app/cards-use-gridview/+merge/279700
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

[Carlos Jose Mazieri]

I will fix that, thanks.
-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02/+merge/280388
Your team Ubuntu File Manager Developers is subscribed to branch 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/cards-use-gridview into lp:music-app

[noreply]

The proposal to merge lp:~ahayzen/music-app/cards-use-gridview into 
lp:music-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/cards-use-gridview/+merge/279700
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/cards-use-gridview into lp:music-app

[Victor Thompson]

The proposal to merge lp:~ahayzen/music-app/cards-use-gridview into 
lp:music-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/cards-use-gridview/+merge/279700
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/cards-use-gridview into lp:music-app

[Victor Thompson]

Review: Approve

lgtm! Thanks! :)
-- 
https://code.launchpad.net/~ahayzen/music-app/cards-use-gridview/+merge/279700
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/20/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1420/console

-- 
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix/+merge/282083
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app

[Jenkins Bot]

The proposal to merge 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix
 into lp:ubuntu-calculator-app has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix/+merge/282083
-- 
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-multiline-support into lp:ubuntu-calculator-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/21/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1421/console

-- 
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-multiline-support/+merge/278897
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app

[Bartosz Kosiorek]

Review: Needs Fixing

We would like to press virtual keyboard of calculator, and not keys from On 
Screen Keyboard (OSK):

  File 
"/tmp/adt-run.gw7Oyz/deps/usr/lib/python3/dist-packages/ubuntu_keyboard/emulators/keyboard.py",
 line 211, in type
self.press_key(char)
  File 
"/tmp/adt-run.gw7Oyz/deps/usr/lib/python3/dist-packages/ubuntu_keyboard/emulators/keyboard.py",
 line 165, in press_key
raise RuntimeError("Keyboard is not on screen")
RuntimeError: Keyboard is not on screen
-- 
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix/+merge/282083
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-multiline-support into lp:ubuntu-calculator-app

[Jenkins Bot]

The proposal to merge 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-multiline-support
 into lp:ubuntu-calculator-app has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-multiline-support/+merge/278897
-- 
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app

[Bartosz Kosiorek]

The proposal to merge 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view
 into lp:ubuntu-calculator-app has been updated.

Status: Work in progress => Approved

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view/+merge/282264
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed 
merge of 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view
 into lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app

[Bartosz Kosiorek]

The proposal to merge 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix
 into lp:ubuntu-calculator-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix/+merge/282083
-- 
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-multiline-support into lp:ubuntu-calculator-app

[Bartosz Kosiorek]

The proposal to merge 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-multiline-support
 into lp:ubuntu-calculator-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-multiline-support/+merge/278897
-- 
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix into lp:ubuntu-calculator-app

[Bartosz Kosiorek]

Review: Needs Fixing

It seems that it is unable to press any key in calculator:

05:18:39.231 INFO _logging:41 - 

05:18:39.232 INFO _logging:42 - Starting test 
ubuntu_calculator_app.tests.test_main.MainTestCase.test_simple_calculation_via_keyboard
05:18:39.279 WARNING testcase:181 - Process manager backend unavailable, 
application snapshot support disabled.
05:18:39.282 INFO logging:45 - MainTestCase: launch_test_click. Arguments (). 
Keyword arguments: {}.
05:18:39.282 INFO _launcher:299 - Attempting to launch click application 
'(default)' from click package  'com.ubuntu.calculator' and URIs ''
05:18:40.442 INFO _launcher:123 - Attempting to launch application 
'com.ubuntu.calculator_calculator_2.0.258' with URIs '' via upstart-app-launch
05:18:47.923 ERROR testresult:44 - ERROR: 
ubuntu_calculator_app.tests.test_main.MainTestCase.test_simple_calculation_via_keyboard
05:18:47.924 ERROR testresult:44 - /var/log/syslog: {{{
Jan 12 05:18:40 ubuntu-phablet powerd[997]: handle_requestSysState from :1.64 
(active) - ACTIVE (1)
Jan 12 05:18:40 ubuntu-phablet powerd[997]: name_watch_add: looking for :1.64
Jan 12 05:18:40 ubuntu-phablet powerd[997]: watching :1.64 to see when it 
disappears on dbus
Jan 12 05:18:40 ubuntu-phablet powerd[997]: libsuspend: acquire_wake_lock: 
powerd_power_request
Jan 12 05:18:40 ubuntu-phablet powerd[997]: handle_requestSysState - SUCCESS
Jan 12 05:18:40 ubuntu-phablet powerd[997]: Enqueue state change to ACTIVE
Jan 12 05:18:40 ubuntu-phablet powerd[997]: queue empty && state == current, 
discarding
Jan 12 05:18:40 ubuntu-phablet powerd[997]: libsuspend: release_wake_lock: 
powerd_power_request
Jan 12 05:18:47 ubuntu-phablet powerd[997]: handle_clearSysState from :1.64, 
cookie: c0b8d061-d91a-4615-833a-738e4afb8a93
Jan 12 05:18:47 ubuntu-phablet powerd[997]: clear_sys_request: active - :1.64
Jan 12 05:18:47 ubuntu-phablet powerd[997]: name_watch_remove: looking for :1.64
Jan 12 05:18:47 ubuntu-phablet powerd[997]: name_watch: ref_count for :1.64 is 
now 0
Jan 12 05:18:47 ubuntu-phablet powerd[997]: no longer watching :1.64, there are 
no more requests
Jan 12 05:18:47 ubuntu-phablet powerd[997]: libsuspend: acquire_wake_lock: 
powerd_power_request
Jan 12 05:18:47 ubuntu-phablet powerd[997]: Enqueue state change to ACTIVE
Jan 12 05:18:47 ubuntu-phablet powerd[997]: queue empty && state == current, 
discarding
Jan 12 05:18:47 ubuntu-phablet powerd[997]: libsuspend: release_wake_lock: 
powerd_power_request
Jan 12 05:18:47 ubuntu-phablet dbus[863]: [system] Activating service 
name='com.canonical.PropertyService' (using servicehelper)
Jan 12 05:18:47 ubuntu-phablet dbus[863]: [system] Successfully activated 
service 'com.canonical.PropertyService'
}}}
05:18:47.925 ERROR testresult:44 - traceback: {{{
Traceback (most recent call last):
  File 
"/tmp/adt-run.gw7Oyz/tree/tests/autopilot/ubuntu_calculator_app/tests/test_main.py",
 line 17, in test_simple_calculation_via_keyboard
self.app.main_view.enter_text_via_keyboard('.9')
  File 
"/tmp/adt-run.gw7Oyz/tree/tests/autopilot/ubuntu_calculator_app/__init__.py", 
line 187, in enter_text_via_keyboard
ubuntuuitoolkit.get_keyboard().type(textToEnter, delay=0.1)
  File 
"/tmp/adt-run.gw7Oyz/deps/usr/lib/python3/dist-packages/autopilot/input/_osk.py",
 line 105, in type
self._keyboard.type(string, delay)
  File 
"/tmp/adt-run.gw7Oyz/deps/usr/lib/python3/dist-packages/ubuntu_keyboard/emulators/keyboard.py",
 line 211, in type
self.press_key(char)
  File 
"/tmp/adt-run.gw7Oyz/deps/usr/lib/python3/dist-packages/ubuntu_keyboard/emulators/keyboard.py",
 line 165, in press_key
raise RuntimeError("Keyboard is not on screen")
RuntimeError: Keyboard is not on screen
}}}
-- 
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-bottom-row-fix/+merge/282083
Your team Ubuntu Calculator Developers is subscribed to branch 
lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Continuous integration, rev:258
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/86/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/352/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/86/rebuild

-- 
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view/+merge/282264
Your team Ubuntu Calculator Developers is requested to review the proposed 
merge of 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view
 into lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app

[Jenkins Bot]

The proposal to merge 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view
 into lp:ubuntu-calculator-app has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view/+merge/282264
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed 
merge of 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view
 into lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/22/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1422/console

-- 
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view/+merge/282264
Your team Ubuntu Calculator Developers is requested to review the proposed 
merge of 
lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view
 into lp:ubuntu-calculator-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app

[Victor Thompson]

Review: Needs Fixing

This is looking pretty good. I have some inline comments. The only other minor 
thing is to update the copyright header where appropriate with 2016.

Also, I mentioned this before: I think we need to put something in the control 
file to require the new media-hub and other packages be installed.

Diff comments:

> 
> === modified file 'app/components/MusicToolbar.qml'
> --- app/components/MusicToolbar.qml   2015-08-12 23:36:44 +
> +++ app/components/MusicToolbar.qml   2016-01-12 01:08:02 +
> @@ -260,16 +261,27 @@
>  }
>  color: UbuntuColors.blue
>  height: parent.height
> -width: player.duration > 0 ? (player.position / 
> player.duration) * playerControlsProgressBar.width : 0
> +width: player.mediaPlayer.progress * 
> playerControlsProgressBar.width
> +
> +// FIXME: Workaround for pad.lv/1494031 by querying gst as 
> it does not
> +// emit until it changes to the PLAYING state. But by asking 
> for a
> +// value we get gst to perform a query and return a result
> +// However this has to be done once the source is set, hence 
> the delay
> +//
> +// NOTE: This does not solve when the currentIndex is 
> removed though
> +Timer {
> +id: refreshProgressTimer
> +interval: 48

Is there a reason this length of time was chosen?

> +repeat: false
> +onTriggered: playerControlsProgressBarHint.width = 
> player.mediaPlayer.progress * playerControlsProgressBar.width
> +}
>  
>  Connections {
> -target: player
> -onPositionChanged: {
> -playerControlsProgressBarHint.width = 
> (player.position / player.duration) * playerControlsProgressBar.width
> -}
> -onStopped: {
> -playerControlsProgressBarHint.width = 0;
> -}
> +target: player.mediaPlayer.playlist
> +// Call timer when source or index changes
> +// so we call even if there are duplicate sources or 
> source removal
> +onCurrentItemSourceChanged: refreshProgressTimer.start()
> +onCurrentIndexChanged: refreshProgressTimer.start()
>  }
>  }
>  }
> 
> === added file 'app/components/Player.qml'
> --- app/components/Player.qml 1970-01-01 00:00:00 +
> +++ app/components/Player.qml 2016-01-12 01:08:02 +
> @@ -0,0 +1,355 @@
> +/*
> + * Copyright (C) 2015
> + *  Andrew Hayzen 
> + *  Victor Thompson 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 3.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see .
> + */
> +
> +import QtMultimedia 5.6
> +import QtQuick 2.4
> +import Qt.labs.settings 1.0
> +
> +import QtQuick.LocalStorage 2.0
> +import "../logic/meta-database.js" as Library
> +
> +Item {
> +objectName: "player"
> +
> +// For autopilot as we can't access the MediaPlayer object pad.lv/1269578
> +readonly property bool isPlaying: mediaPlayerObject.playbackState === 
> MediaPlayer.PlayingState
> +readonly property alias count: mediaPlayerPlaylist.itemCount
> +readonly property alias currentIndex: mediaPlayerPlaylist.currentIndex
> +readonly property alias currentItemSource: 
> mediaPlayerPlaylist.currentItemSource
> +readonly property alias position: mediaPlayerObject.position
> +
> +// FIXME: pad.lv/1269578 use Item as autopilot cannot 'see' a 
> var/QtObject

Hasn't this bug been fixed and released?

> +property alias currentMeta: currentMetaItem
> +
> +property alias mediaPlayer: mediaPlayerObject
> +property alias repeat: settings.repeat
> +property alias shuffle: settings.shuffle
> +
> +Item {
> +id: currentMetaItem
> +objectName: "currentMeta"
> +
> +property string album: ""
> +property string art: ""
> +property string author: ""
> +property string filename: ""
> +property string title: ""
> +}
> +
> +// Return the metadata for the source given from mediascanner2
> +function metaForSource(source) {
> +var blankMeta = {
> +album: "",
> +art: 

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app

[Gary.Wang]

Looks like Jenkins issue:
DEBUG: jenkins job parameter [use_description_for_commit]: not found

-- 
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/add_prefix/+merge/267317
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Continuous integration, rev:744
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/80/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/346/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/80/rebuild

-- 
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/add_prefix/+merge/267317
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app

[Gary.Wang]

Looks like Jenkins issue:
DEBUG: jenkins job parameter [use_description_for_commit]: not found

-- 
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1515722/+merge/278759
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Continuous integration, rev:744
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/81/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/347/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/81/rebuild

-- 
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1515722/+merge/278759
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Jenkins Bot]

The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into 
lp:music-app has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/16/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1416/console

-- 
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Jenkins Bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:965
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/83/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/349/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/83/rebuild

-- 
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Nicholas Skaggs]

Turns out the human is at fault here. The autolanding job(s) were a bit 
misconfigured on a couple params.
-- 
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Jenkins Bot]

The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into 
lp:music-app has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Jenkins Bot]

The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into 
lp:music-app has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[noreply]

The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into 
lp:music-app has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Nicholas Skaggs]

The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into 
lp:music-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/15/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1415/console

-- 
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Nicholas Skaggs]

The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into 
lp:music-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Nicholas Skaggs]

The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into 
lp:music-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/14/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1414/console

-- 
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Continuous integration, rev:744
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/82/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/348/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/82/rebuild

-- 
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1515722/+merge/278759
Your team Ubuntu Calendar Developers is subscribed to branch 
lp:ubuntu-calendar-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] sboichakov-gmail deactivated by sboichakov-gmail

[Ubuntu File Manager Developers]

Hello Ubuntu Core Apps Reviewers,

The membership status of Sboichakov Dmitriy (sboichakov-gmail) in the
team Ubuntu File Manager Developers (ubuntu-filemanager-dev) was changed
by the user from Approved to Deactivated.


-- 
You received this email because your team Ubuntu Core Apps Reviewers is an 
admin of the Ubuntu File Manager Developers team.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Jenkins Bot]

Review: Needs Fixing continuous-integration

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/13/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1413/console

-- 
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1526274-use-layouts into lp:music-app

[Nicholas Skaggs]

The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into 
lp:music-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
-- 
Your team Music App Developers is subscribed to branch lp:music-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp