[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app has been updated. Commit Message changed to: Changes authentication dialogue to "Enter passcode or passphrase" instead of "Enter password", to be more in line with other parts of the OS For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot. https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/29/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1430/console -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
Review: Approve continuous-integration -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/28/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1429/console -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1533383] Re: undefined symbol lookup error: _ZN6QDebugD1Ev on filemanager_0.4.501 version
thanks in advance, looking for .click old version one -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1533383 Title: undefined symbol lookup error: _ZN6QDebugD1Ev on filemanager_0.4.501 version Status in Ubuntu File Manager App: New Bug description: filemanager_0.4.501 isn't working on nexus 4(mako) S.O. Ubuntu 14.10(r226) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1533383/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1533383] [NEW] undefined symbol lookup error: _ZN6QDebugD1Ev on filemanager_0.4.501 version
Public bug reported: filemanager_0.4.501 isn't working on nexus 4(mako) S.O. Ubuntu 14.10(r226) ** Affects: ubuntu-filemanager-app Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1533383 Title: undefined symbol lookup error: _ZN6QDebugD1Ev on filemanager_0.4.501 version Status in Ubuntu File Manager App: New Bug description: filemanager_0.4.501 isn't working on nexus 4(mako) S.O. Ubuntu 14.10(r226) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1533383/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app
Review: Needs Fixing all the failures I see seem correct. I run the test by hand and it doesn't work as the test says it should. Are you sure the functionality is correct? run3:10: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_adding_comma_without_number_on_temp_result run3:44: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_simple_calculation_via_keyboard run3:78: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_temporarly_result -- https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view/+merge/282264 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406 -- Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/27/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1428/console -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/calendar-app-autolanding/12/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1427/console -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406 -- Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/26/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1426/console -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/Uitk1_3 into lp:ubuntu-calendar-app
Review: Needs Fixing It still overlaps on long month names. I think we need to switch to the short version of the month name so they fit, or perhaps use a smaller font. http://people.canonical.com/~alan/screenshots/device-2016-01-12-205023.png -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/Uitk1_3/+merge/276338 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Commit Message changed to: Fix missing commit message. For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/25/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1425/console -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/24/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1424/console -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:623 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/90/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/357/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/90/rebuild -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize/+merge/254398 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app
Review: Needs Information
added inline comment
Diff comments:
>
> === modified file 'MonthComponentDateDelegate.qml'
> --- MonthComponentDateDelegate.qml2015-09-05 05:30:23 +
> +++ MonthComponentDateDelegate.qml2016-01-12 18:02:54 +
> @@ -9,20 +9,21 @@
> property bool isToday;
> property bool showEvent;
> property alias fontSize: dateLabel.font.pixelSize
> -
> property bool isSelected: false
>
> -Loader {
> -sourceComponent: (isToday && isCurrentMonth) || isSelected ?
> highLightComp : undefined
> +UbuntuShape{
I don't know now how heavy UbuntuShape component is, but this will create
UbuntuShape for every date displayed on month and year. Which occupies memory
unnecessarily. If Loader is not suitable here then we should just use
dynamically to create UbuntuShape when needed.
> +visible: (isToday && isCurrentMonth) || isSelected
> +color: isToday && !isSelected ? "#DD4814" : "gray"
>
> -onSourceComponentChanged: {
> -width = Qt.binding( function() {
> -var width = dateRootItem.height > dateRootItem.width ?
> dateRootItem.width :dateRootItem.height
> -return ( width / 1.3 );
> -});
> -height = Qt.binding ( function() { return width} );
> -anchors.centerIn = Qt.binding( function() { return dateLabel});
> +Rectangle{
> +anchors.fill: parent
> +anchors.margins: units.gu(0.5)
> +color: isToday ? "#DD4814" : "darkgray"
> }
> +
> +width: Math.min(parent.height, parent.width) / 1.3
> +height: width
> +anchors.centerIn: dateLabel
> }
>
> Label {
> @@ -47,46 +48,19 @@
> }
> }
>
> -Loader{
> -sourceComponent: showEvent ? eventIndicatorComp : undefined
> -onSourceComponentChanged: {
> -width = Qt.binding( function() { return units.gu(0.8)})
> -height = Qt.binding( function() { return width })
> -anchors.horizontalCenter = Qt.binding( function() { return
> parent.horizontalCenter })
> -anchors.top = Qt.binding( function() { return
> parent.verticalCenter })
> -anchors.topMargin = Qt.binding( function() {
> -var w = (dateRootItem.height > dateRootItem.width ?
> dateRootItem.width :dateRootItem.height)/1.3
> -return (w/2) + units.gu(0.1)
> -});
> -}
> -}
> -
> -Component{
> -id: eventIndicatorComp
> -Rectangle {
> -anchors.fill: parent
> -radius: height/2
> -color: "black"
> -}
> -}
> -
> -Component{
> -id: highLightComp
> -UbuntuShape{
> -color: {
> -if( isToday && !isSelected ) {
> -"#DD4814"
> -} else {
> -"gray"
> -}
> -}
> -
> -Rectangle{
> -anchors.fill: parent
> -anchors.margins: units.gu(0.5)
> -color: isToday ? "#DD4814" : "darkgray"
> -}
> -}
> +Rectangle {
Same comment as for Highlight visual
> +id: eventIndicator
> +
> +width: units.gu(0.8)
> +height: width
> +anchors {
> +horizontalCenter: parent.horizontalCenter
> +top: parent.verticalCenter
> +topMargin: ((Math.min(parent.height, dateRootItem.width) / 1.3)
> / 2) + units.gu(0.1)
> +}
> +radius: height/2
> +color:"black"
> +visible: showEvent
> }
>
> MouseArea {
--
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize/+merge/254398
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 -- Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/23/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1423/console -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:623 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/89/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/356/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/89/rebuild -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize/+merge/254398 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app
Renato Araujo Oliveira Filho has proposed merging
lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app.
Commit message:
Optimize MonthComponent
Requested reviews:
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot):
continuous-integration
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize/+merge/254398
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app.
=== modified file 'MonthComponent.qml'
--- MonthComponent.qml 2015-11-23 07:15:20 +
+++ MonthComponent.qml 2016-01-12 18:02:54 +
@@ -17,6 +17,7 @@
*/
import QtQuick 2.3
import Ubuntu.Components 1.1
+import QtOrganizer 5.0
import "dateExt.js" as DateExt
import "colorUtils.js" as Color
@@ -45,37 +46,51 @@
signal dateSelected(var date);
signal dateHighlighted(var date);
-//creatng timer only if we need to show events in month
-Loader {
-id: timerLoader
-sourceComponent: showEvents ? timerComp : undefined
-}
-
-// Timer to delay creation of Model, There seems some problem fetching events if we create Model immediatly
-Component {
-id: timerComp
-Timer{
- interval: 200; running: true; repeat: false
- onTriggered: {
-modelLoader.sourceComponent = modelComponent
- }
-}
-}
-
-Loader{
-id: modelLoader
-}
-
-Component{
-id: modelComponent
-EventListModel {
-id: mainModel
-startPeriod: intern.monthStart.midnight();
-endPeriod: intern.monthStart.addDays((/*monthGrid.rows * cols */ 42 )-1).endOfDay()
-filter: eventModel.filter
-onModelChanged: {
-intern.eventStatus = Qt.binding(function() { return mainModel.containsItems(startPeriod, endPeriod, 86400/*24*60*60*/)});
-}
+// optimize painter
+layer.enabled: true
+
+Timer {
+id: modelIsDirty
+
+interval: 500
+repeat: false
+onTriggered: if(showEvents) mainModel.update()
+}
+
+onCurrentMonthChanged: {
+intern.selectedIndex = -1;
+modelIsDirty.start()
+}
+
+onSelectedDayChanged: {
+if( isCurrentItem ) {
+intern.selectedIndex = intern.findSelectedDayIndex();
+}
+}
+
+
+InvalidFilter {
+id: invalidFilter
+}
+
+EventListModel {
+id: mainModel
+
+autoUpdate: false
+startPeriod: intern.monthStart.midnight();
+endPeriod: intern.monthStart.addDays((/*monthGrid.rows * cols */ 42 )-1).endOfDay()
+filter: showEvents ? eventModel.filter : invalidFilter
+fetchHint: FetchHint {
+detailTypesHint: [ Detail.EventTime,
+ Detail.JournalTime,
+ Detail.TodoTime
+ ]
+}
+
+onModelChanged: {
+intern.eventStatus = mainModel.containsItems(mainModel.startPeriod,
+ mainModel.endPeriod,
+ 86400/*24*60*60*/);
}
}
@@ -132,16 +147,6 @@
}
}
-onSelectedDayChanged: {
-if( isCurrentItem ) {
-intern.selectedIndex = intern.findSelectedDayIndex();
-}
-}
-
-onCurrentMonthChanged: {
-intern.selectedIndex = -1;
-}
-
Column{
id: column
=== modified file 'MonthComponentDateDelegate.qml'
--- MonthComponentDateDelegate.qml 2015-09-05 05:30:23 +
+++ MonthComponentDateDelegate.qml 2016-01-12 18:02:54 +
@@ -9,20 +9,21 @@
property bool isToday;
property bool showEvent;
property alias fontSize: dateLabel.font.pixelSize
-
property bool isSelected: false
-Loader {
-sourceComponent: (isToday && isCurrentMonth) || isSelected ? highLightComp : undefined
+UbuntuShape{
+visible: (isToday && isCurrentMonth) || isSelected
+color: isToday && !isSelected ? "#DD4814" : "gray"
-onSourceComponentChanged: {
-width = Qt.binding( function() {
-var width = dateRootItem.height > dateRootItem.width ? dateRootItem.width :dateRootItem.height
-return ( width / 1.3 );
-});
-height = Qt.binding ( function() { return width} );
-anchors.centerIn = Qt.binding( function() { return dateLabel});
+Rectangle{
+anchors.fill: parent
+anchors.margins: units.gu(0.5)
+color: isToday ? "#DD4814" : "darkgray"
}
+
+width: Math.min(parent.height, parent.width) / 1.3
+height: width
+anchors.centerIn: dateLabel
}
Label {
@@ -47,46 +48,19 @@
}
}
-Loader{
-s
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun. https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781/+edit-commit-message -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app
Review: Approve Great! Thanks Evan. -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun. https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461/+edit-commit-message -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app
Replaced ListView with Column+Repeater, in order to delay things a bit. New example: http://paste.ubuntu.com/14479638/ That's the result: https://www.youtube.com/watch?v=CSM62wu8fiY It seems that the issue lives in the UCPageTreeNode component (used by UITK Page) - just my speculation. Replacing the Page with a Rectangle makes the issue not reproducible anymore. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge/+merge/281860 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app
It doesn't seem to be related to something we've done in DocViewer.
I wrote a minimal code which reproduces the issue, and there's nothing strange
with the ListView usage (the rest of the code comes from the official examples).
A first workaround I found is making the ListView not visible as long as the
page is not active.
ListView {
...
visible: bePage.active
}
Still having a deeper look.
import QtQuick 2.4
import Ubuntu.Components 1.3
MainView {
// Note! applicationName needs to match the "name" field of the click
manifest
applicationName: "untitled1.verzegnassi-stefano"
width: units.gu(100)
height: units.gu(75)
Page {
id: page
title: i18n.tr("Main")
BottomEdge {
height: parent.height
hint.text: "My bottom edge"
contentComponent: bottomEdgeContent
Component {
id: bottomEdgeContent
Page {
id: bePage
width: page.width
height: page.height
title: "Bottom Edge"
ListView {
anchors.fill: parent
model: 1000
delegate: Label { text: model.index }
}
}
}
}
}
}
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge/+merge/281860
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app
On it! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge/+merge/281860 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app
Hi, Alan, I've seen video - yes, I can see flickering, we should find out is it SDK bug or ours! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge/+merge/281860 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app
Review: Needs Fixing Works well, but I noticed a strange flickering of the content appearing on screen. I made a video showing it which should be available shortly. Not sure if this is a toolkit bug (likely)? https://www.youtube.com/watch?v=2KSWIlJ0Y5c -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge/+merge/281860 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app
Review: Approve Loving this change. It's quite a difference not having the stark blacks. Thanks! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/night-shader/+merge/282041 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app
It seems to me an HIDPI issue. The only math involved is a conversion from TWIPs to pixels, based on the value of the pixel density of the screen. Except for some rounding issue, but DocViewer should return the same size (in cm or inches) for the same object, as in this picture: https://imgur.com/NOI1Rwm I've seen that a number of issues about HIDPI screens has been reported for some core app recently[1]. May it be related somehow with the result of your tests? [1] https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1532950 -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom/+merge/281385 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app
Review: Needs Fixing Confirmed with a community member that the MX4 also has the "zoomed out" look. As that's a supported device, I think we should improve that. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom/+merge/281385 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app
(I should add, I quite like the zoomed in level. While the text is very large, it loads fast, and is easy enough to scroll around / zoom in/out). -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom/+merge/281385 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app
Tested on bq e4.5:- http://people.canonical.com/~alan/screenshots/device-2016-01-12-133308.png Tested on OnePlus One:- http://people.canonical.com/~alan/screenshots/device-2016-01-12-133734.png So it looks like we're detecting the screen size / resolution and automatic zoom on larger resolution (1080p) devices isn't working correctly. I don't have an MX4 handy to see what it is like on that. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom/+merge/281385 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:254 https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/64/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/355/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/64/rebuild -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom/+merge/281385 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app
OK, fixed the positionAt issue, if we land trunk into the store before bgplaylists we should include this patch [0] 0 - http://bazaar.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/revision/931 -- https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app
1) Is there a reason this length of time was chosen? 48ms is the maximum possible time we can wait without being noticeable to the user (less than 50ms) that is still divisible by 16ms. (note that this worked when set to 16ms on mako to me, I just wanted to give extra time to slower devices) 2) Hasn't this bug been fixed and released? Nope, using print_tree I could not see the MediaPlayer or the property var :-/ (Would be nice if it was though :-) ) 3) Consider changing to a switch statement. Since there are only 3 conditions it isn't too bad though. I'm not sure that can be a switch statement? What would be the control ? if you did switch(settings.shuffle) you couldn't have a case for repeat? I think it reads fine as an if, else if, else 4) Could you change "bgplaylists" to something more specific? MediaPlayer's playlist/queue or something? Fixed. I also noticed that the positionAt currentIndex was broken when switching to the queue view, currently investigating could be due to the Layouts change as then the height isn't 'fixed'. -- https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:148 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself): https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280/+edit-commit-message https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/88/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/354/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/88/rebuild -- https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:147 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself): https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280/+edit-commit-message https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/87/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/353/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/87/rebuild -- https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
Alan Pope has proposed merging lp:~popey/ubuntu-terminal-app/add-control into
lp:ubuntu-terminal-app.
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Victor Thompson (vthompson)
For more details, see:
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280
Adds a toggle-able general purpose control key to the functions keys overlay.
--
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
=== modified file 'po/com.ubuntu.terminal.pot'
--- po/com.ubuntu.terminal.pot 2015-08-09 14:03:25 +
+++ po/com.ubuntu.terminal.pot 2016-01-12 09:58:28 +
@@ -8,7 +8,7 @@
msgstr ""
"Project-Id-Version: \n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-08-09 16:01+0200\n"
+"POT-Creation-Date: 2016-01-10 19:21+0100\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME \n"
"Language-Team: LANGUAGE \n"
@@ -53,7 +53,7 @@
msgid "Authentication failed"
msgstr ""
-#: ../src/app/qml/KeyboardBar.qml:174
+#: ../src/app/qml/KeyboardBar.qml:178
msgid "Change Keyboard"
msgstr ""
@@ -177,7 +177,7 @@
msgid "New tab"
msgstr ""
-#: ../src/app/qml/TerminalPage.qml:164
+#: ../src/app/qml/TerminalPage.qml:165
msgid "Selection Mode"
msgstr ""
@@ -214,7 +214,7 @@
msgstr ""
#: ../src/plugin/konsole/Vt102Emulation.cpp:961
-#: ../src/plugin/qmltermwidget/lib/Vt102Emulation.cpp:977
+#: ../src/plugin/qmltermwidget/lib/Vt102Emulation.cpp:985
msgid ""
"No keyboard translator available. The information needed to convert key "
"presses into characters to send to the terminal is missing."
=== modified file 'src/app/qml/KeyboardBar.qml'
--- src/app/qml/KeyboardBar.qml 2015-07-13 20:25:21 +
+++ src/app/qml/KeyboardBar.qml 2016-01-12 09:58:28 +
@@ -12,6 +12,7 @@
signal simulateCommand(string command);
signal simulateKey(int key, int mod);
+signal simulateModifier(int modifiers);
ListModel {
id: layoutsList
@@ -56,6 +57,7 @@
layoutObject.z = rootItem.z;
layoutObject.simulateKey.disconnect(simulateKey);
layoutObject.simulateCommand.disconnect(simulateCommand);
+layoutObject.simulateModifier.disconnect(simulateModifier);
}
function enableLayout(index) {
@@ -68,6 +70,7 @@
layoutObject.z = rootItem.z + 0.01;
layoutObject.simulateKey.connect(simulateKey);
layoutObject.simulateCommand.connect(simulateCommand);
+layoutObject.simulateModifier.connect(simulateModifier);
}
function isIndexLayoutValid(index) {
@@ -161,6 +164,7 @@
onSimulateKey: pressFeedbackEffect.start();
onSimulateCommand: pressFeedbackEffect.start();
+onSimulateModifier: pressFeedbackEffect.start();
Item {
id: keyboardContainer
=== modified file 'src/app/qml/KeyboardRows/KeyboardLayout.qml'
--- src/app/qml/KeyboardRows/KeyboardLayout.qml 2015-08-09 14:25:36 +
+++ src/app/qml/KeyboardRows/KeyboardLayout.qml 2016-01-12 09:58:28 +
@@ -28,6 +28,8 @@
return createKeyActionString(action.key, action.mod, action.text, action.id);
case "string":
return createStringActionString(action.string, action.text);
+case "modifier":
+return createNextModifierActionString(action.modifier);
}
}
@@ -56,6 +58,10 @@
return "Action { " + textString + " onTriggered: simulateCommand(\"" + string + "\"); }";
}
+function createNextModifierActionString(modifier) {
+return "Action { text: \"" + modifier + "\"; onTriggered: simulateModifier(Qt." + modifier + "Modifier); }";
+}
+
function createEntryString(text, actionString, otherActionsString) {
var objectString = "
import QtQuick 2.4
=== modified file 'src/app/qml/KeyboardRows/KeyboardRow.qml'
--- src/app/qml/KeyboardRows/KeyboardRow.qml 2015-07-13 20:25:21 +
+++ src/app/qml/KeyboardRows/KeyboardRow.qml 2016-01-12 09:58:28 +
@@ -14,6 +14,7 @@
// External signals.
signal simulateKey(int key, int mod);
signal simulateCommand(string command);
+signal simulateModifier(int modifiers);
// Internal variables
property int _firstVisibleIndex: gridView.contentX / keyWidth
=== modified file 'src/app/qml/KeyboardRows/Layouts/FunctionKeys.json'
--- src/app/qml/KeyboardRows/Layouts/FunctionKeys.json 2015-07-10 14:34:00 +
+++ src/app/qml/KeyboardRows/Layouts/FunctionKeys.json 2016-01-12 09:58:28 +
@@ -11,6 +11,13 @@
},
{
"main_action" : {
+"type": "modifier",
+"modifier": "Control",
+"text": "Control"
+}
+},
+{
+"main_action" : {
"type": "key",
"key" : "F1"
}
=== modified file 'src/app/qml/KeyboardRows/jsonParser.js'
--- src/app/qml/KeyboardRows/jsonParser.js 2015-07-13 17:36:57 +
+++ src/app/qml/KeyboardRows/js
