[Ubuntu-touch-coreapps-reviewers] [Bug 1543736] [NEW] [RSS Reader] crashes when refreshing and no pics shown
Public bug reported: Latest release (0.2.418) crashes the app when refreshing the feeds. "Searching..." appears and the app closes. When starting the app again all new feeds are shown but without pictures. In the past it worked great and I haven't added new feeds. Deleting /home/phablet/.local/share/com.ubuntu.shorts and adding my "old" feeds solved both problems. bq Auqaris 4.5 Ubuntu Edition - UT 15.04.3 - OTA-9 ** Affects: ubuntu-rssreader-app Importance: Undecided Status: New ** Description changed: - Latest release ( 0.2.418) crashes the app when refreshing the feeds. + Latest release (0.2.418) crashes the app when refreshing the feeds. "Searching..." appears and the app closes. When starting the app again - all new feeds are shown but withour pictures. In the past it worked + all new feeds are shown but without pictures. In the past it worked great and I haven't added new feeds. Deleting /home/phablet/.local/share/com.ubuntu.shorts and adding my "old" feeds solved both problems. bq Auqaris 4.5 Ubuntu Edition - UT 15.04.3 - OTA-9 -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1543736 Title: [RSS Reader] crashes when refreshing and no pics shown Status in Ubuntu Shorts App: New Bug description: Latest release (0.2.418) crashes the app when refreshing the feeds. "Searching..." appears and the app closes. When starting the app again all new feeds are shown but without pictures. In the past it worked great and I haven't added new feeds. Deleting /home/phablet/.local/share/com.ubuntu.shorts and adding my "old" feeds solved both problems. bq Auqaris 4.5 Ubuntu Edition - UT 15.04.3 - OTA-9 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1543736/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1543435] Re: Since OTA 9 open link does randomly not work
Thanks for your report! I will review it. -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1543435 Title: Since OTA 9 open link does randomly not work Status in Ubuntu Shorts App: New Bug description: I have a BQ 4.5 since the latest OTA, I experience quite that I can't open the page (menu->open page) to read my whole feed. Somehow the browser does not open. It happens whether the browser is already open or closed. When the bug appears, I have to browse through some other feeds and switch back to the one, I want to open, and after some back and forth it works. So it seems to be no problem with my feed. Sorry that I can't narrow down the circumstances which trigger the bug. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1543435/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dpm/sudoku-app/rm-pot into lp:sudoku-app
The proposal to merge lp:~dpm/sudoku-app/rm-pot into lp:sudoku-app has been updated. Commit Message changed to: The additional sudoku-app.pot file, dating from 2014, is getting Launchpad confused. Removing it to allow the only 1 valid .pot file to be imported For more details, see: https://code.launchpad.net/~dpm/sudoku-app/rm-pot/+merge/285397 -- Your team Sudoku Touch developers is requested to review the proposed merge of lp:~dpm/sudoku-app/rm-pot into lp:sudoku-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
To be clear, this patch was originally created by @bartbes who asked me to manage the bzr mangling for him. Neither of us is currently skilled enough in qml to implement the ctrl lock right now. Hints / tips / forks welcome :) -- https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
Let me preface this by saying I'm the original author of the patch: I definitely agree it should be highlighted or something similar to indicate it's active. As the patch might show, this was my first foray into QML, and.. I simply wouldn't know how to even implement that. As for the translation, once again, I blame my lack of experience. I did try, but I couldn't quite figure out how to get it to pass the validation code if there wasn't a text attribute. Lastly, I'd like to draw your attention to Vt102Emulation.cpp, where at the moment it only supports adding the Control modifier. Perhaps it would make sense to expand this to alt and/or shift too? -- https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
Review: Needs Fixing I just skimmed through the code and one thing I noticed is that we would probably want the CTRL key to be translatable, so please remove the "text" attributes from the keyboard layouts and use the "id" attribute instead. Furthermore, I'm not sure whether we would want to set the "modifier" attribute. That is used to turn the press of one exact button to be modifier + key and that probably isn't needed here. (Just to be clear: I haven't reviewed the whole code yet.) -- https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1543582] [NEW] updating of graphical icons
Public bug reported: updating of graphical icons like folders and all the others, using the new style of ubuntu unity 8, as those that are present are in unity 7 ** Affects: ubuntu-filemanager-app Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1543582 Title: updating of graphical icons Status in Ubuntu File Manager App: New Bug description: updating of graphical icons like folders and all the others, using the new style of ubuntu unity 8, as those that are present are in unity 7 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1543582/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app
Hi Bart,
In my opinion the patch looks way better than a lot of first-time QML patches.
Congrats on that!
Regarding your questions: I guess we can give you a helping hand here. ;)
I'll try to answer the translation question right now.
Translations are handled by JsonTranslator.qml. It contains a
getTranslatedNamyById() method which is already capable of translating the
string "CTRL". You can find an example call to that method in line 84 of
KeyboardLayout.qml. You only need to tell it that you are trying to translate a
modifier (arg #1) and then pass the modifier string from the json file (arg #2)
and it will provide you with the translated string.
To become more specific, I would suggest to modify the json file to contain the
following code:
"main_action" : {
"type": "modifier",
"mod": "Control"
}
(The shorter form "mod" to keep it in line with the rest of the syntax if it
doesn't break anything else.)
Then add another case to the createKeyText() method of KeyboardLayout.qml to
enable translations of modifier keys and use that method in
createNextModifierActionString() to determine the text of the action.
That should do the trick. ;)
By the way, while we're at it, would you mind adjusting the error message in
line 36 of jsonParser.js to include the new modifier keyword? :)
If you have any further questions, feel free to ask. I agree that the
highlighting thing is not easy and it will require some time for me to look
into it as well. I'll try to do that when I have some spare time but maybe
someone else is capable of doing that earlier.
Thanks again for the great patch!
--
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
