[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/fix-1538838-export-long-press into lp:music-app
The proposal to merge lp:~ahayzen/music-app/fix-1538838-export-long-press into lp:music-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~ahayzen/music-app/fix-1538838-export-long-press/+merge/287260 -- Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/fix-1549580 into lp:music-app
Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1549580 into
lp:music-app.
Commit message:
* Fix fallback image path in MusicListItem
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1549580 in Ubuntu Music App: "Fallback art is NOT displayed in the Songs
tab"
https://bugs.launchpad.net/music-app/+bug/1549580
For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1549580/+merge/287250
* Fix fallback image path in MusicListItem
--
Your team Music App Developers is requested to review the proposed merge of
lp:~vthompson/music-app/fix-1549580 into lp:music-app.
=== modified file 'app/components/Delegates/MusicListItem.qml'
--- app/components/Delegates/MusicListItem.qml 2016-01-06 16:34:32 +
+++ app/components/Delegates/MusicListItem.qml 2016-02-26 00:19:23 +
@@ -102,7 +102,7 @@
onStatusChanged: {
if (status === Image.Error) {
-source = Qt.resolvedUrl("../graphics/music-app-co...@30.png")
+source = Qt.resolvedUrl("../../graphics/music-app-co...@30.png")
}
}
=== modified file 'debian/changelog'
--- debian/changelog 2016-02-21 16:15:08 +
+++ debian/changelog 2016-02-26 00:19:23 +
@@ -5,6 +5,7 @@
* Remove repeater for getting album titles in Artists.qml (LP: #1515067).
* Change translation strings from song to track (LP: #1378143).
* Ensure that only one ContentHubExport page is open (LP: #1538863).
+ * Fix fallback image path in MusicListItem (LP: #1549580).
-- Victor Wed, 27 Jan 2016 19:40:55 -0600
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app
The proposal to merge lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:451 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1068/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/624/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1068/rebuild -- https://code.launchpad.net/~nik90/ubuntu-clock-app/new-bottom-edge/+merge/287236 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app
The proposal to merge lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app
Review: Approve ooh lots of red color..love the code removal. The debian changelog hasn't been updated, but I will do that in my upcoming bottom edge MP. Thanks for this. -- https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:445 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1065/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/621/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1065/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:444 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1064/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/619/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1064/rebuild -- https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app has been updated. Description changed to: Use the new bottom edge The new SDK Bottom edge allows us to remove the PageWithBottomEdge custom component. For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/new-bottom-edge/+merge/287236 -- Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app
The proposal to merge lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app has been updated. Description changed to: Autopilot test cleanup for clock * fix launching and add option for building with SDK * remove fixtures * Remove debug print_trees For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238 -- Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:446 https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/57/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/618/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/57/rebuild -- https://code.launchpad.net/~nik90/ubuntu-clock-app/new-bottom-edge/+merge/287236 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app.
Commit message:
Use the new bottom edge
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
Bug #1543496 in Ubuntu Clock App: "‘Shutter’ effect animation on title bar
when opening bottom edge should not be present."
https://bugs.launchpad.net/ubuntu-clock-app/+bug/1543496
Bug #1549988 in Ubuntu Clock App: "Clock should use standard Bottom Page"
https://bugs.launchpad.net/ubuntu-clock-app/+bug/1549988
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/new-bottom-edge/+merge/287236
Use the new bottom edge
--
Your team Ubuntu Clock Developers is requested to review the proposed merge of
lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app.
=== modified file 'app/MainPage.qml'
--- app/MainPage.qml 2016-02-20 08:13:21 +
+++ app/MainPage.qml 2016-02-25 22:07:07 +
@@ -26,7 +26,7 @@
import "stopwatch"
import "components"
-PageWithBottomEdge {
+Page {
id: _mainPage
objectName: "mainPage"
@@ -49,9 +49,16 @@
property var alarmModel
flickable: null
-bottomEdgeTitle: _mainPage.visible ? alarmUtils.set_bottom_edge_title(alarmModel, notLocalizedDateTimeString)
- : i18n.tr("No active alarms")
-bottomEdgePageComponent: AlarmPage {}
+
+BottomEdge {
+id: bottomEdge
+height: parent.height
+hint.text: "Alarms"
+contentComponent: AlarmPage {
+width: bottomEdge.width
+height: bottomEdge.height
+}
+}
AlarmUtils {
id: alarmUtils
=== modified file 'app/alarm/AlarmList.qml'
--- app/alarm/AlarmList.qml 2015-10-22 16:49:23 +
+++ app/alarm/AlarmList.qml 2016-02-25 22:07:07 +
@@ -31,7 +31,7 @@
signal selectAll()
clip: true
-anchors.fill: parent
+currentIndex: -1
Timer {
id: alarmTimer
@@ -71,7 +71,7 @@
if (selectMode) {
selected = !selected
} else {
-pageStack.push(Qt.resolvedUrl("EditAlarmPage.qml"), {isNewAlarm: false, tempAlarm: model, alarmModel: alarmModel})
+mainStack.push(Qt.resolvedUrl("EditAlarmPage.qml"), {isNewAlarm: false, tempAlarm: model, alarmModel: alarmModel})
}
}
=== modified file 'app/alarm/AlarmPage.qml'
--- app/alarm/AlarmPage.qml 2015-10-22 16:49:23 +
+++ app/alarm/AlarmPage.qml 2016-02-25 22:07:07 +
@@ -24,102 +24,105 @@
readonly property bool isAlarmPage: true
-title: i18n.tr("Alarms")
objectName: 'AlarmPage'
-flickable: null
+header: standardHeader
Component.onCompleted: console.log("[LOG]: Alarm Page loaded")
-states: [
-PageHeadState {
-name: "default"
-head: alarmPage.head
-when: !alarmListView.ViewItems.selectMode
-
-backAction: Action {
-iconName: "down"
-text: i18n.tr("Back")
-onTriggered: {
-pageStack.pop()
-}
-}
-
-actions: [
-Action {
-objectName: "addAlarmAction"
-iconName: "add"
-text: i18n.tr("Alarm")
-onTriggered: {
-pageStack.push(Qt.resolvedUrl("EditAlarmPage.qml"))
-}
-}
-]
-},
-
-PageHeadState {
-name: "selection"
-head: alarmPage.head
-when: alarmListView.ViewItems.selectMode
-
-backAction: Action {
+PageHeader {
+id: standardHeader
+title: i18n.tr("Alarms")
+leadingActionBar.actions: [
+Action {
+text: "close"
+iconName: "go-down"
+onTriggered: {
+bottomEdge.collapse()
+}
+}
+]
+trailingActionBar.actions: [
+Action {
+objectName: "addAlarmAction"
+iconName: "add"
+text: i18n.tr("Alarm")
+onTriggered: {
+mainStack.push(Qt.resolvedUrl("EditAlarmPage.qml"))
+}
+}
+]
+}
+
+PageHeader {
+id: selectionHeader
+visible: alarmListView.ViewItems.selectMode
+leadingActionBar.actions: [
+Action {
iconName: "back"
text: i18n.tr("Back")
onTriggered: {
+alarmPage.header = standardHeader
alarmListView.ViewItems.selectMode = false
}
}
-
-actions: [
-Action {
-text: {
-if(alarmListView.ViewItems.selectedIndices.length === alarmListView.count) {
-
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/reminders-app/remove-account-mocks-from-tests into lp:reminders-app
The proposal to merge lp:~nskaggs/reminders-app/remove-account-mocks-from-tests into lp:reminders-app has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~nskaggs/reminders-app/remove-account-mocks-from-tests/+merge/287226 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~nskaggs/reminders-app/remove-account-mocks-from-tests into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into lp:ubuntu-clock-app
The proposal to merge lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into lp:ubuntu-clock-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design/+merge/281972 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into lp:ubuntu-clock-app
Review: Approve continuous-integration -- https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design/+merge/281972 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into lp:ubuntu-clock-app
The proposal to merge lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design/+merge/281972 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
Review: Approve continuous-integration -- https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:475 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1062/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/614/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1062/rebuild -- https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design/+merge/281972 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
Thanks Max! -- https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:475 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1061/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/613/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1061/rebuild -- https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design/+merge/281972 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
Review: Approve continuous-integration -- https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app has been updated. Commit Message changed to: This branch updates the test code to import specific gi versions, fixing lp#1546782. For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app
The proposal to merge lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/lp1546782/+merge/286926 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~canonical-platform-qa/reminders-app/lp1546782 into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:474 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1060/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/612/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1060/rebuild -- https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design/+merge/281972 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into lp:ubuntu-docviewer-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:306 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1059/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/611/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1059/rebuild -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option/+merge/287187 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into lp:ubuntu-docviewer-app
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into
lp:ubuntu-docviewer-app.
Commit message:
Allow to disable .click dependencies caching through a CMake option
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
Bug #1547059 in Ubuntu Document Viewer App: "needs no-cache option during
cmake build"
https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1547059
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option/+merge/287187
Allow to disable .click dependencies caching through a CMake option
--
Your team Ubuntu Document Viewer Developers is requested to review the proposed
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option
into lp:ubuntu-docviewer-app.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2016-02-05 22:57:24 +
+++ CMakeLists.txt 2016-02-25 15:13:53 +
@@ -14,6 +14,7 @@
option(INSTALL_TESTS"Install the tests on make install" on)
option(CLICK_MODE "Installs to a contained location" on)
+option(NO_CACHE "Disable caching of click dependencies (CLICK_MODE only)" off)
set(APP_NAMEubuntu-docviewer-app)
set(DESKTOP_FILE"${PROJECT_NAME}.desktop")
=== modified file 'cmake/modules/Click.cmake'
--- cmake/modules/Click.cmake 2016-01-17 20:15:53 +
+++ cmake/modules/Click.cmake 2016-02-25 15:13:53 +
@@ -19,22 +19,33 @@
MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}")
- get_filename_component(BLD_CONFIGURATION_NAME ${CMAKE_BINARY_DIR} NAME)
- set(UPSTREAM_CACHE $ENV{HOME}/dev/upstream-libs-docviewer/${BLD_CONFIGURATION_NAME})
- MESSAGE("Upstream libs cache path: ${UPSTREAM_CACHE}")
-
- if(EXISTS "${UPSTREAM_CACHE}")
-MESSAGE("Upstream libs cache exists.")
-file(COPY ${UPSTREAM_CACHE}/upstream-libs/ DESTINATION ${UPSTREAM_LIBS_DIR} PATTERN * )
- else()
-MESSAGE("Cache miss, downloading from network.")
+ if(NO_CACHE)
+# It has been specified not to cache .click dependencies on the machine.
+# This is meant to be used for automatic builds (e.g. Jenkins Bot).
execute_process(
COMMAND mkdir ${UPSTREAM_LIBS_DIR}
COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} -c ${CUSTOM_SCRIPT} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
)
-# Cache for next usage.
-file(COPY ${UPSTREAM_LIBS_DIR} DESTINATION ${UPSTREAM_CACHE} )
- endif()
+ else(NO_CACHE)
+# Cache the .click dependencies for next usage. (Default)
+# Useful on developer machine.
+get_filename_component(BLD_CONFIGURATION_NAME ${CMAKE_BINARY_DIR} NAME)
+set(UPSTREAM_CACHE $ENV{HOME}/dev/upstream-libs-docviewer/${BLD_CONFIGURATION_NAME})
+MESSAGE("Upstream libs cache path: ${UPSTREAM_CACHE}")
+
+if(EXISTS "${UPSTREAM_CACHE}")
+ MESSAGE("Upstream libs cache exists.")
+ file(COPY ${UPSTREAM_CACHE}/upstream-libs/ DESTINATION ${UPSTREAM_LIBS_DIR} PATTERN * )
+else()
+ MESSAGE("Cache miss, downloading from network.")
+ execute_process(
+COMMAND mkdir ${UPSTREAM_LIBS_DIR}
+COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} -c ${CUSTOM_SCRIPT} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
+ )
+ # Cache for next usage.
+ file(COPY ${UPSTREAM_LIBS_DIR} DESTINATION ${UPSTREAM_CACHE} )
+endif() #EXISTS "${UPSTREAM_CACHE}"
+ endif() #NO_CACHE
MESSAGE("Installing upstream libs from ${UPSTREAM_LIBS_DIR}/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
file(GLOB_RECURSE UPSTREAM_LIBS "${UPSTREAM_LIBS_DIR}/usr/lib/${ARCH_TRIPLET}/*")
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
