[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ken-vandine/ubuntu-clock-app/lp1554621 into lp:ubuntu-clock-app
Ken VanDine has proposed merging lp:~ken-vandine/ubuntu-clock-app/lp1554621
into lp:ubuntu-clock-app.
Commit message:
Bump Ubuntu.Content import to 1.3 to fix theme issue
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
Bug #1554621 in Ubuntu Clock App: "Invalid use of palette apparent with new
SDK in content-hub"
https://bugs.launchpad.net/ubuntu-clock-app/+bug/1554621
For more details, see:
https://code.launchpad.net/~ken-vandine/ubuntu-clock-app/lp1554621/+merge/289246
Bump Ubuntu.Content import to 1.3 to fix theme issue
--
Your team Ubuntu Clock Developers is requested to review the proposed merge of
lp:~ken-vandine/ubuntu-clock-app/lp1554621 into lp:ubuntu-clock-app.
=== modified file 'app/alarm/AlarmSound.qml'
--- app/alarm/AlarmSound.qml 2016-03-03 00:28:40 +
+++ app/alarm/AlarmSound.qml 2016-03-16 16:17:38 +
@@ -19,7 +19,7 @@
import QtQuick 2.4
import Alarm 1.0
import QtMultimedia 5.0
-import Ubuntu.Content 1.1
+import Ubuntu.Content 1.3
import Ubuntu.Components 1.3
import Qt.labs.folderlistmodel 2.1
=== modified file 'app/alarm/SoundPeerPicker.qml'
--- app/alarm/SoundPeerPicker.qml 2016-02-25 22:16:54 +
+++ app/alarm/SoundPeerPicker.qml 2016-03-16 16:17:38 +
@@ -18,7 +18,7 @@
import QtQuick 2.4
import Ubuntu.Components 1.3
-import Ubuntu.Content 1.1
+import Ubuntu.Content 1.3
Page {
id: picker
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into lp:ubuntu-docviewer-app
Review: Approve Looks good to me! By the way, I just want to take the opportunity to thank you for the time you've spent on the core apps. Good luck with juju! :) -- https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/restore-ap-template/+merge/288454 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/keep-event-size into lp:ubuntu-calendar-app
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/keep-event-size into lp:ubuntu-calendar-app has been updated. Commit Message changed to: Make sure that event keep the same size when changing the start date. For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/keep-event-size/+merge/289288 -- Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-calendar-app/keep-event-size into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app
The proposal to merge lp:~mpt/reminders-app/1551780-setup into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-calendar-app/revamp-eventdetails-page into lp:ubuntu-calendar-app
Fixed remaining issues. -- https://code.launchpad.net/~nik90/ubuntu-calendar-app/revamp-eventdetails-page/+merge/288492 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~nik90/ubuntu-calendar-app/revamp-eventdetails-page into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 into lp:ubuntu-docviewer-app
Review: Approve -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218/+merge/288689 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot. https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/306/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5686/console -- https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ken-vandine/ubuntu-clock-app/lp1554621 into lp:ubuntu-clock-app
Review: Needs Fixing Thanks for the fix. When we migrated to UC 1.3, I did notice the issue, but wasn't aware of ContentHub 1.3 import. Could you please update debian changelog? -- https://code.launchpad.net/~ken-vandine/ubuntu-clock-app/lp1554621/+merge/289246 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder into lp:ubuntu-calendar-app
Arthur Mello has proposed merging
lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder into
lp:ubuntu-calendar-app.
Commit message:
Fix default reminder displayed at new event view
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder/+merge/289315
Fix default reminder displayed at new event view
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder
into lp:ubuntu-calendar-app.
=== modified file 'NewEvent.qml'
--- NewEvent.qml 2016-03-14 20:25:50 +
+++ NewEvent.qml 2016-03-17 00:42:17 +
@@ -73,6 +73,11 @@
root.canceled()
}
+function updateEventInfo(date, allDay) {
+updateEventDate(date, allDay)
+eventReminder.subText = eventReminder.getReminderLabel(root.reminderValue)
+}
+
function updateEventDate(date, allDay) {
root.startDate = undefined
root.endDate = undefined
@@ -709,21 +714,21 @@
progression: true
text: i18n.tr("Reminder")
-RemindersModel {
-id: reminderModel
-}
-
-subText:{
-if(visualReminder.secondsBeforeStart !== -1) {
-for( var i=0; i--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into lp:ubuntu-calendar-app
Review: Approve looks good -- https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click/+merge/289280 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into lp:ubuntu-docviewer-app
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into
lp:ubuntu-docviewer-app.
Commit message:
[TextView] Switch to UITK 1.3 PageHeader component
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview/+merge/289482
[TextView] Switch to UITK 1.3 PageHeader component
--
Your team Ubuntu Document Viewer Developers is requested to review the proposed
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/textView/TextView.qml'
--- src/app/qml/textView/TextView.qml 2015-12-26 18:27:13 +
+++ src/app/qml/textView/TextView.qml 2016-03-18 11:23:04 +
@@ -23,10 +23,11 @@
Page {
id: textPage
-title: DocumentViewer.getFileBaseNameFromPath(file.path)
-// Reset night mode shader settings when closing the page
-// Component.onDestruction: mainView.nightModeEnabled = false
+header: TextViewDefaultHeader {
+title: DocumentViewer.getFileBaseNameFromPath(file.path)
+activityRunning: textAreaMain.isLoading
+}
TextArea {
id: textAreaMain
@@ -34,7 +35,12 @@
property bool isLoading: true
-anchors.fill: parent
+anchors {
+top: textPage.header.bottom
+left: parent.left
+right: parent.right
+bottom: parent.bottom
+}
// FIXME: If set to true, some of the keyboard hooks are disabled
// And it's not possible to move the cursor with arrow keys.
@@ -61,14 +67,4 @@
background: Rectangle { color: "white" }
}
}
-
-// *** HEADER ***
-state: "default"
-states: [
-TextViewDefaultHeader {
-name: "default"
-targetPage: textPage
-activityRunning: textAreaMain.isLoading
-}
-]
}
=== modified file 'src/app/qml/textView/TextViewDefaultHeader.qml'
--- src/app/qml/textView/TextViewDefaultHeader.qml 2015-11-13 21:19:46 +
+++ src/app/qml/textView/TextViewDefaultHeader.qml 2016-03-18 11:23:04 +
@@ -20,44 +20,30 @@
import Ubuntu.Components.Popups 1.3
import DocumentViewer 1.0
-PageHeadState {
+PageHeader {
id: rootItem
-property Page targetPage
property alias activityRunning: activity.running
-head: targetPage.head
-
-contents: RowLayout {
-anchors.fill: parent
-spacing: units.gu(1)
-
-ActivityIndicator { id: activity; visible: running }
-
-Column {
-id: layout
-Layout.fillWidth: true
-
-Label {
-width: parent.width
-//horizontalAlignment: Text.AlignHCenter
-elide: Text.ElideMiddle
-
-font.weight: Font.DemiBold
-text: targetPage.title
-}
-Label {
-width: parent.width
-//horizontalAlignment: Text.AlignHCenter
-elide: Text.ElideMiddle
-
-textSize: Label.Small
-text: file.mimetype.description
-}
-}
+contents: ListItemLayout {
+anchors.centerIn: parent
+
+ActivityIndicator {
+id: activity
+SlotsLayout.position: SlotsLayout.Leading
+visible: running
+}
+
+title {
+font.weight: Font.DemiBold
+elide: Text.ElideMiddle
+text: rootItem.title
+}
+
+subtitle.text: file.mimetype.description
}
-actions: [
+trailingActionBar.actions: [
Action {
iconName: "night-mode"
text: mainView.nightModeEnabled ? i18n.tr("Disable night mode") : i18n.tr("Enable night mode")
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1559114] Re: No "Night Mode" button in article view
You can use "Options" -> "Dark" to switch ;) ** Changed in: ubuntu-rssreader-app Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1559114 Title: No "Night Mode" button in article view Status in Ubuntu Shorts App: Invalid Bug description: If I want to switch "Night mode" when I am reading an article, I have to switch back to topic view. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1559114/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/fix-edit-ocurrence into lp:ubuntu-calendar-app
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/fix-edit-ocurrence into lp:ubuntu-calendar-app has been updated. Commit Message changed to: Fix edit occurrence. For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-edit-ocurrence/+merge/288638 -- Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-calendar-app/fix-edit-ocurrence into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ken-vandine/ubuntu-filemanager-app/lp1554621 into lp:ubuntu-filemanager-app
Ken VanDine has proposed merging lp:~ken-vandine/ubuntu-filemanager-app/lp1554621 into lp:ubuntu-filemanager-app. Commit message: Bump Ubuntu.Content import to 1.3 to fix theme issue Requested reviews: Ubuntu File Manager Developers (ubuntu-filemanager-dev) Related bugs: Bug #1554621 in content-hub (Ubuntu): "Invalid use of palette apparent with new SDK in content-hub" https://bugs.launchpad.net/ubuntu/+source/content-hub/+bug/1554621 For more details, see: https://code.launchpad.net/~ken-vandine/ubuntu-filemanager-app/lp1554621/+merge/289247 Bump Ubuntu.Content import to 1.3 to fix theme issue -- Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~ken-vandine/ubuntu-filemanager-app/lp1554621 into lp:ubuntu-filemanager-app. === modified file 'src/app/qml/content-hub/FileOpener.qml' --- src/app/qml/content-hub/FileOpener.qml 2016-01-18 10:32:34 + +++ src/app/qml/content-hub/FileOpener.qml 2016-03-16 16:17:47 + @@ -18,7 +18,7 @@ import QtQuick 2.4 import Ubuntu.Components 1.3 -import Ubuntu.Content 0.1 +import Ubuntu.Content 1.3 import "contenttyperesolver.js" as Resolver === modified file 'src/app/qml/content-hub/contenttyperesolver.js' --- src/app/qml/content-hub/contenttyperesolver.js 2015-12-03 12:10:42 + +++ src/app/qml/content-hub/contenttyperesolver.js 2016-03-16 16:17:47 + @@ -15,7 +15,7 @@ * * Authored by: Arto Jalkanen */ -.import Ubuntu.Content 0.1 as CH +.import Ubuntu.Content 1.3 as CH /** * For now a simple static mapping of file extensions to ContentHub types. === modified file 'src/app/qml/filemanager.qml' --- src/app/qml/filemanager.qml 2016-02-02 00:35:27 + +++ src/app/qml/filemanager.qml 2016-03-16 16:17:47 + @@ -21,7 +21,7 @@ import Ubuntu.Components.Popups 1.3 import Ubuntu.Unity.Action 1.1 as UnityActions import U1db 1.0 as U1db -import Ubuntu.Content 0.1 +import Ubuntu.Content 1.3 import com.ubuntu.PlacesModel 0.1 import com.ubuntu.PamAuthentication 0.1 -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app
Items #4 and #6 still need to be fixed. Item #6 could be argued as fine as-is, however (maybe it's the way it is per design). 4. Disabled header actions are not greyed out. 6. The leadingActions for Remove are no longer red with a white icon. -- https://code.launchpad.net/~music-app-dev/music-app/fix-1550096-ota10-sdk-update/+merge/287363 Your team Music App Developers is requested to review the proposed merge of lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into lp:ubuntu-docviewer-app
Review: Approve Like this, simple and elegant. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page/+merge/288556 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ken-vandine/ubuntu-clock-app/lp1554621 into lp:ubuntu-clock-app
Review: Approve Awesome! Thnx again. -- https://code.launchpad.net/~ken-vandine/ubuntu-clock-app/lp1554621/+merge/289246 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ken-vandine/music-app/lp1554621 into lp:music-app
Ken VanDine has proposed merging lp:~ken-vandine/music-app/lp1554621 into lp:music-app. Commit message: Bump Ubuntu.Content import to 1.3 to prevent mixed version imports Requested reviews: Music App Developers (music-app-dev) Related bugs: Bug #1554621 in Ubuntu Music App: "Invalid use of palette apparent with new SDK in content-hub" https://bugs.launchpad.net/music-app/+bug/1554621 For more details, see: https://code.launchpad.net/~ken-vandine/music-app/lp1554621/+merge/289254 Bump Ubuntu.Content import to 1.3 to prevent mixed version imports -- Your team Music App Developers is requested to review the proposed merge of lp:~ken-vandine/music-app/lp1554621 into lp:music-app. === modified file 'app/components/Helpers/ContentHubHelper.qml' --- app/components/Helpers/ContentHubHelper.qml 2016-01-29 04:05:56 + +++ app/components/Helpers/ContentHubHelper.qml 2016-03-16 16:54:16 + @@ -20,7 +20,7 @@ import QtQuick 2.4 import Ubuntu.Components 1.3 import Ubuntu.Components.Popups 1.3 -import Ubuntu.Content 1.1 +import Ubuntu.Content 1.3 import "../../logic/stored-request.js" as StoredRequest === modified file 'app/ui/ContentHubExport.qml' --- app/ui/ContentHubExport.qml 2016-02-26 03:16:35 + +++ app/ui/ContentHubExport.qml 2016-03-16 16:54:16 + @@ -18,7 +18,7 @@ import QtQuick 2.4 import Ubuntu.Components 1.3 -import Ubuntu.Content 1.1 +import Ubuntu.Content 1.3 import Ubuntu.MediaScanner 0.1 import Ubuntu.Thumbnailer 0.1 -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-settings-help into lp:ubuntu-rssreader-app
The proposal to merge lp:~qqworini/ubuntu-rssreader-app/new-settings-help into lp:ubuntu-rssreader-app has been updated. Commit Message changed to: 0. replace U1DB with QSettings 1. add a help page 2. add an info page To all reviewers, in those new added pages, some words, sentences or statements may NOT right or NOT clear, pls help me to correct them before merge :) For more details, see: https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-settings-help/+merge/289180 -- Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~qqworini/ubuntu-rssreader-app/new-settings-help into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app
Review: Needs Fixing continuous-integration FAILED: Autolanding. Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot. https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/307/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5687/console -- https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1559114] [NEW] No "Night Mode" button in article view
Public bug reported: If I want to switch "Night mode" when I am reading an article, I have to switch back to topic view. ** Affects: ubuntu-rssreader-app Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1559114 Title: No "Night Mode" button in article view Status in Ubuntu Shorts App: New Bug description: If I want to switch "Night mode" when I am reading an article, I have to switch back to topic view. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1559114/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582 into lp:ubuntu-calendar-app
Review: Needs Information
Whats happen on NewEvent page? Do we need something special when editing a
event with end date null?
Diff comments:
>
> === modified file 'TimeLineBase.qml'
> --- TimeLineBase.qml 2016-03-03 21:42:08 +
> +++ TimeLineBase.qml 2016-03-16 19:14:10 +
> @@ -95,8 +95,15 @@
> dirty = true
> }
> if (e.endDateTime.getTime() != events[i].eventEndTime) {
> -console.warn("Event does not match end time")
> -dirty = true
> +if (!isNaN(e.endDateTime.getTime()) &&
> !isNaN(events[i].eventEndTime)) {
this is wrong. this will cause the view to be update forever.
This check needs to verify if the event enddatetime is different from map
endTime. This implementation will mark the view as dirty if the dates are not
null (which is the most of the cases).
> +console.warn("Event does not match end time")
> +dirty = true
> +} else {
> +// Sometimes when both star and end time are
> equals
> +// end time is reported as empty
> +e.endDateTime = e.startDateTime
> +events[i].eventEndTime = events[i].eventStartTime
> +}
> }
>
> if (dirty) {
--
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582/+merge/289278
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app
Victor Thompson has proposed merging
lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app.
Commit message:
* Resolve issues related to SDK changes in OTA10
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1550096 in Ubuntu Music App: "Potential music app updates needed due to
a change in theming/UI toolkit in OTA10"
https://bugs.launchpad.net/music-app/+bug/1550096
For more details, see:
https://code.launchpad.net/~music-app-dev/music-app/fix-1550096-ota10-sdk-update/+merge/287363
* Resolve issues related to SDK changes in OTA10
See bug report for a working list of necessary changes.
--
Your team Music App Developers is requested to review the proposed merge of
lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app.
=== modified file 'app/components/HeadState/MultiSelectHeadState.qml'
--- app/components/HeadState/MultiSelectHeadState.qml 2016-01-16 01:30:31 +
+++ app/components/HeadState/MultiSelectHeadState.qml 2016-03-19 17:12:45 +
@@ -35,9 +35,9 @@
}
},
Action {
-enabled: listview !== null ? listview.getSelectedIndices().length > 0 : false
iconName: "add-to-playlist"
text: i18n.tr("Add to playlist")
+visible: listview !== null ? listview.getSelectedIndices().length > 0 : false
onTriggered: {
var items = []
var indicies = listview.getSelectedIndices();
@@ -53,10 +53,9 @@
}
},
Action {
-enabled: listview !== null ? listview.getSelectedIndices().length > 0 : false
iconName: "add"
text: i18n.tr("Add to queue")
-visible: addToQueue
+visible: listview !== null ? (listview.getSelectedIndices().length > 0) && addToQueue: false
onTriggered: {
var items = [];
@@ -72,10 +71,9 @@
}
},
Action {
-enabled: listview !== null ? listview.getSelectedIndices().length > 0 : false
iconName: "delete"
text: i18n.tr("Delete")
-visible: removable
+visible: listview !== null ? (listview.getSelectedIndices().length > 0) && removable : false
onTriggered: {
removed(listview.getSelectedIndices())
=== modified file 'app/components/HeadState/PlaylistsHeadState.qml'
--- app/components/HeadState/PlaylistsHeadState.qml 2015-10-23 03:08:43 +
+++ app/components/HeadState/PlaylistsHeadState.qml 2016-03-19 17:12:45 +
@@ -41,7 +41,7 @@
}
]
-property alias newPlaylistEnabled: newPlaylistAction.enabled
-property alias searchEnabled: searchAction.enabled
+property alias newPlaylistEnabled: newPlaylistAction.visible
+property alias searchEnabled: searchAction.visible
property Page thisPage
}
=== modified file 'app/components/HeadState/SearchHeadState.qml'
--- app/components/HeadState/SearchHeadState.qml 2015-11-17 01:59:32 +
+++ app/components/HeadState/SearchHeadState.qml 2016-03-19 17:12:45 +
@@ -36,7 +36,6 @@
right: parent ? parent.right : undefined
rightMargin: units.gu(2)
}
-color: styleMusic.common.black
hasClearButton: true
inputMethodHints: Qt.ImhNoPredictiveText
placeholderText: i18n.tr("Search music")
=== modified file 'app/components/NowPlayingFullView.qml'
--- app/components/NowPlayingFullView.qml 2016-01-16 01:30:31 +
+++ app/components/NowPlayingFullView.qml 2016-03-19 17:12:45 +
@@ -187,7 +187,7 @@
anchors.right: parent.right
maximumValue: player.mediaPlayer.duration || 1 // fallback to 1 when 0 so that the progress bar works
objectName: "progressSliderShape"
-style: UbuntuBlueSliderStyle {}
+style: SliderStyle {}
value: player.mediaPlayer.position // load value at startup
function formatValue(v) {
=== modified file 'app/components/Style.qml'
--- app/components/Style.qml 2015-08-12 23:36:44 +
+++ app/components/Style.qml 2016-03-19 17:12:45 +
@@ -48,8 +48,8 @@
property QtObject dialog: QtObject {
property color confirmButtonColor: UbuntuColors.green;
property color confirmRemoveButtonColor: UbuntuColors.red;
-property color cancelButtonColor: UbuntuColors.coolGrey;
-property color normalTextFieldColor: common.white
+property color cancelButtonColor: UbuntuColors.jet;
+property color normalTextFieldColor: common.white;
}
property QtObject libraryEmpty: QtObject {
=== modified file 'app/components/Themes/Ambiance/BubbleShape.qml'
--- app/components/Themes/Ambiance/BubbleShape.qml 2015-11-17 01:33:03 +
+++ app/components/Themes/Ambiance/BubbleShape.qml 2016-03-19 17:12:45 +
@@ -1,5 +1,5 @@
/*
- * Copyright 2015 Canonical Ltd.
+ * Copyright 2016 Canonical Ltd.
*
*
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/convergence-tabs-with-sidebar-01 into lp:music-app
I can still reproduce #12 while on the new silo #50. -- https://code.launchpad.net/~ahayzen/music-app/convergence-tabs-with-sidebar-01/+merge/286127 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app
I fixed #4 by making the icons invisible when not enabled. This matched the behavior in the Contacts app. I also added and fixed another issue (#7) with the Dialog views. This should be ready for review. We can file another bug/issue for #6 if it is seen as an issue. -- https://code.launchpad.net/~music-app-dev/music-app/fix-1550096-ota10-sdk-update/+merge/287363 Your team Music App Developers is requested to review the proposed merge of lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1550096] Re: Potential music app updates needed due to a change in theming/UI toolkit in OTA10
** Changed in: music-app Assignee: Music App Developers (music-app-dev) => Victor Thompson (vthompson) -- You received this bug notification because you are a member of Music App Developers, which is a bug assignee. https://bugs.launchpad.net/bugs/1550096 Title: Potential music app updates needed due to a change in theming/UI toolkit in OTA10 Status in Ubuntu Music App: In Progress Bug description: This is meant to function as a list of issues needing to be fixed once landing silo 50 lands in OTA10 [1]. There are changes in theming that resulted. This will be a running list as some of these things might change before OTA10 and/or this silo lands. Some of these issues might actually be UIToolkit issues and need more research. 1. Text typed into the now dark search bar is black and hard to read. 2. The progress bar's current position icon is dark gray. 3. Related to #2, the theming done for the slider could possibly be removed since the default is now blue. 4. Disabled header actions are not greyed out. 5. The app's startup is even more "violent" than it was before. With the silo installed the app starts up as completely white and then the Cards/ListItems fill in. Previously, IIRC, just the top would be white and the UI would shift upwards. 6. The leadingActions for Remove are no longer red with a white icon. 1 - https://requests.ci-train.ubuntu.com/#/ticket/905 To manage notifications about this bug go to: https://bugs.launchpad.net/music-app/+bug/1550096/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder into lp:ubuntu-calendar-app
The proposal to merge lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder into lp:ubuntu-calendar-app has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder/+merge/289315 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ken-vandine/ubuntu-clock-app/lp1554621 into lp:ubuntu-clock-app
The proposal to merge lp:~ken-vandine/ubuntu-clock-app/lp1554621 into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ken-vandine/ubuntu-clock-app/lp1554621/+merge/289246 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1554621] Re: Invalid use of palette apparent with new SDK in content-hub
** Branch linked: lp:~ken-vandine/music-app/lp1554621 -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1554621 Title: Invalid use of palette apparent with new SDK in content-hub Status in address-book-app: Confirmed Status in camera-app: Confirmed Status in Canonical System Image: Confirmed Status in messaging-app: Confirmed Status in Ubuntu Music App: Confirmed Status in Tagger: New Status in Telegram app: Confirmed Status in Ubuntu Clock App: Confirmed Status in Ubuntu File Manager App: Confirmed Status in content-hub package in Ubuntu: Invalid Status in ubuntu-system-settings package in Ubuntu: In Progress Bug description: The content hub uses the wrong palette values for text (which becomes apparent with new UITK), see screenshot. The new UITK is landing here: https://requests.ci- train.ubuntu.com/#/ticket/905 ProblemType: Bug DistroRelease: Ubuntu 15.04 Package: content-hub 0.1+15.04.20160129.1-0ubuntu1 [origin: LP-PPA-ci-train-ppa-service-stable-phone-overlay] Uname: Linux 3.4.67 armv7l ApportVersion: 2.17.2-0ubuntu1.3touch1 Architecture: armhf Date: Tue Mar 8 18:00:22 2016 InstallationDate: Installed on 2016-03-08 (0 days ago) InstallationMedia: Ubuntu 15.04 - armhf (20160308-020304) SourcePackage: content-hub UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/address-book-app/+bug/1554621/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into lp:ubuntu-docviewer-app
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into lp:ubuntu-docviewer-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/restore-ap-template/+merge/288454 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into lp:ubuntu-calendar-app
Arthur Mello has proposed merging
lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into
lp:ubuntu-calendar-app.
Commit message:
Add script to build click package
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click/+merge/289280
Add script to build click package
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into
lp:ubuntu-calendar-app.
=== added file 'click-build.sh'
--- click-build.sh 1970-01-01 00:00:00 +
+++ click-build.sh 2016-03-16 19:14:56 +
@@ -0,0 +1,16 @@
+#!/bin/sh
+
+export LC_ALL=C
+
+BZR_SOURCE=${1:-lp:ubuntu-calendar-app}
+
+CLICKARCH=armhf
+rm -rf $CLICKARCH-build
+mkdir $CLICKARCH-build
+cd $CLICKARCH-build
+cmake .. -DCLICK_MODE=on \
+-DBZR_REVNO=$(cd ..; bzr revno) \
+-DBZR_SOURCE="$BZR_SOURCE"
+make DESTDIR=../package install
+cd ..
+click build package
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945 into lp:ubuntu-calendar-app
You will need this patch: http://paste.ubuntu.com/15411068/ -- https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945/+merge/288988 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-settings-help into lp:ubuntu-rssreader-app
Seems that *.pro version is broken. -- https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-settings-help/+merge/289180 Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~qqworini/ubuntu-rssreader-app/new-settings-help into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1554621] Re: Invalid use of palette apparent with new SDK in content-hub
** Also affects: messaging-app Importance: Undecided Status: New ** Also affects: camera-app Importance: Undecided Status: New ** Also affects: ubuntu-clock-app Importance: Undecided Status: New ** Also affects: address-book-app Importance: Undecided Status: New ** Also affects: ubuntu-filemanager-app Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1554621 Title: Invalid use of palette apparent with new SDK in content-hub Status in address-book-app: New Status in camera-app: New Status in Canonical System Image: Confirmed Status in messaging-app: New Status in Tagger: New Status in Telegram app: New Status in Ubuntu Clock App: New Status in Ubuntu File Manager App: New Status in content-hub package in Ubuntu: Invalid Bug description: The content hub uses the wrong palette values for text (which becomes apparent with new UITK), see screenshot. The new UITK is landing here: https://requests.ci- train.ubuntu.com/#/ticket/905 ProblemType: Bug DistroRelease: Ubuntu 15.04 Package: content-hub 0.1+15.04.20160129.1-0ubuntu1 [origin: LP-PPA-ci-train-ppa-service-stable-phone-overlay] Uname: Linux 3.4.67 armv7l ApportVersion: 2.17.2-0ubuntu1.3touch1 Architecture: armhf Date: Tue Mar 8 18:00:22 2016 InstallationDate: Installed on 2016-03-08 (0 days ago) InstallationMedia: Ubuntu 15.04 - armhf (20160308-020304) SourcePackage: content-hub UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/address-book-app/+bug/1554621/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app has been updated. Commit Message changed to: Accept 'calendar://*' url as argument on app startup. This is necessary because url-dispatcher calls the app with argument if the app is not opened yet. For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-1439049/+merge/289198 -- Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page/+merge/288556 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 into lp:ubuntu-docviewer-app
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218/+merge/288689 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582 into lp:ubuntu-calendar-app
Arthur Mello has proposed merging
lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582 into
lp:ubuntu-calendar-app.
Commit message:
Add support to create and import/export events with start date equals to end
date
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1544582 in Ubuntu Calendar App: "starttime cannot be equal to endtime"
https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1544582
For more details, see:
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582/+merge/289278
Add support to create and import/export events with start date equals to end
date
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582 into
lp:ubuntu-calendar-app.
=== modified file 'NewEvent.qml'
--- NewEvent.qml 2016-03-14 20:25:50 +
+++ NewEvent.qml 2016-03-16 19:14:10 +
@@ -172,7 +172,7 @@
//Save the new or Existing event
function saveToQtPim() {
internal.clearFocus()
-if ( startDate >= endDate && !allDayEventCheckbox.checked) {
+if ( startDate > endDate && !allDayEventCheckbox.checked) {
PopupUtils.open(errorDlgComponent,root,{"text":i18n.tr("End time can't be before start time")});
} else {
var newCollection = calendarsOption.model[calendarsOption.selectedIndex].collectionId;
=== modified file 'TimeLineBase.qml'
--- TimeLineBase.qml 2016-03-03 21:42:08 +
+++ TimeLineBase.qml 2016-03-16 19:14:10 +
@@ -95,8 +95,15 @@
dirty = true
}
if (e.endDateTime.getTime() != events[i].eventEndTime) {
-console.warn("Event does not match end time")
-dirty = true
+if (!isNaN(e.endDateTime.getTime()) && !isNaN(events[i].eventEndTime)) {
+console.warn("Event does not match end time")
+dirty = true
+} else {
+// Sometimes when both star and end time are equals
+// end time is reported as empty
+e.endDateTime = e.startDateTime
+events[i].eventEndTime = events[i].eventStartTime
+}
}
if (dirty) {
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app
Renato Araujo Oliveira Filho has proposed merging
lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app.
Commit message:
Accept 'calendar://*' url as argument on app startup.
This is necessary because url-dispatcher calls the app with argument if the app
is not opened yet.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1439049 in Ubuntu Calendar App: "Indicator entry doesn’t open event
details"
https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1439049
For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-1439049/+merge/289198
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app.
=== modified file 'calendar.qml'
--- calendar.qml 2016-03-14 20:38:05 +
+++ calendar.qml 2016-03-16 14:09:44 +
@@ -31,6 +31,25 @@
property int reminderDefaultValue: 900;
readonly property bool syncInProgress: commonHeaderActions.syncInProgress
+function handleUri(uri)
+{
+if(uri !== undefined && uri !== "") {
+var commands = uri.split("://")[1].split("=");
+if(commands[0].toLowerCase() === "eventid") {
+// calendar://eventid=??
+if( eventModel ) {
+// qtorganizer:eds::
+var eventId = commands[1];
+var prefix = "qtorganizer:eds::";
+if (eventId.indexOf(prefix) < 0)
+eventId = prefix + eventId;
+
+eventModel.showEventFromId(eventId);
+}
+}
+}
+}
+
// Work-around until this branch lands:
// https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/optIn-tabsDrawer/+merge/212496
//property bool windowActive: typeof window != 'undefined'
@@ -99,24 +118,7 @@
Connections {
target: UriHandler
-onOpened: {
-var uri = uris[0]
-if(uri !== undefined && uri !== "") {
-var commands = uri.split("://")[1].split("=");
-if(commands[0].toLowerCase() === "eventid") {
-// calendar://eventid=??
-if( eventModel ) {
-// qtorganizer:eds::
-var eventId = commands[1];
-var prefix = "qtorganizer:eds::";
-if (eventId.indexOf(prefix) < 0)
-eventId = prefix + eventId;
-
-eventModel.showEventFromId(eventId);
-}
-}
-}
-}
+onOpened: handleUri(uris[0])
}
PageStack {
@@ -379,6 +381,12 @@
var starttimepattern = new RegExp ("starttime=\\d+");
var endtimepattern = new RegExp ("endtime=\\d+");
var eventIdpattern = new RegExp ("eventId=.*")
+var urlpattern = new RegExp("calendar://.*")
+
+if (urlpattern.test(url)) {
+handleUri(url)
+return
+}
newevent = newevenpattern.test(url);
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into lp:ubuntu-docviewer-app
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/restore-ap-template/+merge/288454 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into lp:ubuntu-calendar-app
The proposal to merge lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into lp:ubuntu-calendar-app has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click/+merge/289279 -- Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/fix-edit-ocurrence into lp:ubuntu-calendar-app
Review: Approve tested with silo 56 and working -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-edit-ocurrence/+merge/288638 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/keep-event-size into lp:ubuntu-calendar-app
Renato Araujo Oliveira Filho has proposed merging
lp:~renatofilho/ubuntu-calendar-app/keep-event-size into lp:ubuntu-calendar-app.
Commit message:
Make sure that event keep the same size when changing the start date.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/keep-event-size/+merge/289288
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~renatofilho/ubuntu-calendar-app/keep-event-size into
lp:ubuntu-calendar-app.
=== modified file 'NewEvent.qml'
--- NewEvent.qml 2016-03-14 20:25:50 +
+++ NewEvent.qml 2016-03-16 20:02:22 +
@@ -25,6 +25,7 @@
import Ubuntu.Components.Pickers 1.0
import QtOrganizer 5.0
import "Defines.js" as Defines
+import "dateExt.js" as DateExt
Page {
id: root
@@ -35,19 +36,21 @@
property var date;
property alias allDay: allDayEventCheckbox.checked
+property int eventSize: -1
property var event:null;
property var rule :null;
property var model:null;
-property var startDate;
-property var endDate;
-//default reminder time = 15 min
-property int reminderValue: 900;
+property alias startDate: startDateTimeInput.dateTime
+property alias endDate: endDateTimeInput.dateTime
property alias scrollY: flickable.contentY
property bool isEdit: false
+readonly property int millisecsInADay: 8640
+readonly property int millisecsInAHour: 360
+
signal eventAdded(var event);
signal eventDeleted(var event);
signal canceled()
@@ -74,8 +77,6 @@
}
function updateEventDate(date, allDay) {
-root.startDate = undefined
-root.endDate = undefined
setDate(date)
root.allDay = allDay
}
@@ -90,18 +91,9 @@
date.setHours(newDate.getHours(), newDate.getMinutes());
}
-// If startDate is setted by argument we have to not change it
-//Set the nearest current time.
-if (typeof(startDate) === 'undefined')
-startDate = new Date(root.roundDate(date))
-
-// If endDate is setted by argument we have to not change it
-if (typeof(endDate) === 'undefined') {
-endDate = new Date(root.roundDate(date))
-endDate.setMinutes(endDate.getMinutes() + 30)
-endTimeInput.text = Qt.formatDateTime(endDate, Qt.locale().timeFormat(Locale.ShortFormat));
-}
-
+startDate = new Date(root.roundDate(date))
+var enDateValue = new Date(root.roundDate(date))
+endDate = enDateValue.addMinutes(60)
}
function selectCalendar(collectionId) {
@@ -136,9 +128,14 @@
titleEdit.text = e.displayLabel;
}
+allDayEventCheckbox.checked = e.allDay;
if (e.allDay) {
allDayEventCheckbox.checked = true
endDate = new Date(e.endDateTime).addDays(-1);
+eventSize = DateExt.daysBetween(startDate, endDate) * root.millisecsInADay
+} else {
+endDate = e.endDateTime
+eventSize = (endDate.getTime() - startDate.getTime())
}
if(e.location) {
@@ -149,7 +146,6 @@
messageEdit.text = e.description;
}
-allDayEventCheckbox.checked = e.allDay;
var index = 0;
if( e.itemType === Type.Event ) {
@@ -311,26 +307,6 @@
}
Keys.onEscapePressed: root.cancel()
-onStartDateChanged: {
-if (!startDate)
-return
-
-startDateTimeInput.dateTime = startDate;
-
-// set time forward to one hour
-var time_forward = 360;
-
-if (isEdit && event !== null) {
-time_forward = event.endDateTime - event.startDateTime;
-}
-adjustEndDateToStartDate(time_forward);
-}
-
-onEndDateChanged: {
-if (endDate)
-endDateTimeInput.dateTime = endDate;
-}
-
header: PageHeader {
id: pageHeader
@@ -445,6 +421,7 @@
}
onDateTimeChanged: {
startDate = dateTime;
+endDateTimeInput.dateTime = new Date(startDate.getTime() + root.eventSize)
}
}
@@ -457,7 +434,17 @@
right: parent.right
}
onDateTimeChanged: {
+if (dateTime.getTime() < startDate.getTime()) {
+root.eventSize = root.allDay ? 0 : root.millisecsInAHour
+dateTime = new Date(startDate.getTime() + root.eventSize)
+return
+}
+
endDate = dateTime;
+if (allDay)
+root.eventSize = endDate.midnight().getTime() - startDate.midnight().getTime()
+else
+root.eventSize = endDate.getTime() - startDate.getTime()
}
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder into lp:ubuntu-calendar-app
Review: Needs Fixing It is failing to edit event with no reminder: 1 - Create a event with no-reminder 2 - Save event and go back to the view 3 - Open the same event (event details will show it as no-reminder) 4 - Edit it Expected: The Reminder combo shows "no reminder" Current: The Reminder compo shows "15 minutes" -- https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder/+merge/289315 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into lp:ubuntu-calendar-app
The proposal to merge lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click into lp:ubuntu-calendar-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click/+merge/289280 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945 into lp:ubuntu-calendar-app
The proposal to merge lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945 into lp:ubuntu-calendar-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945/+merge/288988 -- Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1554621] Re: Invalid use of palette apparent with new SDK in content-hub
** Also affects: music-app Importance: Undecided Status: New ** Changed in: music-app Importance: Undecided => High ** Changed in: music-app Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1554621 Title: Invalid use of palette apparent with new SDK in content-hub Status in address-book-app: Confirmed Status in camera-app: Confirmed Status in Canonical System Image: Confirmed Status in messaging-app: Confirmed Status in Ubuntu Music App: Confirmed Status in Tagger: New Status in Telegram app: Confirmed Status in Ubuntu Clock App: Confirmed Status in Ubuntu File Manager App: Confirmed Status in content-hub package in Ubuntu: Invalid Status in ubuntu-system-settings package in Ubuntu: In Progress Bug description: The content hub uses the wrong palette values for text (which becomes apparent with new UITK), see screenshot. The new UITK is landing here: https://requests.ci- train.ubuntu.com/#/ticket/905 ProblemType: Bug DistroRelease: Ubuntu 15.04 Package: content-hub 0.1+15.04.20160129.1-0ubuntu1 [origin: LP-PPA-ci-train-ppa-service-stable-phone-overlay] Uname: Linux 3.4.67 armv7l ApportVersion: 2.17.2-0ubuntu1.3touch1 Architecture: armhf Date: Tue Mar 8 18:00:22 2016 InstallationDate: Installed on 2016-03-08 (0 days ago) InstallationMedia: Ubuntu 15.04 - armhf (20160308-020304) SourcePackage: content-hub UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/address-book-app/+bug/1554621/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app
What still needs doing to make this non-WIP ? -- https://code.launchpad.net/~music-app-dev/music-app/fix-1550096-ota10-sdk-update/+merge/287363 Your team Music App Developers is requested to review the proposed merge of lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1554621] Re: Invalid use of palette apparent with new SDK in content-hub
** Also affects: camera-app (Ubuntu) Importance: Undecided Status: New ** Changed in: camera-app (Ubuntu) Status: New => Fix Released ** No longer affects: camera-app -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1554621 Title: Invalid use of palette apparent with new SDK in content-hub Status in address-book-app: Confirmed Status in Canonical System Image: Confirmed Status in messaging-app: Confirmed Status in Ubuntu Music App: In Progress Status in Tagger: New Status in Telegram app: Confirmed Status in Ubuntu Clock App: In Progress Status in Ubuntu File Manager App: Confirmed Status in camera-app package in Ubuntu: Fix Released Status in content-hub package in Ubuntu: Invalid Status in ubuntu-system-settings package in Ubuntu: In Progress Bug description: The content hub uses the wrong palette values for text (which becomes apparent with new UITK), see screenshot. The new UITK is landing here: https://requests.ci- train.ubuntu.com/#/ticket/905 ProblemType: Bug DistroRelease: Ubuntu 15.04 Package: content-hub 0.1+15.04.20160129.1-0ubuntu1 [origin: LP-PPA-ci-train-ppa-service-stable-phone-overlay] Uname: Linux 3.4.67 armv7l ApportVersion: 2.17.2-0ubuntu1.3touch1 Architecture: armhf Date: Tue Mar 8 18:00:22 2016 InstallationDate: Installed on 2016-03-08 (0 days ago) InstallationMedia: Ubuntu 15.04 - armhf (20160308-020304) SourcePackage: content-hub UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/address-book-app/+bug/1554621/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app has been updated. Commit Message changed to: Accept 'calendar://*' url as argument on app startup. This is necessary because url-dispatcher calls the app with uri as an argument if the app is not opened yet. For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-1439049/+merge/289198 -- Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~renatofilho/ubuntu-calendar-app/fix-1439049 into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1554621] Re: Invalid use of palette apparent with new SDK
** Summary changed: - Invalid use of palette apparent with new SDK in content-hub + Invalid use of palette apparent with new SDK -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1554621 Title: Invalid use of palette apparent with new SDK Status in address-book-app: Confirmed Status in Canonical System Image: Confirmed Status in messaging-app: Confirmed Status in Ubuntu Music App: In Progress Status in Tagger: New Status in Telegram app: Confirmed Status in Ubuntu Clock App: In Progress Status in Ubuntu File Manager App: Confirmed Status in camera-app package in Ubuntu: Fix Released Status in content-hub package in Ubuntu: Invalid Status in ubuntu-system-settings package in Ubuntu: In Progress Bug description: The content hub uses the wrong palette values for text (which becomes apparent with new UITK), see screenshot. The new UITK is landing here: https://requests.ci- train.ubuntu.com/#/ticket/905 ProblemType: Bug DistroRelease: Ubuntu 15.04 Package: content-hub 0.1+15.04.20160129.1-0ubuntu1 [origin: LP-PPA-ci-train-ppa-service-stable-phone-overlay] Uname: Linux 3.4.67 armv7l ApportVersion: 2.17.2-0ubuntu1.3touch1 Architecture: armhf Date: Tue Mar 8 18:00:22 2016 InstallationDate: Installed on 2016-03-08 (0 days ago) InstallationMedia: Ubuntu 15.04 - armhf (20160308-020304) SourcePackage: content-hub UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/address-book-app/+bug/1554621/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945 into lp:ubuntu-calendar-app
Review: Approve works fine. -- https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945/+merge/288988 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app
Review: Approve continuous-integration -- https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mardy/reminders-app/new-api into lp:reminders-app
Please read carefully this MP's description, as there's a problem with the deb version (I've tested the click and it seems to work fine). Let me know how to proceed. -- https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app
Review: Approve -- https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1554621] Re: Invalid use of palette apparent with new SDK in content-hub
** Changed in: music-app Status: Confirmed => In Progress ** Changed in: music-app Milestone: None => ota10 ** Changed in: music-app Assignee: (unassigned) => Ken VanDine (ken-vandine) -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1554621 Title: Invalid use of palette apparent with new SDK in content-hub Status in address-book-app: Confirmed Status in camera-app: Confirmed Status in Canonical System Image: Confirmed Status in messaging-app: Confirmed Status in Ubuntu Music App: In Progress Status in Tagger: New Status in Telegram app: Confirmed Status in Ubuntu Clock App: In Progress Status in Ubuntu File Manager App: Confirmed Status in content-hub package in Ubuntu: Invalid Status in ubuntu-system-settings package in Ubuntu: In Progress Bug description: The content hub uses the wrong palette values for text (which becomes apparent with new UITK), see screenshot. The new UITK is landing here: https://requests.ci- train.ubuntu.com/#/ticket/905 ProblemType: Bug DistroRelease: Ubuntu 15.04 Package: content-hub 0.1+15.04.20160129.1-0ubuntu1 [origin: LP-PPA-ci-train-ppa-service-stable-phone-overlay] Uname: Linux 3.4.67 armv7l ApportVersion: 2.17.2-0ubuntu1.3touch1 Architecture: armhf Date: Tue Mar 8 18:00:22 2016 InstallationDate: Installed on 2016-03-08 (0 days ago) InstallationMedia: Ubuntu 15.04 - armhf (20160308-020304) SourcePackage: content-hub UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/address-book-app/+bug/1554621/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder into lp:ubuntu-calendar-app
Review: Approve looks good. -- https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_default_reminder/+merge/289315 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1554621] Re: Invalid use of palette apparent with new SDK in content-hub
** Also affects: ubuntu-system-settings (Ubuntu) Importance: Undecided Status: New ** Changed in: telegram-app Importance: Undecided => High ** Changed in: telegram-app Status: New => Confirmed ** Changed in: ubuntu-clock-app Importance: Undecided => High ** Changed in: ubuntu-clock-app Status: New => Confirmed ** Changed in: ubuntu-filemanager-app Importance: Undecided => High ** Changed in: ubuntu-filemanager-app Status: New => Confirmed ** Changed in: address-book-app Importance: Undecided => High ** Changed in: address-book-app Status: New => Confirmed ** Changed in: camera-app Importance: Undecided => High ** Changed in: camera-app Status: New => Confirmed ** Changed in: messaging-app Importance: Undecided => High ** Changed in: messaging-app Status: New => Confirmed ** Changed in: ubuntu-system-settings (Ubuntu) Importance: Undecided => High ** Changed in: ubuntu-system-settings (Ubuntu) Status: New => Confirmed ** Changed in: ubuntu-system-settings (Ubuntu) Assignee: (unassigned) => Ken VanDine (ken-vandine) ** Changed in: ubuntu-system-settings (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1554621 Title: Invalid use of palette apparent with new SDK in content-hub Status in address-book-app: Confirmed Status in camera-app: Confirmed Status in Canonical System Image: Confirmed Status in messaging-app: Confirmed Status in Tagger: New Status in Telegram app: Confirmed Status in Ubuntu Clock App: Confirmed Status in Ubuntu File Manager App: Confirmed Status in content-hub package in Ubuntu: Invalid Status in ubuntu-system-settings package in Ubuntu: In Progress Bug description: The content hub uses the wrong palette values for text (which becomes apparent with new UITK), see screenshot. The new UITK is landing here: https://requests.ci- train.ubuntu.com/#/ticket/905 ProblemType: Bug DistroRelease: Ubuntu 15.04 Package: content-hub 0.1+15.04.20160129.1-0ubuntu1 [origin: LP-PPA-ci-train-ppa-service-stable-phone-overlay] Uname: Linux 3.4.67 armv7l ApportVersion: 2.17.2-0ubuntu1.3touch1 Architecture: armhf Date: Tue Mar 8 18:00:22 2016 InstallationDate: Installed on 2016-03-08 (0 days ago) InstallationMedia: Ubuntu 15.04 - armhf (20160308-020304) SourcePackage: content-hub UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/address-book-app/+bug/1554621/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-settings-help into lp:ubuntu-rssreader-app
Great work, mate! Give me some time to test it :) As you may know I am preparing a lot of changes right now, so I foresee a lot of merge conflicts =\ -- https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-settings-help/+merge/289180 Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~qqworini/ubuntu-rssreader-app/new-settings-help into lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
