[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/improve-tags-dialog/+merge/293466 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/improve-tags-dialog/+merge/293466 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app
Review: Approve Much better, thanks! -- https://code.launchpad.net/~mzanetti/reminders-app/improve-tags-dialog/+merge/293466 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-sorting-dialog/+merge/293472 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app
Review: Approve Works a treat, thanks for the fix! -- https://code.launchpad.net/~mzanetti/reminders-app/fix-sorting-dialog/+merge/293472 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-sorting-dialog/+merge/293472 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576140 into lp:reminders-app
The proposal to merge lp:~popey/reminders-app/fix-1576140 into lp:reminders-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1576140/+merge/293288 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576139 into lp:reminders-app
The proposal to merge lp:~popey/reminders-app/fix-1576139 into lp:reminders-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1576139/+merge/293298 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:553 https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/55/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/888/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/55/rebuild -- https://code.launchpad.net/~mzanetti/reminders-app/fix-sorting-dialog/+merge/293472 Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/fix-sorting-dialog into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/textarea into lp:reminders-app
The proposal to merge lp:~mzanetti/reminders-app/textarea into lp:reminders-app has been updated. Status: Work in progress => Rejected For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/textarea/+merge/253286 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/textarea into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/textarea into lp:reminders-app
this change was done with another branch -- https://code.launchpad.net/~mzanetti/reminders-app/textarea/+merge/253286 Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/textarea into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576139 into lp:reminders-app
The proposal to merge lp:~popey/reminders-app/fix-1576139 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1576139/+merge/293298 -- Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576139 into lp:reminders-app
Review: Approve as james said, good to go -- https://code.launchpad.net/~popey/reminders-app/fix-1576139/+merge/293298 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576140 into lp:reminders-app
The proposal to merge lp:~popey/reminders-app/fix-1576140 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1576140/+merge/293288 -- Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~popey/reminders-app/fix-1576140 into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app
Michael Zanetti has proposed merging
lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app.
Commit message:
Improve tags dialog
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu Notes app developers (notes-app-dev)
Related bugs:
Bug #1478094 in Ubuntu Notes app: "Tags wil not allow you to tap okay until
the word is released from the keyboard"
https://bugs.launchpad.net/reminders-app/+bug/1478094
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/improve-tags-dialog/+merge/293466
--
Your team Ubuntu Notes app developers is requested to review the proposed merge
of lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app.
=== modified file 'src/app/qml/components/EditTagsDialog.qml'
--- src/app/qml/components/EditTagsDialog.qml 2015-09-21 16:32:10 +
+++ src/app/qml/components/EditTagsDialog.qml 2016-04-30 16:58:43 +
@@ -33,7 +33,6 @@
property string haveTagsText: i18n.tr("Enter a tag name or select one from the list to attach it to the note.")
property var note
-property int pageHeight
signal done();
@@ -66,7 +65,12 @@
function accept() {
var tagName = displayText;
-text = '';
+// While displayText might be something useful, text will be empty when typing with
+// predictive keyboard. displayText is read-only though, in order to update it, we
+// need to actually cause a changed event on text, so let's set it and unset it again.
+textField.text = ' ';
+textField.text = '';
+
// Check if the tag exists
for (var i=0; i < tags.count; i++) {
@@ -146,25 +150,33 @@
}
}
-OptionSelector {
-id: optionSelector
-
-Layout.preferredWidth: parent.width - units.gu(2)
-Layout.alignment: Qt.AlignHCenter
-
-currentlyExpanded: true
-multiSelection: true
-
-containerHeight: Math.min(root.pageHeight / 3, tags.count * itemHeight)
-
-model: tags
-
-delegate: OptionSelectorDelegate {
-text: model.name
-selected: root.note ? root.note.tagGuids.indexOf(model.guid) !== -1 : false
-
-MouseArea {
-anchors.fill: parent
+Column {
+width: parent.width
+
+Repeater {
+id: optionSelector
+
+model: tags
+
+ListItem {
+id: tagDelegate
+height: units.gu(5)
+property bool selected: root.note ? root.note.tagGuids.indexOf(model.guid) !== -1 : false
+
+SlotsLayout {
+height: units.gu(5)
+mainSlot: Label {
+text: model.name
+}
+
+Icon {
+name: "tick"
+height: units.gu(3)
+width: height
+visible: tagDelegate.selected
+SlotsLayout.position: SlotsLayout.Trailing
+}
+}
onClicked: {
if (selected) {
=== modified file 'src/app/qml/ui/EditNoteView.qml'
--- src/app/qml/ui/EditNoteView.qml 2016-04-29 08:30:47 +
+++ src/app/qml/ui/EditNoteView.qml 2016-04-30 16:58:43 +
@@ -162,7 +162,7 @@
pageStack.push(Qt.resolvedUrl("SetReminderPage.qml"), { note: root.note});
}
onEditTags: {
-PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root, { note: root.note, pageHeight: root.height});
+PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root, { note: root.note });
}
}
=== modified file 'src/app/qml/ui/NoteView.qml'
--- src/app/qml/ui/NoteView.qml 2015-09-15 14:50:55 +
+++ src/app/qml/ui/NoteView.qml 2016-04-30 16:58:43 +
@@ -69,7 +69,7 @@
pagestack.push(Qt.resolvedUrl("SetReminderPage.qml"), { note: root.note});
}
onEditTags: {
-PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root, { note: root.note, pageHeight: root.height });
+PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root, { note: root.note });
}
}
}
=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml 2015-11-02 20:26:37 +
+++ src/app/qml/ui/NotesPage.qml 2016-04-30 16:58:43 +
@@ -201,7 +201,7 @@
}
onEditTags: {
var popup = PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root,
-{ note: NotesStore.note(model.guid),
[Ubuntu-touch-coreapps-reviewers] [Bug 1552100] Re: Move to .snap
Now with 16.04 is possibile? -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1552100 Title: Move to .snap Status in Canonical System Image: Opinion Status in Ubuntu Music App: Triaged Status in Ubuntu Notes app: Triaged Status in Telegram app: Triaged Status in Ubuntu Calendar App: Triaged Status in Ubuntu Clock App: Triaged Status in Ubuntu Document Viewer App: Triaged Status in Ubuntu File Manager App: Triaged Status in Ubuntu Terminal App: Triaged Status in Ubuntu Weather App: Triaged Status in webbrowser-app package in Ubuntu: Invalid Bug description: Move all packages to .snap (snappy) To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1552100/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576140 into lp:reminders-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:551 https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/53/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/886/console Click here to trigger a rebuild: https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/53/rebuild -- https://code.launchpad.net/~popey/reminders-app/fix-1576140/+merge/293288 Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~popey/reminders-app/fix-1576140 into lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
